163740 2016-10-20 10:00:01 -0700 Invalid assertion in arguments elimination 2016-10-20 10:44:58 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller commit-queue mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1242457 0 keith_miller 2016-10-20 10:00:01 -0700 Invalid assertion in arguments elimination 1242462 1 292216 keith_miller 2016-10-20 10:08:11 -0700 Created attachment 292216 Patch 1242463 2 292217 keith_miller 2016-10-20 10:09:35 -0700 Created attachment 292217 Patch 1242465 3 keith_miller 2016-10-20 10:11:27 -0700 <rdar://problem/27911462> 1242482 4 292217 msaboff 2016-10-20 10:31:45 -0700 Comment on attachment 292217 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292217&action=review r=me > Source/JavaScriptCore/ChangeLog:12 > + number of reasons that a DFG GetFromArguments may not point to another a Should "another" be removed? 1242484 5 292217 keith_miller 2016-10-20 10:33:41 -0700 Comment on attachment 292217 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292217&action=review Thanks for the review. >> Source/JavaScriptCore/ChangeLog:12 >> + number of reasons that a DFG GetFromArguments may not point to another a > > Should "another" be removed? Fixed. 1242486 6 keith_miller 2016-10-20 10:43:06 -0700 Committed r207623: <http://trac.webkit.org/changeset/207623> 1242487 7 292217 fpizlo 2016-10-20 10:44:58 -0700 Comment on attachment 292217 Patch r=me too 292216 2016-10-20 10:08:11 -0700 2016-10-20 10:09:31 -0700 Patch bug-163740-20161020100434.patch text/plain 3226 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3NTc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 NTQyMTJkMGZjYWZkMjNlMmQ5YjIzMTUyYTdkZmE3MzVmZWEzNTAwLi5lOGI2YjJiMGI1MTY1MjI1 ZTc2MTQ5NzY0YjFjMDAzOTI4MDk3ZGMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNi0xMC0yMCAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBJbnZhbGlkIGFzc2VydGlvbiBpbiBhcmd1bWVudHMgZWxpbWluYXRp b24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2Mzc0 MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBE RkdGVEwncyBhcmd1bWVudHMgZWxpbWluYXRpb24gcGhhc2UgaW5jb3JyZWN0bHkgYXNzZXJ0ZWQg dGhhdCBhIEdldEZyb21Bcmd1bWVudHMnIGZpcnN0CisgICAgICAgIGNoaWxkIHdvdWxkIGFsd2F5 cyBiZSBhIENyZWF0ZURpcmVjdEFyZ3VtZW50cy4gIFdoaWxlIHdlIG9ubHkgY3JlYXRlIHRoZQor ICAgICAgICBvcF9nZXRfZnJvbV9hcmd1bWVudHMgYnl0ZWNvZGUgcG9pbnRpbmcgdG8gYSBjcmVh dGVfZGlyZWN0X2FyZ3VtZW50cywgaXRzIHBvc3NpYmxlIGZvciBhCisgICAgICAgIG51bWJlciBv ZiByZWFzb25zIHRoYXQgYSBERkcgR2V0RnJvbUFyZ3VtZW50cyBtYXkgbm90IHBvaW50IHRvIGFu b3RoZXIgYQorICAgICAgICBDcmVhdGVEaXJlY3RBcmd1bWVudHMuIEZvciBleGFtcGxlLCBpZiB3 ZSBhcmUgT1NSIGVudGVyaW5nIGluIHNvbWUgZnVuY3Rpb24gd2l0aCBkaXJlY3QKKyAgICAgICAg YXJndW1lbnRzIHRoZSBDcmVhdGVEaXJlY3RBcmd1bWVudHMgbm9kZSBtaWdodCBiZWNvbWUgRXh0 cmFjdE9TUkVudHJ5TG9jYWxzLgorCisgICAgICAgICogZGZnL0RGR0FyZ3VtZW50c0VsaW1pbmF0 aW9uUGhhc2UuY3BwOgorCiAyMDE2LTEwLTE5ICBKRiBCYXN0aWVuICA8amZiYXN0aWVuQGFwcGxl LmNvbT4KIAogICAgICAgICBKYXZhU2NyaXB0IFdlYkFzc2VtYmx5IEFQSTogYmFieSBzdGVwcwpk aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBcmd1bWVudHNFbGltaW5h dGlvblBoYXNlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQXJndW1lbnRzRWxp bWluYXRpb25QaGFzZS5jcHAKaW5kZXggYWY1YzY5NjI2Y2U0NjlmZWFkYmIxN2I1NTc0NDEzZmUy ODEyNDIwMi4uNjIxNWNmZmZmOTJhYzBkYTM4M2IyYTdkZWU5MzUyYTdlYmM0OGEyNiAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBcmd1bWVudHNFbGltaW5hdGlvblBo YXNlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0FyZ3VtZW50c0VsaW1p bmF0aW9uUGhhc2UuY3BwCkBAIC0xNjgsNyArMTY4LDYgQEAgcHJpdmF0ZToKICAgICAgICAgICAg IGZvciAoTm9kZSogbm9kZSA6ICpibG9jaykgewogICAgICAgICAgICAgICAgIHN3aXRjaCAobm9k ZS0+b3AoKSkgewogICAgICAgICAgICAgICAgIGNhc2UgR2V0RnJvbUFyZ3VtZW50czoKLSAgICAg ICAgICAgICAgICAgICAgREZHX0FTU0VSVChtX2dyYXBoLCBub2RlLCBub2RlLT5jaGlsZDEoKS0+ b3AoKSA9PSBDcmVhdGVEaXJlY3RBcmd1bWVudHMpOwogICAgICAgICAgICAgICAgICAgICBicmVh azsKICAgICAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgY2FzZSBHZXRCeVZhbDoK ZGlmZiAtLWdpdCBhL0pTVGVzdHMvQ2hhbmdlTG9nIGIvSlNUZXN0cy9DaGFuZ2VMb2cKaW5kZXgg MDNkODMwMzY0M2Y1ZmU4ZDgwMDM5ZmQ5MmJmYmFmMDZmYjNmZDE1Mi4uZmQ1NDBjMzYzYzUxNTQz NWNlMzc1OWRhNThiNjcxYTMxZjM4ODgxOSAxMDA2NDQKLS0tIGEvSlNUZXN0cy9DaGFuZ2VMb2cK KysrIGIvSlNUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxNi0xMC0yMCAgS2Vp dGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxlLmNvbT4KKworICAgICAgICBJbnZhbGlkIGFz c2VydGlvbiBpbiBhcmd1bWVudHMgZWxpbWluYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2Mzc0MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3RyZXNzL2RpcmVjdC1hcmd1bWVudHMtb3NyLWVu dHJ5LmpzOiBBZGRlZC4KKyAgICAgICAgKGZvby4pOgorICAgICAgICAoZm9vKToKKwogMjAxNi0x MC0xOSAgSkYgQmFzdGllbiAgPGpmYmFzdGllbkBhcHBsZS5jb20+CiAKICAgICAgICAgSmF2YVNj cmlwdCBXZWJBc3NlbWJseSBBUEk6IGJhYnkgc3RlcHMKZGlmZiAtLWdpdCBhL0pTVGVzdHMvc3Ry ZXNzL2RpcmVjdC1hcmd1bWVudHMtb3NyLWVudHJ5LmpzIGIvSlNUZXN0cy9zdHJlc3MvZGlyZWN0 LWFyZ3VtZW50cy1vc3ItZW50cnkuanMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uOTdkMWFiNGY4NWIxZTEwMTAyZDBm ZGQwYTAyODRjY2YyMWQ4MTU0ZgotLS0gL2Rldi9udWxsCisrKyBiL0pTVGVzdHMvc3RyZXNzL2Rp cmVjdC1hcmd1bWVudHMtb3NyLWVudHJ5LmpzCkBAIC0wLDAgKzEsMjIgQEAKKy8vIFRoaXMgdGVz dHMgdGhhdCBhcmd1bWVudHMgZWxpbWluYXRpb24gd29ya3Mgd2l0aCBPU1IgZW50cnkuCisvLyBX ZSBuZWVkIHRvIGhhdmUgYW4gaW5uZXIgY2FsbCBzbyB0aGF0IGFyZ3VtZW50cyBlbGltaW5hdGlv bgorLy8gc2VlcyB0aGVyZSBhcmUgcG90ZW50aWFsIGNhbmRpZGF0ZXMuCisKK3ZhciBhcmdzOwor CitmdW5jdGlvbiBmb28oYSkKK3sKKyAgICBhcmdzID0gYXJndW1lbnRzOworICAgIHZhciByZXN1 bHQgPSAwOworICAgIGZvciAodmFyIGkgPSAwOyBpIDwgMTAwMDAwMDsgKytpKSB7CisgICAgICAg IChmdW5jdGlvbigpIHsKKyAgICAgICAgICAgIHJldHVybiBhcmd1bWVudHNbMF07CisgICAgICAg IH0pKDQyKTsKKyAgICAgICAgcmVzdWx0ICs9IGE7CisgICAgfQorICAgIHJldHVybiByZXN1bHQ7 Cit9CisKK25vSW5saW5lKGZvbyk7CisKK2Zvbyg0Mik7Cg== 292217 2016-10-20 10:09:35 -0700 2016-10-20 10:31:45 -0700 Patch bug-163740-20161020100557.patch text/plain 3296 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3NTc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 NTQyMTJkMGZjYWZkMjNlMmQ5YjIzMTUyYTdkZmE3MzVmZWEzNTAwLi43YzIxMzJkNWJhODg2M2Y0 ZTgzOGRiOTAwMGIyY2UxMTU4YTJjODUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxNi0xMC0yMCAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBJbnZhbGlkIGFzc2VydGlvbiBpbiBhcmd1bWVudHMgZWxpbWluYXRp b24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2Mzc0 MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjc5MTE0NjI+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIERGR0ZUTCdzIGFyZ3VtZW50cyBlbGlt aW5hdGlvbiBwaGFzZSBpbmNvcnJlY3RseSBhc3NlcnRlZCB0aGF0IGEgR2V0RnJvbUFyZ3VtZW50 cycgZmlyc3QKKyAgICAgICAgY2hpbGQgd291bGQgYWx3YXlzIGJlIGEgQ3JlYXRlRGlyZWN0QXJn dW1lbnRzLiAgV2hpbGUgd2Ugb25seSBjcmVhdGUgdGhlCisgICAgICAgIG9wX2dldF9mcm9tX2Fy Z3VtZW50cyBieXRlY29kZSBwb2ludGluZyB0byBhIGNyZWF0ZV9kaXJlY3RfYXJndW1lbnRzLCBp dHMgcG9zc2libGUgZm9yIGEKKyAgICAgICAgbnVtYmVyIG9mIHJlYXNvbnMgdGhhdCBhIERGRyBH ZXRGcm9tQXJndW1lbnRzIG1heSBub3QgcG9pbnQgdG8gYW5vdGhlciBhCisgICAgICAgIENyZWF0 ZURpcmVjdEFyZ3VtZW50cy4gRm9yIGV4YW1wbGUsIGlmIHdlIGFyZSBPU1IgZW50ZXJpbmcgaW4g c29tZSBmdW5jdGlvbiB3aXRoIGRpcmVjdAorICAgICAgICBhcmd1bWVudHMgdGhlIENyZWF0ZURp cmVjdEFyZ3VtZW50cyBub2RlIG1pZ2h0IGJlY29tZSBFeHRyYWN0T1NSRW50cnlMb2NhbHMuCisK KyAgICAgICAgKiBkZmcvREZHQXJndW1lbnRzRWxpbWluYXRpb25QaGFzZS5jcHA6CisKIDIwMTYt MTAtMTkgIEpGIEJhc3RpZW4gIDxqZmJhc3RpZW5AYXBwbGUuY29tPgogCiAgICAgICAgIEphdmFT Y3JpcHQgV2ViQXNzZW1ibHkgQVBJOiBiYWJ5IHN0ZXBzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR0FyZ3VtZW50c0VsaW1pbmF0aW9uUGhhc2UuY3BwIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBcmd1bWVudHNFbGltaW5hdGlvblBoYXNlLmNwcAppbmRl eCBhZjVjNjk2MjZjZTQ2OWZlYWRiYjE3YjU1NzQ0MTNmZTI4MTI0MjAyLi42MjE1Y2ZmZmY5MmFj MGRhMzgzYjJhN2RlZTkzNTJhN2ViYzQ4YTI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvZGZnL0RGR0FyZ3VtZW50c0VsaW1pbmF0aW9uUGhhc2UuY3BwCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9kZmcvREZHQXJndW1lbnRzRWxpbWluYXRpb25QaGFzZS5jcHAKQEAgLTE2 OCw3ICsxNjgsNiBAQCBwcml2YXRlOgogICAgICAgICAgICAgZm9yIChOb2RlKiBub2RlIDogKmJs b2NrKSB7CiAgICAgICAgICAgICAgICAgc3dpdGNoIChub2RlLT5vcCgpKSB7CiAgICAgICAgICAg ICAgICAgY2FzZSBHZXRGcm9tQXJndW1lbnRzOgotICAgICAgICAgICAgICAgICAgICBERkdfQVNT RVJUKG1fZ3JhcGgsIG5vZGUsIG5vZGUtPmNoaWxkMSgpLT5vcCgpID09IENyZWF0ZURpcmVjdEFy Z3VtZW50cyk7CiAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgICAgICAg ICAKICAgICAgICAgICAgICAgICBjYXNlIEdldEJ5VmFsOgpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9D aGFuZ2VMb2cgYi9KU1Rlc3RzL0NoYW5nZUxvZwppbmRleCAwM2Q4MzAzNjQzZjVmZThkODAwMzlm ZDkyYmZiYWYwNmZiM2ZkMTUyLi43ODE1MGJhZDdjOThmZDliYjdmMWYxZWZmZjlhN2I4NWM0Mjg3 YWUzIDEwMDY0NAotLS0gYS9KU1Rlc3RzL0NoYW5nZUxvZworKysgYi9KU1Rlc3RzL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTEwLTIwICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxs ZXJAYXBwbGUuY29tPgorCisgICAgICAgIEludmFsaWQgYXNzZXJ0aW9uIGluIGFyZ3VtZW50cyBl bGltaW5hdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTYzNzQwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNzkxMTQ2Mj4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy9kaXJlY3QtYXJn dW1lbnRzLW9zci1lbnRyeS5qczogQWRkZWQuCisgICAgICAgIChmb28uKToKKyAgICAgICAgKGZv byk6CisKIDIwMTYtMTAtMTkgIEpGIEJhc3RpZW4gIDxqZmJhc3RpZW5AYXBwbGUuY29tPgogCiAg ICAgICAgIEphdmFTY3JpcHQgV2ViQXNzZW1ibHkgQVBJOiBiYWJ5IHN0ZXBzCmRpZmYgLS1naXQg YS9KU1Rlc3RzL3N0cmVzcy9kaXJlY3QtYXJndW1lbnRzLW9zci1lbnRyeS5qcyBiL0pTVGVzdHMv c3RyZXNzL2RpcmVjdC1hcmd1bWVudHMtb3NyLWVudHJ5LmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjk3ZDFhYjRm ODViMWUxMDEwMmQwZmRkMGEwMjg0Y2NmMjFkODE1NGYKLS0tIC9kZXYvbnVsbAorKysgYi9KU1Rl c3RzL3N0cmVzcy9kaXJlY3QtYXJndW1lbnRzLW9zci1lbnRyeS5qcwpAQCAtMCwwICsxLDIyIEBA CisvLyBUaGlzIHRlc3RzIHRoYXQgYXJndW1lbnRzIGVsaW1pbmF0aW9uIHdvcmtzIHdpdGggT1NS IGVudHJ5LgorLy8gV2UgbmVlZCB0byBoYXZlIGFuIGlubmVyIGNhbGwgc28gdGhhdCBhcmd1bWVu dHMgZWxpbWluYXRpb24KKy8vIHNlZXMgdGhlcmUgYXJlIHBvdGVudGlhbCBjYW5kaWRhdGVzLgor Cit2YXIgYXJnczsKKworZnVuY3Rpb24gZm9vKGEpCit7CisgICAgYXJncyA9IGFyZ3VtZW50czsK KyAgICB2YXIgcmVzdWx0ID0gMDsKKyAgICBmb3IgKHZhciBpID0gMDsgaSA8IDEwMDAwMDA7ICsr aSkgeworICAgICAgICAoZnVuY3Rpb24oKSB7CisgICAgICAgICAgICByZXR1cm4gYXJndW1lbnRz WzBdOworICAgICAgICB9KSg0Mik7CisgICAgICAgIHJlc3VsdCArPSBhOworICAgIH0KKyAgICBy ZXR1cm4gcmVzdWx0OworfQorCitub0lubGluZShmb28pOworCitmb28oNDIpOwo=