163733 2016-10-20 08:51:03 -0700 [EFL] REGRESSION(r207616): Build is broken due to missing libgeoclue-dev package 2016-10-21 06:30:07 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P1 Critical --- 160809 1 ossy webkit-unassigned cgarcia clopez gyuyoung.kim hs85.jeong ossy oldest_to_newest 1242409 0 ossy 2016-10-20 08:51:03 -0700 I tried an EFL WebKit build on a fresh new Ubuntu 16.04 machine and got the following build error: In file included from ../../Source/WebCore/platform/geoclue/GeolocationProviderGeoclue1.cpp:27:0: ../../Source/WebCore/platform/geoclue/GeolocationProviderGeoclue.h:32:36: fatal error: geoclue/geoclue-master.h: No such file or directory compilation terminated. It seems https://trac.webkit.org/changeset/204445 is the culprit. geoclue/geoclue-master.h is in libgeoclue-dev package, but after r204445, only libgeoclue-2-dev is installed. But the question is what is the proper fix? - adding geoclue-2.0 to <efl|gtk>/install-dependencies --> isn't enough, because USE(GEOCLUE2) isn't exposed to the build - Source/cmake/OptionsEfl.cmake should use SET_AND_EXPOSE_TO_BUILD similar to GTK - fixing the geoclue 1 build - removing the geoclue path - whatever else Additionally I got the following warnings which should be fixed or suppressed: DerivedSources/WebCore/Geoclue2Interface.c: In function 'geoclue_manager_complete_get_client': DerivedSources/WebCore/Geoclue2Interface.c:673:21: warning: unused parameter 'object' [-Wunused-parameter] DerivedSources/WebCore/Geoclue2Interface.c: In function 'geoclue_manager_complete_add_agent': DerivedSources/WebCore/Geoclue2Interface.c:693:21: warning: unused parameter 'object' [-Wunused-parameter] DerivedSources/WebCore/Geoclue2Interface.c: In function 'geoclue_client_complete_start': DerivedSources/WebCore/Geoclue2Interface.c:2373:20: warning: unused parameter 'object' [-Wunused-parameter] DerivedSources/WebCore/Geoclue2Interface.c: In function 'geoclue_client_complete_stop': DerivedSources/WebCore/Geoclue2Interface.c:2391:20: warning: unused parameter 'object' [-Wunused-parameter] note: I just reported this bug, but have no time and interest in fixing it myself. I'm going to upload my WIP patch, feel free to pick it up if it is important for somebody. 1242411 1 292201 ossy 2016-10-20 08:57:39 -0700 Created attachment 292201 Patch WIP patch, it fixes the geoclue 2 build. 1242742 2 292201 gyuyoung.kim 2016-10-20 19:18:15 -0700 Comment on attachment 292201 Patch LGTM. 1242771 3 cgarcia 2016-10-20 22:25:42 -0700 (In reply to comment #0) > I tried an EFL WebKit build on a fresh new Ubuntu 16.04 > machine and got the following build error: > > In file included from > ../../Source/WebCore/platform/geoclue/GeolocationProviderGeoclue1.cpp:27:0: > ../../Source/WebCore/platform/geoclue/GeolocationProviderGeoclue.h:32:36: > fatal error: geoclue/geoclue-master.h: No such file or directory > compilation terminated. > > It seems https://trac.webkit.org/changeset/204445 is the culprit. > > geoclue/geoclue-master.h is in libgeoclue-dev package, > but after r204445, only libgeoclue-2-dev is installed. > > But the question is what is the proper fix? > - adding geoclue-2.0 to <efl|gtk>/install-dependencies > --> isn't enough, because USE(GEOCLUE2) isn't exposed to the build > - Source/cmake/OptionsEfl.cmake should use SET_AND_EXPOSE_TO_BUILD similar > to GTK > - fixing the geoclue 1 build > - removing the geoclue path > - whatever else > > Additionally I got the following warnings which should be fixed or > suppressed: > DerivedSources/WebCore/Geoclue2Interface.c: In function > 'geoclue_manager_complete_get_client': > DerivedSources/WebCore/Geoclue2Interface.c:673:21: warning: unused parameter > 'object' [-Wunused-parameter] > DerivedSources/WebCore/Geoclue2Interface.c: In function > 'geoclue_manager_complete_add_agent': > DerivedSources/WebCore/Geoclue2Interface.c:693:21: warning: unused parameter > 'object' [-Wunused-parameter] > DerivedSources/WebCore/Geoclue2Interface.c: In function > 'geoclue_client_complete_start': > DerivedSources/WebCore/Geoclue2Interface.c:2373:20: warning: unused > parameter 'object' [-Wunused-parameter] > DerivedSources/WebCore/Geoclue2Interface.c: In function > 'geoclue_client_complete_stop': > DerivedSources/WebCore/Geoclue2Interface.c:2391:20: warning: unused > parameter 'object' [-Wunused-parameter] This is generated code, Michael suppressed those warnings in GTK+ build in r206381 with: set_source_files_properties(${DERIVED_SOURCES_WEBCORE_DIR}/Geoclue2Interface.c PROPERTIES COMPILE_FLAGS -Wno-unused-parameter) > > note: I just reported this bug, but have no time and interest > in fixing it myself. I'm going to upload my WIP patch, feel > free to pick it up if it is important for somebody. 1242857 4 292201 ossy 2016-10-21 06:29:59 -0700 Comment on attachment 292201 Patch Clearing flags on attachment: 292201 Committed r207668: <http://trac.webkit.org/changeset/207668> 1242858 5 ossy 2016-10-21 06:30:07 -0700 All reviewed patches have been landed. Closing bug. 292201 2016-10-20 08:57:39 -0700 2016-10-21 06:29:59 -0700 Patch bug-163733-20161020085401.patch text/plain 2495 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3NjE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0VmbC5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCmluZGV4IGVkNDZl OWM3ODVhZjg4NTBjYmI0YjIwYjU3OWYwYWNiODU4OGQwM2UuLmI3NTZkOTIyYTY0ODI1NDY1Yzk2 N2Y0NTE3NzViODk2MzJjNzBjOGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZs LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCkBAIC0xODYsMTAgKzE4 NiwxMiBAQCBpZiAoRU5BQkxFX0dFT0xPQ0FUSU9OKQogICAgIGxpc3QoQVBQRU5EIEdMSUJfQ09N UE9ORU5UUyBnaW8tdW5peCkKICAgICBmaW5kX3BhY2thZ2UoR2VvQ2x1ZTIgMi4xLjUpCiAgICAg aWYgKEdFT0NMVUUyX0ZPVU5EKQotICAgICAgc2V0KFVTRV9HRU9DTFVFMiAxKQorICAgICAgICBT RVRfQU5EX0VYUE9TRV9UT19CVUlMRChVU0VfR0VPQ0xVRTIgJHtHRU9DTFVFMl9GT1VORH0pCiAg ICAgZWxzZSAoKQotICAgICAgZmluZF9wYWNrYWdlKEdlb0NsdWUpCi0gICAgICBzZXQoVVNFX0dF T0NMVUUyIDApCisgICAgICAgIGZpbmRfcGFja2FnZShHZW9DbHVlKQorICAgICAgICBpZiAoTk9U IEdFT0NMVUVfRk9VTkQpCisgICAgICAgICAgICBtZXNzYWdlKEZBVEFMX0VSUk9SICJHZW9jbHVl IGlzIG5lZWRlZCBmb3IgRU5BQkxFX0dFT0xPQ0FUSU9OLiIpCisgICAgICAgIGVuZGlmICgpCiAg ICAgZW5kaWYgKCkKIGVuZGlmICgpCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rv b2xzL0NoYW5nZUxvZwppbmRleCBhMjc1NjVjZTBjMjI3NWMxNDFhZDE1MDMzNWU5MzhjZjI1N2Q3 OWNmLi4wOTQwMTVmMTdmNWU3ZjNiNTZlN2YxM2Q4ZDlkNmIyYmNlZDAwZWM3IDEwMDY0NAotLS0g YS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTYtMTAtMjAgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKworICAg ICAgICBbRUZMXSBSRUdSRVNTSU9OKHIyMDc2MTYpOiBCdWlsZCBpcyBicm9rZW4gZHVlIHRvIG1p c3NpbmcgbGliZ2VvY2x1ZS1kZXYgcGFja2FnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzNzMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBlZmwvaW5zdGFsbC1kZXBlbmRlbmNpZXM6IEFkZGVkIGdl b2NsdWUtMi4wIHBhY2thZ2UuCisKIDIwMTYtMTAtMjAgIEZ1amlpIEhpcm9ub3JpICA8SGlyb25v cmkuRnVqaWlAc29ueS5jb20+CiAKICAgICAgICAgW0NNYWtlXSBDTWFrZSBkb2VzIG5vdCBzdXBw b3J0IHRoZSBkZXAgZmlsZXMgZm9yIGltcGxpY2l0IGRlcGVuZGVuY3kKZGlmZiAtLWdpdCBhL1Rv b2xzL2VmbC9pbnN0YWxsLWRlcGVuZGVuY2llcyBiL1Rvb2xzL2VmbC9pbnN0YWxsLWRlcGVuZGVu Y2llcwppbmRleCAzOTdkODYwOWJhMTE0ZjIzMDM0OWI1ZGNlNWQyZTExMTAzOThkMTk1Li5lMjg5 OGNjNzUwZDRkMDg5ZDU5MzljNGIxNTYxYTUyYjNhZDg5NjUxIDEwMDc1NQotLS0gYS9Ub29scy9l ZmwvaW5zdGFsbC1kZXBlbmRlbmNpZXMKKysrIGIvVG9vbHMvZWZsL2luc3RhbGwtZGVwZW5kZW5j aWVzCkBAIC02Niw2ICs2Niw3IEBAIGZ1bmN0aW9uIGluc3RhbGxEZXBlbmRlbmNpZXNXaXRoQXB0 IHsKICAgICAgICAgZG94eWdlbiBcCiAgICAgICAgIGZsZXggXAogICAgICAgICBnKysgXAorICAg ICAgICBnZW9jbHVlLTIuMCBcCiAgICAgICAgIGdwZXJmIFwKICAgICAgICAgZ3RrLWRvYy10b29s cyBcCiAgICAgICAgIGxpYmF0azEuMC1kZXYgXApkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hh bmdlTG9nCmluZGV4IDE4MTdlNDhkOTU3NTdhMjM2ZTY1NmY3M2FjZTYwNGRhMDIxYTQ2MTguLmI4 ZDI3NTkwYTc5N2U3ODcxODA5MGVhZTdiN2EwYzQ5ZmNlNzYyYzcgMTAwNjQ0Ci0tLSBhL0NoYW5n ZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxNi0xMC0yMCAgQ3NhYmEg T3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgorCisgICAgICAgIFtFRkxdIFJFR1JFU1NJ T04ocjIwNzYxNik6IEJ1aWxkIGlzIGJyb2tlbiBkdWUgdG8gbWlzc2luZyBsaWJnZW9jbHVlLWRl diBwYWNrYWdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNjM3MzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlOiBFeHBvc2UgVVNFX0dFT0NMVUUyIHRv IHRoZSBidWlsZCBwcm9wZXJseS4KKwogMjAxNi0xMC0yMCAgRnVqaWkgSGlyb25vcmkgIDxIaXJv bm9yaS5GdWppaUBzb255LmNvbT4KIAogICAgICAgICBbQ01ha2VdIENNYWtlIGRvZXMgbm90IHN1 cHBvcnQgdGhlIGRlcCBmaWxlcyBmb3IgaW1wbGljaXQgZGVwZW5kZW5jeQo=