163723 2016-10-20 04:58:07 -0700 WebRTC: [OpenWebRTC] Probe the platform before building the audio/video payload lists 2018-06-26 14:56:20 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 143211 1 adam.bergkvist webkit-unassigned alex bugs-noreply calvaris pnormand tsaunier oldest_to_newest 1242332 0 adam.bergkvist 2016-10-20 04:58:07 -0700 The audio and video payloads are currently hard coded. We should probe the platform to see what's available. This will require a move to an async API, similar to how generateDtlsInfo() works. 1257221 1 296386 pnormand 2016-12-07 04:12:33 -0800 Created attachment 296386 patch Here's a WIP patch, not marking for review because it depends on this commit in a OpenWebRTC (still)-WiP branch: https://github.com/Metrological/openwebrtc/commit/164b79ea00c522c6eb431b65f1e658ec6e87327b 1436674 2 tsaunier 2018-06-26 14:50:08 -0700 OpenWebRTC implementation has been removed, should we close as OBSELETE? 296386 2016-12-07 04:12:33 -0800 2016-12-07 04:12:33 -0800 patch 0001-MediaEndPointOwr-probe-for-supported-codecs.patch text/plain 7175 pnormand RnJvbSBiNjIxMmJkMDk4MGFhZDE5MzAxMGQ0ODcxOWViN2M4YmNkN2MxNzdkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBNb24sIDUgRGVjIDIwMTYgMTQ6Mzc6MzMgKzAxMDAKU3ViamVjdDogW1BBVENIXSBN ZWRpYUVuZFBvaW50T3dyOiBwcm9iZSBmb3Igc3VwcG9ydGVkIGNvZGVjcwoKLS0tCiAuLi4vbWVk aWFzdHJlYW0vb3BlbndlYnJ0Yy9NZWRpYUVuZHBvaW50T3dyLmNwcCAgICB8IDc0ICsrKysrKysr KysrKystLS0tLS0tLS0KIC4uLi9tZWRpYXN0cmVhbS9vcGVud2VicnRjL01lZGlhRW5kcG9pbnRP d3IuaCAgICAgIHwgIDIgKwogMiBmaWxlcyBjaGFuZ2VkLCA0NyBpbnNlcnRpb25zKCspLCAyOSBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0 cmVhbS9vcGVud2VicnRjL01lZGlhRW5kcG9pbnRPd3IuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbWVkaWFzdHJlYW0vb3BlbndlYnJ0Yy9NZWRpYUVuZHBvaW50T3dyLmNwcAppbmRleCBh N2EyMWY0Li45NTQzYzI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRp YXN0cmVhbS9vcGVud2VicnRjL01lZGlhRW5kcG9pbnRPd3IuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL29wZW53ZWJydGMvTWVkaWFFbmRwb2ludE93ci5jcHAK QEAgLTU3LDcgKzU3LDYgQEAgc3RhdGljIHZvaWQgZ290SW5jb21pbmdTb3VyY2UoT3dyTWVkaWFT ZXNzaW9uKiwgT3dyTWVkaWFTb3VyY2UqLCBNZWRpYUVuZHBvaW50T3cKIAogc3RhdGljIGNvbnN0 IFZlY3RvcjxTdHJpbmc+IGNhbmRpZGF0ZVR5cGVzID0geyAiaG9zdCIsICJzcmZseCIsICJwcmZs eCIsICJyZWxheSIgfTsKIHN0YXRpYyBjb25zdCBWZWN0b3I8U3RyaW5nPiBjYW5kaWRhdGVUY3BU eXBlcyA9IHsgIiIsICJhY3RpdmUiLCAicGFzc2l2ZSIsICJzbyIgfTsKLXN0YXRpYyBjb25zdCBW ZWN0b3I8U3RyaW5nPiBjb2RlY1R5cGVzID0geyAiTk9ORSIsICJQQ01VIiwgIlBDTUEiLCAiT1BV UyIsICJIMjY0IiwgIlZQOCIgfTsKIAogc3RhdGljIGNvbnN0IGNoYXIqIGhlbHBlclNlcnZlclJl Z0V4ID0gIih0dXJuc3x0dXJufHN0dW4pOihbXFx3XFwuXFwtXSt8XFxbW1xcd1xcOl0rXFxdKSg6 XFxkKyk/KFxcPy4rKT8iOwogCkBAIC04Miw2ICs4MSwxNiBAQCBNZWRpYUVuZHBvaW50T3dyOjpN ZWRpYUVuZHBvaW50T3dyKE1lZGlhRW5kcG9pbnRDbGllbnQmIGNsaWVudCkKICAgICBHUmVnZXhD b21waWxlRmxhZ3MgY29tcGlsZUZsYWdzID0gR19SRUdFWF9KQVZBU0NSSVBUX0NPTVBBVDsKICAg ICBHUmVnZXhNYXRjaEZsYWdzIG1hdGNoRmxhZ3MgPSBzdGF0aWNfY2FzdDxHUmVnZXhNYXRjaEZs YWdzPigwKTsKICAgICBtX2hlbHBlclNlcnZlclJlZ0V4ID0gZ19yZWdleF9uZXcoaGVscGVyU2Vy dmVyUmVnRXgsIGNvbXBpbGVGbGFncywgbWF0Y2hGbGFncywgbnVsbHB0cik7CisKKyAgICBtX2Nv ZGVjVHlwZXMuYXBwZW5kKCJOT05FIik7CisgICAgbV9jb2RlY1R5cGVzLmFwcGVuZCgiUENNVSIp OworICAgIG1fY29kZWNUeXBlcy5hcHBlbmQoIlBDTUEiKTsKKyAgICBpZiAob3dyX3BheWxvYWRf c3VwcG9ydGVkKE9XUl9DT0RFQ19UWVBFX09QVVMpKQorICAgICAgICBtX2NvZGVjVHlwZXMuYXBw ZW5kKCJPUFVTIik7CisgICAgaWYgKG93cl9wYXlsb2FkX3N1cHBvcnRlZChPV1JfQ09ERUNfVFlQ RV9IMjY0KSkKKyAgICAgICAgbV9jb2RlY1R5cGVzLmFwcGVuZCgiSDI2NCIpOworICAgIGlmIChv d3JfcGF5bG9hZF9zdXBwb3J0ZWQoT1dSX0NPREVDX1RZUEVfVlA4KSkKKyAgICAgICAgbV9jb2Rl Y1R5cGVzLmFwcGVuZCgiVlA4Iik7CiB9CiAKIE1lZGlhRW5kcG9pbnRPd3I6On5NZWRpYUVuZHBv aW50T3dyKCkKQEAgLTExOCwxMyArMTI3LDE0IEBAIE1lZGlhUGF5bG9hZFZlY3RvciBNZWRpYUVu ZHBvaW50T3dyOjpnZXREZWZhdWx0QXVkaW9QYXlsb2FkcygpCiB7CiAgICAgTWVkaWFQYXlsb2Fk VmVjdG9yIHBheWxvYWRzOwogCi0gICAgLy8gRklYTUU6IFRoaXMgbGlzdCBzaG91bGQgYmUgYmFz ZWQgb24gd2hhdCBpcyBhdmFpbGFibGUgaW4gdGhlIHBsYXRmb3JtIChidWc6IGh0dHA6Ly93ZWJr aXQub3JnL2IvMTYzNzIzKQotICAgIE1lZGlhUGF5bG9hZCBwYXlsb2FkMTsKLSAgICBwYXlsb2Fk MS50eXBlID0gMTExOwotICAgIHBheWxvYWQxLmVuY29kaW5nTmFtZSA9ICJPUFVTIjsKLSAgICBw YXlsb2FkMS5jbG9ja1JhdGUgPSA0ODAwMDsKLSAgICBwYXlsb2FkMS5jaGFubmVscyA9IDI7Ci0g ICAgcGF5bG9hZHMuYXBwZW5kKFdURk1vdmUocGF5bG9hZDEpKTsKKyAgICBpZiAobV9jb2RlY1R5 cGVzLmZpbmQoIk9QVVMiKSAhPSBub3RGb3VuZCkgeworICAgICAgICBNZWRpYVBheWxvYWQgcGF5 bG9hZDE7CisgICAgICAgIHBheWxvYWQxLnR5cGUgPSAxMTE7CisgICAgICAgIHBheWxvYWQxLmVu Y29kaW5nTmFtZSA9ICJPUFVTIjsKKyAgICAgICAgcGF5bG9hZDEuY2xvY2tSYXRlID0gNDgwMDA7 CisgICAgICAgIHBheWxvYWQxLmNoYW5uZWxzID0gMjsKKyAgICAgICAgcGF5bG9hZHMuYXBwZW5k KFdURk1vdmUocGF5bG9hZDEpKTsKKyAgICB9CiAKICAgICBNZWRpYVBheWxvYWQgcGF5bG9hZDI7 CiAgICAgcGF5bG9hZDIudHlwZSA9IDg7CkBAIC0xNDcsMjQgKzE1NywyNyBAQCBNZWRpYVBheWxv YWRWZWN0b3IgTWVkaWFFbmRwb2ludE93cjo6Z2V0RGVmYXVsdFZpZGVvUGF5bG9hZHMoKQogewog ICAgIE1lZGlhUGF5bG9hZFZlY3RvciBwYXlsb2FkczsKIAotICAgIC8vIEZJWE1FOiBUaGlzIGxp c3Qgc2hvdWxkIGJlIGJhc2VkIG9uIHdoYXQgaXMgYXZhaWxhYmxlIGluIHRoZSBwbGF0Zm9ybSAo YnVnOiBodHRwOi8vd2Via2l0Lm9yZy9iLzE2MzcyMykKLSAgICBNZWRpYVBheWxvYWQgcGF5bG9h ZDE7Ci0gICAgcGF5bG9hZDEudHlwZSA9IDEwMzsKLSAgICBwYXlsb2FkMS5lbmNvZGluZ05hbWUg PSAiSDI2NCI7Ci0gICAgcGF5bG9hZDEuY2xvY2tSYXRlID0gOTAwMDA7Ci0gICAgcGF5bG9hZDEu Y2NtZmlyID0gdHJ1ZTsKLSAgICBwYXlsb2FkMS5uYWNrcGxpID0gdHJ1ZTsKLSAgICBwYXlsb2Fk MS5hZGRQYXJhbWV0ZXIoInBhY2tldGl6YXRpb25Nb2RlIiwgMSk7Ci0gICAgcGF5bG9hZHMuYXBw ZW5kKFdURk1vdmUocGF5bG9hZDEpKTsKKyAgICBpZiAobV9jb2RlY1R5cGVzLmZpbmQoIkgyNjQi KSAhPSBub3RGb3VuZCkgeworICAgICAgICBNZWRpYVBheWxvYWQgcGF5bG9hZDE7CisgICAgICAg IHBheWxvYWQxLnR5cGUgPSAxMDM7CisgICAgICAgIHBheWxvYWQxLmVuY29kaW5nTmFtZSA9ICJI MjY0IjsKKyAgICAgICAgcGF5bG9hZDEuY2xvY2tSYXRlID0gOTAwMDA7CisgICAgICAgIHBheWxv YWQxLmNjbWZpciA9IHRydWU7CisgICAgICAgIHBheWxvYWQxLm5hY2twbGkgPSB0cnVlOworICAg ICAgICBwYXlsb2FkMS5hZGRQYXJhbWV0ZXIoInBhY2tldGl6YXRpb25Nb2RlIiwgMSk7CisgICAg ICAgIHBheWxvYWRzLmFwcGVuZChXVEZNb3ZlKHBheWxvYWQxKSk7CisgICAgfQogCi0gICAgTWVk aWFQYXlsb2FkIHBheWxvYWQyOwotICAgIHBheWxvYWQyLnR5cGUgPSAxMDA7Ci0gICAgcGF5bG9h ZDIuZW5jb2RpbmdOYW1lID0gIlZQOCI7Ci0gICAgcGF5bG9hZDIuY2xvY2tSYXRlID0gOTAwMDA7 Ci0gICAgcGF5bG9hZDIuY2NtZmlyID0gdHJ1ZTsKLSAgICBwYXlsb2FkMi5uYWNrcGxpID0gdHJ1 ZTsKLSAgICBwYXlsb2FkMi5uYWNrID0gdHJ1ZTsKLSAgICBwYXlsb2Fkcy5hcHBlbmQoV1RGTW92 ZShwYXlsb2FkMikpOworICAgIGlmIChtX2NvZGVjVHlwZXMuZmluZCgiVlA4IikgIT0gbm90Rm91 bmQpIHsKKyAgICAgICAgTWVkaWFQYXlsb2FkIHBheWxvYWQyOworICAgICAgICBwYXlsb2FkMi50 eXBlID0gMTAwOworICAgICAgICBwYXlsb2FkMi5lbmNvZGluZ05hbWUgPSAiVlA4IjsKKyAgICAg ICAgcGF5bG9hZDIuY2xvY2tSYXRlID0gOTAwMDA7CisgICAgICAgIHBheWxvYWQyLmNjbWZpciA9 IHRydWU7CisgICAgICAgIHBheWxvYWQyLm5hY2twbGkgPSB0cnVlOworICAgICAgICBwYXlsb2Fk Mi5uYWNrID0gdHJ1ZTsKKyAgICAgICAgcGF5bG9hZHMuYXBwZW5kKFdURk1vdmUocGF5bG9hZDIp KTsKKyAgICB9CiAKICAgICBNZWRpYVBheWxvYWQgcGF5bG9hZDM7CiAgICAgcGF5bG9hZDMudHlw ZSA9IDEyMDsKQEAgLTIzMSw2ICsyNDQsNyBAQCBNZWRpYUVuZHBvaW50OjpVcGRhdGVSZXN1bHQg TWVkaWFFbmRwb2ludE93cjo6dXBkYXRlUmVjZWl2ZUNvbmZpZ3VyYXRpb24oTWVkaWFFbgogICAg ICAgICB0cmFuc2NlaXZlckNvbmZpZ3MuYXBwZW5kKFdURk1vdmUoY29uZmlnKSk7CiAgICAgfQog CisgICAgZ19wcmludGVycigicmVjZWl2ZSBjb25maWcgaGFzICVsdSB0cmFuc2NlaXZlcnNcbiIs IHRyYW5zY2VpdmVyQ29uZmlncy5zaXplKCkpOwogICAgIGVuc3VyZVRyYW5zcG9ydEFnZW50QW5k VHJhbnNjZWl2ZXJzKGlzSW5pdGlhdG9yLCB0cmFuc2NlaXZlckNvbmZpZ3MpOwogCiAgICAgLy8g UHJlcGFyZSB0aGUgbmV3IHNlc3Npb25zLgpAQCAtMjY3LDggKzI4MSwxMCBAQCBNZWRpYUVuZHBv aW50OjpVcGRhdGVSZXN1bHQgTWVkaWFFbmRwb2ludE93cjo6dXBkYXRlU2VuZENvbmZpZ3VyYXRp b24oTWVkaWFFbmRwbwogICAgICAgICB0cmFuc2NlaXZlckNvbmZpZ3MuYXBwZW5kKFdURk1vdmUo Y29uZmlnKSk7CiAgICAgfQogCisgICAgZ19wcmludGVycigic2VuZCBjb25maWcgaGFzICVsdSB0 cmFuc2NlaXZlcnNcbiIsIHRyYW5zY2VpdmVyQ29uZmlncy5zaXplKCkpOwogICAgIGVuc3VyZVRy YW5zcG9ydEFnZW50QW5kVHJhbnNjZWl2ZXJzKGlzSW5pdGlhdG9yLCB0cmFuc2NlaXZlckNvbmZp Z3MpOwogCisgICAgZ19wcmludGVycigiJWx1IHRyYW5zY2VpdmVycywgJWx1IG1lZGlhRGVzY3Jp cHRpb25zXG4iLCBtX3RyYW5zY2VpdmVycy5zaXplKCksIGNvbmZpZ3VyYXRpb24tPm1lZGlhRGVz Y3JpcHRpb25zKCkuc2l6ZSgpKTsKICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgbV90cmFu c2NlaXZlcnMuc2l6ZSgpOyArK2kpIHsKICAgICAgICAgYXV0byogc2Vzc2lvbiA9IG1fdHJhbnNj ZWl2ZXJzW2ldLT5zZXNzaW9uKCk7CiAgICAgICAgIGF1dG8mIG1kZXNjID0gY29uZmlndXJhdGlv bi0+bWVkaWFEZXNjcmlwdGlvbnMoKVtpXTsKQEAgLTMwMSw4ICszMTcsOCBAQCBNZWRpYUVuZHBv aW50OjpVcGRhdGVSZXN1bHQgTWVkaWFFbmRwb2ludE93cjo6dXBkYXRlU2VuZENvbmZpZ3VyYXRp b24oTWVkaWFFbmRwbwogICAgICAgICBhdXRvKiBydHhQYXlsb2FkID0gZmluZFJ0eFBheWxvYWQo bWRlc2MucGF5bG9hZHMsIHBheWxvYWQtPnR5cGUpOwogICAgICAgICBhdXRvKiBzb3VyY2UgPSBz dGF0aWNfY2FzdDxSZWFsdGltZU1lZGlhU291cmNlT3dyKj4oc2VuZFNvdXJjZU1hcC5nZXQobWRl c2MubWlkKSk7CiAKLSAgICAgICAgQVNTRVJUKGNvZGVjVHlwZXMuZmluZChwYXlsb2FkLT5lbmNv ZGluZ05hbWUuY29udmVydFRvQVNDSUlVcHBlcmNhc2UoKSkgIT0gbm90Rm91bmQpOwotICAgICAg ICBhdXRvIGNvZGVjVHlwZSA9IHN0YXRpY19jYXN0PE93ckNvZGVjVHlwZT4oY29kZWNUeXBlcy5m aW5kKHBheWxvYWQtPmVuY29kaW5nTmFtZS5jb252ZXJ0VG9BU0NJSVVwcGVyY2FzZSgpKSk7Cisg ICAgICAgIEFTU0VSVChtX2NvZGVjVHlwZXMuZmluZChwYXlsb2FkLT5lbmNvZGluZ05hbWUuY29u dmVydFRvQVNDSUlVcHBlcmNhc2UoKSkgIT0gbm90Rm91bmQpOworICAgICAgICBhdXRvIGNvZGVj VHlwZSA9IHN0YXRpY19jYXN0PE93ckNvZGVjVHlwZT4obV9jb2RlY1R5cGVzLmZpbmQocGF5bG9h ZC0+ZW5jb2RpbmdOYW1lLmNvbnZlcnRUb0FTQ0lJVXBwZXJjYXNlKCkpKTsKIAogICAgICAgICBP d3JQYXlsb2FkKiBzZW5kUGF5bG9hZDsKICAgICAgICAgaWYgKG1kZXNjLnR5cGUgPT0gImF1ZGlv IikKQEAgLTUxMyw4ICs1MjksOCBAQCB2b2lkIE1lZGlhRW5kcG9pbnRPd3I6OnByZXBhcmVNZWRp YVNlc3Npb24oT3dyTWVkaWFTZXNzaW9uKiBtZWRpYVNlc3Npb24sIFBlZXJNZQogCiAgICAgICAg IGF1dG8qIHJ0eFBheWxvYWQgPSBmaW5kUnR4UGF5bG9hZChtZWRpYURlc2NyaXB0aW9uLT5wYXls b2FkcywgcGF5bG9hZC50eXBlKTsKIAotICAgICAgICBBU1NFUlQoY29kZWNUeXBlcy5maW5kKHBh eWxvYWQuZW5jb2RpbmdOYW1lKSAhPSBub3RGb3VuZCk7Ci0gICAgICAgIE93ckNvZGVjVHlwZSBj b2RlY1R5cGUgPSBzdGF0aWNfY2FzdDxPd3JDb2RlY1R5cGU+KGNvZGVjVHlwZXMuZmluZChwYXls b2FkLmVuY29kaW5nTmFtZS5jb252ZXJ0VG9BU0NJSVVwcGVyY2FzZSgpKSk7CisgICAgICAgIEFT U0VSVChtX2NvZGVjVHlwZXMuZmluZChwYXlsb2FkLmVuY29kaW5nTmFtZS5jb252ZXJ0VG9BU0NJ SVVwcGVyY2FzZSgpKSAhPSBub3RGb3VuZCk7CisgICAgICAgIE93ckNvZGVjVHlwZSBjb2RlY1R5 cGUgPSBzdGF0aWNfY2FzdDxPd3JDb2RlY1R5cGU+KG1fY29kZWNUeXBlcy5maW5kKHBheWxvYWQu ZW5jb2RpbmdOYW1lLmNvbnZlcnRUb0FTQ0lJVXBwZXJjYXNlKCkpKTsKIAogICAgICAgICBPd3JQ YXlsb2FkKiByZWNlaXZlUGF5bG9hZDsKICAgICAgICAgaWYgKG1lZGlhRGVzY3JpcHRpb24tPnR5 cGUgPT0gImF1ZGlvIikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlh c3RyZWFtL29wZW53ZWJydGMvTWVkaWFFbmRwb2ludE93ci5oIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbWVkaWFzdHJlYW0vb3BlbndlYnJ0Yy9NZWRpYUVuZHBvaW50T3dyLmgKaW5kZXggZjMx MDQ4Yy4uNWVmMzUwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFz dHJlYW0vb3BlbndlYnJ0Yy9NZWRpYUVuZHBvaW50T3dyLmgKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbWVkaWFzdHJlYW0vb3BlbndlYnJ0Yy9NZWRpYUVuZHBvaW50T3dyLmgKQEAgLTE0 Miw2ICsxNDIsOCBAQCBwcml2YXRlOgogCiAgICAgU3RyaW5nIG1fZHRsc1ByaXZhdGVLZXk7CiAg ICAgU3RyaW5nIG1fZHRsc0NlcnRpZmljYXRlOworCisgICAgVmVjdG9yPFN0cmluZz4gbV9jb2Rl Y1R5cGVzOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQotLSAKMi4xMC4yCgo=