163693 2016-10-19 14:01:09 -0700 [WK2] Expose suggested filename via WKBundleHitTestResult API 2016-10-19 16:58:19 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 156056 1 cdumez cdumez andersca barraclough bfulgham commit-queue rmondello sam oldest_to_newest 1242105 0 cdumez 2016-10-19 14:01:09 -0700 Expose suggested filename via WKBundleHitTestResult API. The implementation can rely on anchors' download attribute now that we support it. 1242106 1 cdumez 2016-10-19 14:01:26 -0700 <rdar://problem/28840734> 1242108 2 292109 cdumez 2016-10-19 14:03:45 -0700 Created attachment 292109 Patch 1242193 3 292109 commit-queue 2016-10-19 16:58:14 -0700 Comment on attachment 292109 Patch Clearing flags on attachment: 292109 Committed r207579: <http://trac.webkit.org/changeset/207579> 1242194 4 commit-queue 2016-10-19 16:58:19 -0700 All reviewed patches have been landed. Closing bug. 292109 2016-10-19 14:03:45 -0700 2016-10-19 16:58:14 -0700 Patch bug-163693-20161019140009.patch text/plain 6418 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3NTQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjk2Yzk0NmY3MzU2OTNh MWVmMzA2NTkyM2RlNjUyODAxMzZmNGQwZi4uZGQ2ZTdhZTc4N2VkZWY5MDE3MzVkMmFmMzZmZDdl YjlkYmY1MTEwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE2LTEwLTE5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW1dLMl0gRXhwb3NlIHN1Z2dl c3RlZCBmaWxlbmFtZSB2aWEgV0tCdW5kbGVIaXRUZXN0UmVzdWx0IEFQSQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzNjkzCisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8yODg0MDczND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBFeHBvc2Ugc3VnZ2VzdGVkIGZpbGVuYW1lIHZpYSBXS0J1bmRsZUhpdFRl c3RSZXN1bHQgQVBJLiBUaGUgaW1wbGVtZW50YXRpb24KKyAgICAgICAgY3VycmVudGx5IHJlbGll cyBvbiB0aGUgJ2Rvd25sb2FkJyBhdHRyaWJ1dGUgb24gYW5jaG9yIC8gYXJlYSBlbGVtZW50cwor ICAgICAgICB0aGF0IHdlIHJlY2VudGx5IHN0YXJ0ZWQgc3VwcG9ydGluZy4KKworICAgICAgICAq IFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVIaXRUZXN0UmVzdWx0LmNw cDoKKyAgICAgICAgKFdLQnVuZGxlSGl0VGVzdFJlc3VsdENvcHlMaW5rU3VnZ2VzdGVkRmlsZW5h bWUpOgorICAgICAgICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVI aXRUZXN0UmVzdWx0Lmg6CisgICAgICAgICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9Jbmpl Y3RlZEJ1bmRsZUhpdFRlc3RSZXN1bHQuY3BwOgorICAgICAgICAoV2ViS2l0OjpJbmplY3RlZEJ1 bmRsZUhpdFRlc3RSZXN1bHQ6OmNyZWF0ZSk6CisgICAgICAgIChXZWJLaXQ6OkluamVjdGVkQnVu ZGxlSGl0VGVzdFJlc3VsdDo6bWVkaWFUeXBlKToKKyAgICAgICAgKFdlYktpdDo6SW5qZWN0ZWRC dW5kbGVIaXRUZXN0UmVzdWx0OjpsaW5rU3VnZ2VzdGVkRmlsZW5hbWUpOgorICAgICAgICAoV2Vi S2l0OjpJbmplY3RlZEJ1bmRsZUhpdFRlc3RSZXN1bHQ6OmltYWdlUmVjdCk6CisgICAgICAgICog V2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZUhpdFRlc3RSZXN1bHQuaDoK KwogMjAxNi0xMC0xOSAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAg TW92ZSBYUGF0aCBmcm9tIEV4Y2VwdGlvbkNvZGUgdG8gRXhjZXB0aW9uCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlSGl0 VGVzdFJlc3VsdC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxl L0FQSS9jL1dLQnVuZGxlSGl0VGVzdFJlc3VsdC5jcHAKaW5kZXggMmU0YTdiNjMxZDEzMWNhMTc2 ZGM0ZDFiMTgxNWQ4ODE5ZjYwOTY4MC4uMmY2ZDJkMDRjZjFhMGE0OWIwZjk0N2VjOWIzYWMxNzNh ZWUyM2ZkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1 bmRsZS9BUEkvYy9XS0J1bmRsZUhpdFRlc3RSZXN1bHQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVIaXRUZXN0UmVzdWx0LmNw cApAQCAtMTIwLDMgKzEyMCw4IEBAIFdLU3RyaW5nUmVmIFdLQnVuZGxlSGl0VGVzdFJlc3VsdENv cHlMaW5rVGl0bGUoV0tCdW5kbGVIaXRUZXN0UmVzdWx0UmVmIGhpdFRlc3RSCiB7CiAgICAgcmV0 dXJuIHRvQ29waWVkQVBJKHRvSW1wbChoaXRUZXN0UmVzdWx0UmVmKS0+bGlua1RpdGxlKCkpOwog fQorCitXS1N0cmluZ1JlZiBXS0J1bmRsZUhpdFRlc3RSZXN1bHRDb3B5TGlua1N1Z2dlc3RlZEZp bGVuYW1lKFdLQnVuZGxlSGl0VGVzdFJlc3VsdFJlZiBoaXRUZXN0UmVzdWx0UmVmKQoreworICAg IHJldHVybiB0b0NvcGllZEFQSSh0b0ltcGwoaGl0VGVzdFJlc3VsdFJlZiktPmxpbmtTdWdnZXN0 ZWRGaWxlbmFtZSgpKTsKK30KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv SW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVIaXRUZXN0UmVzdWx0LmggYi9Tb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlSGl0VGVzdFJlc3Vs dC5oCmluZGV4IDk0MWJlY2FiMzY2Y2ZlMDFhNWFjYmEwY2Y0MjljZDE1MWZlMDVhNjQuLjY2Mzg4 YmY4ZGRkZWNmNGExZmVmZjk2MWExYTIyOTI5NjQwMWQ1NDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVIaXRUZXN0UmVz dWx0LmgKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkv Yy9XS0J1bmRsZUhpdFRlc3RSZXN1bHQuaApAQCAtNjIsNiArNjIsNyBAQCBXS19FWFBPUlQgYm9v bCBXS0J1bmRsZUhpdFRlc3RSZXN1bHRHZXRJc1NlbGVjdGVkKFdLQnVuZGxlSGl0VGVzdFJlc3Vs dFJlZiBoaXRUZQogCiBXS19FWFBPUlQgV0tTdHJpbmdSZWYgV0tCdW5kbGVIaXRUZXN0UmVzdWx0 Q29weUxpbmtMYWJlbChXS0J1bmRsZUhpdFRlc3RSZXN1bHRSZWYgaGl0VGVzdFJlc3VsdCk7CiBX S19FWFBPUlQgV0tTdHJpbmdSZWYgV0tCdW5kbGVIaXRUZXN0UmVzdWx0Q29weUxpbmtUaXRsZShX S0J1bmRsZUhpdFRlc3RSZXN1bHRSZWYgaGl0VGVzdFJlc3VsdCk7CitXS19FWFBPUlQgV0tTdHJp bmdSZWYgV0tCdW5kbGVIaXRUZXN0UmVzdWx0Q29weUxpbmtTdWdnZXN0ZWRGaWxlbmFtZShXS0J1 bmRsZUhpdFRlc3RSZXN1bHRSZWYgaGl0VGVzdFJlc3VsdCk7CiAKICNpZmRlZiBfX2NwbHVzcGx1 cwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRs ZS9JbmplY3RlZEJ1bmRsZUhpdFRlc3RSZXN1bHQuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZUhpdFRlc3RSZXN1bHQuY3BwCmluZGV4 IGMxMzA1ZWJkODk4NTU4YjJjODc3YzE3ZTlhMDVlMzk3MGVmYWVhODUuLjYyZTViZDNjNjgwOTE4 Yzc3ZjQ0MmYyNjI1M2ExZWJiMzcyNDAyMzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGVIaXRUZXN0UmVzdWx0LmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVu ZGxlSGl0VGVzdFJlc3VsdC5jcHAKQEAgLTM0LDYgKzM0LDggQEAKICNpbmNsdWRlIDxXZWJDb3Jl L0ZyYW1lLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9GcmFtZUxvYWRlci5oPgogI2luY2x1ZGUgPFdl YkNvcmUvRnJhbWVWaWV3Lmg+CisjaW5jbHVkZSA8V2ViQ29yZS9IVE1MQW5jaG9yRWxlbWVudC5o PgorI2luY2x1ZGUgPFdlYkNvcmUvSFRNTE5hbWVzLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9VUkwu aD4KICNpbmNsdWRlIDx3dGYvdGV4dC9XVEZTdHJpbmcuaD4KIApAQCAtNDEsNyArNDMsNyBAQCB1 c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIAogbmFtZXNwYWNlIFdlYktpdCB7CiAKLVJlZjxJbmpl Y3RlZEJ1bmRsZUhpdFRlc3RSZXN1bHQ+IEluamVjdGVkQnVuZGxlSGl0VGVzdFJlc3VsdDo6Y3Jl YXRlKGNvbnN0IFdlYkNvcmU6OkhpdFRlc3RSZXN1bHQmIGhpdFRlc3RSZXN1bHQpCitSZWY8SW5q ZWN0ZWRCdW5kbGVIaXRUZXN0UmVzdWx0PiBJbmplY3RlZEJ1bmRsZUhpdFRlc3RSZXN1bHQ6OmNy ZWF0ZShjb25zdCBIaXRUZXN0UmVzdWx0JiBoaXRUZXN0UmVzdWx0KQogewogICAgIHJldHVybiBh ZG9wdFJlZigqbmV3IEluamVjdGVkQnVuZGxlSGl0VGVzdFJlc3VsdChoaXRUZXN0UmVzdWx0KSk7 CiB9CkBAIC0xMTgsNyArMTIwLDcgQEAgQnVuZGxlSGl0VGVzdFJlc3VsdE1lZGlhVHlwZSBJbmpl Y3RlZEJ1bmRsZUhpdFRlc3RSZXN1bHQ6Om1lZGlhVHlwZSgpIGNvbnN0CiAjaWYgIUVOQUJMRShW SURFTykKICAgICByZXR1cm4gQnVuZGxlSGl0VGVzdFJlc3VsdE1lZGlhVHlwZU5vbmU7CiAjZWxz ZQotICAgIFdlYkNvcmU6Ok5vZGUqIG5vZGUgPSBtX2hpdFRlc3RSZXN1bHQuaW5uZXJOb25TaGFy ZWROb2RlKCk7CisgICAgTm9kZSogbm9kZSA9IG1faGl0VGVzdFJlc3VsdC5pbm5lck5vblNoYXJl ZE5vZGUoKTsKICAgICBpZiAoIWlzPEVsZW1lbnQ+KCpub2RlKSkKICAgICAgICAgcmV0dXJuIEJ1 bmRsZUhpdFRlc3RSZXN1bHRNZWRpYVR5cGVOb25lOwogICAgIApAQCAtMTM5LDIzICsxNDEsMzEg QEAgU3RyaW5nIEluamVjdGVkQnVuZGxlSGl0VGVzdFJlc3VsdDo6bGlua1RpdGxlKCkgY29uc3QK ICAgICByZXR1cm4gbV9oaXRUZXN0UmVzdWx0LnRpdGxlRGlzcGxheVN0cmluZygpOwogfQogCi1X ZWJDb3JlOjpJbnRSZWN0IEluamVjdGVkQnVuZGxlSGl0VGVzdFJlc3VsdDo6aW1hZ2VSZWN0KCkg Y29uc3QKK1N0cmluZyBJbmplY3RlZEJ1bmRsZUhpdFRlc3RSZXN1bHQ6OmxpbmtTdWdnZXN0ZWRG aWxlbmFtZSgpIGNvbnN0Cit7CisgICAgYXV0byogdXJsRWxlbWVudCA9IG1faGl0VGVzdFJlc3Vs dC5VUkxFbGVtZW50KCk7CisgICAgaWYgKCFpczxIVE1MQW5jaG9yRWxlbWVudD4odXJsRWxlbWVu dCkpCisgICAgICAgIHJldHVybiBTdHJpbmcoKTsKKyAgICByZXR1cm4gdXJsRWxlbWVudC0+YXR0 cmlidXRlV2l0aG91dFN5bmNocm9uaXphdGlvbihIVE1MTmFtZXM6OmRvd25sb2FkQXR0cik7Cit9 CisKK0ludFJlY3QgSW5qZWN0ZWRCdW5kbGVIaXRUZXN0UmVzdWx0OjppbWFnZVJlY3QoKSBjb25z dAogewotICAgIFdlYkNvcmU6OkludFJlY3QgaW1hZ2VSZWN0ID0gbV9oaXRUZXN0UmVzdWx0Lmlt YWdlUmVjdCgpOworICAgIEludFJlY3QgaW1hZ2VSZWN0ID0gbV9oaXRUZXN0UmVzdWx0LmltYWdl UmVjdCgpOwogICAgIGlmIChpbWFnZVJlY3QuaXNFbXB0eSgpKQogICAgICAgICByZXR1cm4gaW1h Z2VSZWN0OwogICAgICAgICAKLSAgICAvLyBUaGUgaW1hZ2UgcmVjdCBpbiBXZWJDb3JlOjpIaXRU ZXN0UmVzdWx0IGlzIGluIGZyYW1lIGNvb3JkaW5hdGVzLCBidXQgd2UgbmVlZCBpdCBpbiBXS1Zp ZXcKKyAgICAvLyBUaGUgaW1hZ2UgcmVjdCBpbiBIaXRUZXN0UmVzdWx0IGlzIGluIGZyYW1lIGNv b3JkaW5hdGVzLCBidXQgd2UgbmVlZCBpdCBpbiBXS1ZpZXcKICAgICAvLyBjb29yZGluYXRlcyBz aW5jZSBXZWJLaXQyIGNsaWVudHMgZG9uJ3QgaGF2ZSBlbm91Z2ggY29udGV4dCB0byBkbyB0aGUg Y29udmVyc2lvbiB0aGVtc2VsdmVzLgogICAgIFdlYkZyYW1lKiB3ZWJGcmFtZSA9IGZyYW1lKCk7 CiAgICAgaWYgKCF3ZWJGcmFtZSkKICAgICAgICAgcmV0dXJuIGltYWdlUmVjdDsKICAgICAKLSAg ICBXZWJDb3JlOjpGcmFtZSogY29yZUZyYW1lID0gd2ViRnJhbWUtPmNvcmVGcmFtZSgpOworICAg IEZyYW1lKiBjb3JlRnJhbWUgPSB3ZWJGcmFtZS0+Y29yZUZyYW1lKCk7CiAgICAgaWYgKCFjb3Jl RnJhbWUpCiAgICAgICAgIHJldHVybiBpbWFnZVJlY3Q7CiAgICAgCi0gICAgV2ViQ29yZTo6RnJh bWVWaWV3KiB2aWV3ID0gY29yZUZyYW1lLT52aWV3KCk7CisgICAgRnJhbWVWaWV3KiB2aWV3ID0g Y29yZUZyYW1lLT52aWV3KCk7CiAgICAgaWYgKCF2aWV3KQogICAgICAgICByZXR1cm4gaW1hZ2VS ZWN0OwogICAgIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3Rl ZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZUhpdFRlc3RSZXN1bHQuaCBiL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGVIaXRUZXN0UmVzdWx0LmgKaW5k ZXggY2I3NTg5ZWVlNGFjZmVjNGViNzNkZWMyYmM0ODRiNjFjYzJmM2Q5MC4uMjU4MmI0N2RkZjk5 YTc3Zjg2ZDg0ZTQ4MWZjN2I0ZjA1MWQ5MDI3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZUhpdFRlc3RSZXN1bHQuaAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVu ZGxlSGl0VGVzdFJlc3VsdC5oCkBAIC02MCw2ICs2MCw3IEBAIHB1YmxpYzoKIAogICAgIFN0cmlu ZyBsaW5rTGFiZWwoKSBjb25zdDsKICAgICBTdHJpbmcgbGlua1RpdGxlKCkgY29uc3Q7CisgICAg U3RyaW5nIGxpbmtTdWdnZXN0ZWRGaWxlbmFtZSgpIGNvbnN0OwogICAgIAogICAgIFdlYkNvcmU6 OkludFJlY3QgaW1hZ2VSZWN0KCkgY29uc3Q7CiAgICAgCg==