163629 2016-10-18 16:23:01 -0700 GetByVal to GetById conversion in the DFG is incorrect for getters with control flow 2016-10-18 16:42:55 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller commit-queue mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1241673 0 keith_miller 2016-10-18 16:23:01 -0700 GetByVal to GetById conversion in the DFG is incorrect for getters with control flow 1241676 1 291999 keith_miller 2016-10-18 16:28:35 -0700 Created attachment 291999 Patch 1241678 2 291999 ysuzuki 2016-10-18 16:31:48 -0700 Comment on attachment 291999 Patch Nice. r=me 1241684 3 keith_miller 2016-10-18 16:37:36 -0700 rdar://problem/28781434 1241686 4 webkit-bug-importer 2016-10-18 16:38:41 -0700 <rdar://problem/28834975> 1241687 5 webkit-bug-importer 2016-10-18 16:39:09 -0700 <rdar://problem/28834986> 1241690 6 keith_miller 2016-10-18 16:42:55 -0700 Committed r207500: <http://trac.webkit.org/changeset/207500> 291999 2016-10-18 16:28:35 -0700 2016-10-18 16:41:02 -0700 Patch bug-163629-20161018162500.patch text/plain 5934 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3MzYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk ZjM5MDExMzMxYTYyNDczMjBhNDA3YzlmZDgxMzhhMGNmMjgyZmUyLi5lYTMxODNmNjZhZGExZDZk YTQ5ZmE4NTkxYjdmY2JjYTM2OGUyN2ZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxNi0xMC0xOCAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBHZXRCeVZhbCB0byBHZXRCeUlkIGNvbnZlcnNpb24gaW4gdGhlIERG RyBpcyBpbmNvcnJlY3QgZm9yIGdldHRlcnMgd2l0aCBjb250cm9sIGZsb3cKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MzYyOQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggZml4ZXMgYSBi dWcgaW4gdGhlIERGRyB3aGVuIGF0dGVtcHQgdG8gY29udmVydCBhCisgICAgICAgIEdldEJ5VmFs IGludG8gYSBHZXRCeUlkLiBXaGlsZSBjb252ZXJ0aW5nIHRoZSBHZXRCeVZhbCwgZHVyaW5nCisg ICAgICAgIGhhbmRsZUdldEJ5SWQgaW4gdGhlIEJ5dGVjb2RlIHBhcnNlciwgd2Ugd291bGQgbWlz dGFrZW5seSB1c2UgdGhlCisgICAgICAgIG9wY29kZSBsZW5ndGggb2Ygb3BfZ2V0X2J5X2lkIHJh dGhlciB0aGFuIG9wX2dldF9ieV92YWwuIFRoaXMgY2F1c2VzCisgICAgICAgIHRoZSBuZXcgYmFz aWMgYmxvY2sgd2UgY3JlYXRlIHRvIHBvaW50IHRvIHRoZSB3cm9uZyBvZmZzZXQuIEluIHRoZQor ICAgICAgICBhZGRlZCB0ZXN0IHRoaXMgd2lsbCBjYXVzZSB1cyB0byBpbmZpbml0ZSBsb29wLgor CisgICAgICAgICogZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcDoKKyAgICAgICAgKEpTQzo6REZH OjpCeXRlQ29kZVBhcnNlcjo6aGFuZGxlR2V0QnlJZCk6CisgICAgICAgIChKU0M6OkRGRzo6Qnl0 ZUNvZGVQYXJzZXI6OnBhcnNlQmxvY2spOgorCiAyMDE2LTEwLTE0ICBLZWl0aCBNaWxsZXIgIDxr ZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEIzIG5lZWRzIGEgc3BlY2lhbCBXYXNt QWRkcmVzcyBPcGNvZGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH Qnl0ZUNvZGVQYXJzZXIuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdCeXRlQ29k ZVBhcnNlci5jcHAKaW5kZXggYmU4ZDNmMDI3NmY0NTI4NzFiNzU1NDhhMGIzN2I1ZWM4YzNiOTBi OS4uZTFkNmRmMTAyMzQwZTMxM2FhODgyMzMxYzU0MTUwNzAyNjQ5NDgzMSAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHAKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHAKQEAgLTIzOSw3ICsy MzksNyBAQCBwcml2YXRlOgogICAgIE5vZGUqIHN0b3JlKE5vZGUqIGJhc2UsIHVuc2lnbmVkIGlk ZW50aWZpZXIsIGNvbnN0IFB1dEJ5SWRWYXJpYW50JiwgTm9kZSogdmFsdWUpOwogCiAgICAgdm9p ZCBoYW5kbGVHZXRCeUlkKAotICAgICAgICBpbnQgZGVzdGluYXRpb25PcGVyYW5kLCBTcGVjdWxh dGVkVHlwZSwgTm9kZSogYmFzZSwgdW5zaWduZWQgaWRlbnRpZmllck51bWJlciwgR2V0QnlJZFN0 YXR1cywgQWNjZXNzVHlwZSk7CisgICAgICAgIGludCBkZXN0aW5hdGlvbk9wZXJhbmQsIFNwZWN1 bGF0ZWRUeXBlLCBOb2RlKiBiYXNlLCB1bnNpZ25lZCBpZGVudGlmaWVyTnVtYmVyLCBHZXRCeUlk U3RhdHVzLCBBY2Nlc3NUeXBlLCB1bnNpZ25lZCBpbnN0cnVjdGlvblNpemUpOwogICAgIHZvaWQg ZW1pdFB1dEJ5SWQoCiAgICAgICAgIE5vZGUqIGJhc2UsIHVuc2lnbmVkIGlkZW50aWZpZXJOdW1i ZXIsIE5vZGUqIHZhbHVlLCAgY29uc3QgUHV0QnlJZFN0YXR1cyYsIGJvb2wgaXNEaXJlY3QpOwog ICAgIHZvaWQgaGFuZGxlUHV0QnlJZCgKQEAgLTMyNzMsNyArMzI3Myw3IEBAIE5vZGUqIEJ5dGVD b2RlUGFyc2VyOjpzdG9yZShOb2RlKiBiYXNlLCB1bnNpZ25lZCBpZGVudGlmaWVyLCBjb25zdCBQ dXRCeUlkVmFyaWFuCiAKIHZvaWQgQnl0ZUNvZGVQYXJzZXI6OmhhbmRsZUdldEJ5SWQoCiAgICAg aW50IGRlc3RpbmF0aW9uT3BlcmFuZCwgU3BlY3VsYXRlZFR5cGUgcHJlZGljdGlvbiwgTm9kZSog YmFzZSwgdW5zaWduZWQgaWRlbnRpZmllck51bWJlciwKLSAgICBHZXRCeUlkU3RhdHVzIGdldEJ5 SWRTdGF0dXMsIEFjY2Vzc1R5cGUgdHlwZSkKKyAgICBHZXRCeUlkU3RhdHVzIGdldEJ5SWRTdGF0 dXMsIEFjY2Vzc1R5cGUgdHlwZSwgdW5zaWduZWQgaW5zdHJ1Y3Rpb25TaXplKQogewogICAgIC8v IEF0dGVtcHQgdG8gcmVkdWNlIHRoZSBzZXQgb2YgdGhpbmdzIGluIHRoZSBHZXRCeUlkU3RhdHVz LgogICAgIGlmIChiYXNlLT5vcCgpID09IE5ld09iamVjdCkgewpAQCAtMzQzNSw3ICszNDM1LDcg QEAgdm9pZCBCeXRlQ29kZVBhcnNlcjo6aGFuZGxlR2V0QnlJZCgKICAgICBhZGRUb0dyYXBoKEV4 aXRPSyk7CiAgICAgCiAgICAgaGFuZGxlQ2FsbCgKLSAgICAgICAgZGVzdGluYXRpb25PcGVyYW5k LCBDYWxsLCBJbmxpbmVDYWxsRnJhbWU6OkdldHRlckNhbGwsIE9QQ09ERV9MRU5HVEgob3BfZ2V0 X2J5X2lkKSwKKyAgICAgICAgZGVzdGluYXRpb25PcGVyYW5kLCBDYWxsLCBJbmxpbmVDYWxsRnJh bWU6OkdldHRlckNhbGwsIGluc3RydWN0aW9uU2l6ZSwKICAgICAgICAgZ2V0dGVyLCBudW1iZXJP ZlBhcmFtZXRlcnMgLSAxLCByZWdpc3Rlck9mZnNldCwgKnZhcmlhbnQuY2FsbExpbmtTdGF0dXMo KSwgcHJlZGljdGlvbik7CiB9CiAKQEAgLTQyMTEsNyArNDIxMSw3IEBAIGJvb2wgQnl0ZUNvZGVQ YXJzZXI6OnBhcnNlQmxvY2sodW5zaWduZWQgbGltaXQpCiAgICAgICAgICAgICB9CiAKICAgICAg ICAgICAgIGlmIChjb21waWxlZEFzR2V0QnlJZCkKLSAgICAgICAgICAgICAgICBoYW5kbGVHZXRC eUlkKGN1cnJlbnRJbnN0cnVjdGlvblsxXS51Lm9wZXJhbmQsIHByZWRpY3Rpb24sIGJhc2UsIGlk ZW50aWZpZXJOdW1iZXIsIGdldEJ5SWRTdGF0dXMsIEFjY2Vzc1R5cGU6OkdldCk7CisgICAgICAg ICAgICAgICAgaGFuZGxlR2V0QnlJZChjdXJyZW50SW5zdHJ1Y3Rpb25bMV0udS5vcGVyYW5kLCBw cmVkaWN0aW9uLCBiYXNlLCBpZGVudGlmaWVyTnVtYmVyLCBnZXRCeUlkU3RhdHVzLCBBY2Nlc3NU eXBlOjpHZXQsIE9QQ09ERV9MRU5HVEgob3BfZ2V0X2J5X3ZhbCkpOwogICAgICAgICAgICAgZWxz ZSB7CiAgICAgICAgICAgICAgICAgQXJyYXlNb2RlIGFycmF5TW9kZSA9IGdldEFycmF5TW9kZShj dXJyZW50SW5zdHJ1Y3Rpb25bNF0udS5hcnJheVByb2ZpbGUsIEFycmF5OjpSZWFkKTsKICAgICAg ICAgICAgICAgICBOb2RlKiBnZXRCeVZhbCA9IGFkZFRvR3JhcGgoR2V0QnlWYWwsIE9wSW5mbyhh cnJheU1vZGUuYXNXb3JkKCkpLCBPcEluZm8ocHJlZGljdGlvbiksIGJhc2UsIHByb3BlcnR5KTsK QEAgLTQzNDksOSArNDM0OSwxMSBAQCBib29sIEJ5dGVDb2RlUGFyc2VyOjpwYXJzZUJsb2NrKHVu c2lnbmVkIGxpbWl0KQogICAgICAgICAgICAgICAgIG1faW5saW5lU3RhY2tUb3AtPm1fc3R1Yklu Zm9zLCBtX2RmZ1N0dWJJbmZvcywKICAgICAgICAgICAgICAgICBjdXJyZW50Q29kZU9yaWdpbigp LCB1aWQpOwogICAgICAgICAgICAgQWNjZXNzVHlwZSB0eXBlID0gb3BfdHJ5X2dldF9ieV9pZCA9 PSBvcGNvZGVJRCA/IEFjY2Vzc1R5cGU6OkdldFB1cmUgOiBBY2Nlc3NUeXBlOjpHZXQ7Ci0gICAg ICAgICAgICAKKworICAgICAgICAgICAgdW5zaWduZWQgb3Bjb2RlTGVuZ3RoID0gb3Bjb2RlSUQg PT0gb3BfdHJ5X2dldF9ieV9pZCA/IE9QQ09ERV9MRU5HVEgob3BfdHJ5X2dldF9ieV9pZCkgOiBP UENPREVfTEVOR1RIKG9wX2dldF9ieV9pZCk7CisKICAgICAgICAgICAgIGhhbmRsZUdldEJ5SWQo Ci0gICAgICAgICAgICAgICAgY3VycmVudEluc3RydWN0aW9uWzFdLnUub3BlcmFuZCwgcHJlZGlj dGlvbiwgYmFzZSwgaWRlbnRpZmllck51bWJlciwgZ2V0QnlJZFN0YXR1cywgdHlwZSk7CisgICAg ICAgICAgICAgICAgY3VycmVudEluc3RydWN0aW9uWzFdLnUub3BlcmFuZCwgcHJlZGljdGlvbiwg YmFzZSwgaWRlbnRpZmllck51bWJlciwgZ2V0QnlJZFN0YXR1cywgdHlwZSwgb3Bjb2RlTGVuZ3Ro KTsKIAogICAgICAgICAgICAgaWYgKG9wX3RyeV9nZXRfYnlfaWQgPT0gb3Bjb2RlSUQpCiAgICAg ICAgICAgICAgICAgTkVYVF9PUENPREUob3BfdHJ5X2dldF9ieV9pZCk7IC8vIE9wY29kZSdzIGxl bmd0aCBpcyBkaWZmZXJlbnQgZnJvbSBvdGhlcnMgaW4gdGhpcyBjYXNlLgpkaWZmIC0tZ2l0IGEv SlNUZXN0cy9DaGFuZ2VMb2cgYi9KU1Rlc3RzL0NoYW5nZUxvZwppbmRleCAzZGE2ZGMzYWYzY2Jm YTEyZDI1NmY1NTAwZThhMjM5MDQzZTRjYWQyLi5jMzQwMmNhNjZiMjlkOGM0ZGFjYjk3ZjBhYmMw ZjFhMThmZWRmOGNhIDEwMDY0NAotLS0gYS9KU1Rlc3RzL0NoYW5nZUxvZworKysgYi9KU1Rlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE2LTEwLTE4ICBLZWl0aCBNaWxsZXIgIDxr ZWl0aF9taWxsZXJAYXBwbGUuY29tPgorCisgICAgICAgIEdldEJ5VmFsIHRvIEdldEJ5SWQgY29u dmVyc2lvbiBpbiB0aGUgREZHIGlzIGluY29ycmVjdCBmb3IgZ2V0dGVycyB3aXRoIGNvbnRyb2wg ZmxvdworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYz NjI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBz dHJlc3MvZ2V0LWJ5LXZhbC10by1pZC13aXRoLWdldHRlci5qczogQWRkZWQuCisgICAgICAgIChm b28pOgorICAgICAgICAoby5nZXQgaGVsbG8pOgorCiAyMDE2LTEwLTE0ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgdGVzdDI2MjogQGlzQ29uc3RydWN0 b3IgaW5jb3JyZWN0bHkgdGhpbmtzIE1hdGguY29zIGlzIGEgY29uc3RydWN0b3IKZGlmZiAtLWdp dCBhL0pTVGVzdHMvc3RyZXNzL2dldC1ieS12YWwtdG8taWQtd2l0aC1nZXR0ZXIuanMgYi9KU1Rl c3RzL3N0cmVzcy9nZXQtYnktdmFsLXRvLWlkLXdpdGgtZ2V0dGVyLmpzCm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmI0 NmMxNjUxNmVjYTU4NjgxMDRmMmVkNzk2ZTY5YWY3NjMyMzY0OWMKLS0tIC9kZXYvbnVsbAorKysg Yi9KU1Rlc3RzL3N0cmVzcy9nZXQtYnktdmFsLXRvLWlkLXdpdGgtZ2V0dGVyLmpzCkBAIC0wLDAg KzEsMjUgQEAKKworLy8gVGVzdCBHZXRCeVZhbCA9PiBHZXRCeUlkIGNvbnZlcnNpb24gd29ya3Mg Y29ycmVjdGx5IHdoZW4gaW5saW5pbmcgYSBnZXR0ZXIgaW4gdGhlIERGRy4KK2Z1bmN0aW9uIGZv byhvYmosIHZhbCkgeworICAgIGlmIChvYmpbdmFsXSkgeworICAgICAgICByZXR1cm4gMTsKKyAg ICB9CisgICAgcmV0dXJuIDA7Cit9Citub0lubGluZShmb28pOworCisKK28gPSB7IG51bTogMCwK KyAgICAgIGdldCBoZWxsbygpIHsKKyAgICAgICAgICBpZiAodGhpcy5udW0gPT09IDEpCisgICAg ICAgICAgICAgIHJldHVybiB0cnVlOworICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgIH0K KyAgICB9OworCitmb3IoaSA9IDA7IGkgPCAxMDAwMDA7ICsraSkgeworICAgIGxldCBudW0gPSBp ICUgMjsKKyAgICBvLm51bSA9IG51bTsKKyAgICBpZiAoZm9vKG8sICJoZWxsbyIpICE9PSBudW0p CisgICAgICAgIHRocm93IG5ldyBFcnJvcigiYmFkIHJlc3VsdCBvbiBpdGVyYXRpb246ICIgKyBp KTsKK30K