163622 2016-10-18 14:50:54 -0700 SpeculativeJIT::compileTryGetById needs to pass in NeedsToSpill along both the cell speculation and untyped speculation path 2016-10-21 15:41:12 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff oliver ticaiolima ysuzuki oldest_to_newest 1241626 0 saam 2016-10-18 14:50:54 -0700 ... 1242611 1 292268 saam 2016-10-20 15:16:35 -0700 Created attachment 292268 patch 1242613 2 292268 jfbastien 2016-10-20 15:21:44 -0700 Comment on attachment 292268 patch Looks good! 1242614 3 292268 ysuzuki 2016-10-20 15:22:50 -0700 Comment on attachment 292268 patch View in context: https://bugs.webkit.org/attachment.cgi?id=292268&action=review r=me > Source/JavaScriptCore/ChangeLog:11 > + that it allocated for it after the TryGetById node executed. Yeah, if base's use count remains, we still should keep this in that register! 1242627 4 292268 ggaren 2016-10-20 15:39:42 -0700 Comment on attachment 292268 patch View in context: https://bugs.webkit.org/attachment.cgi?id=292268&action=review > JSTests/stress/try-get-by-id-should-spill-registers-dfg.js:10 > +let f = createBuiltin(`(function (arg) { > + let r = @tryGetById(arg, "prototype"); > + if (arg !== true) throw new @Error("Bad clobber of arg"); > + return r; > + })`); > +noInline(f); > + > +for (let i = 0; i < 10000; i++) { > + f(true); > +} Looks like you used tabs instead of spaces? 1242629 5 292268 saam 2016-10-20 15:41:18 -0700 Comment on attachment 292268 patch View in context: https://bugs.webkit.org/attachment.cgi?id=292268&action=review >> JSTests/stress/try-get-by-id-should-spill-registers-dfg.js:10 >> +} > > Looks like you used tabs instead of spaces? I don't think I did but my indentation is a bit off. I'll fix before landing. 1243090 6 292403 saam 2016-10-21 14:21:40 -0700 Created attachment 292403 patch for landing 1243130 7 292403 commit-queue 2016-10-21 15:41:07 -0700 Comment on attachment 292403 patch for landing Clearing flags on attachment: 292403 Committed r207697: <http://trac.webkit.org/changeset/207697> 1243131 8 commit-queue 2016-10-21 15:41:12 -0700 All reviewed patches have been landed. Closing bug. 292268 2016-10-20 15:16:35 -0700 2016-10-21 14:21:40 -0700 patch a-backup.diff text/plain 3084 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMDc2NDApCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE2LTEwLTIwICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIFNwZWN1bGF0aXZlSklUOjpjb21waWxlVHJ5R2V0QnlJZCBuZWVkcyB0 byBwYXNzIGluIE5lZWRzVG9TcGlsbCBhbG9uZyBib3RoIHRoZSBjZWxsIHNwZWN1bGF0aW9uIGFu ZCB1bnR5cGVkIHNwZWN1bGF0aW9uIHBhdGgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE2MzYyMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogc3RyZXNzL3RyeS1nZXQtYnktaWQtc2hvdWxkLXNwaWxsLXJl Z2lzdGVycy1kZmcuanM6IEFkZGVkLgorICAgICAgICAobGV0LmYuY3JlYXRlQnVpbHRpbik6CisK IDIwMTYtMTAtMjAgIENhaXRsaW4gUG90dGVyICA8Y2FpdHBAaWdhbGlhLmNvbT4KIAogICAgICAg ICBbSlNDXSBkaXNhbGxvdyByZWZlcmVuY2VzIHRvIGBhd2FpdGAgaW4gQXN5bmNGdW5jdGlvbiBm b3JtYWwgcGFyYW1ldGVycwpJbmRleDogSlNUZXN0cy9zdHJlc3MvdHJ5LWdldC1ieS1pZC1zaG91 bGQtc3BpbGwtcmVnaXN0ZXJzLWRmZy5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy90 cnktZ2V0LWJ5LWlkLXNob3VsZC1zcGlsbC1yZWdpc3RlcnMtZGZnLmpzCShyZXZpc2lvbiAwKQor KysgSlNUZXN0cy9zdHJlc3MvdHJ5LWdldC1ieS1pZC1zaG91bGQtc3BpbGwtcmVnaXN0ZXJzLWRm Zy5qcwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDEwIEBACitsZXQgZiA9IGNyZWF0ZUJ1aWx0 aW4oYChmdW5jdGlvbiAoYXJnKSB7IAorICAgICAgICBsZXQgciA9IEB0cnlHZXRCeUlkKGFyZywg InByb3RvdHlwZSIpOworICAgICAgICBpZiAoYXJnICE9PSB0cnVlKSB0aHJvdyBuZXcgQEVycm9y KCJCYWQgY2xvYmJlciBvZiBhcmciKTsKKyAgICAgICAgcmV0dXJuIHI7CisgICAgfSlgKTsKK25v SW5saW5lKGYpOworCitmb3IgKGxldCBpID0gMDsgaSA8IDEwMDAwOyBpKyspIHsKKyAgICBmKHRy dWUpOworfQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMDc2MjkpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTggQEAKKzIwMTYtMTAtMjAgIFNhYW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CisK KyAgICAgICAgU3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVUcnlHZXRCeUlkIG5lZWRzIHRvIHBhc3Mg aW4gTmVlZHNUb1NwaWxsIGFsb25nIGJvdGggdGhlIGNlbGwgc3BlY3VsYXRpb24gYW5kIHVudHlw ZWQgc3BlY3VsYXRpb24gcGF0aAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTYzNjIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgV2Ugd2VyZSBwYXNzaW5nIGluIERvbnRTcGlsbCBpbiB0aGUgVW50eXBlZDpj aGlsZDEoKSBjYXNlLCB3aGljaCBjYXVzZWQgdXMKKyAgICAgICAgbm90IHRvIHNwaWxsIHRoZSBi YXNlIHJlZ2lzdGVyLiBUaGlzIGlzIG9idmlvdXNseSB3cm9uZyBiZWNhdXNlIHRoZQorICAgICAg ICBERkcncyByZWdpc3RlciBhbGxvY2F0b3IgZXhwZWN0ZWQgdGhlIGJhc2UgdG8gc3RpbGwgYmUg aW4gdGhlIHJlZ2lzdGVyCisgICAgICAgIHRoYXQgaXQgYWxsb2NhdGVkIGZvciBpdCBhZnRlciB0 aGUgVHJ5R2V0QnlJZCBub2RlIGV4ZWN1dGVkLgorCisgICAgICAgICogZGZnL0RGR1NwZWN1bGF0 aXZlSklULmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZVRy eUdldEJ5SWQpOgorCiAyMDE2LTEwLTIwICBDYWl0bGluIFBvdHRlciAgPGNhaXRwQGlnYWxpYS5j b20+CiAKICAgICAgICAgW0pTQ10gZGlzYWxsb3cgcmVmZXJlbmNlcyB0byBgYXdhaXRgIGluIEFz eW5jRnVuY3Rpb24gZm9ybWFsIHBhcmFtZXRlcnMKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCShyZXZpc2lvbiAyMDc2MjkpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTAyMCw3ICsxMDIwLDcgQEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZVRy eUdldEJ5SWQoTgogCiAgICAgICAgIEpJVENvbXBpbGVyOjpKdW1wIG5vdENlbGwgPSBtX2ppdC5i cmFuY2hJZk5vdENlbGwoYmFzZVJlZ3MpOwogCi0gICAgICAgIGNhY2hlZEdldEJ5SWQobm9kZS0+ b3JpZ2luLnNlbWFudGljLCBiYXNlUmVncywgcmVzdWx0UmVncywgbm9kZS0+aWRlbnRpZmllck51 bWJlcigpLCBub3RDZWxsLCBEb250U3BpbGwsIEFjY2Vzc1R5cGU6OkdldFB1cmUpOworICAgICAg ICBjYWNoZWRHZXRCeUlkKG5vZGUtPm9yaWdpbi5zZW1hbnRpYywgYmFzZVJlZ3MsIHJlc3VsdFJl Z3MsIG5vZGUtPmlkZW50aWZpZXJOdW1iZXIoKSwgbm90Q2VsbCwgTmVlZFRvU3BpbGwsIEFjY2Vz c1R5cGU6OkdldFB1cmUpOwogCiAgICAgICAgIGpzVmFsdWVSZXN1bHQocmVzdWx0UmVncywgbm9k ZSwgRGF0YUZvcm1hdEpTLCBVc2VDaGlsZHJlbkNhbGxlZEV4cGxpY2l0bHkpOwogICAgICAgICBi cmVhazsK 292403 2016-10-21 14:21:40 -0700 2016-10-21 15:41:07 -0700 patch for landing a-backup.diff text/plain 3067 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMDc2MjkpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE2LTEwLTIwICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIFNwZWN1bGF0aXZlSklUOjpjb21waWxlVHJ5R2V0QnlJZCBuZWVkcyB0 byBwYXNzIGluIE5lZWRzVG9TcGlsbCBhbG9uZyBib3RoIHRoZSBjZWxsIHNwZWN1bGF0aW9uIGFu ZCB1bnR5cGVkIHNwZWN1bGF0aW9uIHBhdGgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE2MzYyMgorCisgICAgICAgIFJldmlld2VkIGJ5IFl1c3VrZSBT dXp1a2kuCisKKyAgICAgICAgKiBzdHJlc3MvdHJ5LWdldC1ieS1pZC1zaG91bGQtc3BpbGwtcmVn aXN0ZXJzLWRmZy5qczogQWRkZWQuCisgICAgICAgIChsZXQuZi5jcmVhdGVCdWlsdGluKToKKwog MjAxNi0xMC0yMCAgQ2FpdGxpbiBQb3R0ZXIgIDxjYWl0cEBpZ2FsaWEuY29tPgogCiAgICAgICAg IFtKU0NdIGRpc2FsbG93IHJlZmVyZW5jZXMgdG8gYGF3YWl0YCBpbiBBc3luY0Z1bmN0aW9uIGZv cm1hbCBwYXJhbWV0ZXJzCkluZGV4OiBKU1Rlc3RzL3N0cmVzcy90cnktZ2V0LWJ5LWlkLXNob3Vs ZC1zcGlsbC1yZWdpc3RlcnMtZGZnLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL3Ry eS1nZXQtYnktaWQtc2hvdWxkLXNwaWxsLXJlZ2lzdGVycy1kZmcuanMJKG5vbmV4aXN0ZW50KQor KysgSlNUZXN0cy9zdHJlc3MvdHJ5LWdldC1ieS1pZC1zaG91bGQtc3BpbGwtcmVnaXN0ZXJzLWRm Zy5qcwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDEwIEBACitsZXQgZiA9IGNyZWF0ZUJ1aWx0 aW4oYChmdW5jdGlvbiAoYXJnKSB7IAorICAgIGxldCByID0gQHRyeUdldEJ5SWQoYXJnLCAicHJv dG90eXBlIik7CisgICAgaWYgKGFyZyAhPT0gdHJ1ZSkgdGhyb3cgbmV3IEBFcnJvcigiQmFkIGNs b2JiZXIgb2YgYXJnIik7CisgICAgcmV0dXJuIHI7Cit9KWApOworbm9JbmxpbmUoZik7CisKK2Zv ciAobGV0IGkgPSAwOyBpIDwgMTAwMDA7IGkrKykgeworICAgIGYodHJ1ZSk7Cit9CkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNzYyOSkKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxOCBAQAorMjAxNi0x MC0yMCAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KKworICAgICAgICBTcGVjdWxh dGl2ZUpJVDo6Y29tcGlsZVRyeUdldEJ5SWQgbmVlZHMgdG8gcGFzcyBpbiBOZWVkc1RvU3BpbGwg YWxvbmcgYm90aCB0aGUgY2VsbCBzcGVjdWxhdGlvbiBhbmQgdW50eXBlZCBzcGVjdWxhdGlvbiBw YXRoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjM2 MjIKKworICAgICAgICBSZXZpZXdlZCBieSBZdXN1a2UgU3V6dWtpLgorCisgICAgICAgIFdlIHdl cmUgcGFzc2luZyBpbiBEb250U3BpbGwgaW4gdGhlIFVudHlwZWQ6Y2hpbGQxKCkgY2FzZSwgd2hp Y2ggY2F1c2VkIHVzCisgICAgICAgIG5vdCB0byBzcGlsbCB0aGUgYmFzZSByZWdpc3Rlci4gVGhp cyBpcyBvYnZpb3VzbHkgd3JvbmcgYmVjYXVzZSB0aGUKKyAgICAgICAgREZHJ3MgcmVnaXN0ZXIg YWxsb2NhdG9yIGV4cGVjdGVkIHRoZSBiYXNlIHRvIHN0aWxsIGJlIGluIHRoZSByZWdpc3Rlcgor ICAgICAgICB0aGF0IGl0IGFsbG9jYXRlZCBmb3IgaXQgYWZ0ZXIgdGhlIFRyeUdldEJ5SWQgbm9k ZSBleGVjdXRlZC4KKworICAgICAgICAqIGRmZy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHA6CisgICAg ICAgIChKU0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVUcnlHZXRCeUlkKToKKwogMjAx Ni0xMC0yMCAgQ2FpdGxpbiBQb3R0ZXIgIDxjYWl0cEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtK U0NdIGRpc2FsbG93IHJlZmVyZW5jZXMgdG8gYGF3YWl0YCBpbiBBc3luY0Z1bmN0aW9uIGZvcm1h bCBwYXJhbWV0ZXJzCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0 aXZlSklULmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1Nw ZWN1bGF0aXZlSklULmNwcAkocmV2aXNpb24gMjA3NjI5KQorKysgU291cmNlL0phdmFTY3JpcHRD b3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwMjAsNyAr MTAyMCw3IEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVUcnlHZXRCeUlkKE4KIAogICAg ICAgICBKSVRDb21waWxlcjo6SnVtcCBub3RDZWxsID0gbV9qaXQuYnJhbmNoSWZOb3RDZWxsKGJh c2VSZWdzKTsKIAotICAgICAgICBjYWNoZWRHZXRCeUlkKG5vZGUtPm9yaWdpbi5zZW1hbnRpYywg YmFzZVJlZ3MsIHJlc3VsdFJlZ3MsIG5vZGUtPmlkZW50aWZpZXJOdW1iZXIoKSwgbm90Q2VsbCwg RG9udFNwaWxsLCBBY2Nlc3NUeXBlOjpHZXRQdXJlKTsKKyAgICAgICAgY2FjaGVkR2V0QnlJZChu b2RlLT5vcmlnaW4uc2VtYW50aWMsIGJhc2VSZWdzLCByZXN1bHRSZWdzLCBub2RlLT5pZGVudGlm aWVyTnVtYmVyKCksIG5vdENlbGwsIE5lZWRUb1NwaWxsLCBBY2Nlc3NUeXBlOjpHZXRQdXJlKTsK IAogICAgICAgICBqc1ZhbHVlUmVzdWx0KHJlc3VsdFJlZ3MsIG5vZGUsIERhdGFGb3JtYXRKUywg VXNlQ2hpbGRyZW5DYWxsZWRFeHBsaWNpdGx5KTsKICAgICAgICAgYnJlYWs7Cg==