163617 2016-10-18 13:41:32 -0700 Add JSC option to show time spent in each optimization phase 2016-10-18 14:31:45 -0700 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 msaboff msaboff commit-queue keith_miller mark.lam saam oldest_to_newest 1241596 0 msaboff 2016-10-18 13:41:32 -0700 This option would provide more detail than the reportXXXCompileTimes options. It would show the times for each phase of DFG / FTL compilation. 1241604 1 291981 msaboff 2016-10-18 13:53:26 -0700 Created attachment 291981 Patch 1241607 2 291981 mark.lam 2016-10-18 13:56:48 -0700 Comment on attachment 291981 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=291981&action=review > Source/JavaScriptCore/dfg/DFGPhase.h:82 > + before = monotonicallyIncreasingTimeMS(); Given that the DFG can run on a separate JIT thread concurrently, should you be using currentCPUTime() instead? 1241608 3 291981 saam 2016-10-18 13:57:26 -0700 Comment on attachment 291981 Patch r=me 1241609 4 msaboff 2016-10-18 14:04:07 -0700 (In reply to comment #2) > Comment on attachment 291981 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=291981&action=review > > > Source/JavaScriptCore/dfg/DFGPhase.h:82 > > + before = monotonicallyIncreasingTimeMS(); > > Given that the DFG can run on a separate JIT thread concurrently, should you > be using currentCPUTime() instead? All of the other time stats for the compiler tiers use monotonicallyIncreasingTime(). Given that the compilation threads "should" run without being preempted, I think we're fine. 1241617 5 291981 commit-queue 2016-10-18 14:31:40 -0700 Comment on attachment 291981 Patch Clearing flags on attachment: 291981 Committed r207491: <http://trac.webkit.org/changeset/207491> 1241618 6 commit-queue 2016-10-18 14:31:45 -0700 All reviewed patches have been landed. Closing bug. 291981 2016-10-18 13:53:26 -0700 2016-10-18 14:31:40 -0700 Patch 163617.patch text/plain 4068 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA3NDg2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDE2LTEwLTE4ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEFkZCBKU0Mgb3B0aW9uIHRvIHNob3cgdGltZSBzcGVudCBpbiBlYWNoIG9wdGltaXphdGlv biBwaGFzZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTYzNjE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWRkZWQgcmVwb3J0REZHUGhhc2VUaW1lcyBvcHRpb24uICBUaGlzIG91dHB1dHMgb25lIGxpbmUg cGVyIHBoYXNlIHNpbWlsYXIgdG8KKyAgICAgICAgICAgIFBoYXNlIENQUyByZXRocmVhZGluZyB0 b29rIDAuMjY2MSBtcworCisgICAgICAgIE9uZSBsaW5lIGlzIG91dHB1dCBmb3IgZWFjaCBwaGFz ZSBydW4uCisKKyAgICAgICAgKiBkZmcvREZHUGhhc2UuaDoKKyAgICAgICAgKEpTQzo6REZHOjpy dW5BbmRMb2cpOgorICAgICAgICAqIGRmZy9ERkdQbGFuLmNwcDoKKyAgICAgICAgKEpTQzo6REZH OjpQbGFuOjpjb21waWxlSW5UaHJlYWQpOgorICAgICAgICAqIHJ1bnRpbWUvT3B0aW9ucy5jcHA6 CisgICAgICAgIChKU0M6OnJlY29tcHV0ZURlcGVuZGVudE9wdGlvbnMpOgorICAgICAgICAqIHJ1 bnRpbWUvT3B0aW9ucy5oOgorCiAyMDE2LTEwLTE4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBs ZS5jb20+CiAKICAgICAgICAgV1RGIHNob3VsZCBtYWtlIGl0IGVhc2llciB0byBjcmVhdGUgdGhy ZWFkcyB0aGF0IGRpZSBhdXRvbWF0aWNhbGx5IGFmdGVyIGluYWN0aXZpdHkKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHUGhhc2UuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR1BoYXNlLmgJKHJldmlzaW9uIDIwNzQ3MykKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9kZmcvREZHUGhhc2UuaAkod29ya2luZyBjb3B5KQpAQCAtNzYsNyArNzYs MTcgQEAgcHJpdmF0ZToKIHRlbXBsYXRlPHR5cGVuYW1lIFBoYXNlVHlwZT4KIGJvb2wgcnVuQW5k TG9nKFBoYXNlVHlwZSYgcGhhc2UpCiB7CisgICAgZG91YmxlIGJlZm9yZSA9IDA7CisKKyAgICBp ZiAoVU5MSUtFTFkoT3B0aW9uczo6cmVwb3J0REZHUGhhc2VUaW1lcygpKSkKKyAgICAgICAgYmVm b3JlID0gbW9ub3RvbmljYWxseUluY3JlYXNpbmdUaW1lTVMoKTsKKwogICAgIGJvb2wgcmVzdWx0 ID0gcGhhc2UucnVuKCk7CisKKyAgICBpZiAoVU5MSUtFTFkoT3B0aW9uczo6cmVwb3J0REZHUGhh c2VUaW1lcygpKSkgeworICAgICAgICBkb3VibGUgYWZ0ZXIgPSBtb25vdG9uaWNhbGx5SW5jcmVh c2luZ1RpbWVNUygpOworICAgICAgICBkYXRhTG9nRigiUGhhc2UgJXMgdG9vayAlLjRmIG1zXG4i LCBwaGFzZS5uYW1lKCksIGFmdGVyIC0gYmVmb3JlKTsKKyAgICB9CiAgICAgaWYgKHJlc3VsdCAm JiBsb2dDb21waWxhdGlvbkNoYW5nZXMocGhhc2UuZ3JhcGgoKS5tX3BsYW4ubW9kZSkpCiAgICAg ICAgIGRhdGFMb2dGKCJQaGFzZSAlcyBjaGFuZ2VkIHRoZSBJUi5cbiIsIHBoYXNlLm5hbWUoKSk7 CiAgICAgcmV0dXJuIHJlc3VsdDsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH UGxhbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdQbGFu LmNwcAkocmV2aXNpb24gMjA3NDczKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdQ bGFuLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTgzLDcgKzE4Myw3IEBAIHZvaWQgUGxhbjo6Y29t cGlsZUluVGhyZWFkKExvbmdMaXZlZFN0YXQKICAgICAKICAgICBDb21waWxhdGlvblNjb3BlIGNv bXBpbGF0aW9uU2NvcGU7CiAKLSAgICBpZiAobG9nQ29tcGlsYXRpb25DaGFuZ2VzKG1vZGUpKQor ICAgIGlmIChsb2dDb21waWxhdGlvbkNoYW5nZXMobW9kZSkgfHwgT3B0aW9uczo6cmVwb3J0REZH UGhhc2VUaW1lcygpKQogICAgICAgICBkYXRhTG9nKCJERkcoUGxhbikgY29tcGlsaW5nICIsICpj b2RlQmxvY2ssICIgd2l0aCAiLCBtb2RlLCAiLCBudW1iZXIgb2YgaW5zdHJ1Y3Rpb25zID0gIiwg Y29kZUJsb2NrLT5pbnN0cnVjdGlvbkNvdW50KCksICJcbiIpOwogCiAgICAgQ29tcGlsYXRpb25Q YXRoIHBhdGggPSBjb21waWxlSW5UaHJlYWRJbXBsKGxvbmdMaXZlZFN0YXRlKTsKSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09wdGlvbnMuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09wdGlvbnMuY3BwCShyZXZpc2lvbiAyMDc0NzMp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9PcHRpb25zLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMzQ5LDYgKzM0OSw3IEBAIHN0YXRpYyB2b2lkIHJlY29tcHV0ZURlcGVuZGVudE9w dGlvbnMoKQogICAgICAgICB8fCBPcHRpb25zOjpyZXBvcnRCYXNlbGluZUNvbXBpbGVUaW1lcygp CiAgICAgICAgIHx8IE9wdGlvbnM6OnJlcG9ydERGR0NvbXBpbGVUaW1lcygpCiAgICAgICAgIHx8 IE9wdGlvbnM6OnJlcG9ydEZUTENvbXBpbGVUaW1lcygpCisgICAgICAgIHx8IE9wdGlvbnM6OnJl cG9ydERGR1BoYXNlVGltZXMoKQogICAgICAgICB8fCBPcHRpb25zOjp2ZXJib3NlQ0ZBKCkKICAg ICAgICAgfHwgT3B0aW9uczo6dmVyYm9zZUZUTEZhaWx1cmUoKSkKICAgICAgICAgT3B0aW9uczo6 YWx3YXlzQ29tcHV0ZUhhc2goKSA9IHRydWU7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9PcHRpb25zLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvT3B0aW9ucy5oCShyZXZpc2lvbiAyMDc0NzMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9PcHRpb25zLmgJKHdvcmtpbmcgY29weSkKQEAgLTE3Myw2ICsxNzMsNyBAQCB0 eXBlZGVmIGNvbnN0IGNoYXIqIG9wdGlvblN0cmluZzsKICAgICB2KGJvb2wsIHJlcG9ydEJhc2Vs aW5lQ29tcGlsZVRpbWVzLCBmYWxzZSwgTm9ybWFsLCAiZHVtcHMgSlMgZnVuY3Rpb24gc2lnbmF0 dXJlIGFuZCB0aGUgdGltZSBpdCB0b29rIHRvIEJhc2VsaW5lSklUIGNvbXBpbGUiKSBcCiAgICAg dihib29sLCByZXBvcnRERkdDb21waWxlVGltZXMsIGZhbHNlLCBOb3JtYWwsICJkdW1wcyBKUyBm dW5jdGlvbiBzaWduYXR1cmUgYW5kIHRoZSB0aW1lIGl0IHRvb2sgdG8gREZHIGFuZCBGVEwgY29t cGlsZSIpIFwKICAgICB2KGJvb2wsIHJlcG9ydEZUTENvbXBpbGVUaW1lcywgZmFsc2UsIE5vcm1h bCwgImR1bXBzIEpTIGZ1bmN0aW9uIHNpZ25hdHVyZSBhbmQgdGhlIHRpbWUgaXQgdG9vayB0byBG VEwgY29tcGlsZSIpIFwKKyAgICB2KGJvb2wsIHJlcG9ydERGR1BoYXNlVGltZXMsIGZhbHNlLCBO b3JtYWwsICJkdW1wcyBKUyBmdW5jdGlvbiBuYW1lIGFuZCB0aGUgdGltZSBpcyB0b29rIGZvciBl YWNoIERGRyBwaGFzZSIpIFwKICAgICB2KGJvb2wsIHJlcG9ydFRvdGFsQ29tcGlsZVRpbWVzLCBm YWxzZSwgTm9ybWFsLCBudWxscHRyKSBcCiAgICAgdihib29sLCB2ZXJib3NlRXhpdFByb2ZpbGUs IGZhbHNlLCBOb3JtYWwsIG51bGxwdHIpIFwKICAgICB2KGJvb2wsIHZlcmJvc2VDRkEsIGZhbHNl LCBOb3JtYWwsIG51bGxwdHIpIFwK