163612 2016-10-18 12:48:40 -0700 Web Inspector: CSS Autocompletion sometimes adds extra unexpected characters 2016-10-18 13:23:48 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue joepeck mattbaker nvasilyev timothy vicki webkit-bug-importer oldest_to_newest 1241559 0 joepeck 2016-10-18 12:48:40 -0700 Summary: CSS Autocompletion sometimes adds extra unexpected characters Steps to Reproduce: 1. Inspect <body> on about:blank 2. Show Styles - Rules sidebar 3. Type "transform: translate(10px)" 4. Place cursor at "translate|(" and push Esc to force completions => Expected suggestions like: "transform: translateX(10px)" => Actual suggestions like: "transform: translateX() (10px)" 5. Type: "color: blue;" 6. Place cursor at "bl|ue" and push Esc to force completions => Expected no completions, or fancy suggestions for "bl" that account for the "ue" in a reasonable way => Actual result: "color: black ue;" Notes: This makes working in the style sidebar pretty frustrating for me. 1241561 1 webkit-bug-importer 2016-10-18 12:49:05 -0700 <rdar://problem/28829557> 1241562 2 291972 joepeck 2016-10-18 12:50:00 -0700 Created attachment 291972 [PATCH] Proposed Fix 1241566 3 291974 joepeck 2016-10-18 12:52:35 -0700 Created attachment 291974 [PATCH] Proposed Fix 1241574 4 291974 timothy 2016-10-18 13:00:35 -0700 Comment on attachment 291974 [PATCH] Proposed Fix Nice! 1241583 5 291974 commit-queue 2016-10-18 13:23:44 -0700 Comment on attachment 291974 [PATCH] Proposed Fix Clearing flags on attachment: 291974 Committed r207481: <http://trac.webkit.org/changeset/207481> 1241584 6 commit-queue 2016-10-18 13:23:48 -0700 All reviewed patches have been landed. Closing bug. 291972 2016-10-18 12:50:00 -0700 2016-10-18 12:52:35 -0700 [PATCH] Proposed Fix completion-1.patch text/plain 3217 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDAwNDQ0MjkuLmIzZTc1YjYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTEwLTE4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ1NTIEF1 dG9jb21wbGV0aW9uIHNvbWV0aW1lcyBhZGRzIGV4dHJhIHVuZXhwZWN0ZWQgY2hhcmFjdGVycwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzNjEyCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50 ZXJmYWNlL0NvbnRyb2xsZXJzL0NvZGVNaXJyb3JDb21wbGV0aW9uQ29udHJvbGxlci5qczoKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5Db2RlTWlycm9yQ29tcGxldGlvbkNvbnRyb2xsZXIucHJvdG90 eXBlLl9nZW5lcmF0ZUNTU0NvbXBsZXRpb25zKToKKyAgICAgICAgQmV0dGVyIGhhbmRsZSBjb21w bGV0aW9ucyBpbiBjYXNlcyB3aGVyZSB3ZSBhcmUgaW4gdGhlIG1pZGRsZSBvZiBhIHByb3BlcnR5 CisgICAgICAgIHRvIGF2b2lkIG9ycGhhbmVkIGNoYXJhY3RlcnMsIG9yIGF0IHRoZSBlbmQgb2Yg YSBmdW5jdGlvbiBuYW1lIHRvIGF2b2lkIGNyZWF0aW5nCisgICAgICAgIGR1cGxpY2F0ZSBwYXJh bnRoZXNpcy4KKwogMjAxNi0xMC0xNSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IENsZWFudXAgcGFydHMgb2YgRGVidWdnZXJN YW5hZ2VyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9D b250cm9sbGVycy9Db2RlTWlycm9yQ29tcGxldGlvbkNvbnRyb2xsZXIuanMgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9Db2RlTWlycm9yQ29tcGxldGlv bkNvbnRyb2xsZXIuanMKaW5kZXggZTYwMzAxOS4uMzNkN2NjYiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvQ29kZU1pcnJvckNvbXBs ZXRpb25Db250cm9sbGVyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL0NvbnRyb2xsZXJzL0NvZGVNaXJyb3JDb21wbGV0aW9uQ29udHJvbGxlci5qcwpAQCAtNTM3 LDYgKzUzNywxMCBAQCBXZWJJbnNwZWN0b3IuQ29kZU1pcnJvckNvbXBsZXRpb25Db250cm9sbGVy ID0gY2xhc3MgQ29kZU1pcnJvckNvbXBsZXRpb25Db250cm9sbAogICAgICAgICBpZiAobWFpblRv a2VuLnN0YXRlLnN0YXRlID09PSAibWVkaWEiIHx8IG1haW5Ub2tlbi5zdGF0ZS5zdGF0ZSA9PT0g InRvcCIgfHwgbWFpblRva2VuLnN0YXRlLnN0YXRlID09PSAicGFyZW5zIikKICAgICAgICAgICAg IHJldHVybiBbXTsKIAorICAgICAgICAvLyBEb24ndCBjb21wbGV0ZSBpbiB0aGUgbWlkZGxlIG9m IGEgcHJvcGVydHkgbmFtZS4KKyAgICAgICAgaWYgKC9eW2Etel0vaS50ZXN0KHN1ZmZpeCkpCisg ICAgICAgICAgICByZXR1cm4gW107CisKICAgICAgICAgdmFyIHRva2VuID0gbWFpblRva2VuOwog ICAgICAgICB2YXIgbGluZU51bWJlciA9IHRoaXMuX2xpbmVOdW1iZXI7CiAKQEAgLTU2MSwxNCAr NTY1LDI0IEBAIFdlYkluc3BlY3Rvci5Db2RlTWlycm9yQ29tcGxldGlvbkNvbnRyb2xsZXIgPSBj bGFzcyBDb2RlTWlycm9yQ29tcGxldGlvbkNvbnRyb2xsCiAgICAgICAgICAgICB2YXIgcHJvcGVy dHlOYW1lID0gdG9rZW4uc3RyaW5nOwogCiAgICAgICAgICAgICAvLyBJZiB0aGVyZSBpcyBhIHN1 ZmZpeCBhbmQgaXQgaXNuJ3QgYSBzZW1pY29sb24sIHRoZW4gd2Ugc2hvdWxkIHVzZSBhIHNwYWNl IHNpbmNlCi0gICAgICAgICAgICAvLyB0aGUgdXNlciBpcyBlZGl0aW5nIGluIHRoZSBtaWRkbGUu Ci0gICAgICAgICAgICB0aGlzLl9pbXBsaWNpdFN1ZmZpeCA9IHN1ZmZpeCAmJiBzdWZmaXggIT09 ICI7IiA/ICIgIiA6ICh0aGlzLl9ub0VuZGluZ1NlbWljb2xvbiA/ICIiIDogIjsiKTsKKyAgICAg ICAgICAgIC8vIHRoZSB1c2VyIGlzIGVkaXRpbmcgaW4gdGhlIG1pZGRsZS4gTGlrZXdpc2UgaWYg dGhlIHN1ZmZpeCBzdGFydHMgd2l0aCBhbiBvcGVuCisgICAgICAgICAgICAvLyBwYXJlbiB3ZSBh cmUgY2hhbmdpbmcgYSBmdW5jdGlvbiBuYW1lIHNvIGRvbid0IGFkZCBhIHN1ZmZpeC4KKyAgICAg ICAgICAgIHRoaXMuX2ltcGxpY2l0U3VmZml4ID0gIiAiOworICAgICAgICAgICAgaWYgKHN1ZmZp eCA9PT0gIjsiKQorICAgICAgICAgICAgICAgIHRoaXMuX2ltcGxpY2l0U3VmZml4ID0gdGhpcy5f bm9FbmRpbmdTZW1pY29sb24gPyAiIiA6ICI7IjsKKyAgICAgICAgICAgIGVsc2UgaWYgKHN1ZmZp eC5zdGFydHNXaXRoKCIoIikpCisgICAgICAgICAgICAgICAgdGhpcy5faW1wbGljaXRTdWZmaXgg PSAiIjsKIAogICAgICAgICAgICAgLy8gRG9uJ3QgdXNlIGFuIGltcGxpY2l0IHN1ZmZpeCBpZiBp dCB3b3VsZCBiZSB0aGUgc2FtZSBhcyB0aGUgZXhpc3Rpbmcgc3VmZml4LgogICAgICAgICAgICAg aWYgKHRoaXMuX2ltcGxpY2l0U3VmZml4ID09PSBzdWZmaXgpCiAgICAgICAgICAgICAgICAgdGhp cy5faW1wbGljaXRTdWZmaXggPSAiIjsKIAotICAgICAgICAgICAgcmV0dXJuIFdlYkluc3BlY3Rv ci5DU1NLZXl3b3JkQ29tcGxldGlvbnMuZm9yUHJvcGVydHkocHJvcGVydHlOYW1lKS5zdGFydHNX aXRoKHRoaXMuX3ByZWZpeCk7CisgICAgICAgICAgICBsZXQgY29tcGxldGlvbnMgPSBXZWJJbnNw ZWN0b3IuQ1NTS2V5d29yZENvbXBsZXRpb25zLmZvclByb3BlcnR5KHByb3BlcnR5TmFtZSkuc3Rh cnRzV2l0aCh0aGlzLl9wcmVmaXgpOworCisgICAgICAgICAgICBpZiAoc3VmZml4LnN0YXJ0c1dp dGgoIigiKSkKKyAgICAgICAgICAgICAgICBjb21wbGV0aW9ucyA9IGNvbXBsZXRpb25zLm1hcCgo eCkgPT4geC5yZXBsYWNlKC9cKFwpJC8sICIiKSk7CisKKyAgICAgICAgICAgIHJldHVybiBjb21w bGV0aW9uczsKICAgICAgICAgfQogCiAgICAgICAgIHRoaXMuX2ltcGxpY2l0U3VmZml4ID0gc3Vm Zml4ICE9PSAiOiIgPyAiOiAiIDogIiI7Cg== 291974 2016-10-18 12:52:35 -0700 2016-10-18 13:23:44 -0700 [PATCH] Proposed Fix completion-2.patch text/plain 3252 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDAwNDQ0MjkuLmU2MTFjMWMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTEwLTE4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ1NTIEF1 dG9jb21wbGV0aW9uIHNvbWV0aW1lcyBhZGRzIGV4dHJhIHVuZXhwZWN0ZWQgY2hhcmFjdGVycwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzNjEyCisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yODgyOTU1Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvQ29k ZU1pcnJvckNvbXBsZXRpb25Db250cm9sbGVyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNv ZGVNaXJyb3JDb21wbGV0aW9uQ29udHJvbGxlci5wcm90b3R5cGUuX2dlbmVyYXRlQ1NTQ29tcGxl dGlvbnMpOgorICAgICAgICBCZXR0ZXIgaGFuZGxlIGNvbXBsZXRpb25zIGluIGNhc2VzIHdoZXJl IHdlIGFyZSBpbiB0aGUgbWlkZGxlIG9mIGEgcHJvcGVydHkKKyAgICAgICAgdG8gYXZvaWQgb3Jw aGFuZWQgY2hhcmFjdGVycywgb3IgYXQgdGhlIGVuZCBvZiBhIGZ1bmN0aW9uIG5hbWUgdG8gYXZv aWQgY3JlYXRpbmcKKyAgICAgICAgZHVwbGljYXRlIHBhcmVudGhlc2lzLgorCiAyMDE2LTEwLTE1 ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIElu c3BlY3RvcjogQ2xlYW51cCBwYXJ0cyBvZiBEZWJ1Z2dlck1hbmFnZXIKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0NvZGVNaXJyb3JD b21wbGV0aW9uQ29udHJvbGxlci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL0NvbnRyb2xsZXJzL0NvZGVNaXJyb3JDb21wbGV0aW9uQ29udHJvbGxlci5qcwppbmRleCBl NjAzMDE5Li4zM2Q3Y2NiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9Db250cm9sbGVycy9Db2RlTWlycm9yQ29tcGxldGlvbkNvbnRyb2xsZXIuanMKKysr IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvQ29kZU1p cnJvckNvbXBsZXRpb25Db250cm9sbGVyLmpzCkBAIC01MzcsNiArNTM3LDEwIEBAIFdlYkluc3Bl Y3Rvci5Db2RlTWlycm9yQ29tcGxldGlvbkNvbnRyb2xsZXIgPSBjbGFzcyBDb2RlTWlycm9yQ29t cGxldGlvbkNvbnRyb2xsCiAgICAgICAgIGlmIChtYWluVG9rZW4uc3RhdGUuc3RhdGUgPT09ICJt ZWRpYSIgfHwgbWFpblRva2VuLnN0YXRlLnN0YXRlID09PSAidG9wIiB8fCBtYWluVG9rZW4uc3Rh dGUuc3RhdGUgPT09ICJwYXJlbnMiKQogICAgICAgICAgICAgcmV0dXJuIFtdOwogCisgICAgICAg IC8vIERvbid0IGNvbXBsZXRlIGluIHRoZSBtaWRkbGUgb2YgYSBwcm9wZXJ0eSBuYW1lLgorICAg ICAgICBpZiAoL15bYS16XS9pLnRlc3Qoc3VmZml4KSkKKyAgICAgICAgICAgIHJldHVybiBbXTsK KwogICAgICAgICB2YXIgdG9rZW4gPSBtYWluVG9rZW47CiAgICAgICAgIHZhciBsaW5lTnVtYmVy ID0gdGhpcy5fbGluZU51bWJlcjsKIApAQCAtNTYxLDE0ICs1NjUsMjQgQEAgV2ViSW5zcGVjdG9y LkNvZGVNaXJyb3JDb21wbGV0aW9uQ29udHJvbGxlciA9IGNsYXNzIENvZGVNaXJyb3JDb21wbGV0 aW9uQ29udHJvbGwKICAgICAgICAgICAgIHZhciBwcm9wZXJ0eU5hbWUgPSB0b2tlbi5zdHJpbmc7 CiAKICAgICAgICAgICAgIC8vIElmIHRoZXJlIGlzIGEgc3VmZml4IGFuZCBpdCBpc24ndCBhIHNl bWljb2xvbiwgdGhlbiB3ZSBzaG91bGQgdXNlIGEgc3BhY2Ugc2luY2UKLSAgICAgICAgICAgIC8v IHRoZSB1c2VyIGlzIGVkaXRpbmcgaW4gdGhlIG1pZGRsZS4KLSAgICAgICAgICAgIHRoaXMuX2lt cGxpY2l0U3VmZml4ID0gc3VmZml4ICYmIHN1ZmZpeCAhPT0gIjsiID8gIiAiIDogKHRoaXMuX25v RW5kaW5nU2VtaWNvbG9uID8gIiIgOiAiOyIpOworICAgICAgICAgICAgLy8gdGhlIHVzZXIgaXMg ZWRpdGluZyBpbiB0aGUgbWlkZGxlLiBMaWtld2lzZSBpZiB0aGUgc3VmZml4IHN0YXJ0cyB3aXRo IGFuIG9wZW4KKyAgICAgICAgICAgIC8vIHBhcmVuIHdlIGFyZSBjaGFuZ2luZyBhIGZ1bmN0aW9u IG5hbWUgc28gZG9uJ3QgYWRkIGEgc3VmZml4LgorICAgICAgICAgICAgdGhpcy5faW1wbGljaXRT dWZmaXggPSAiICI7CisgICAgICAgICAgICBpZiAoc3VmZml4ID09PSAiOyIpCisgICAgICAgICAg ICAgICAgdGhpcy5faW1wbGljaXRTdWZmaXggPSB0aGlzLl9ub0VuZGluZ1NlbWljb2xvbiA/ICIi IDogIjsiOworICAgICAgICAgICAgZWxzZSBpZiAoc3VmZml4LnN0YXJ0c1dpdGgoIigiKSkKKyAg ICAgICAgICAgICAgICB0aGlzLl9pbXBsaWNpdFN1ZmZpeCA9ICIiOwogCiAgICAgICAgICAgICAv LyBEb24ndCB1c2UgYW4gaW1wbGljaXQgc3VmZml4IGlmIGl0IHdvdWxkIGJlIHRoZSBzYW1lIGFz IHRoZSBleGlzdGluZyBzdWZmaXguCiAgICAgICAgICAgICBpZiAodGhpcy5faW1wbGljaXRTdWZm aXggPT09IHN1ZmZpeCkKICAgICAgICAgICAgICAgICB0aGlzLl9pbXBsaWNpdFN1ZmZpeCA9ICIi OwogCi0gICAgICAgICAgICByZXR1cm4gV2ViSW5zcGVjdG9yLkNTU0tleXdvcmRDb21wbGV0aW9u cy5mb3JQcm9wZXJ0eShwcm9wZXJ0eU5hbWUpLnN0YXJ0c1dpdGgodGhpcy5fcHJlZml4KTsKKyAg ICAgICAgICAgIGxldCBjb21wbGV0aW9ucyA9IFdlYkluc3BlY3Rvci5DU1NLZXl3b3JkQ29tcGxl dGlvbnMuZm9yUHJvcGVydHkocHJvcGVydHlOYW1lKS5zdGFydHNXaXRoKHRoaXMuX3ByZWZpeCk7 CisKKyAgICAgICAgICAgIGlmIChzdWZmaXguc3RhcnRzV2l0aCgiKCIpKQorICAgICAgICAgICAg ICAgIGNvbXBsZXRpb25zID0gY29tcGxldGlvbnMubWFwKCh4KSA9PiB4LnJlcGxhY2UoL1woXCkk LywgIiIpKTsKKworICAgICAgICAgICAgcmV0dXJuIGNvbXBsZXRpb25zOwogICAgICAgICB9CiAK ICAgICAgICAgdGhpcy5faW1wbGljaXRTdWZmaXggPSBzdWZmaXggIT09ICI6IiA/ICI6ICIgOiAi IjsK