163588 2016-10-18 00:23:48 -0700 NetworkSession: updatedRequest parameter of NetworkProcess::findPendingDownloadLocation is unused since r206988 2016-10-19 01:02:18 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 163597 1 cgarcia webkit-unassigned achristensen oldest_to_newest 1241362 0 cgarcia 2016-10-18 00:23:48 -0700 The parameter was used only for the DownloadProxy::DidStart message that is no longer sent from findPendingDownloadLocation since r206988. 1241363 1 291928 cgarcia 2016-10-18 00:28:14 -0700 Created attachment 291928 Patch 1241877 2 cgarcia 2016-10-19 01:02:18 -0700 Committed r207530: <http://trac.webkit.org/changeset/207530> 291928 2016-10-18 00:28:14 -0700 2016-10-18 10:56:53 -0700 Patch wk2-unused-request.diff text/plain 6180 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5ZGUxMTJkLi5jYjQ5OWRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTYtMTAtMTggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIE5ldHdvcmtTZXNzaW9uOiB1cGRhdGVkUmVxdWVzdCBwYXJhbWV0ZXIgb2Yg TmV0d29ya1Byb2Nlc3M6OmZpbmRQZW5kaW5nRG93bmxvYWRMb2NhdGlvbiBpcyB1bnVzZWQgc2lu Y2UgcjIwNjk4OAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTYzNTg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGhlIHBhcmFtZXRlciB3YXMgdXNlZCBvbmx5IGZvciB0aGUgRG93bmxvYWRQcm94eTo6RGlk U3RhcnQgbWVzc2FnZSB0aGF0IGlzIG5vIGxvbmdlciBzZW50IGZyb20KKyAgICAgICAgZmluZFBl bmRpbmdEb3dubG9hZExvY2F0aW9uIHNpbmNlIHIyMDY5ODguCisKKyAgICAgICAgKiBOZXR3b3Jr UHJvY2Vzcy9OZXR3b3JrRGF0YVRhc2suaDoKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya0RhdGFU YXNrOjpjdXJyZW50UmVxdWVzdCk6IFJlbW92ZWQgc2luY2UgaXQncyB1bnVzZWQgbm93LgorICAg ICAgICAqIE5ldHdvcmtQcm9jZXNzL05ldHdvcmtMb2FkLmNwcDoKKyAgICAgICAgKFdlYktpdDo6 TmV0d29ya0xvYWQ6OmNvbnZlcnRUYXNrVG9Eb3dubG9hZCk6IFVwZGF0ZSB0aGUgbV9jdXJyZW50 UmVxdWVzdCBhbmQgcGFzcyBpdCB0byBEaWRTdGFydCBtZXNzYWdlLgorICAgICAgICAoV2ViS2l0 OjpOZXR3b3JrTG9hZDo6ZGlkUmVjZWl2ZVJlc3BvbnNlTmV0d29ya1Nlc3Npb24pOgorICAgICAg ICAqIE5ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6 TmV0d29ya1Byb2Nlc3M6OmZpbmRQZW5kaW5nRG93bmxvYWRMb2NhdGlvbik6CisgICAgICAgICog TmV0d29ya1Byb2Nlc3MvTmV0d29ya1Byb2Nlc3MuaDoKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vz cy9jb2NvYS9OZXR3b3JrRGF0YVRhc2tDb2NvYS5tbTogUmVtb3ZlIGN1cnJlbnRSZXF1ZXN0KCkg aW1wbGVtZW50YXRpb24uCisKIDIwMTYtMTAtMTcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dh cmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIE5ldHdvcmtTZXNzaW9uOiBQZW5kaW5nRG93bmxv YWQgaXMgbGVha2VkIGlmIGNhbmNlbGVkIGJlZm9yZSB3aWxsRGVjaWRlUGVuZGluZ0Rvd25sb2Fk RGVzdGluYXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05l dHdvcmtEYXRhVGFzay5oIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0Rh dGFUYXNrLmgKaW5kZXggYTJiMzQ2Mi4uOTE5MTgwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0RhdGFUYXNrLmgKKysrIGIvU291cmNlL1dlYktpdDIv TmV0d29ya1Byb2Nlc3MvTmV0d29ya0RhdGFUYXNrLmgKQEAgLTE0Niw3ICsxNDYsNiBAQCBwdWJs aWM6CiAgICAgY29uc3QgU3RyaW5nJiBwZW5kaW5nRG93bmxvYWRMb2NhdGlvbigpIHsgcmV0dXJu IG1fcGVuZGluZ0Rvd25sb2FkTG9jYXRpb247IH0KIAogICAgIGNvbnN0IFdlYkNvcmU6OlJlc291 cmNlUmVxdWVzdCYgZmlyc3RSZXF1ZXN0KCkgY29uc3QgeyByZXR1cm4gbV9maXJzdFJlcXVlc3Q7 IH0KLSAgICBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QgY3VycmVudFJlcXVlc3QoKTsKICAgICBT dHJpbmcgc3VnZ2VzdGVkRmlsZW5hbWUoKTsKICAgICB2b2lkIHNldFN1Z2dlc3RlZEZpbGVuYW1l KGNvbnN0IFN0cmluZyYpOwogICAgIGJvb2wgYWxsb3dzU3BlY2lmaWNIVFRQU0NlcnRpZmljYXRl Rm9ySG9zdChjb25zdCBXZWJDb3JlOjpBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSYpOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0xvYWQuY3BwIGIvU291 cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0xvYWQuY3BwCmluZGV4IDc4M2IzOTcu LjJmZGQzYjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdv cmtMb2FkLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrTG9h ZC5jcHAKQEAgLTE5MCwxMiArMTkwLDEzIEBAIHZvaWQgTmV0d29ya0xvYWQ6OmNvbnZlcnRUYXNr VG9Eb3dubG9hZChEb3dubG9hZElEIGRvd25sb2FkSUQsIGNvbnN0IFJlc291cmNlUmVxCiAgICAg aWYgKCFtX3Rhc2spCiAgICAgICAgIHJldHVybjsKIAotICAgIE5ldHdvcmtQcm9jZXNzOjpzaW5n bGV0b24oKS5kb3dubG9hZE1hbmFnZXIoKS5kb3dubG9hZFByb3h5Q29ubmVjdGlvbigpLT5zZW5k KE1lc3NhZ2VzOjpEb3dubG9hZFByb3h5OjpEaWRTdGFydCh1cGRhdGVkUmVxdWVzdCwgU3RyaW5n KCkpLCBkb3dubG9hZElELmRvd25sb2FkSUQoKSk7CisgICAgbV9jdXJyZW50UmVxdWVzdCA9IHVw ZGF0ZWRSZXF1ZXN0OworICAgIE5ldHdvcmtQcm9jZXNzOjpzaW5nbGV0b24oKS5kb3dubG9hZE1h bmFnZXIoKS5kb3dubG9hZFByb3h5Q29ubmVjdGlvbigpLT5zZW5kKE1lc3NhZ2VzOjpEb3dubG9h ZFByb3h5OjpEaWRTdGFydChtX2N1cnJlbnRSZXF1ZXN0LCBTdHJpbmcoKSksIGRvd25sb2FkSUQu ZG93bmxvYWRJRCgpKTsKICAgICBtX3Rhc2stPnNldFBlbmRpbmdEb3dubG9hZElEKGRvd25sb2Fk SUQpOwogICAgIAogICAgIEFTU0VSVChtX3Jlc3BvbnNlQ29tcGxldGlvbkhhbmRsZXIpOwogICAg IGlmIChtX3Jlc3BvbnNlQ29tcGxldGlvbkhhbmRsZXIpCi0gICAgICAgIE5ldHdvcmtQcm9jZXNz OjpzaW5nbGV0b24oKS5maW5kUGVuZGluZ0Rvd25sb2FkTG9jYXRpb24oKm1fdGFzay5nZXQoKSwg c3RkOjpleGNoYW5nZShtX3Jlc3BvbnNlQ29tcGxldGlvbkhhbmRsZXIsIG51bGxwdHIpLCB1cGRh dGVkUmVxdWVzdCwgcmVzcG9uc2UpOworICAgICAgICBOZXR3b3JrUHJvY2Vzczo6c2luZ2xldG9u KCkuZmluZFBlbmRpbmdEb3dubG9hZExvY2F0aW9uKCptX3Rhc2suZ2V0KCksIHN0ZDo6ZXhjaGFu Z2UobV9yZXNwb25zZUNvbXBsZXRpb25IYW5kbGVyLCBudWxscHRyKSwgcmVzcG9uc2UpOwogfQog CiB2b2lkIE5ldHdvcmtMb2FkOjpzZXRQZW5kaW5nRG93bmxvYWRJRChEb3dubG9hZElEIGRvd25s b2FkSUQpCkBAIC0yNzIsNyArMjczLDcgQEAgdm9pZCBOZXR3b3JrTG9hZDo6ZGlkUmVjZWl2ZVJl c3BvbnNlTmV0d29ya1Nlc3Npb24oUmVzb3VyY2VSZXNwb25zZSYmIHJlc3BvbnNlLAogewogICAg IEFTU0VSVChpc01haW5UaHJlYWQoKSk7CiAgICAgaWYgKG1fdGFzayAmJiBtX3Rhc2stPnBlbmRp bmdEb3dubG9hZElEKCkuZG93bmxvYWRJRCgpKQotICAgICAgICBOZXR3b3JrUHJvY2Vzczo6c2lu Z2xldG9uKCkuZmluZFBlbmRpbmdEb3dubG9hZExvY2F0aW9uKCptX3Rhc2suZ2V0KCksIFdURk1v dmUoY29tcGxldGlvbkhhbmRsZXIpLCBtX3Rhc2stPmN1cnJlbnRSZXF1ZXN0KCksIHJlc3BvbnNl KTsKKyAgICAgICAgTmV0d29ya1Byb2Nlc3M6OnNpbmdsZXRvbigpLmZpbmRQZW5kaW5nRG93bmxv YWRMb2NhdGlvbigqbV90YXNrLmdldCgpLCBXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKSwgcmVz cG9uc2UpOwogICAgIGVsc2UgaWYgKHNoYXJlZERpZFJlY2VpdmVSZXNwb25zZShXVEZNb3ZlKHJl c3BvbnNlKSkgPT0gTmV0d29ya0xvYWRDbGllbnQ6OlNob3VsZENvbnRpbnVlRGlkUmVjZWl2ZVJl c3BvbnNlOjpZZXMpCiAgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKFBvbGljeVVzZSk7CiAgICAg ZWxzZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1By b2Nlc3MuY3BwIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Byb2Nlc3Mu Y3BwCmluZGV4IDAyNDg1OTQuLjNiMzk1ZDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL05l dHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3 b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5jcHAKQEAgLTUwNiw3ICs1MDYsNyBAQCB2b2lkIE5l dHdvcmtQcm9jZXNzOjpwZW5kaW5nRG93bmxvYWRDYW5jZWxlZChEb3dubG9hZElEIGRvd25sb2Fk SUQpCiAgICAgZG93bmxvYWRQcm94eUNvbm5lY3Rpb24oKS0+c2VuZChNZXNzYWdlczo6RG93bmxv YWRQcm94eTo6RGlkQ2FuY2VsKHsgfSksIGRvd25sb2FkSUQuZG93bmxvYWRJRCgpKTsKIH0KIAot dm9pZCBOZXR3b3JrUHJvY2Vzczo6ZmluZFBlbmRpbmdEb3dubG9hZExvY2F0aW9uKE5ldHdvcmtE YXRhVGFzayYgbmV0d29ya0RhdGFUYXNrLCBSZXNwb25zZUNvbXBsZXRpb25IYW5kbGVyJiYgY29t cGxldGlvbkhhbmRsZXIsIGNvbnN0IFJlc291cmNlUmVxdWVzdCYgdXBkYXRlZFJlcXVlc3QsIGNv bnN0IFJlc291cmNlUmVzcG9uc2UmIHJlc3BvbnNlKQordm9pZCBOZXR3b3JrUHJvY2Vzczo6Zmlu ZFBlbmRpbmdEb3dubG9hZExvY2F0aW9uKE5ldHdvcmtEYXRhVGFzayYgbmV0d29ya0RhdGFUYXNr LCBSZXNwb25zZUNvbXBsZXRpb25IYW5kbGVyJiYgY29tcGxldGlvbkhhbmRsZXIsIGNvbnN0IFJl c291cmNlUmVzcG9uc2UmIHJlc3BvbnNlKQogewogICAgIHVpbnQ2NF90IGRlc3RpbmF0aW9uSUQg PSBuZXR3b3JrRGF0YVRhc2sucGVuZGluZ0Rvd25sb2FkSUQoKS5kb3dubG9hZElEKCk7CiAgICAg ZG93bmxvYWRQcm94eUNvbm5lY3Rpb24oKS0+c2VuZChNZXNzYWdlczo6RG93bmxvYWRQcm94eTo6 RGlkUmVjZWl2ZVJlc3BvbnNlKHJlc3BvbnNlKSwgZGVzdGluYXRpb25JRCk7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5oIGIvU291cmNl L1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Byb2Nlc3MuaAppbmRleCBlMTYzNWJmLi4y Njg2NDZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3Jr UHJvY2Vzcy5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9j ZXNzLmgKQEAgLTEwNyw3ICsxMDcsNyBAQCBwdWJsaWM6CiAjZW5kaWYKIAogI2lmIFVTRShORVRX T1JLX1NFU1NJT04pCi0gICAgdm9pZCBmaW5kUGVuZGluZ0Rvd25sb2FkTG9jYXRpb24oTmV0d29y a0RhdGFUYXNrJiwgUmVzcG9uc2VDb21wbGV0aW9uSGFuZGxlciYmLCBjb25zdCBXZWJDb3JlOjpS ZXNvdXJjZVJlcXVlc3QmLCBjb25zdCBXZWJDb3JlOjpSZXNvdXJjZVJlc3BvbnNlJik7CisgICAg dm9pZCBmaW5kUGVuZGluZ0Rvd25sb2FkTG9jYXRpb24oTmV0d29ya0RhdGFUYXNrJiwgUmVzcG9u c2VDb21wbGV0aW9uSGFuZGxlciYmLCBjb25zdCBXZWJDb3JlOjpSZXNvdXJjZVJlc3BvbnNlJik7 CiAjZW5kaWYKIAogI2lmIFVTRShQUk9URUNUSU9OX1NQQUNFX0FVVEhfQ0FMTEJBQ0spCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrRGF0YVRh c2tDb2NvYS5tbSBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtE YXRhVGFza0NvY29hLm1tCmluZGV4IGE5ZDRhZGIuLjk0NTA5ODYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtEYXRhVGFza0NvY29hLm1tCisr KyBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtEYXRhVGFza0Nv Y29hLm1tCkBAIC0zODUsMTEgKzM4NSw2IEBAIHZvaWQgTmV0d29ya0RhdGFUYXNrOjpzZXRTdWdn ZXN0ZWRGaWxlbmFtZShjb25zdCBTdHJpbmcmIHN1Z2dlc3RlZE5hbWUpCiAgICAgbV9zdWdnZXN0 ZWRGaWxlbmFtZSA9IHN1Z2dlc3RlZE5hbWU7CiB9CiAKLVdlYkNvcmU6OlJlc291cmNlUmVxdWVz dCBOZXR3b3JrRGF0YVRhc2s6OmN1cnJlbnRSZXF1ZXN0KCkKLXsKLSAgICByZXR1cm4gW21fdGFz ayBjdXJyZW50UmVxdWVzdF07Ci19Ci0KIHZvaWQgTmV0d29ya0RhdGFUYXNrOjpjYW5jZWwoKQog ewogICAgIFttX3Rhc2sgY2FuY2VsXTsK