163573 2016-10-17 16:59:56 -0700 REGRESSION (r169805): WKWebView canGoBack returning YES when nothing is in the back-forward list after restoring session state 2016-10-17 17:47:50 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca beidson commit-queue mitz simon.fraser oldest_to_newest 1241251 0 thorton 2016-10-17 16:59:56 -0700 REGRESSION (r169805): WKWebView canGoBack returning YES when nothing is in the back-forward list after restoring session state 1241253 1 291899 thorton 2016-10-17 17:02:33 -0700 Created attachment 291899 Patch 1241254 2 thorton 2016-10-17 17:03:01 -0700 Steps To Reproduce: 1. Create a WKWebView and navigate to a page. 2. Use -[WKWebView _sessionStateWithFilter:] to remove the one item in the WKWebView’s back forward list, and use -[WKWebView _restoreSessionState:andNavigate:] (navigate = NO) to restore the empty back forward list. 3. Observe the value of -[WKWebView canGoBack]. Results: -[WKWebView canGoBack] returns YES even though there are no items in the back list. Regression: This bug was introduced by: https://trac.webkit.org/changeset/169805 1241279 3 291899 commit-queue 2016-10-17 17:47:47 -0700 Comment on attachment 291899 Patch Clearing flags on attachment: 291899 Committed r207445: <http://trac.webkit.org/changeset/207445> 1241280 4 commit-queue 2016-10-17 17:47:50 -0700 All reviewed patches have been landed. Closing bug. 291899 2016-10-17 17:02:33 -0700 2016-10-17 17:47:47 -0700 Patch bug-163573-20161017165900.patch text/plain 4660 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3NDEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjAzZTlhMmM5ZWY5MTM1 MmU1NjE2ZmRkYjM1ZjAzODk0YjI3ZjQyZi4uY2M0ZDM0NDlmZGYyOGEzODEyNDgyNTQ4NTQxNmFm MmVjZDlkYmU3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTEwLTE3ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04g KHIxNjk4MDUpOiBXS1dlYlZpZXcgY2FuR29CYWNrIHJldHVybmluZyBZRVMgd2hlbiBub3RoaW5n IGlzIGluIHRoZSBiYWNrLWZvcndhcmQgbGlzdCBhZnRlciByZXN0b3Jpbmcgc2Vzc2lvbiBzdGF0 ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzNTcz CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yODc0NDU0OT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3Bw OgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OnJlc3RvcmVGcm9tU2Vzc2lvblN0YXRl KToKKyAgICAgICAgVXBkYXRlIFBhZ2VMb2FkU3RhdGUncyBjYW5Hb0JhY2svY2FuR29Gb3J3YXJk IGJpdHMgd2hlbiByZXN0b3JpbmcgZnJvbQorICAgICAgICBzZXNzaW9uIHN0YXRlLCBiZWNhdXNl IGluIHRoZSBkb24ndC1uYXZpZ2F0ZSBjYXNlLCBub3RoaW5nIGVsc2Ugd2lsbCBtYWtlIHRoaXMg aGFwcGVuLAorICAgICAgICBhbmQgaXQgd2lsbCByZW1haW4gc3RhbGUuCisKIDIwMTYtMTAtMTcg IEtvbnN0YW50aW4gVG9rYXJldiAgPGFubnVsZW5AeWFuZGV4LnJ1PgogCiAgICAgICAgIEVsZW1p bmF0ZSBjb2RlIGR1cGxpY2F0aW9uIGJldHdlZW4gUmVzb3VyY2VSZXF1ZXN0IGVuY29kaW5nL2Rl Y29kaW5nIGltcGxlbWVudGF0aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL1dlYlBhZ2VQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVBy b3h5LmNwcAppbmRleCA0YTg5YWMxMGY1MzRkYTc3YjEzYzA4N2I3OTlhZTVmZDQ5M2Q4NDA4Li40 MTQ2ZWI4OGE0YWU1MjcyZTM5ZWU0MDk0M2FkNmQxMzNmYjE0Mzc1IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcApAQCAtMjM4NSw2ICsyMzg1LDEwIEBAIFJlZlB0 cjxBUEk6Ok5hdmlnYXRpb24+IFdlYlBhZ2VQcm94eTo6cmVzdG9yZUZyb21TZXNzaW9uU3RhdGUo U2Vzc2lvblN0YXRlIHNlc3NpCiAKICAgICAgICAgcHJvY2VzcygpLnNlbmQoTWVzc2FnZXM6Oldl YlBhZ2U6OlJlc3RvcmVTZXNzaW9uKG1fYmFja0ZvcndhcmRMaXN0LT5pdGVtU3RhdGVzKCkpLCBt X3BhZ2VJRCk7CiAKKyAgICAgICAgYXV0byB0cmFuc2FjdGlvbiA9IG1fcGFnZUxvYWRTdGF0ZS50 cmFuc2FjdGlvbigpOworICAgICAgICBtX3BhZ2VMb2FkU3RhdGUuc2V0Q2FuR29CYWNrKHRyYW5z YWN0aW9uLCBtX2JhY2tGb3J3YXJkTGlzdC0+YmFja0l0ZW0oKSk7CisgICAgICAgIG1fcGFnZUxv YWRTdGF0ZS5zZXRDYW5Hb0ZvcndhcmQodHJhbnNhY3Rpb24sIG1fYmFja0ZvcndhcmRMaXN0LT5m b3J3YXJkSXRlbSgpKTsKKwogICAgICAgICAvLyBUaGUgYmFjayAvIGZvcndhcmQgbGlzdCB3YXMg cmVzdG9yZWQgZnJvbSBhIHNlc3Npb25TdGF0ZSBzbyB3ZSBkb24ndCB3YW50IHRvIHNuYXBzaG90 IHRoZSBjdXJyZW50CiAgICAgICAgIC8vIHBhZ2Ugd2hlbiBuYXZpZ2F0aW5nIGF3YXkuIFN1cHBy ZXNzIG5hdmlnYXRpb24gc25hcHNob3R0aW5nIHVudGlsIHRoZSBuZXh0IGxvYWQgaGFzIGNvbW1p dHRlZAogICAgICAgICBtX3N1cHByZXNzQXV0b21hdGljTmF2aWdhdGlvblNuYXBzaG90dGluZyA9 IHRydWU7CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5k ZXggNGRhNGI0MWE1N2U1ZGU3MTkxOWJkOTIwMzYyNDg3MGI4NjAxMjE4Yy4uZWU3YjVhYWE4NWY2 ODRjMTIzYWNlNzIwMjcyODJjNWJmMGE3MzBiYyAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9n CisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTEwLTE3ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04g KHIxNjk4MDUpOiBXS1dlYlZpZXcgY2FuR29CYWNrIHJldHVybmluZyBZRVMgd2hlbiBub3RoaW5n IGlzIGluIHRoZSBiYWNrLWZvcndhcmQgbGlzdCBhZnRlciByZXN0b3Jpbmcgc2Vzc2lvbiBzdGF0 ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzNTcz CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yODc0NDU0OT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0 Mi9XS0JhY2tGb3J3YXJkTGlzdC5tbToKKyAgICAgICAgKFRFU1QpOgorICAgICAgICBBZGQgYSB0 ZXN0IGVuc3VyaW5nIHRoYXQgY2FuR29CYWNrIHJldHVybnMgTk8gYWZ0ZXIgcmVzdG9yaW5nIHNl c3Npb24gc3RhdGUgd2l0aG91dCBuYXZpZ2F0aW5nLgorCiAyMDE2LTEwLTE3ICBNaWNoYWVsIENh dGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAogICAgICAgICBNb3ZlIHVzZXIgYWdl bnQgcXVpcmtzIHRvIGNyb3NzLXBsYXRmb3JtIGxvY2F0aW9uCmRpZmYgLS1naXQgYS9Ub29scy9U ZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDIvV0tCYWNrRm9yd2FyZExpc3QubW0gYi9Ub29scy9U ZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDIvV0tCYWNrRm9yd2FyZExpc3QubW0KaW5kZXggMjBj ZjhkODdlNDBmZDlmMWM3ZDZjNzQ0M2FlOWE5OGM0MjcwMTA1Mi4uZmQzYTZlYzM3NmRhOGQzN2M5 ODJkZjAxZDlhMjhhYTRiODJkOTI5MSAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9U ZXN0cy9XZWJLaXQyL1dLQmFja0ZvcndhcmRMaXN0Lm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRB UEkvVGVzdHMvV2ViS2l0Mi9XS0JhY2tGb3J3YXJkTGlzdC5tbQpAQCAtNzIsNCArNzIsMzUgQEAg VEVTVChXS0JhY2tGb3J3YXJkTGlzdCwgUmVtb3ZlQ3VycmVudEl0ZW0pCiAgICAgRVhQRUNUX1NU UkVRKFtbbmV3TGlzdC5jdXJyZW50SXRlbSBVUkxdIGFic29sdXRlU3RyaW5nXS5VVEY4U3RyaW5n LCBsb2FkYWJsZVVSTDIuVVRGOFN0cmluZyk7CiB9CiAKK1RFU1QoV0tCYWNrRm9yd2FyZExpc3Qs IENhbk5vdEdvQmFja0FmdGVyUmVzdG9yaW5nRW1wdHlTZXNzaW9uU3RhdGUpCit7CisgICAgYXV0 byB3ZWJWaWV3ID0gYWRvcHROUyhbW1dLV2ViVmlldyBhbGxvY10gaW5pdF0pOworCisgICAgW3dl YlZpZXcgbG9hZFJlcXVlc3Q6W05TVVJMUmVxdWVzdCByZXF1ZXN0V2l0aFVSTDpbTlNVUkwgVVJM V2l0aFN0cmluZzpsb2FkYWJsZVVSTDFdXV07CisgICAgW3dlYlZpZXcgX3Rlc3Rfd2FpdEZvckRp ZEZpbmlzaE5hdmlnYXRpb25dOworCisgICAgW3dlYlZpZXcgbG9hZFJlcXVlc3Q6W05TVVJMUmVx dWVzdCByZXF1ZXN0V2l0aFVSTDpbTlNVUkwgVVJMV2l0aFN0cmluZzpsb2FkYWJsZVVSTDJdXV07 CisgICAgW3dlYlZpZXcgX3Rlc3Rfd2FpdEZvckRpZEZpbmlzaE5hdmlnYXRpb25dOworCisgICAg V0tCYWNrRm9yd2FyZExpc3QgKmxpc3QgPSBbd2ViVmlldyBiYWNrRm9yd2FyZExpc3RdOworICAg IEVYUEVDVF9FUShZRVMsIFt3ZWJWaWV3IGNhbkdvQmFja10pOworICAgIEVYUEVDVF9FUShOTywg W3dlYlZpZXcgY2FuR29Gb3J3YXJkXSk7CisgICAgRVhQRUNUX0VRKChOU1VJbnRlZ2VyKTEsIGxp c3QuYmFja0xpc3QuY291bnQpOworICAgIEVYUEVDVF9FUSgoTlNVSW50ZWdlcikwLCBsaXN0LmZv cndhcmRMaXN0LmNvdW50KTsKKworICAgIGF1dG8gc2luZ2xlUGFnZVdlYlZpZXcgPSBhZG9wdE5T KFtbV0tXZWJWaWV3IGFsbG9jXSBpbml0XSk7CisKKyAgICBbc2luZ2xlUGFnZVdlYlZpZXcgbG9h ZFJlcXVlc3Q6W05TVVJMUmVxdWVzdCByZXF1ZXN0V2l0aFVSTDpbTlNVUkwgVVJMV2l0aFN0cmlu Zzpsb2FkYWJsZVVSTDFdXV07CisgICAgW3NpbmdsZVBhZ2VXZWJWaWV3IF90ZXN0X3dhaXRGb3JE aWRGaW5pc2hOYXZpZ2F0aW9uXTsKKworICAgIFt3ZWJWaWV3IF9yZXN0b3JlU2Vzc2lvblN0YXRl OltzaW5nbGVQYWdlV2ViVmlldyBfc2Vzc2lvblN0YXRlXSBhbmROYXZpZ2F0ZTpOT107CisKKyAg ICBXS0JhY2tGb3J3YXJkTGlzdCAqbmV3TGlzdCA9IFt3ZWJWaWV3IGJhY2tGb3J3YXJkTGlzdF07 CisKKyAgICBFWFBFQ1RfRVEoTk8sIFt3ZWJWaWV3IGNhbkdvQmFja10pOworICAgIEVYUEVDVF9F UShOTywgW3dlYlZpZXcgY2FuR29Gb3J3YXJkXSk7CisgICAgRVhQRUNUX0VRKChOU1VJbnRlZ2Vy KTAsIG5ld0xpc3QuYmFja0xpc3QuY291bnQpOworICAgIEVYUEVDVF9FUSgoTlNVSW50ZWdlcikw LCBuZXdMaXN0LmZvcndhcmRMaXN0LmNvdW50KTsKK30KKwogI2VuZGlmCg==