163547 2016-10-17 09:41:36 -0700 [iOS] Hook up WebPlatformTouchPoint's radiusX / radiusY to _UIWebTouchPoint.majorRadiusInScreenCoordinates 2016-11-07 09:36:19 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 162801 1 cdumez cdumez benjamin commit-queue darin dbates dino ryanhaddad simon.fraser thorton oldest_to_newest 1240978 0 cdumez 2016-10-17 09:41:36 -0700 Hook up WebPlatformTouchPoint's radiusX / radiusY to _UIWebTouchPoint.majorRadiusInScreenCoordinates. 1240979 1 291825 cdumez 2016-10-17 09:43:30 -0700 Created attachment 291825 Patch 1240980 2 commit-queue 2016-10-17 09:45:50 -0700 Attachment 291825 did not pass style-queue: ERROR: Source/WebKit2/Platform/spi/ios/UIKitSPI.h:0: Use #pragma once header guard. [build/header_guard] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1241013 3 291825 commit-queue 2016-10-17 10:51:09 -0700 Comment on attachment 291825 Patch Clearing flags on attachment: 291825 Committed r207413: <http://trac.webkit.org/changeset/207413> 1241014 4 commit-queue 2016-10-17 10:51:14 -0700 All reviewed patches have been landed. Closing bug. 1241029 5 dbates 2016-10-17 11:02:26 -0700 Can we write tests for this change? 1241034 6 cdumez 2016-10-17 11:03:27 -0700 (In reply to comment #5) > Can we write tests for this change? Sure, this is my next patch (see https://bugs.webkit.org/show_bug.cgi?id=162801) which is blocked by this bug. 1241648 7 ryanhaddad 2016-10-18 15:36:20 -0700 Reverted r207413 for reason: This change broke iOS builds. Committed r207494: <http://trac.webkit.org/changeset/207494> 1241651 8 ryanhaddad 2016-10-18 15:37:12 -0700 <rdar://problem/28833585> 1244239 9 cdumez 2016-10-25 09:37:24 -0700 Reverted r207494 for reason: iOS SDK has been updated on the bots now so rollout the rollout Committed r207823: <http://trac.webkit.org/changeset/207823> 1248764 10 cdumez 2016-11-07 09:36:19 -0800 Relanded in r207823. 291825 2016-10-17 09:43:30 -0700 2016-10-17 10:51:09 -0700 Patch bug-163547-20161017093958.patch text/plain 2961 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3NDA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjAzZTlhMmM5ZWY5MTM1 MmU1NjE2ZmRkYjM1ZjAzODk0YjI3ZjQyZi4uZDkxYzA2MWUwOWViZTAyY2Q2YjMyY2E1NTcwYTJi OTc2ZDI2YjMwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTEwLTE3ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gSG9vayB1cCBXZWJQ bGF0Zm9ybVRvdWNoUG9pbnQncyByYWRpdXNYIC8gcmFkaXVzWSB0byBfVUlXZWJUb3VjaFBvaW50 Lm1ham9yUmFkaXVzSW5TY3JlZW5Db29yZGluYXRlcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzNTQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSG9vayB1cCBXZWJQbGF0Zm9ybVRvdWNoUG9pbnQncyBy YWRpdXNYIC8gcmFkaXVzWSB0byBfVUlXZWJUb3VjaFBvaW50Lm1ham9yUmFkaXVzSW5TY3JlZW5D b29yZGluYXRlcworICAgICAgICBub3cgdGhhdCBpdCBpcyBhdmFpbGFibGUgaW4gVUlLaXQuCisK KyAgICAgICAgKiBQbGF0Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmg6CisgICAgICAgICogU2hhcmVk L2lvcy9OYXRpdmVXZWJUb3VjaEV2ZW50SU9TLm1tOgorICAgICAgICAoV2ViS2l0OjpOYXRpdmVX ZWJUb3VjaEV2ZW50OjpleHRyYWN0V2ViVG91Y2hQb2ludCk6CisKIDIwMTYtMTAtMTcgIEtvbnN0 YW50aW4gVG9rYXJldiAgPGFubnVsZW5AeWFuZGV4LnJ1PgogCiAgICAgICAgIEVsZW1pbmF0ZSBj b2RlIGR1cGxpY2F0aW9uIGJldHdlZW4gUmVzb3VyY2VSZXF1ZXN0IGVuY29kaW5nL2RlY29kaW5n IGltcGxlbWVudGF0aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vc3Bp L2lvcy9VSUtpdFNQSS5oIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vc3BpL2lvcy9VSUtpdFNQ SS5oCmluZGV4IDRhOTY2MDE3YzJmOGM4MWJkYjZhYzQ2MGFiMmMwNTc4MjA0NzNlNTIuLjUzYjI3 NDAwM2Q2NjAwMDc3YTY5ZDM4OTgyOTVjMjg4N2I0YzJkMzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1BsYXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9Q bGF0Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmgKQEAgLTY1NCw4ICs2NTQsNyBAQCBzdHJ1Y3QgX1VJ V2ViVG91Y2hQb2ludCB7CiAgICAgdW5zaWduZWQgaWRlbnRpZmllcjsKICAgICBVSVRvdWNoUGhh c2UgcGhhc2U7CiAjaWYgX19JUEhPTkVfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPiAxMDAwMDAK LSAgICAvLyBGSVhNRTogVW5jb21tZW50IHRoaXMgb25jZSBVSUtpdCBpcyB1cGRhdGVkIChyZGFy Oi8vcHJvYmxlbS8yODU1NTMxMykuCi0gICAgLy8gQ0dGbG9hdCBtYWpvclJhZGl1c0luU2NyZWVu Q29vcmRpbmF0ZXM7CisgICAgQ0dGbG9hdCBtYWpvclJhZGl1c0luU2NyZWVuQ29vcmRpbmF0ZXM7 CiAgICAgQ0dGbG9hdCBmb3JjZTsKICAgICBDR0Zsb2F0IGFsdGl0dWRlQW5nbGU7CiAgICAgQ0dG bG9hdCBhemltdXRoQW5nbGU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvaW9z L05hdGl2ZVdlYlRvdWNoRXZlbnRJT1MubW0gYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvaW9zL05h dGl2ZVdlYlRvdWNoRXZlbnRJT1MubW0KaW5kZXggMTlkYzEwNGVjNGI2YTQ4YTdlMGQ0ODU1MzQ0 MDZkNzYxN2IzNzMzOC4uNjhlMGU2Y2FmZGY1ZGM1NWFmODdkYTgzODNhMTdmNTNmYjE5NmNkNSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2hhcmVkL2lvcy9OYXRpdmVXZWJUb3VjaEV2ZW50 SU9TLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9pb3MvTmF0aXZlV2ViVG91Y2hFdmVu dElPUy5tbQpAQCAtMTAzLDkgKzEwMyw4IEBAIFZlY3RvcjxXZWJQbGF0Zm9ybVRvdWNoUG9pbnQ+ IE5hdGl2ZVdlYlRvdWNoRXZlbnQ6OmV4dHJhY3RXZWJUb3VjaFBvaW50KGNvbnN0IF9VCiAgICAg ICAgIFdlYlBsYXRmb3JtVG91Y2hQb2ludDo6VG91Y2hQb2ludFN0YXRlIHBoYXNlID0gY29udmVy dFRvdWNoUGhhc2UodG91Y2hQb2ludC5waGFzZSk7CiAgICAgICAgIFdlYlBsYXRmb3JtVG91Y2hQ b2ludCBwbGF0Zm9ybVRvdWNoUG9pbnQgPSBXZWJQbGF0Zm9ybVRvdWNoUG9pbnQoaWRlbnRpZmll ciwgbG9jYXRpb24sIHBoYXNlKTsKICNpZiBFTkFCTEUoSU9TX1RPVUNIX0VWRU5UUykKLSAgICAg ICAgLy8gRklYTUU6IFdlIHNob3VsZCB1c2UgdG91Y2hQb2ludC5tYWpvclJhZGl1c0luU2NyZWVu Q29vcmRpbmF0ZXMgZm9yIHJhZGl1c1ggLyByYWRpdXNZIG9uY2UgaXQgaXMgYXZhaWxhYmxlIChy ZGFyOi8vcHJvYmxlbS8yODU1NTMxMykuCi0gICAgICAgIHBsYXRmb3JtVG91Y2hQb2ludC5zZXRS YWRpdXNYKDApOwotICAgICAgICBwbGF0Zm9ybVRvdWNoUG9pbnQuc2V0UmFkaXVzWSgwKTsKKyAg ICAgICAgcGxhdGZvcm1Ub3VjaFBvaW50LnNldFJhZGl1c1godG91Y2hQb2ludC5tYWpvclJhZGl1 c0luU2NyZWVuQ29vcmRpbmF0ZXMpOworICAgICAgICBwbGF0Zm9ybVRvdWNoUG9pbnQuc2V0UmFk aXVzWSh0b3VjaFBvaW50Lm1ham9yUmFkaXVzSW5TY3JlZW5Db29yZGluYXRlcyk7CiAgICAgICAg IHBsYXRmb3JtVG91Y2hQb2ludC5zZXRSb3RhdGlvbkFuZ2xlKDApOyAvLyBOb3QgYXZhaWxhYmxl IGluIF9VSVdlYlRvdWNoRXZlbnQgeWV0LgogICAgICAgICBwbGF0Zm9ybVRvdWNoUG9pbnQuc2V0 Rm9yY2UodG91Y2hQb2ludC5mb3JjZSk7CiAjaWYgZGVmaW5lZCBVSV9XRUJfVE9VQ0hfRVZFTlRf SEFTX1NUWUxVU19EQVRBICYmIFVJX1dFQl9UT1VDSF9FVkVOVF9IQVNfU1RZTFVTX0RBVEEK