16353 2007-12-08 05:31:57 -0800 [GTK] Check for deprecated API use (G_DISABLE_DEPRECATED etc.) 2007-12-27 15:14:41 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) All All RESOLVED FIXED Gtk P2 Minor --- 1 alp webkit-unassigned jmalonzo oldest_to_newest 63662 0 alp 2007-12-08 05:31:57 -0800 We should have a special build target (perhaps in addition to Debug and Release) that can be used to check for deprecated API use in WebKit/GTK+. These are the relevant flags GIMP enables: -DG_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -DPANGO_DISABLE_DEPRECATED -DGDK_MULTIHEAD_SAFE -DGTK_MULTIHEAD_SAFE We would also add (for the GStreamer code): -DGST_DISABLE_DEPRECATED There may be others I've missed, but these seem the most important. These flags probably shouldn't be used in standard build profiles since they may cause the build to break needlessly in the long term. They should be used only to assist developers in tracking down bad API use, similarly to -Werror. 65337 1 jmalonzo 2007-12-26 23:34:09 -0800 Hi! I don't see why we need another target for this. Normally, _DISABLE_DEPRECATED is part of the 'debug' profile since debug builds are usually the place for fixing this sort of things. > These flags probably shouldn't be used in standard build profiles since they > may cause the build to break needlessly in the long term Just wondering what sort of build breakages are you expecting to come if we enable these flags in the 'debug' build? 65338 2 alp 2007-12-26 23:41:23 -0800 (In reply to comment #1) > Hi! I don't see why we need another target for this. Normally, > _DISABLE_DEPRECATED is part of the 'debug' profile since debug builds are > usually the place for fixing this sort of things. Adding these flags only for debug builds sounds fine to me. We don't want to use them in release builds since a release build needs to be forward-compatible. 65389 3 18130 jmalonzo 2007-12-27 05:49:38 -0800 Created attachment 18130 patch to define the flags mentioned during debug builds This patch defines the flags only when doing debug builds. cheers 65411 4 18130 alp 2007-12-27 15:12:31 -0800 Comment on attachment 18130 patch to define the flags mentioned during debug builds r=me There's some bad whitespace changes in WebCore.pro and you missed wrapping GST_DISABLE_DEPRECATED withCONFIG(debug) though. Will fix up before landing. 65412 5 alp 2007-12-27 15:14:41 -0800 Landed in r29006. 18130 2007-12-27 05:49:38 -0800 2007-12-27 15:12:31 -0800 patch to define the flags mentioned during debug builds webkit-debug-deprecated.patch text/plain 3399 jmalonzo ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBlODE1YTI3Li45NGY1Y2Y2 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMDctMTItMjcgIEphbiBNaWNoYWVsIEFsb256byAgPGptYWxvbnpvQHVucGx1Z2dhYmxlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRw Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjM1MworICAgICAgICBbR1RLXSBD aGVjayBmb3IgZGVwcmVjYXRlZCBBUEkgdXNlIChHX0RJU0FCTEVfREVQUkVDQVRFRCBldGMuKQor CisgICAgICAgIEFkZGVkIHRoZSBmbGFncyBtZW50aW9uZWQgaW4gdGhlIGJ1ZyBvbmx5IHdoZW4g ZG9pbmcgJ2RlYnVnJworICAgICAgICBidWlsZHMuIC1ER1NUX0RJU0FCTEVfREVQUkVDQVRFRCBv bmx5IGFkZGVkIHdoZW4gdmlkZW8gaXMgZW5hYmxlZC4KKworICAgICAgICAqIEdOVW1ha2VmaWxl LmFtOgorICAgICAgICAqIFdlYktpdC5wcmk6CisKIDIwMDctMTItMjYgIEphbiBNaWNoYWVsIEFs b256byAgPGptYWxvbnpvQHVucGx1Z2dhYmxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBB bHAgVG9rZXIuCmRpZmYgLS1naXQgYS9HTlVtYWtlZmlsZS5hbSBiL0dOVW1ha2VmaWxlLmFtCmlu ZGV4IDg0MWU4YmQuLmI1ZmY2ODAgMTAwNjQ0Ci0tLSBhL0dOVW1ha2VmaWxlLmFtCisrKyBiL0dO VW1ha2VmaWxlLmFtCkBAIC0xNTQsNiArMTU0LDE1IEBAIGdsb2JhbF9jcHBmbGFncyArPSBcCiAK IGlmICFFTkFCTEVfREVCVUcKIGdsb2JhbF9jcHBmbGFncyArPSAtRE5ERUJVRworZWxzZSAKK3dl YmtpdGd0a19jcHBmbGFncyArPSBcCisJLURHX0RJU0FCTEVfREVQUkVDQVRFRCBcCisJLURHREtf UElYQlVGX0RJU0FCTEVfREVQUkVDQVRFRCBcCisJLURHREtfRElTQUJMRV9ERVBSRUNBVEVEIFwK KwktREdUS19ESVNBQkxFX0RFUFJFQ0FURUQgXAorCS1EUEFOR09fRElTQUJMRV9ERVBSRUNBVEVE IFwKKwktREdES19NVUxUSUhFQURfU0FGRSBcCisJLURHVEtfTVVMVElIRUFEX1NBRkUKIGVuZGlm CiAKIGlmIFRBUkdFVF9YMTEKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29y ZS9DaGFuZ2VMb2cKaW5kZXggNmQ5NThhOS4uY2U3ZGM3NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9D aGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAwNy0x Mi0yNyAgSmFuIE1pY2hhZWwgQWxvbnpvICA8am1hbG9uem9AdW5wbHVnZ2FibGUuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdBUk5JTkc6IE5P IFRFU1QgQ0FTRVMgQURERUQgT1IgQ0hBTkdFRAorCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MzUzCisgICAgICAgIFtHVEtdIENoZWNrIGZvciBkZXBy ZWNhdGVkIEFQSSB1c2UgKEdfRElTQUJMRV9ERVBSRUNBVEVEIGV0Yy4pCisKKyAgICAgICAgQWRk ZWQgdGhlIGZsYWdzIG1lbnRpb25lZCBpbiB0aGUgYnVnIG9ubHkgd2hlbiBkb2luZyAnZGVidWcn CisgICAgICAgIGJ1aWxkcy4gLURHU1RfRElTQUJMRV9ERVBSRUNBVEVEIG9ubHkgYWRkZWQgd2hl biB2aWRlbyBpcyBlbmFibGVkLgorCisgICAgICAgICogR05VbWFrZWZpbGUuYW06CisgICAgICAg ICogV2ViQ29yZS5wcm86CisKIDIwMDctMTItMjcgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3 ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hY2llai4KZGlmZiAtLWdpdCBhL1dl YkNvcmUvR05VbWFrZWZpbGUuYW0gYi9XZWJDb3JlL0dOVW1ha2VmaWxlLmFtCmluZGV4IGU1Y2Y3 M2YuLjk5ZmU4MTQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvR05VbWFrZWZpbGUuYW0KKysrIGIvV2Vi Q29yZS9HTlVtYWtlZmlsZS5hbQpAQCAtMTA0NCw2ICsxMDQ0LDExIEBAIEZFQVRVUkVfREVGSU5F U19KQVZBU0NSSVBUICs9IEVOQUJMRV9WSURFTz0xCiAKIHdlYmtpdGd0a19jcHBmbGFncyArPSAt REVOQUJMRV9WSURFTz0xCiAKK2lmIEVOQUJMRV9ERUJVRword2Via2l0Z3RrX2NwcGZsYWdzICs9 IC1ER1NUX0RJU0FCTEVfREVQUkVDQVRFRAorZW5kaWYgIyBFTkQgRU5BQkxFX0RFQlVHCisKKwog d2Via2l0Z3RrX2J1aWx0X3NvdXJjZXMgKz0gXAogCURlcml2ZWRTb3VyY2VzL0pTSFRNTFNvdXJj ZUVsZW1lbnQuaCBcCiAJRGVyaXZlZFNvdXJjZXMvSlNIVE1MQXVkaW9FbGVtZW50LmggXApkaWZm IC0tZ2l0IGEvV2ViQ29yZS9XZWJDb3JlLnBybyBiL1dlYkNvcmUvV2ViQ29yZS5wcm8KaW5kZXgg ODRkYzZlOC4uYTJmNTVkYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9XZWJDb3JlLnBybworKysgYi9X ZWJDb3JlL1dlYkNvcmUucHJvCkBAIC0xMTIxLDkgKzExMjEsMTEgQEAgY29udGFpbnMoREVGSU5F UywgRU5BQkxFX1ZJREVPPTEpIHsKICAgICAgICAgYmluZGluZ3MvanMvSlNIVE1MQXVkaW9FbGVt ZW50Q29uc3RydWN0b3IuY3BwIAogCiAgICAgZ3RrLXBvcnQgewotICAgICAgICBTT1VSQ0VTICs9 IFwKKwlTT1VSQ0VTICs9IFwKICAgICAgICAgICAgIHBsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwIFwKLSAgICAgICAgICAgIHBsYXRmb3JtL2dyYXBo aWNzL2d0ay9WaWRlb1NpbmtHU3RyZWFtZXIuY3BwCisJICAgIHBsYXRmb3JtL2dyYXBoaWNzL2d0 ay9WaWRlb1NpbmtHU3RyZWFtZXIuY3BwCisKKyAgICAgICAgREVGSU5FUyArPSBHU1RfRElTQUJM RV9ERVBSRUNBVEVECiAKICAgICAgICAgUEtHQ09ORklHICs9IGdzdHJlYW1lci0wLjEwIGdzdHJl YW1lci1wbHVnaW5zLWJhc2UtMC4xMCBnbm9tZS12ZnMtMi4wCiAgICAgICAgIExJQlMgKz0gLWxn c3RpbnRlcmZhY2VzLTAuMTAgLWxnc3RiYXNlLTAuMTAgLWxnc3R2aWRlby0wLjEwCmRpZmYgLS1n aXQgYS9XZWJLaXQucHJpIGIvV2ViS2l0LnByaQppbmRleCA2NDBmYTM0Li4zZTJmNTI4IDEwMDY0 NAotLS0gYS9XZWJLaXQucHJpCisrKyBiL1dlYktpdC5wcmkKQEAgLTU4LDYgKzU4LDEwIEBAIENP TkZJRyhyZWxlYXNlKSB7CiAgICAgREVGSU5FUyArPSBOREVCVUcKIH0KIAorZ3RrLXBvcnQ6Q09O RklHKGRlYnVnKSB7CisgICAgREVGSU5FUyArPSBHX0RJU0FCTEVfREVQUkVDQVRFRCBHREtfUElY QlVGX0RJU0FCTEVfREVQUkVDQVRFRCBHREtfRElTQUJMRV9ERVBSRUNBVEVEIEdUS19ESVNBQkxF X0RFUFJFQ0FURUQgUEFOR09fRElTQUJMRV9ERVBSRUNBVEVEIEdES19NVUxUSUhFQURfU0FGRSBH VEtfTVVMVElIRUFEX1NBRkUgCit9CisKIEJBU0VfRElSID0gJCRQV0QKIHF0LXBvcnQ6SU5DTFVE RVBBVEggKz0gXAogICAgICQkUFdEL1dlYktpdC9xdC9BcGkK