16351 2007-12-07 20:01:35 -0800 FontFallbackList.h doesn't include wtf/PassRefPtr.h 2007-12-14 12:57:26 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Other RESOLVED FIXED P3 Trivial --- 1 rob darin oldest_to_newest 63647 0 rob 2007-12-07 20:01:35 -0800 WebCore/platform/graphics/FontFallbackList.h uses PassRefPtr but doesn't include wtf/PassRefPtr.h. This causes the following build error on my port: In file included from ../../../WebCore/platform/graphics/FontFallbackList.cpp:30: ../../../WebCore/platform/graphics/FontFallbackList.h:47: error: 'PassRefPtr' has not been declared ../../../WebCore/platform/graphics/FontFallbackList.h:47: error: expected ',' or '...' before '<' token ../../../WebCore/platform/graphics/FontFallbackList.cpp:45: error: prototype for 'void WebCore::FontFallbackList::invalidate(WTF::PassRefPtr<WebCore::FontSelector>)' does not match any in class 'WebCore::FontFallbackList' ../../../WebCore/platform/graphics/FontFallbackList.h:47: error: candidate is: void WebCore::FontFallbackList::invalidate(int) make[1]: *** [tmp/FontFallbackList.o] Error 1 Adding the include resolves this. On my port nearly all my platform files are currently no-op stubs, so I guess on other ports PassRefPtr.h is being brought in elsewhere. This at least occurs in r28509, but it doesn't seem to have been changed yet. 63693 1 ddkilzer 2007-12-08 14:18:18 -0800 Please post a patch with a ChangeLog entry for review. Thanks! http://webkit.org/coding/contributing.html 63699 2 17791 rob 2007-12-08 14:55:04 -0800 Created attachment 17791 Patch to include PassRefPtr.h in FontFallbackList.h 63747 3 17791 darin 2007-12-09 06:57:52 -0800 Comment on attachment 17791 Patch to include PassRefPtr.h in FontFallbackList.h This change is wrong. When using PassRefPtr in a header, you don't need to include <wtf/PassRefPtr.h>. Instead you can include <wtf/Forward.h>. But also, we have a test that FontFallbackList.h already includes everything it needs to be compiled on its own. That's the fact that FontFallbackList.cpp includes it first. If there was any missing dependency, that would catch it because it would fail to compile. The way it gets Forward.h included is that it includes FontData.h, which includes FontPlatformData.h, which includes StringImpl.h, which includes Forward.h. If there was any other header needed for PassRefPtr, it would need to be included by StringImpl.h. In fact, there's no need for FontFallbackList.h to include RefCounted.h or Vector.h -- they are both included by StringImpl.h, so the correct patch would be to remove both of those wtf includes. 63748 4 darin 2007-12-09 07:02:12 -0800 Oh, I overlooked the fact that the FontPlatformData.h file in question was the Mac one. I suppose there's no guarantee that StringImpl.h will be included. So given that, it's fine to include <wtf/Forward.h> in FontFallbackList.h. But I would also think we would need to include RefPtr.h -- was PassRefPtr,h alone really enough in your testing? 63751 5 17805 darin 2007-12-09 08:42:36 -0800 Created attachment 17805 patch 63771 6 rob 2007-12-09 16:03:54 -0800 RefPtr.h was being included by GlyphPageTreeNode.h, like so: GlyphPageTreeNode.h wtf/HashMap.h wtf/HashTable.h wtf/HashTraits.h wtf/HashFunctions.h wtf/RefPtr.h This is no longer a problem. At the time I had an empty FontPlatformData.h which was making this break. Now I don't (I include StringImpl.h and other things) and it doesn't happen. I filed the bug because I thought it odd that things missing from my own files would cause other files to break. If you don't think thats a problem then there is no bug on my end :) Patch looks good. 64202 7 darin 2007-12-14 12:57:26 -0800 Committed revision 28721. 17791 2007-12-08 14:55:04 -0800 2007-12-09 08:42:36 -0800 Patch to include PassRefPtr.h in FontFallbackList.h fontfallbacklist-include-passrefptr.patch text/plain 925 rob ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NmQzYjNhOS4uYWQyMTFhZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwNy0xMi0wOCAgUm9iZXJ0IE5vcnJp cyAgPHJvYkBjYXRhY2x5c20uY3g+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQnJpbmcgaW4gUGFzc1JlZlB0ciBleHBsaWNpdGx5CisKKyAgICAgICAg V0FSTklORzogTk8gVEVTVCBDQVNFUyBBRERFRCBPUiBDSEFOR0VECisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9Gb250RmFsbGJhY2tMaXN0Lmg6CisKIDIwMDctMTItMDcgIFNhbSBXZWlu aWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbi4KZGlmZiAt LWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udEZhbGxiYWNrTGlzdC5oIGIvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250RmFsbGJhY2tMaXN0LmgKaW5kZXggYjc4NzNmOS4u NzIwN2YwMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250RmFsbGJh Y2tMaXN0LmgKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250RmFsbGJhY2tMaXN0 LmgKQEAgLTI1LDYgKzI1LDcgQEAKIC8vIGFuZCBzbyB0aGlzIHNob3VsZCBjYXRjaCBhbnlvbmUg dHJ5aW5nIHRvIGluY2x1ZGUgdGhpcyBmaWxlIGluIHB1YmxpYyBjcHAgZmlsZXMuCiAKICNpbmNs dWRlICJGb250RGF0YS5oIgorI2luY2x1ZGUgPHd0Zi9QYXNzUmVmUHRyLmg+CiAjaW5jbHVkZSA8 d3RmL1JlZkNvdW50ZWQuaD4KICNpbmNsdWRlICJGb250U2VsZWN0b3IuaCIKICNpbmNsdWRlIDx3 dGYvVmVjdG9yLmg+Cg== 17805 2007-12-09 08:42:36 -0800 2007-12-09 20:43:33 -0800 patch IncludePatch.txt text/plain 5243 darin SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI4NTcyKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDctMTItMDkgIERhcmluIEFk bGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIC0gcmVtb3ZlZCB1bm5lY2Vzc2FyeSBpbmNsdWRlcyBvZiAiVmVjdG9y LmgiCisKKyAgICAgICAgKiB3dGYvSGFzaE1hcC5oOgorICAgICAgICAoV1RGOjpjb3B5S2V5c1Rv VmVjdG9yKTogTWFrZSB0aGUgdHlwZSBvZiB0aGUgdmVjdG9yIGJlIGEgdGVtcGxhdGUgcGFyYW1l dGVyLgorICAgICAgICBUaGlzIGFsbG93cyBjb3B5aW5nIGtleXMgaW50byBhIHZlY3RvciBvZiBh IGJhc2UgY2xhc3Mgb3Igb25lIHdpdGggYW4gaW5saW5lIGNhcGFjaXR5LgorICAgICAgICAoV1RG Ojpjb3B5VmFsdWVzVG9WZWN0b3IpOiBEaXR0by4KKyAgICAgICAgKiB3dGYvSGFzaFNldC5oOgor ICAgICAgICAoV1RGOjpjb3B5VG9WZWN0b3IpOiBEaXR0by4KKwogMjAwNy0xMi0wOCAgT2xpdmVy IEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXLgpJ bmRleDogSmF2YVNjcmlwdENvcmUvd3RmL0hhc2hNYXAuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2Ny aXB0Q29yZS93dGYvSGFzaE1hcC5oCShyZXZpc2lvbiAyODU3MikKKysrIEphdmFTY3JpcHRDb3Jl L3d0Zi9IYXNoTWFwLmgJKHdvcmtpbmcgY29weSkKQEAgLTIzLDcgKzIzLDYgQEAKICNkZWZpbmUg V1RGX0hhc2hNYXBfaAogCiAjaW5jbHVkZSAiSGFzaFRhYmxlLmgiCi0jaW5jbHVkZSAiVmVjdG9y LmgiCiAKIG5hbWVzcGFjZSBXVEYgewogCkBAIC0zOTMsOCArMzkyLDggQEAgbmFtZXNwYWNlIFdU RiB7CiAgICAgICAgIGRlbGV0ZUFsbFBhaXJGaXJzdHM8dHlwZW5hbWUgSGFzaE1hcDxULCBVLCBW LCBXLCBYPjo6S2V5VHlwZT4oY29sbGVjdGlvbik7CiAgICAgfQogICAgIAotICAgIHRlbXBsYXRl PHR5cGVuYW1lIFQsIHR5cGVuYW1lIFUsIHR5cGVuYW1lIFYsIHR5cGVuYW1lIFcsIHR5cGVuYW1l IFg+Ci0gICAgaW5saW5lIHZvaWQgY29weUtleXNUb1ZlY3Rvcihjb25zdCBIYXNoTWFwPFQsIFUs IFYsIFcsIFg+JiBjb2xsZWN0aW9uLCBWZWN0b3I8VD4mIHZlY3RvcikKKyAgICB0ZW1wbGF0ZTx0 eXBlbmFtZSBULCB0eXBlbmFtZSBVLCB0eXBlbmFtZSBWLCB0eXBlbmFtZSBXLCB0eXBlbmFtZSBY LCB0eXBlbmFtZSBZPgorICAgIGlubGluZSB2b2lkIGNvcHlLZXlzVG9WZWN0b3IoY29uc3QgSGFz aE1hcDxULCBVLCBWLCBXLCBYPiYgY29sbGVjdGlvbiwgWSYgdmVjdG9yKQogICAgIHsKICAgICAg ICAgdHlwZWRlZiB0eXBlbmFtZSBIYXNoTWFwPFQsIFUsIFYsIFcsIFg+Ojpjb25zdF9pdGVyYXRv cjo6S2V5cyBpdGVyYXRvcjsKICAgICAgICAgCkBAIC00MDYsOCArNDA1LDggQEAgbmFtZXNwYWNl IFdURiB7CiAgICAgICAgICAgICB2ZWN0b3JbaV0gPSAqaXQ7CiAgICAgfSAgCiAKLSAgICB0ZW1w bGF0ZTx0eXBlbmFtZSBULCB0eXBlbmFtZSBVLCB0eXBlbmFtZSBWLCB0eXBlbmFtZSBXLCB0eXBl bmFtZSBYPgotICAgIGlubGluZSB2b2lkIGNvcHlWYWx1ZXNUb1ZlY3Rvcihjb25zdCBIYXNoTWFw PFQsIFUsIFYsIFcsIFg+JiBjb2xsZWN0aW9uLCBWZWN0b3I8VT4mIHZlY3RvcikKKyAgICB0ZW1w bGF0ZTx0eXBlbmFtZSBULCB0eXBlbmFtZSBVLCB0eXBlbmFtZSBWLCB0eXBlbmFtZSBXLCB0eXBl bmFtZSBYLCB0eXBlbmFtZSBZPgorICAgIGlubGluZSB2b2lkIGNvcHlWYWx1ZXNUb1ZlY3Rvcihj b25zdCBIYXNoTWFwPFQsIFUsIFYsIFcsIFg+JiBjb2xsZWN0aW9uLCBZJiB2ZWN0b3IpCiAgICAg ewogICAgICAgICB0eXBlZGVmIHR5cGVuYW1lIEhhc2hNYXA8VCwgVSwgViwgVywgWD46OmNvbnN0 X2l0ZXJhdG9yOjpWYWx1ZXMgaXRlcmF0b3I7CiAgICAgICAgIApJbmRleDogSmF2YVNjcmlwdENv cmUvd3RmL0hhc2hTZXQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93dGYvSGFzaFNl dC5oCShyZXZpc2lvbiAyODU3MikKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi9IYXNoU2V0LmgJKHdv cmtpbmcgY29weSkKQEAgLTEsOCArMSw2IEBACiAvLyAtKi0gbW9kZTogYysrOyBjLWJhc2ljLW9m ZnNldDogNCAtKi0KIC8qCi0gKiBUaGlzIGZpbGUgaXMgcGFydCBvZiB0aGUgS0RFIGxpYnJhcmll cwotICoKLSAqIENvcHlyaWdodCAoQykgMjAwNSwgMjAwNiBBcHBsZSBDb21wdXRlciwgSW5jLgor ICogQ29weXJpZ2h0IChDKSAyMDA1LCAyMDA2LCAyMDA3IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyBy ZXNlcnZlZC4KICAqCiAgKiBUaGlzIGxpYnJhcnkgaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiBy ZWRpc3RyaWJ1dGUgaXQgYW5kL29yCiAgKiBtb2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRo ZSBHTlUgTGlicmFyeSBHZW5lcmFsIFB1YmxpYwpAQCAtMjUsNyArMjMsNiBAQAogI2RlZmluZSBX VEZfSGFzaFNldF9oCiAKICNpbmNsdWRlICJIYXNoVGFibGUuaCIKLSNpbmNsdWRlICJWZWN0b3Iu aCIKIAogbmFtZXNwYWNlIFdURiB7CiAKQEAgLTMxNyw4ICszMTQsOCBAQCBuYW1lc3BhY2UgV1RG IHsKICAgICAgICAgZGVsZXRlQWxsVmFsdWVzPHR5cGVuYW1lIEhhc2hTZXQ8VCwgVSwgVj46OlZh bHVlVHlwZT4oY29sbGVjdGlvbi5tX2ltcGwpOwogICAgIH0KICAgICAKLSAgICB0ZW1wbGF0ZTx0 eXBlbmFtZSBULCB0eXBlbmFtZSBVLCB0eXBlbmFtZSBWPgotICAgIGlubGluZSB2b2lkIGNvcHlU b1ZlY3Rvcihjb25zdCBIYXNoU2V0PFQsIFUsIFY+JiBjb2xsZWN0aW9uLCBWZWN0b3I8VD4mIHZl Y3RvcikKKyAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBULCB0eXBlbmFtZSBVLCB0eXBlbmFtZSBWLCB0 eXBlbmFtZSBXPgorICAgIGlubGluZSB2b2lkIGNvcHlUb1ZlY3Rvcihjb25zdCBIYXNoU2V0PFQs IFUsIFY+JiBjb2xsZWN0aW9uLCBXJiB2ZWN0b3IpCiAgICAgewogICAgICAgICB0eXBlZGVmIHR5 cGVuYW1lIEhhc2hTZXQ8VCwgVSwgVj46OmNvbnN0X2l0ZXJhdG9yIGl0ZXJhdG9yOwogICAgICAg ICAKQEAgLTMyOSw2ICszMjYsNyBAQCBuYW1lc3BhY2UgV1RGIHsKICAgICAgICAgZm9yICh1bnNp Z25lZCBpID0gMDsgaXQgIT0gZW5kOyArK2l0LCArK2kpCiAgICAgICAgICAgICB2ZWN0b3JbaV0g PSAqaXQ7CiAgICAgfSAgCisKIH0gLy8gbmFtZXNwYWNlIFdURgogCiB1c2luZyBXVEY6Okhhc2hT ZXQ7CkluZGV4OiBXZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL0NoYW5n ZUxvZwkocmV2aXNpb24gMjg1NzIpCisrKyBXZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDEzIEBACisyMDA3LTEyLTA5ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAt IGZpeCBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjM1MQorICAgICAg ICAgIEZvbnRGYWxsYmFja0xpc3QuaCBkb2Vzbid0IGluY2x1ZGUgd3RmL1Bhc3NSZWZQdHIuaAor ICAgICAgICAgIAorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ZvbnRGYWxsYmFja0xpc3Qu aDogQWRkZWQgaW5jbHVkZSBvZiA8d3RmL0ZvcndhcmQuaD4KKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9HbHlwaFBhZ2VUcmVlTm9kZS5oOiBSZW1vdmVkIGFuIHVubmVlZGVkIGluY2x1ZGUu CisKIDIwMDctMTItMDggIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBPbGl2ZXIuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnRG YWxsYmFja0xpc3QuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Zv bnRGYWxsYmFja0xpc3QuaAkocmV2aXNpb24gMjg1NzIpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL0ZvbnRGYWxsYmFja0xpc3QuaAkod29ya2luZyBjb3B5KQpAQCAtMjIsMTIgKzIyLDEx IEBACiAgKi8KIAogLy8gVGhpcyBmaWxlIGhhcyBubyBndWFyZHMgb24gcHVycG9zZSBpbiBvcmRl ciB0byBkZXRlY3QgcmVkdW5kYW50IGluY2x1ZGVzLiBUaGlzIGlzIGEgcHJpdmF0ZSBoZWFkZXIK LS8vIGFuZCBzbyB0aGlzIHNob3VsZCBjYXRjaCBhbnlvbmUgdHJ5aW5nIHRvIGluY2x1ZGUgdGhp cyBmaWxlIGluIHB1YmxpYyBjcHAgZmlsZXMuCisvLyBhbmQgc28gdGhpcyBtYXkgY2F0Y2ggc29t ZW9uZSB0cnlpbmcgdG8gaW5jbHVkZSB0aGlzIGZpbGUgaW4gcHVibGljIGNwcCBmaWxlcy4KIAog I2luY2x1ZGUgIkZvbnREYXRhLmgiCi0jaW5jbHVkZSA8d3RmL1JlZkNvdW50ZWQuaD4KICNpbmNs dWRlICJGb250U2VsZWN0b3IuaCIKLSNpbmNsdWRlIDx3dGYvVmVjdG9yLmg+CisjaW5jbHVkZSA8 d3RmL0ZvcndhcmQuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCkluZGV4OiBXZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL0dseXBoUGFnZVRyZWVOb2RlLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9HbHlwaFBhZ2VUcmVlTm9kZS5oCShyZXZpc2lvbiAyODU3MikK KysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR2x5cGhQYWdlVHJlZU5vZGUuaAkod29ya2lu ZyBjb3B5KQpAQCAtMzEsNyArMzEsNiBAQAogCiAjaW5jbHVkZSA8d3RmL1JlZkNvdW50ZWQuaD4K ICNpbmNsdWRlIDx3dGYvdW5pY29kZS9Vbmljb2RlLmg+Ci0jaW5jbHVkZSA8d3RmL05vbmNvcHlh YmxlLmg+CiAjaW5jbHVkZSA8d3RmL0hhc2hNYXAuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewo=