163493 2016-10-15 16:20:51 -0700 Add a $vm.getpid() method. 2016-10-15 18:47:01 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam commit-queue jfbastien keith_miller msaboff saam oldest_to_newest 1240662 0 mark.lam 2016-10-15 16:20:51 -0700 This is especially useful when we need to know the pid of an instance of jsc in the foreground that we're trying to attach a debugger to while the JSC tests are running in the background with a gazillion other jsc processes live at the same time. 1240664 1 291730 mark.lam 2016-10-15 16:24:07 -0700 Created attachment 291730 proposed patch. 1240671 2 291730 jfbastien 2016-10-15 16:41:05 -0700 Comment on attachment 291730 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=291730&action=review Test that it returns a non-0 and non-1 integer? > Source/JavaScriptCore/tools/JSDollarVMPrototype.cpp:416 > + return JSValue::encode(JSValue(getpid())); Does that work on Windows? Docs say deprecated, but I don't see why they'd remove it. 1240673 3 mark.lam 2016-10-15 16:48:16 -0700 (In reply to comment #2) > Comment on attachment 291730 [details] > proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=291730&action=review > > Test that it returns a non-0 and non-1 integer? I don't think it matters. This is just a debugging tool, and we just want whatever int value getpid() returns. > > Source/JavaScriptCore/tools/JSDollarVMPrototype.cpp:416 > > + return JSValue::encode(JSValue(getpid())); > > Does that work on Windows? Docs say deprecated, but I don't see why they'd > remove it. Good catch. Let me fix. 1240675 4 291731 mark.lam 2016-10-15 17:10:10 -0700 Created attachment 291731 proposed patch. 1240682 5 jfbastien 2016-10-15 17:46:00 -0700 (In reply to comment #3) > (In reply to comment #2) > > Comment on attachment 291730 [details] > > proposed patch. > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=291730&action=review > > > > Test that it returns a non-0 and non-1 integer? > > I don't think it matters. This is just a debugging tool, and we just want > whatever int value getpid() returns. Yeah but broken debugging is worst debugging. Unlikely to fail given the posix spec, but getting just 0 is really annoying. I don't care much about it, just seems weird, so lgtm either way. 1240685 6 291731 saam 2016-10-15 18:23:56 -0700 Comment on attachment 291731 proposed patch. r=me 1240687 7 291731 commit-queue 2016-10-15 18:46:57 -0700 Comment on attachment 291731 proposed patch. Clearing flags on attachment: 291731 Committed r207387: <http://trac.webkit.org/changeset/207387> 1240688 8 commit-queue 2016-10-15 18:47:01 -0700 All reviewed patches have been landed. Closing bug. 291730 2016-10-15 16:24:07 -0700 2016-10-15 17:10:10 -0700 proposed patch. bug-163493.patch text/plain 1878 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA3MzgyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE2LTEwLTE1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB ZGQgYSAkdm0uZ2V0cGlkKCkgbWV0aG9kLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTYzNDkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhpcyBpcyBlc3BlY2lhbGx5IHVzZWZ1bCB3aGVuIHdlIG5lZWQg dG8ga25vdyB0aGUgcGlkIG9mIGFuIGluc3RhbmNlIG9mIGpzYyBpbgorICAgICAgICB0aGUgZm9y ZWdyb3VuZCB0aGF0IHdlJ3JlIHRyeWluZyB0byBhdHRhY2ggYSBkZWJ1Z2dlciB0byB3aGlsZSB0 aGUgSlNDIHRlc3RzIGFyZQorICAgICAgICBydW5uaW5nIGluIHRoZSBiYWNrZ3JvdW5kIHdpdGgg YSBnYXppbGxpb24gb3RoZXIganNjIHByb2Nlc3NlcyBsaXZlIGF0IHRoZSBzYW1lCisgICAgICAg IHRpbWUuCisKKyAgICAgICAgKiB0b29scy9KU0RvbGxhclZNUHJvdG90eXBlLmNwcDoKKyAgICAg ICAgKEpTQzo6ZnVuY3Rpb25HZXRQSUQpOgorICAgICAgICAoSlNDOjpKU0RvbGxhclZNUHJvdG90 eXBlOjpmaW5pc2hDcmVhdGlvbik6CisKIDIwMTYtMTAtMTUgIFNhYW0gQmFyYXRpICA8c2JhcmF0 aUBhcHBsZS5jb20+CiAKICAgICAgICAgQXNzZXJ0aW9uIGZhaWxlZCB1bmRlciBvcGVyYXRpb25U b0xvd2VyQ2FzZSB3aXRoIGEgcm9wZSB3aXRoIHplcm8gbGVuZ3RoCkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvdG9vbHMvSlNEb2xsYXJWTVByb3RvdHlwZS5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL3Rvb2xzL0pTRG9sbGFyVk1Qcm90b3R5cGUuY3BwCShyZXZp c2lvbiAyMDczNzYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdG9vbHMvSlNEb2xsYXJWTVBy b3RvdHlwZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQxMSw2ICs0MTEsMTEgQEAgc3RhdGljIEVu Y29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgZnVuYwogICAgIHJldHVybiBKU1ZhbHVlOjplbmNv ZGUoanNTdHJpbmcoZXhlYywgc3RyZWFtLnRvU3RyaW5nKCkpKTsKIH0KIAorc3RhdGljIEVuY29k ZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgZnVuY3Rpb25HZXRQSUQoRXhlY1N0YXRlKikKK3sKKyAg ICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKEpTVmFsdWUoZ2V0cGlkKCkpKTsKK30KKwogdm9pZCBK U0RvbGxhclZNUHJvdG90eXBlOjpmaW5pc2hDcmVhdGlvbihWTSYgdm0sIEpTR2xvYmFsT2JqZWN0 KiBnbG9iYWxPYmplY3QpCiB7CiAgICAgQmFzZTo6ZmluaXNoQ3JlYXRpb24odm0pOwpAQCAtNDM0 LDYgKzQzOSw3IEBAIHZvaWQgSlNEb2xsYXJWTVByb3RvdHlwZTo6ZmluaXNoQ3JlYXRpb24KICAg ICBhZGRGdW5jdGlvbih2bSwgZ2xvYmFsT2JqZWN0LCAicHJpbnRTdGFjayIsIGZ1bmN0aW9uUHJp bnRTdGFjaywgMCk7CiAKICAgICBhZGRGdW5jdGlvbih2bSwgZ2xvYmFsT2JqZWN0LCAidmFsdWUi LCBmdW5jdGlvblZhbHVlLCAxKTsKKyAgICBhZGRGdW5jdGlvbih2bSwgZ2xvYmFsT2JqZWN0LCAi Z2V0cGlkIiwgZnVuY3Rpb25HZXRQSUQsIDApOwogfQogCiB9IC8vIG5hbWVzcGFjZSBKU0MK 291731 2016-10-15 17:10:10 -0700 2016-10-15 18:46:57 -0700 proposed patch. bug-163493.patch text/plain 2479 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA3MzgyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBA CisyMDE2LTEwLTE1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB ZGQgYSAkdm0uZ2V0cGlkKCkgbWV0aG9kLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTYzNDkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhpcyBpcyBlc3BlY2lhbGx5IHVzZWZ1bCB3aGVuIHdlIG5lZWQg dG8ga25vdyB0aGUgcGlkIG9mIGFuIGluc3RhbmNlIG9mIGpzYyBpbgorICAgICAgICB0aGUgZm9y ZWdyb3VuZCB0aGF0IHdlJ3JlIHRyeWluZyB0byBhdHRhY2ggYSBkZWJ1Z2dlciB0byB3aGlsZSB0 aGUgSlNDIHRlc3RzIGFyZQorICAgICAgICBydW5uaW5nIGluIHRoZSBiYWNrZ3JvdW5kIHdpdGgg YSBnYXppbGxpb24gb3RoZXIganNjIHByb2Nlc3NlcyBsaXZlIGF0IHRoZSBzYW1lCisgICAgICAg IHRpbWUuCisKKyAgICAgICAgQ3VycmVudGx5LCAkdm0uZ2V0cGlkKCkgaXMgb25seSBzdXBwb3J0 ZWQgb24gbm9uLVdpbmRvd3MgcGxhdGZvcm1zLgorICAgICAgICBBY2NvcmRpbmcgdG8gaHR0cHM6 Ly9tc2RuLm1pY3Jvc29mdC5jb20vZW4tdXMvbGlicmFyeS9tczIzNTM3Mi5hc3B4LCBnZXRwaWQo KSBpcworICAgICAgICBkZXByZWNhdGVkLiAgQWNjb3JkaW5nIHRvIGh0dHBzOi8vbXNkbi5taWNy b3NvZnQuY29tL2VuLXVzL2xpYnJhcnkvdDJ5MzR5NDAuYXNweCwKKyAgICAgICAgX2dldHBpZCgp IGNhbm5vdCBiZSB1c2VkIGluIGFwcGxpY2F0aW9ucyB0aGF0IGV4ZWN1dGUgaW4gdGhlIFdpbmRv d3MgUnVudGltZS4KKworICAgICAgICBTaW5jZSB0aGlzIGlzIG9ubHkgYSBkZWJ1Z2dpbmcgdG9v bCBhbmQgaXMgbm90IGEgcmVxdWlyZWQgZmVhdHVyZSwgSSdsbCBkZWZlcgorICAgICAgICB0aGUg V2luZG93cyBpbXBsZW1lbnRhdGlvbiBvZiB0aGlzIGZ1bmN0aW9uIHRpbGwgdGhlIHRpbWUgd2hl biBzb21lb25lIGFjdHVhbGx5CisgICAgICAgIG5lZWRzIGl0LgorCisgICAgICAgICogdG9vbHMv SlNEb2xsYXJWTVByb3RvdHlwZS5jcHA6CisgICAgICAgIChKU0M6OmZ1bmN0aW9uR2V0UElEKToK KyAgICAgICAgKEpTQzo6SlNEb2xsYXJWTVByb3RvdHlwZTo6ZmluaXNoQ3JlYXRpb24pOgorCiAy MDE2LTEwLTE1ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIEFz c2VydGlvbiBmYWlsZWQgdW5kZXIgb3BlcmF0aW9uVG9Mb3dlckNhc2Ugd2l0aCBhIHJvcGUgd2l0 aCB6ZXJvIGxlbmd0aApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3Rvb2xzL0pTRG9sbGFy Vk1Qcm90b3R5cGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90b29s cy9KU0RvbGxhclZNUHJvdG90eXBlLmNwcAkocmV2aXNpb24gMjA3Mzc2KQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL3Rvb2xzL0pTRG9sbGFyVk1Qcm90b3R5cGUuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC00MTEsNiArNDExLDEzIEBAIHN0YXRpYyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxM IGZ1bmMKICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzU3RyaW5nKGV4ZWMsIHN0cmVhbS50 b1N0cmluZygpKSk7CiB9CiAKKyNpZiAhUExBVEZPUk0oV0lOKQorc3RhdGljIEVuY29kZWRKU1Zh bHVlIEpTQ19IT1NUX0NBTEwgZnVuY3Rpb25HZXRQSUQoRXhlY1N0YXRlKikKK3sKKyAgICByZXR1 cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzTnVtYmVyKGdldHBpZCgpKSk7Cit9CisjZW5kaWYKKwogdm9p ZCBKU0RvbGxhclZNUHJvdG90eXBlOjpmaW5pc2hDcmVhdGlvbihWTSYgdm0sIEpTR2xvYmFsT2Jq ZWN0KiBnbG9iYWxPYmplY3QpCiB7CiAgICAgQmFzZTo6ZmluaXNoQ3JlYXRpb24odm0pOwpAQCAt NDM0LDYgKzQ0MSw5IEBAIHZvaWQgSlNEb2xsYXJWTVByb3RvdHlwZTo6ZmluaXNoQ3JlYXRpb24K ICAgICBhZGRGdW5jdGlvbih2bSwgZ2xvYmFsT2JqZWN0LCAicHJpbnRTdGFjayIsIGZ1bmN0aW9u UHJpbnRTdGFjaywgMCk7CiAKICAgICBhZGRGdW5jdGlvbih2bSwgZ2xvYmFsT2JqZWN0LCAidmFs dWUiLCBmdW5jdGlvblZhbHVlLCAxKTsKKyNpZiAhUExBVEZPUk0oV0lOKQorICAgIGFkZEZ1bmN0 aW9uKHZtLCBnbG9iYWxPYmplY3QsICJnZXRwaWQiLCBmdW5jdGlvbkdldFBJRCwgMCk7CisjZW5k aWYKIH0KIAogfSAvLyBuYW1lc3BhY2UgSlNDCg==