163478 2016-10-14 18:23:11 -0700 REGRESSION (r206973): Running "webkit-patch suggest-reviewers" throws an AttributeError: 'NoneType' object has no attribute 'full_name' 2016-10-14 21:21:02 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 163183 1 aestes simon.fraser commit-queue dbates glenn lforschler simon.fraser oldest_to_newest 1240518 0 aestes 2016-10-14 18:23:11 -0700 % webkit-patch suggest-reviewers Traceback (most recent call last): File "/Users/andy/Code/OpenSource/Tools/Scripts/webkit-patch", line 84, in <module> main() File "/Users/andy/Code/OpenSource/Tools/Scripts/webkit-patch", line 79, in main WebKitPatch(os.path.abspath(__file__)).main() File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main result = command.check_arguments_and_execute(options, args, self) File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 55, in execute self._sequence.run_and_handle_errors(tool, options, state) File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors self._run(tool, options, state) File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run step(tool, options).run(state) File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/tool/steps/suggestreviewers.py", line 45, in run reviewers = self._tool.checkout().suggested_reviewers(self._options.git_commit, self._changed_files(state))[:5] File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 146, in suggested_reviewers unique_reviewers = reduce(lambda suggestions, reviewer: suggestions + [reviewer if reviewer not in suggestions else None], reviewers, []) File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 146, in <lambda> unique_reviewers = reduce(lambda suggestions, reviewer: suggestions + [reviewer if reviewer not in suggestions else None], reviewers, []) File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/common/config/committers.py", line 79, in __eq__ return (self.full_name == other.full_name AttributeError: 'NoneType' object has no attribute 'full_name' 1240549 1 291701 simon.fraser 2016-10-14 20:26:30 -0700 Created attachment 291701 Patch 1240558 2 291701 commit-queue 2016-10-14 21:20:58 -0700 Comment on attachment 291701 Patch Clearing flags on attachment: 291701 Committed r207370: <http://trac.webkit.org/changeset/207370> 1240559 3 commit-queue 2016-10-14 21:21:02 -0700 All reviewed patches have been landed. Closing bug. 291701 2016-10-14 20:26:30 -0700 2016-10-14 21:20:58 -0700 Patch bug-163478-20161014202301.patch text/plain 1664 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3MzIxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTc1Zjg4MWE5NjQ4M2JhNzAzZDE2YTRlZDJhMGJlZWQw MjU4YTk5Mi4uMzljMmQ1MzcxOTZhYWRkNjFkOTYwZWFlZWFiZjFlNmM0NDc5NTQwMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE2LTEwLTE0ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgor CisgICAgICAgIFJFR1JFU1NJT04gKHIyMDY5NzMpOiBSdW5uaW5nICJ3ZWJraXQtcGF0Y2ggc3Vn Z2VzdC1yZXZpZXdlcnMiIHRocm93cyBhbiBBdHRyaWJ1dGVFcnJvcjogJ05vbmVUeXBlJyBvYmpl Y3QgaGFzIG5vIGF0dHJpYnV0ZSAnZnVsbF9uYW1lJworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzNDc4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBIYW5kbGUgYSBOb25lIG90aGVyIGluIENv bnRyaWJ1dG9yLl9fZXFfXy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2Nv bmZpZy9jb21taXR0ZXJzLnB5OgorICAgICAgICAoQ29udHJpYnV0b3IuX19lcV9fKToKKwogMjAx Ni0xMC0xMyAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAg ICAgICAgIEhvc3RzIG9mIFVSTHMgd2l0aCBub24tc3BlY2lhbCBzY2hlbWVzIHNob3VsZCBiZSBj YXNlLXNlbnNpdGl2ZSwgYW5kIG5vbi1BU0NJSSBjaGFyYWN0ZXJzIGluIHN1Y2ggaG9zdHMgc2hv dWxkIGJlIHB1bnljb2RlLWVuY29kZWQKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvY29tbW9uL2NvbmZpZy9jb21taXR0ZXJzLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9j b21tb24vY29uZmlnL2NvbW1pdHRlcnMucHkKaW5kZXggYWM0ZmJiY2YxYjEzYjQzMTFkOGIwYTU3 OTdmNDFmNThlZTY0YTEwOS4uN2UzMGRmMjE1YTE0NTZlNzQ5MDQ0ZmMyOWE0MzQ1ODU3NDZlZDA1 NiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL2NvbW1p dHRlcnMucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL2NvbW1p dHRlcnMucHkKQEAgLTc1LDcgKzc1LDggQEAgY2xhc3MgQ29udHJpYnV0b3Iob2JqZWN0KToKICAg ICAgICAgcmV0dXJuICciJXMiIDwlcz4nICUgKHNlbGYuZnVsbF9uYW1lLCBzZWxmLmVtYWlsc1sw XSkKIAogICAgIGRlZiBfX2VxX18oc2VsZiwgb3RoZXIpOgotICAgICAgICByZXR1cm4gKHNlbGYu ZnVsbF9uYW1lID09IG90aGVyLmZ1bGxfbmFtZQorICAgICAgICByZXR1cm4gKG90aGVyIGlzIG5v dCBOb25lCisgICAgICAgICAgICBhbmQgc2VsZi5mdWxsX25hbWUgPT0gb3RoZXIuZnVsbF9uYW1l CiAgICAgICAgICAgICBhbmQgc2VsZi5lbWFpbHMgPT0gb3RoZXIuZW1haWxzCiAgICAgICAgICAg ICBhbmQgc2VsZi5fY2FzZV9wcmVzZXJ2ZWRfZW1haWxzID09IG90aGVyLl9jYXNlX3ByZXNlcnZl ZF9lbWFpbHMKICAgICAgICAgICAgIGFuZCBzZWxmLmlyY19uaWNrbmFtZXMgPT0gb3RoZXIuaXJj X25pY2tuYW1lcwo=