163451 2016-10-14 09:56:58 -0700 [CMake] Private/unsupported build options should be marked as advanced 2016-10-14 11:31:58 -0700 1 1 1 Unclassified WebKit WebKit Misc. Other PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro annulen bugs-noreply commit-queue mcatanzaro oldest_to_newest 1240313 0 mcatanzaro 2016-10-14 09:56:58 -0700 Private/unsupported build options should be marked as advanced so that they are hidden to users listing CMake options (e.g. with 'cmake -L'). 1240314 1 mcatanzaro 2016-10-14 09:57:54 -0700 Er wait, we already have code for this (WebKitFeatures.cmake): option(${_name} "${_WEBKIT_AVAILABLE_OPTIONS_DESCRIPTION_${_name}}" ${_WEBKIT_AVAILABLE_OPTIONS_INITIAL_VALUE_${_name}}) if (NOT _WEBKIT_AVAILABLE_OPTIONS_IS_PUBLIC_${_name}) mark_as_advanced(FORCE ${_name}) endif () 1240328 2 291645 mcatanzaro 2016-10-14 10:30:02 -0700 Created attachment 291645 Patch 1240369 3 291645 commit-queue 2016-10-14 11:31:54 -0700 Comment on attachment 291645 Patch Clearing flags on attachment: 291645 Committed r207351: <http://trac.webkit.org/changeset/207351> 1240370 4 commit-queue 2016-10-14 11:31:58 -0700 All reviewed patches have been landed. Closing bug. 291645 2016-10-14 10:30:02 -0700 2016-10-14 11:31:54 -0700 Patch bug-163451-20161014122634.patch text/plain 1512 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3MzAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0RmVhdHVyZXMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UKaW5k ZXggN2I3ZWY1ZThiMTRlMDRlZTEzYWU5ZTFjM2Q5YmYzYzY2ZGIyNTU0ZC4uM2JiNGMxMzdiMjU5 MGYyNjQ2Y2I5ZjQ2ZjViYmE5MDlkODg3YmQ2OCAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dl YktpdEZlYXR1cmVzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFr ZQpAQCAtMjY4LDcgKzI2OCw3IEBAIG1hY3JvKFdFQktJVF9PUFRJT05fRU5EKQogICAgICAgICBl bmRpZiAoKQogCiAgICAgICAgIG9wdGlvbigke19uYW1lfSAiJHtfV0VCS0lUX0FWQUlMQUJMRV9P UFRJT05TX0RFU0NSSVBUSU9OXyR7X25hbWV9fSIgJHtfV0VCS0lUX0FWQUlMQUJMRV9PUFRJT05T X0lOSVRJQUxfVkFMVUVfJHtfbmFtZX19KQotICAgICAgICBpZiAoTk9UIF9XRUJLSVRfQVZBSUxB QkxFX09QVElPTlNfSVNfUFVCTElDXyR7X25hbWV9KQorICAgICAgICBpZiAoTk9UICR7X1dFQktJ VF9BVkFJTEFCTEVfT1BUSU9OU19JU19QVUJMSUNfJHtfbmFtZX19KQogICAgICAgICAgICAgbWFy a19hc19hZHZhbmNlZChGT1JDRSAke19uYW1lfSkKICAgICAgICAgZW5kaWYgKCkKICAgICBlbmRm b3JlYWNoICgpCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggMjNiMzcw OTNkYmM0ZTQ1OWUzMWYwM2JjNTRiOGY1YTliYmFiNzZjNC4uZjA1NmQ2MjM5MDg4YTNlOTBkYWJk MmQxYTk2MTRjODI1ZDFlM2Y5YiAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTEwLTE0ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRh bnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbQ01ha2VdIFByaXZhdGUvdW5zdXBwb3J0ZWQg YnVpbGQgb3B0aW9ucyBzaG91bGQgYmUgbWFya2VkIGFzIGFkdmFuY2VkCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjM0NTEKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGNoZWNraW5nIHRvIGRlY2lk ZSB3aGV0aGVyIHRvIG1hcmsgYW4gb3B0aW9uIGFzIGFkdmFuY2VkLCB0aGUgY29uZGl0aW9uYWwg Y2hlY2tzCisgICAgICAgIHdoZXRoZXIgX1dFQktJVF9BVkFJTEFCTEVfT1BUSU9OU19JU19QVUJM SUNfJHtfbmFtZX0gaXMgZGVmaW5lZC4gSXQgaXMgYWx3YXlzIGRlZmluZWQuIFdlCisgICAgICAg IG5lZWQgdG8gY2hlY2sgaXRzIHZhbHVlIGluc3RlYWQuCisKKyAgICAgICAgKiBTb3VyY2UvY21h a2UvV2ViS2l0RmVhdHVyZXMuY21ha2U6CisKIDIwMTYtMTAtMTIgIENocmlzIER1bWV6ICA8Y2R1 bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViIElETF0gRHJvcCBzdXBwb3J0IGZvciBsZWdh Y3kgW0NvbnN0cnVjdG9yQ29uZGl0aW9uYWw9Kl0K