163441 2016-10-14 02:52:30 -0700 resolve-ChangeLogs: Specify --no-page to git diff 2016-10-17 19:38:27 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 fujii webkit-unassigned commit-queue darin ddkilzer lforschler oldest_to_newest 1240202 0 fujii 2016-10-14 02:52:30 -0700 resolve-ChangeLogs shows the result after resolving by invoking 'git diff'. It runs a pager for every ChangeLog if it is under TTY. 1240204 1 291605 fujii 2016-10-14 02:57:13 -0700 Created attachment 291605 Patch 1241010 2 291605 darin 2016-10-17 10:45:47 -0700 Comment on attachment 291605 Patch Sorry, could you explain why this is an improvement? If I am running this script from the TTY, why wouldn’t I want the diff paged? 1241011 3 darin 2016-10-17 10:46:24 -0700 I guess maybe because it’s multiple diffs and we want to look at them all in a row? 1241012 4 291605 darin 2016-10-17 10:47:54 -0700 Comment on attachment 291605 Patch OK, I thought it through and I guess this is fine. 1241027 5 291605 commit-queue 2016-10-17 11:01:57 -0700 Comment on attachment 291605 Patch Clearing flags on attachment: 291605 Committed r207416: <http://trac.webkit.org/changeset/207416> 1241028 6 commit-queue 2016-10-17 11:02:02 -0700 All reviewed patches have been landed. Closing bug. 1241310 7 fujii 2016-10-17 19:38:27 -0700 Thank you for reviewing my patch. After this change, it outputs like following: > $ ./Tools/Scripts/resolve-ChangeLogs > M ChangeLog > M Source/WebCore/ChangeLog > M Tools/ChangeLog But, without this change, Pager was invoked three times because of three ChangeLog files resolved. 291605 2016-10-14 02:57:13 -0700 2016-10-17 11:01:57 -0700 Patch bug-163441-20161014185355.patch text/plain 1421 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3MzI5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzkyMzY0NzNhZjIzMTNlYWJiMWZjZTAzMDA0ZjZiYjhi ZWRkNDgzOC4uOTE5NDUyZDBkMzhlNmFmNjBjMDdiODY1NDljMmQ5MjUxZjBiNTFhNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE2LTEwLTE0ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIHJlc29sdmUtQ2hhbmdlTG9nczogU3BlY2lmeSAtLW5vLXBhZ2UgdG8gZ2l0 IGRpZmYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2 MzQ0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHJl c29sdmUtQ2hhbmdlTG9ncyBzaG93cyB0aGUgcmVzdWx0IGFmdGVyIHJlc29sdmluZyBieSBpbnZv a2luZworICAgICAgICAnZ2l0IGRpZmYnLiBJdCBydW5zIGEgcGFnZXIgZm9yIGV2ZXJ5IENoYW5n ZUxvZyBpZiBpdCBpcyB1bmRlcgorICAgICAgICBUVFkuCisKKyAgICAgICAgKiBTY3JpcHRzL3Jl c29sdmUtQ2hhbmdlTG9nczoKKyAgICAgICAgKHNob3dTdGF0dXMpOiBTcGVjaWZ5ICctLW5vLXBh Z2UnIHRvIGdpdCBkaWZmLgorCiAyMDE2LTEwLTEzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBSZW1vdmVkIG15c2VsZiBm cm9tIEJpbmRpbmdzU2NyaXB0cyB3YXRjaCBsaXN0LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy9yZXNvbHZlLUNoYW5nZUxvZ3MgYi9Ub29scy9TY3JpcHRzL3Jlc29sdmUtQ2hhbmdlTG9ncwpp bmRleCBmNzFlMGMxMjg1NjM4MmNmMDAyYTY3MTk4YjhkNTJlM2IyNTQ1YjBiLi5hYWQ3MzFhZWEx ZDBhOGI4MWU1ZTM1NGYwN2JhYTBlNGE0MDhiYzc0IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRz L3Jlc29sdmUtQ2hhbmdlTG9ncworKysgYi9Ub29scy9TY3JpcHRzL3Jlc29sdmUtQ2hhbmdlTG9n cwpAQCAtNDg3LDcgKzQ4Nyw3IEBAIHN1YiBzaG93U3RhdHVzKCQ7JCkKICAgICB9IGVsc2lmICgk aXNHaXQpIHsKICAgICAgICAgbXkgQGFyZ3MgPSBxdygtLW5hbWUtc3RhdHVzKTsKICAgICAgICAg dW5zaGlmdCBAYXJncywgcXcoLS1jYWNoZWQpIGlmICRpc0NvbmZsaWN0UmVzb2x2ZWQ7Ci0gICAg ICAgIHN5c3RlbSgkR0lULCAiZGlmZiIsIEBhcmdzLCAkZmlsZSk7CisgICAgICAgIHN5c3RlbSgk R0lULCAiLS1uby1wYWdlciIsICJkaWZmIiwgQGFyZ3MsICRmaWxlKTsKICAgICB9IGVsc2Ugewog ICAgICAgICBkaWUgIlVua25vd24gdmVyc2lvbiBjb250cm9sIHN5c3RlbSI7CiAgICAgfQo=