163440 2016-10-14 02:27:11 -0700 Add ProvisionalURLAfterWillSendRequestCallback.cpp and ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp to Mac builds 2016-10-14 08:48:56 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified REOPENED P2 Normal --- 163445 1 youennf youennf cgarcia commit-queue lforschler mcatanzaro ryanhaddad oldest_to_newest 1240192 0 youennf 2016-10-14 02:27:11 -0700 bug 146306 introduces two new test files that are worth executing in Mac bots as well 1240193 1 291602 youennf 2016-10-14 02:29:00 -0700 Created attachment 291602 Patch for landing 1240194 2 youennf 2016-10-14 02:32:43 -0700 In the past, I was usually doing those changes by editing directly the Xcode files. For WebCore at least, this is usually ok by doing copy-and-paste existing lines, changing the IDs a bit. Each file usually needs two IDs which are close but different, needs to be a bit cautious about that. This patch could serve as a template somehow. 1240208 3 291602 commit-queue 2016-10-14 03:25:56 -0700 Comment on attachment 291602 Patch for landing Clearing flags on attachment: 291602 Committed r207335: <http://trac.webkit.org/changeset/207335> 1240209 4 commit-queue 2016-10-14 03:26:00 -0700 All reviewed patches have been landed. Closing bug. 1240276 5 ryanhaddad 2016-10-14 08:29:29 -0700 WebKit2.ProvisionalURLAfterWillSendRequestCallback is timing out: https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK1%20(Tests)/builds/650 1240280 6 commit-queue 2016-10-14 08:40:41 -0700 Re-opened since this is blocked by bug 163445 1240282 7 youennf 2016-10-14 08:41:07 -0700 (In reply to comment #5) > WebKit2.ProvisionalURLAfterWillSendRequestCallback is timing out: > https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK1%20(Tests)/ > builds/650 Thanks ryan! 1240287 8 cgarcia 2016-10-14 08:44:16 -0700 Weird, it passes in GTK+ bots: **PASS** WebKit2.ProvisionalURLAfterWillSendRequestCallback It's cross-platform code, there must be something else. 1240288 9 cgarcia 2016-10-14 08:48:56 -0700 We only wait for didCommitLoadForFrame to be called in that test. 291602 2016-10-14 02:29:00 -0700 2016-10-14 03:25:56 -0700 Patch for landing bug-163440-20161014112532.patch text/plain 6244 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3MzI5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzkyMzY0NzNhZjIzMTNlYWJiMWZjZTAzMDA0ZjZiYjhi ZWRkNDgzOC4uZTU5MjExNWM2YzdlNDdjNjkyNTM3YmQ0N2ZiYmNlMzQ2N2FhMmVmZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE2LTEwLTE0ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAg ICAgICBBZGQgUHJvdmlzaW9uYWxVUkxBZnRlcldpbGxTZW5kUmVxdWVzdENhbGxiYWNrLmNwcCBh bmQgUHJvdmlzaW9uYWxVUkxBZnRlcldpbGxTZW5kUmVxdWVzdENhbGxiYWNrX0J1bmRsZS5jcHAg dG8gTWFjIGJ1aWxkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTYzNDQwCisKKyAgICAgICAgVW5yZXZpZXdlZC4KKworICAgICAgICAqIFRlc3RXZWJL aXRBUEkvVGVzdFdlYktpdEFQSS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qOiBBZGRpbmcgbmV3 IHRlc3QgZmlsZXMgaW50cm9kdWNlZCBpbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQ2MzA2IHBhdGNoLgorCiAyMDE2LTEwLTEzICBDYXJsb3MgR2Fy Y2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBS ZW1vdmVkIG15c2VsZiBmcm9tIEJpbmRpbmdzU2NyaXB0cyB3YXRjaCBsaXN0LgpkaWZmIC0tZ2l0 IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0V2ViS2l0QVBJLnhjb2RlcHJvai9wcm9qZWN0LnBi eHByb2ogYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RXZWJLaXRBUEkueGNvZGVwcm9qL3Byb2pl Y3QucGJ4cHJvagppbmRleCBjOTIzMWM1ZTRhYWE4NjM1NDMzY2YwNmZkNzJiZDg0N2QzYTVjZGU0 Li5iNmY1MzczMmU3ZWQ4NDIxYjYzMThkNjQ4OGFkZWY4NjIyMDRmY2NjIDEwMDY0NAotLS0gYS9U b29scy9UZXN0V2ViS2l0QVBJL1Rlc3RXZWJLaXRBUEkueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJv agorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RXZWJLaXRBUEkueGNvZGVwcm9qL3Byb2pl Y3QucGJ4cHJvagpAQCAtMTAwLDYgKzEwMCw4IEBACiAJCTM3REM2NzkxMTQwRDdENzYwMEFCQ0NE QiAvKiBET01SYW5nZU9mU3RyaW5nLmh0bWwgaW4gQ29weSBSZXNvdXJjZXMgKi8gPSB7aXNhID0g UEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gMzdEQzY3OEYxNDBEN0QzQTAwQUJDQ0RCIC8qIERPTVJh bmdlT2ZTdHJpbmcuaHRtbCAqLzsgfTsKIAkJMzdFMTA2NEMxNjk3NjgxODAwQjc4QkQwIC8qIERP TUhUTUxUYWJsZUNlbGxFbGVtZW50Q2VsbEFib3ZlLmh0bWwgaW4gQ29weSBSZXNvdXJjZXMgKi8g PSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gMzdFMTA2NEIxNjk3NjdGNzAwQjc4QkQw IC8qIERPTUhUTUxUYWJsZUNlbGxFbGVtZW50Q2VsbEFib3ZlLmh0bWwgKi87IH07CiAJCTNGQkQx QjRBMUQzRDY2QUIwMEU2RDZGQSAvKiBGdWxsc2NyZWVuTGF5b3V0Q29uc3RyYWludHMuaHRtbCBp biBDb3B5IFJlc291cmNlcyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSAzRkJE MUI0OTFEMzlEMURCMDBFNkQ2RkEgLyogRnVsbHNjcmVlbkxheW91dENvbnN0cmFpbnRzLmh0bWwg Ki87IH07CisJCTQxMDMwQUU5MURCMEQ5ODkwMDZGQkMzOCAvKiBQcm92aXNpb25hbFVSTEFmdGVy V2lsbFNlbmRSZXF1ZXN0Q2FsbGJhY2suY3BwIGluIFNvdXJjZXMgKi8gPSB7aXNhID0gUEJYQnVp bGRGaWxlOyBmaWxlUmVmID0gNDEwMzBBRTcxREIwRDM0MTAwNkZCQzM4IC8qIFByb3Zpc2lvbmFs VVJMQWZ0ZXJXaWxsU2VuZFJlcXVlc3RDYWxsYmFjay5jcHAgKi87IH07CisJCTQxMDMwQUVCMURC MEQ5RkYwMDZGQkMzOCAvKiBQcm92aXNpb25hbFVSTEFmdGVyV2lsbFNlbmRSZXF1ZXN0Q2FsbGJh Y2tfQnVuZGxlLmNwcCBpbiBTb3VyY2VzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJl ZiA9IDQxMDMwQUU4MURCMEQzRjQwMDZGQkMzOCAvKiBQcm92aXNpb25hbFVSTEFmdGVyV2lsbFNl bmRSZXF1ZXN0Q2FsbGJhY2tfQnVuZGxlLmNwcCAqLzsgfTsKIAkJNDZDNTE5REExRDM1NUFCMjAw REFBNTFBIC8qIExvY2FsU3RvcmFnZU51bGxFbnRyaWVzLm1tIGluIFNvdXJjZXMgKi8gPSB7aXNh ID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gNDZDNTE5RDgxRDM1NUE3MzAwREFBNTFBIC8qIExv Y2FsU3RvcmFnZU51bGxFbnRyaWVzLm1tICovOyB9OwogCQk0NkM1MTlFNjFEMzU2M0ZEMDBEQUE1 MUEgLyogTG9jYWxTdG9yYWdlTnVsbEVudHJpZXMuaHRtbCBpbiBDb3B5IFJlc291cmNlcyAqLyA9 IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSA0NkM1MTlFMjFEMzU2Mjk2MDBEQUE1MUEg LyogTG9jYWxTdG9yYWdlTnVsbEVudHJpZXMuaHRtbCAqLzsgfTsKIAkJNDZDNTE5RTcxRDM1NjNG RDAwREFBNTFBIC8qIExvY2FsU3RvcmFnZU51bGxFbnRyaWVzLmxvY2Fsc3RvcmFnZSBpbiBDb3B5 IFJlc291cmNlcyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSA0NkM1MTlFMzFE MzU2Mjk2MDBEQUE1MUEgLyogTG9jYWxTdG9yYWdlTnVsbEVudHJpZXMubG9jYWxzdG9yYWdlICov OyB9OwpAQCAtODUxLDYgKzg1Myw4IEBACiAJCTM3RTM4QzMzMTY5QjdEMDEwMDg0QzI4QyAvKiBX ZWJWaWV3RGlkUmVtb3ZlRnJhbWVGcm9tSGllcmFyY2h5Lm1tICovID0ge2lzYSA9IFBCWEZpbGVS ZWZlcmVuY2U7IGZpbGVFbmNvZGluZyA9IDQ7IGxhc3RLbm93bkZpbGVUeXBlID0gc291cmNlY29k ZS5jcHAub2JqY3BwOyBwYXRoID0gV2ViVmlld0RpZFJlbW92ZUZyYW1lRnJvbUhpZXJhcmNoeS5t bTsgc291cmNlVHJlZSA9ICI8Z3JvdXA+IjsgfTsKIAkJM0YxQjUyNjgxRDNENzEyOTAwOEQ2MEM0 IC8qIEZ1bGxzY3JlZW5MYXlvdXRDb25zdHJhaW50cy5tbSAqLyA9IHtpc2EgPSBQQlhGaWxlUmVm ZXJlbmNlOyBmaWxlRW5jb2RpbmcgPSA0OyBsYXN0S25vd25GaWxlVHlwZSA9IHNvdXJjZWNvZGUu Y3BwLm9iamNwcDsgcGF0aCA9IEZ1bGxzY3JlZW5MYXlvdXRDb25zdHJhaW50cy5tbTsgc291cmNl VHJlZSA9ICI8Z3JvdXA+IjsgfTsKIAkJM0ZCRDFCNDkxRDM5RDFEQjAwRTZENkZBIC8qIEZ1bGxz Y3JlZW5MYXlvdXRDb25zdHJhaW50cy5odG1sICovID0ge2lzYSA9IFBCWEZpbGVSZWZlcmVuY2U7 IGZpbGVFbmNvZGluZyA9IDQ7IGxhc3RLbm93bkZpbGVUeXBlID0gdGV4dC5odG1sOyBwYXRoID0g RnVsbHNjcmVlbkxheW91dENvbnN0cmFpbnRzLmh0bWw7IHNvdXJjZVRyZWUgPSAiPGdyb3VwPiI7 IH07CisJCTQxMDMwQUU3MURCMEQzNDEwMDZGQkMzOCAvKiBQcm92aXNpb25hbFVSTEFmdGVyV2ls bFNlbmRSZXF1ZXN0Q2FsbGJhY2suY3BwICovID0ge2lzYSA9IFBCWEZpbGVSZWZlcmVuY2U7IGZp bGVFbmNvZGluZyA9IDQ7IGxhc3RLbm93bkZpbGVUeXBlID0gc291cmNlY29kZS5jcHAuY3BwOyBw YXRoID0gUHJvdmlzaW9uYWxVUkxBZnRlcldpbGxTZW5kUmVxdWVzdENhbGxiYWNrLmNwcDsgc291 cmNlVHJlZSA9ICI8Z3JvdXA+IjsgfTsKKwkJNDEwMzBBRTgxREIwRDNGNDAwNkZCQzM4IC8qIFBy b3Zpc2lvbmFsVVJMQWZ0ZXJXaWxsU2VuZFJlcXVlc3RDYWxsYmFja19CdW5kbGUuY3BwICovID0g e2lzYSA9IFBCWEZpbGVSZWZlcmVuY2U7IGZpbGVFbmNvZGluZyA9IDQ7IGxhc3RLbm93bkZpbGVU eXBlID0gc291cmNlY29kZS5jcHAuY3BwOyBwYXRoID0gUHJvdmlzaW9uYWxVUkxBZnRlcldpbGxT ZW5kUmVxdWVzdENhbGxiYWNrX0J1bmRsZS5jcHA7IHNvdXJjZVRyZWUgPSAiPGdyb3VwPiI7IH07 CiAJCTQxOTczQjVBMUFGMjI4NkEwMDZDN0IzNiAvKiBGaWxlU3lzdGVtLmNwcCAqLyA9IHtpc2Eg PSBQQlhGaWxlUmVmZXJlbmNlOyBmaWxlRW5jb2RpbmcgPSA0OyBsYXN0S25vd25GaWxlVHlwZSA9 IHNvdXJjZWNvZGUuY3BwLmNwcDsgcGF0aCA9IEZpbGVTeXN0ZW0uY3BwOyBzb3VyY2VUcmVlID0g Ijxncm91cD4iOyB9OwogCQk0MTk3M0I1QzFBRjIyODc1MDA2QzdCMzYgLyogU2hhcmVkQnVmZmVy LmNwcCAqLyA9IHtpc2EgPSBQQlhGaWxlUmVmZXJlbmNlOyBmaWxlRW5jb2RpbmcgPSA0OyBsYXN0 S25vd25GaWxlVHlwZSA9IHNvdXJjZWNvZGUuY3BwLmNwcDsgcGF0aCA9IFNoYXJlZEJ1ZmZlci5j cHA7IHNvdXJjZVRyZWUgPSAiPGdyb3VwPiI7IH07CiAJCTQ0MEExRDM4MTRBMDEwM0EwMDhBNjZG MiAvKiBVUkwuY3BwICovID0ge2lzYSA9IFBCWEZpbGVSZWZlcmVuY2U7IGZpbGVFbmNvZGluZyA9 IDQ7IGxhc3RLbm93bkZpbGVUeXBlID0gc291cmNlY29kZS5jcHAuY3BwOyBwYXRoID0gVVJMLmNw cDsgc291cmNlVHJlZSA9ICI8Z3JvdXA+IjsgfTsKQEAgLTE3MDgsNiArMTcxMiw4IEBACiAJCQkJ MDc2NkREMUYxQTVBRDUyMDAwMjNFM0JCIC8qIFBlbmRpbmdBUElSZXF1ZXN0VVJMLmNwcCAqLywK IAkJCQkzMzNCOUNFMTEyNzdGMjMxMDBGRUZDRTMgLyogUHJldmVudEVtcHR5VXNlckFnZW50LmNw cCAqLywKIAkJCQlGNkZEREREMjE0MjQxQUQ0MDA0RjE3MjkgLyogUHJpdmF0ZUJyb3dzaW5nUHVz aFN0YXRlTm9IaXN0b3J5Q2FsbGJhY2suY3BwICovLAorCQkJCTQxMDMwQUU3MURCMEQzNDEwMDZG QkMzOCAvKiBQcm92aXNpb25hbFVSTEFmdGVyV2lsbFNlbmRSZXF1ZXN0Q2FsbGJhY2suY3BwICov LAorCQkJCTQxMDMwQUU4MURCMEQzRjQwMDZGQkMzOCAvKiBQcm92aXNpb25hbFVSTEFmdGVyV2ls bFNlbmRSZXF1ZXN0Q2FsbGJhY2tfQnVuZGxlLmNwcCAqLywKIAkJCQk4QTNBRjkzQTE2QzlFRDI3 MDBEMjQ4QzEgLyogUmVsb2FkUGFnZUFmdGVyQ3Jhc2guY3BwICovLAogCQkJCTJERDdEM0E5MTc4 MjA1RDAwMDI2RTFFMyAvKiBSZXNpemVSZXZlcnNlUGFnaW5hdGVkV2ViVmlldy5jcHAgKi8sCiAJ CQkJOEEyQzc1MEQxNkNFRDk1NTAwMjRGMzUyIC8qIFJlc2l6ZVdpbmRvd0FmdGVyQ3Jhc2guY3Bw ICovLApAQCAtMjU0Myw2ICsyNTQ5LDcgQEAKIAkJCQk3QzgzRTBCNTFEMEE2NDkzMDBGRUJDRjMg LyogV0tSZXRhaW5QdHIuY3BwIGluIFNvdXJjZXMgKi8sCiAJCQkJOUM2NERDMzIxRDc2MTk4QTAw NEI1OThFIC8qIFlvdVR1YmVQbHVnaW5SZXBsYWNlbWVudC5jcHAgaW4gU291cmNlcyAqLywKIAkJ CQk1RTRCMUQyRTFENDA0QzYxMDAwNTM2MjEgLyogV0tTY3JvbGxWaWV3RGVsZWdhdGVDcmFzaC5t bSBpbiBTb3VyY2VzICovLAorCQkJCTQxMDMwQUU5MURCMEQ5ODkwMDZGQkMzOCAvKiBQcm92aXNp b25hbFVSTEFmdGVyV2lsbFNlbmRSZXF1ZXN0Q2FsbGJhY2suY3BwIGluIFNvdXJjZXMgKi8sCiAJ CQkJN0NDRTdGMjIxQTQxMUFFNjAwNDQ3QzRDIC8qIFdLU3RyaW5nLmNwcCBpbiBTb3VyY2VzICov LAogCQkJCTdDQ0U3RjFFMUE0MTFBRTYwMDQ0N0M0QyAvKiBXS1N0cmluZ0pTU3RyaW5nLmNwcCBp biBTb3VyY2VzICovLAogCQkJCUExNEZDNTg1MUI4OTczOTEwMEQxMDdFQiAvKiBXS1dlYlZpZXdD b25maWd1cmF0aW9uRXh0cmFzLm1tIGluIFNvdXJjZXMgKi8sCkBAIC0yNjAwLDYgKzI2MDcsNyBA QAogCQkJCTlCMDc4NkE1MUM1ODg1QzMwMEQxNTlFMyAvKiBJbmplY3RlZEJ1bmRsZU1ha2VBbGxT aGFkb3dSb290T3Blbl9CdW5kbGUuY3BwIGluIFNvdXJjZXMgKi8sCiAJCQkJMzNEQzg5MTQxNDE5 NTc5RjAwNzQ3RUY3IC8qIExvYWRDYW5jZWxlZE5vU2VydmVyUmVkaXJlY3RDYWxsYmFja19CdW5k bGUuY3BwIGluIFNvdXJjZXMgKi8sCiAJCQkJMzNCRTVBRjkxMzdCNUFBRTAwNzA1ODEzIC8qIE1v dXNlTW92ZUFmdGVyQ3Jhc2hfQnVuZGxlLmNwcCBpbiBTb3VyY2VzICovLAorCQkJCTQxMDMwQUVC MURCMEQ5RkYwMDZGQkMzOCAvKiBQcm92aXNpb25hbFVSTEFmdGVyV2lsbFNlbmRSZXF1ZXN0Q2Fs bGJhY2tfQnVuZGxlLmNwcCBpbiBTb3VyY2VzICovLAogCQkJCTkzRjFEQjM0MTREQTIwODcwMDI0 QzM2MiAvKiBOZXdGaXJzdFZpc3VhbGx5Tm9uRW1wdHlMYXlvdXRfQnVuZGxlLmNwcCBpbiBTb3Vy Y2VzICovLAogCQkJCTkzRjFEQjU3MTREQjFCODQwMDI0QzM2MiAvKiBOZXdGaXJzdFZpc3VhbGx5 Tm9uRW1wdHlMYXlvdXRGYWlsc19CdW5kbGUuY3BwIGluIFNvdXJjZXMgKi8sCiAJCQkJOTNBRjRF Q0UxNTA2RjA2NDAwN0ZENTdFIC8qIE5ld0ZpcnN0VmlzdWFsbHlOb25FbXB0eUxheW91dEZvcklt YWdlc19CdW5kbGUuY3BwIGluIFNvdXJjZXMgKi8sCg==