163437 2016-10-14 01:55:10 -0700 test262: @isConstructor incorrectly thinks Math.cos is a constructor 2016-10-14 11:16:45 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1240167 0 joepeck 2016-10-14 01:55:10 -0700 test262: @isConstructor incorrectly thinks Math.cos is a constructor test262/test/built-ins/Array/of/return-a-new-array-object.js @isConstructor just checks that the ConstructData is not None. However, host functions return ConstructType::Host even if their default behavior is to throw an exception that it should not be used as a constructor. We could return ConstructType::None for these default cases. 1240177 1 291596 joepeck 2016-10-14 02:04:10 -0700 Created attachment 291596 [PATCH] Proposed Fix 1240186 2 291599 joepeck 2016-10-14 02:14:42 -0700 Created attachment 291599 [PATCH] Proposed Fix Some additional test cases. 1240265 3 291599 saam 2016-10-14 07:48:26 -0700 Comment on attachment 291599 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=291599&action=review r=me > JSTests/stress/is-constructor.js:6 > +let isConstructor = createBuiltin("(function(c) { return @isConstructor(c); })"); This is a nice test. 1240266 4 291599 saam 2016-10-14 07:51:07 -0700 Comment on attachment 291599 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=291599&action=review r=me >> JSTests/stress/is-constructor.js:6 >> +let isConstructor = createBuiltin("(function(c) { return @isConstructor(c); })"); > > This is a nice test. This is a nice test. > Source/JavaScriptCore/runtime/JSFunction.cpp:576 > + if (thisObject->nativeConstructor() == callHostFunctionAsConstructor) Do we get a new kind of error message when we try to "new" non constructor host functions? 1240342 5 291599 joepeck 2016-10-14 10:53:47 -0700 Comment on attachment 291599 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=291599&action=review >> Source/JavaScriptCore/runtime/JSFunction.cpp:576 >> + if (thisObject->nativeConstructor() == callHostFunctionAsConstructor) > > Do we get a new kind of error message when we try to "new" non constructor host functions? Nope, `new Math.cos` produces the exact same error message! 1240354 6 291599 commit-queue 2016-10-14 11:16:42 -0700 Comment on attachment 291599 [PATCH] Proposed Fix Clearing flags on attachment: 291599 Committed r207347: <http://trac.webkit.org/changeset/207347> 1240355 7 commit-queue 2016-10-14 11:16:45 -0700 All reviewed patches have been landed. Closing bug. 291596 2016-10-14 02:04:10 -0700 2016-10-14 02:14:42 -0700 [PATCH] Proposed Fix isconstructor-1.patch text/plain 7082 joepeck ZGlmZiAtLWdpdCBhL0pTVGVzdHMvQ2hhbmdlTG9nIGIvSlNUZXN0cy9DaGFuZ2VMb2cKaW5kZXgg YmY3N2ZkMS4uNmFlYjQzNCAxMDA2NDQKLS0tIGEvSlNUZXN0cy9DaGFuZ2VMb2cKKysrIGIvSlNU ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMCBAQAogMjAxNi0xMC0xNCAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCisgICAgICAgIHRlc3QyNjI6IEBpc0NvbnN0cnVj dG9yIGluY29ycmVjdGx5IHRoaW5rcyBNYXRoLmNvcyBpcyBhIGNvbnN0cnVjdG9yCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjM0MzcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy9pcy1jb25z dHJ1Y3Rvci5qczogQWRkZWQuCisgICAgICAgIChhc3NlcnQpOgorICAgICAgICAocHJvdG90eXBl LmFzc2VydCk6CisgICAgICAgIE5ldyB0ZXN0IHRvIGNvdmVyIHRoZSBAaXNDb25zdHJ1Y3RvciBi dWlsdGluLgorCisgICAgICAgICogdGVzdDI2Mi55YW1sOgorICAgICAgICBUZXN0IG5vdyBwYXNz ZXMuCisKKzIwMTYtMTAtMTQgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4K KwogICAgICAgICB0ZXN0MjYyOiBGYWlsdXJlIHdpdGggUmVnRXhwLnByb3RvdHlwZS5jb21waWxl IHdoZW4gcGF0dGVybiBpcyB1bmRlZmluZWQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE2MzQzMQogCmRpZmYgLS1naXQgYS9KU1Rlc3RzL3N0cmVzcy9p cy1jb25zdHJ1Y3Rvci5qcyBiL0pTVGVzdHMvc3RyZXNzL2lzLWNvbnN0cnVjdG9yLmpzCm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjM4ZjBjYmEKLS0tIC9kZXYvbnVsbAorKysg Yi9KU1Rlc3RzL3N0cmVzcy9pcy1jb25zdHJ1Y3Rvci5qcwpAQCAtMCwwICsxLDk2IEBACitmdW5j dGlvbiBhc3NlcnQoeCkgeworICAgIGlmICgheCkKKyAgICAgICAgdGhyb3cgRXJyb3IoIkJhZCIp OworfQorCitsZXQgaXNDb25zdHJ1Y3RvciA9IGNyZWF0ZUJ1aWx0aW4oIihmdW5jdGlvbihjKSB7 IHJldHVybiBAaXNDb25zdHJ1Y3RvcihjKTsgfSkiKTsKKworLy8gRnVuY3Rpb25zLgorYXNzZXJ0 KGlzQ29uc3RydWN0b3IoYXNzZXJ0KSk7Cithc3NlcnQoaXNDb25zdHJ1Y3RvcihjbGFzc3t9KSk7 Cithc3NlcnQoaXNDb25zdHJ1Y3RvcihmdW5jdGlvbigpe30pKTsKKworLy8gUHJveHkgZnVuY3Rp b25zLgorYXNzZXJ0KGlzQ29uc3RydWN0b3IobmV3IFByb3h5KGFzc2VydCwge30pKSk7Cithc3Nl cnQoaXNDb25zdHJ1Y3RvcihuZXcgUHJveHkoY2xhc3N7fSwge30pKSk7Cithc3NlcnQoaXNDb25z dHJ1Y3RvcihuZXcgUHJveHkoZnVuY3Rpb24oKXt9LCB7fSkpKTsKKworLy8gQm91bmQgZnVuY3Rp b25zLgorYXNzZXJ0KGlzQ29uc3RydWN0b3IoYXNzZXJ0LmJpbmQobnVsbCksIHt9KSk7Cithc3Nl cnQoaXNDb25zdHJ1Y3RvcihmdW5jdGlvbigpe30uYmluZChudWxsKSwge30pKTsKKworLy8gQnVp bHRpbiBjb25zdHJ1Y3RvcnMuCithc3NlcnQoaXNDb25zdHJ1Y3RvcihBcnJheSkpOworYXNzZXJ0 KGlzQ29uc3RydWN0b3IoQXJyYXlCdWZmZXIpKTsKK2Fzc2VydChpc0NvbnN0cnVjdG9yKEJvb2xl YW4pKTsKK2Fzc2VydChpc0NvbnN0cnVjdG9yKERhdGUpKTsKK2Fzc2VydChpc0NvbnN0cnVjdG9y KEVycm9yKSk7Cithc3NlcnQoaXNDb25zdHJ1Y3RvcihNYXApKTsKK2Fzc2VydChpc0NvbnN0cnVj dG9yKE51bWJlcikpOworYXNzZXJ0KGlzQ29uc3RydWN0b3IoT2JqZWN0KSk7Cithc3NlcnQoaXND b25zdHJ1Y3RvcihQcm9taXNlKSk7Cithc3NlcnQoaXNDb25zdHJ1Y3RvcihQcm94eSkpOworYXNz ZXJ0KGlzQ29uc3RydWN0b3IoUmVnRXhwKSk7Cithc3NlcnQoaXNDb25zdHJ1Y3RvcihTZXQpKTsK K2Fzc2VydChpc0NvbnN0cnVjdG9yKFN0cmluZykpOworYXNzZXJ0KGlzQ29uc3RydWN0b3IoV2Vh a01hcCkpOworYXNzZXJ0KGlzQ29uc3RydWN0b3IoV2Vha1NldCkpOworCisvLyBOb24tZnVuY3Rp b24gdmFsdWVzLgorYXNzZXJ0KCFpc0NvbnN0cnVjdG9yKHVuZGVmaW5lZCkpOworYXNzZXJ0KCFp c0NvbnN0cnVjdG9yKG51bGwpKTsKK2Fzc2VydCghaXNDb25zdHJ1Y3Rvcih0cnVlKSk7Cithc3Nl cnQoIWlzQ29uc3RydWN0b3IoZmFsc2UpKTsKK2Fzc2VydCghaXNDb25zdHJ1Y3RvcigwKSk7Cith c3NlcnQoIWlzQ29uc3RydWN0b3IoMSkpOworYXNzZXJ0KCFpc0NvbnN0cnVjdG9yKDEuMSkpOwor YXNzZXJ0KCFpc0NvbnN0cnVjdG9yKC0xKSk7Cithc3NlcnQoIWlzQ29uc3RydWN0b3IoRGF0ZS5u b3coKSkpOworYXNzZXJ0KCFpc0NvbnN0cnVjdG9yKG5ldyBEYXRlKSk7Cithc3NlcnQoIWlzQ29u c3RydWN0b3IoSW5maW5pdHkpKTsKK2Fzc2VydCghaXNDb25zdHJ1Y3RvcihOYU4pKTsKK2Fzc2Vy dCghaXNDb25zdHJ1Y3RvcigiIikpOworYXNzZXJ0KCFpc0NvbnN0cnVjdG9yKCJ0ZXN0IikpOwor YXNzZXJ0KCFpc0NvbnN0cnVjdG9yKFtdKSk7Cithc3NlcnQoIWlzQ29uc3RydWN0b3Ioe30pKTsK K2Fzc2VydCghaXNDb25zdHJ1Y3RvcigvcmVnZXgvKSk7Cithc3NlcnQoIWlzQ29uc3RydWN0b3Io TWF0aCkpOworYXNzZXJ0KCFpc0NvbnN0cnVjdG9yKEpTT04pKTsKK2Fzc2VydCghaXNDb25zdHJ1 Y3RvcihTeW1ib2woKSkpOworYXNzZXJ0KCFpc0NvbnN0cnVjdG9yKG5ldyBFcnJvcikpOworYXNz ZXJ0KCFpc0NvbnN0cnVjdG9yKG5ldyBQcm94eSh7fSwge30pKSk7Cithc3NlcnQoIWlzQ29uc3Ry dWN0b3IoQXJyYXkucHJvdG90eXBlKSk7CisKKy8vIFN5bWJvbCBpcyBub3QgYSBjb25zdHJ1Y3Rv ci4KK2Fzc2VydCghaXNDb25zdHJ1Y3RvcihTeW1ib2wpKTsKKworLy8gR2V0dGVycyAvIHNldHRl cnMgYXJlIG5vdCBjb25zdHJ1Y3RvcnMuCithc3NlcnQoIWlzQ29uc3RydWN0b3IoT2JqZWN0Lmdl dE93blByb3BlcnR5RGVzY3JpcHRvcih7Z2V0IGYoKXt9fSwgImYiKS5nZXQpKTsKK2Fzc2VydCgh aXNDb25zdHJ1Y3RvcihPYmplY3QuZ2V0T3duUHJvcGVydHlEZXNjcmlwdG9yKHtzZXQgZih4KXt9 fSwgImYiKS5zZXQpKTsKKworLy8gQXJyb3cgZnVuY3Rpb25zIGFyZSBub3QgY29uc3RydWN0b3Jz LgorYXNzZXJ0KCFpc0NvbnN0cnVjdG9yKCgpPT57fSkpOworCisvLyBHZW5lcmF0b3JzIGFyZSBu b3QgY29uc3RydWN0b3JzLgorYXNzZXJ0KCFpc0NvbnN0cnVjdG9yKGZ1bmN0aW9uKigpe30pKTsK KworLy8gTmF0aXZlIGJ1aWx0aW5zIGFyZSBub3QgY29uc3RydWN0b3JzLgorYXNzZXJ0KCFpc0Nv bnN0cnVjdG9yKGlzQ29uc3RydWN0b3IpKTsKKworLy8gaHR0cHM6Ly90YzM5LmdpdGh1Yi5pby9l Y21hMjYyLyNzZWMtYnVpbHQtaW4tZnVuY3Rpb24tb2JqZWN0cworLy8gQnVpbHQtaW4gZnVuY3Rp b24gb2JqZWN0cyB0aGF0IGFyZSBub3QgaWRlbnRpZmllZCBhcyBjb25zdHJ1Y3RvcnMgZG8gbm90 CisvLyBpbXBsZW1lbnQgdGhlIFtbQ29uc3RydWN0XV0gaW50ZXJuYWwgbWV0aG9kIHVubGVzcyBv dGhlcndpc2Ugc3BlY2lmaWVkIGluCisvLyB0aGUgZGVzY3JpcHRpb24gb2YgYSBwYXJ0aWN1bGFy IGZ1bmN0aW9uLgorYXNzZXJ0KCFpc0NvbnN0cnVjdG9yKEFycmF5Lm9mKSk7Cithc3NlcnQoIWlz Q29uc3RydWN0b3IoT2JqZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvcikpOworYXNzZXJ0KCFp c0NvbnN0cnVjdG9yKERhdGUubm93KSk7Cithc3NlcnQoIWlzQ29uc3RydWN0b3IoTWF0aC5jb3Mp KTsKK2Fzc2VydCghaXNDb25zdHJ1Y3RvcihKU09OLnN0cmluZ2lmeSkpOworYXNzZXJ0KCFpc0Nv bnN0cnVjdG9yKFByb21pc2UuYWxsKSk7Cithc3NlcnQoIWlzQ29uc3RydWN0b3IoU3ltYm9sLmZv cikpOworYXNzZXJ0KCFpc0NvbnN0cnVjdG9yKEFycmF5LnByb3RvdHlwZS5wdXNoKSk7CisKKy8v IFByb3h5IGFuZCBib3VuZCBmdW5jdGlvbnMgY2FycnkgZm9yd2FyZCBub24tY29uc3RydWN0b3It bmVzcy4KK2Fzc2VydCghaXNDb25zdHJ1Y3RvcihuZXcgUHJveHkoU3ltYm9sLCB7fSkpKTsKK2Fz c2VydCghaXNDb25zdHJ1Y3RvcihuZXcgUHJveHkoTWF0aC5jb3MsIHt9KSkpOworYXNzZXJ0KCFp c0NvbnN0cnVjdG9yKE1hdGguY29zLmJpbmQobnVsbCkpKTsKZGlmZiAtLWdpdCBhL0pTVGVzdHMv dGVzdDI2Mi55YW1sIGIvSlNUZXN0cy90ZXN0MjYyLnlhbWwKaW5kZXggZWFkNjBlNS4uM2I1MWI2 MCAxMDA2NDQKLS0tIGEvSlNUZXN0cy90ZXN0MjYyLnlhbWwKKysrIGIvSlNUZXN0cy90ZXN0MjYy LnlhbWwKQEAgLTMwNTQsOSArMzA1NCw5IEBACiAtIHBhdGg6IHRlc3QyNjIvdGVzdC9idWlsdC1p bnMvQXJyYXkvb2YvcmV0dXJuLWEtY3VzdG9tLWluc3RhbmNlLmpzCiAgIGNtZDogcnVuVGVzdDI2 MiA6bm9ybWFsLCAiTm9FeGNlcHRpb24iLCBbIi4uLy4uLy4uLy4uL2hhcm5lc3MvYXNzZXJ0Lmpz IiwgIi4uLy4uLy4uLy4uL2hhcm5lc3Mvc3RhLmpzIl0sIFs6c3RyaWN0XQogLSBwYXRoOiB0ZXN0 MjYyL3Rlc3QvYnVpbHQtaW5zL0FycmF5L29mL3JldHVybi1hLW5ldy1hcnJheS1vYmplY3QuanMK LSAgY21kOiBydW5UZXN0MjYyIDpmYWlsLCAiTm9FeGNlcHRpb24iLCBbIi4uLy4uLy4uLy4uL2hh cm5lc3MvYXNzZXJ0LmpzIiwgIi4uLy4uLy4uLy4uL2hhcm5lc3Mvc3RhLmpzIl0sIFtdCisgIGNt ZDogcnVuVGVzdDI2MiA6bm9ybWFsLCAiTm9FeGNlcHRpb24iLCBbIi4uLy4uLy4uLy4uL2hhcm5l c3MvYXNzZXJ0LmpzIiwgIi4uLy4uLy4uLy4uL2hhcm5lc3Mvc3RhLmpzIl0sIFtdCiAtIHBhdGg6 IHRlc3QyNjIvdGVzdC9idWlsdC1pbnMvQXJyYXkvb2YvcmV0dXJuLWEtbmV3LWFycmF5LW9iamVj dC5qcwotICBjbWQ6IHJ1blRlc3QyNjIgOmZhaWwsICJOb0V4Y2VwdGlvbiIsIFsiLi4vLi4vLi4v Li4vaGFybmVzcy9hc3NlcnQuanMiLCAiLi4vLi4vLi4vLi4vaGFybmVzcy9zdGEuanMiXSwgWzpz dHJpY3RdCisgIGNtZDogcnVuVGVzdDI2MiA6bm9ybWFsLCAiTm9FeGNlcHRpb24iLCBbIi4uLy4u Ly4uLy4uL2hhcm5lc3MvYXNzZXJ0LmpzIiwgIi4uLy4uLy4uLy4uL2hhcm5lc3Mvc3RhLmpzIl0s IFs6c3RyaWN0XQogLSBwYXRoOiB0ZXN0MjYyL3Rlc3QvYnVpbHQtaW5zL0FycmF5L29mL3JldHVy bi1hYnJ1cHQtZnJvbS1jb250cnVjdG9yLmpzCiAgIGNtZDogcnVuVGVzdDI2MiA6bm9ybWFsLCAi Tm9FeGNlcHRpb24iLCBbIi4uLy4uLy4uLy4uL2hhcm5lc3MvYXNzZXJ0LmpzIiwgIi4uLy4uLy4u Ly4uL2hhcm5lc3Mvc3RhLmpzIl0sIFtdCiAtIHBhdGg6IHRlc3QyNjIvdGVzdC9idWlsdC1pbnMv QXJyYXkvb2YvcmV0dXJuLWFicnVwdC1mcm9tLWNvbnRydWN0b3IuanMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hh bmdlTG9nCmluZGV4IGJhYjUyZGIuLmQ3MzVjMmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpA QCAtMSw1ICsxLDIwIEBACiAyMDE2LTEwLTE0ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0Bh cHBsZS5jb20+CiAKKyAgICAgICAgdGVzdDI2MjogQGlzQ29uc3RydWN0b3IgaW5jb3JyZWN0bHkg dGhpbmtzIE1hdGguY29zIGlzIGEgY29uc3RydWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MzQzNworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogcnVudGltZS9KU0Z1bmN0aW9uLmNwcDoKKyAgICAg ICAgKEpTQzo6SlNGdW5jdGlvbjo6Z2V0Q29uc3RydWN0RGF0YSk6CisgICAgICAgIEJ5IGRlZmF1 bHQsIEhvc3QgSlNGdW5jdGlvbnMgYXJlIG5vdCBjb25zdHJ1Y3RhYmxlLiBUaGV5IGdldAorICAg ICAgICB0aGUgZGVmYXVsdCBjYWxsSG9zdEZ1bmN0aW9uQXNDb25zdHJ1Y3RvciBuYXRpdmUgY29u c3RydWN0b3IuCisgICAgICAgIFdoZW4gZ2V0dGluZyBjb25zdHJ1Y3QgZGF0YSB3ZSBjYW4gcmV0 dXJuIENvbnN0cnVjdFR5cGU6Ok5vbmUKKyAgICAgICAgaW4gdGhlc2UgY2FzZXMgaW5zdGVhZCBv ZiBpbmRpY2F0aW5nIGl0IG1pZ2h0IGJlIGNvbnN0cnVjdGFibGUKKyAgICAgICAgYW5kIGxhdGVy IHRocm93aW5nIGFuIGV4Y2VwdGlvbiB3aGVuIGNvbnN0cnVjdGlvbiBpcyBhdHRlbXB0ZWQuCisK KzIwMTYtMTAtMTQgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAg ICAgICB0ZXN0MjYyOiBGYWlsdXJlIHdpdGggUmVnRXhwLnByb3RvdHlwZS5jb21waWxlIHdoZW4g cGF0dGVybiBpcyB1bmRlZmluZWQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE2MzQzMQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9KU0Z1bmN0aW9uLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pT RnVuY3Rpb24uY3BwCmluZGV4IDRkMjEwNmEuLjBjMDBmNjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTRnVuY3Rpb24uY3BwCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL0pTRnVuY3Rpb24uY3BwCkBAIC01NzMsNiArNTczLDggQEAgQ29uc3Ry dWN0VHlwZSBKU0Z1bmN0aW9uOjpnZXRDb25zdHJ1Y3REYXRhKEpTQ2VsbCogY2VsbCwgQ29uc3Ry dWN0RGF0YSYgY29uc3RydWMKICAgICBKU0Z1bmN0aW9uKiB0aGlzT2JqZWN0ID0ganNDYXN0PEpT RnVuY3Rpb24qPihjZWxsKTsKIAogICAgIGlmICh0aGlzT2JqZWN0LT5pc0hvc3RGdW5jdGlvbigp KSB7CisgICAgICAgIGlmICh0aGlzT2JqZWN0LT5uYXRpdmVDb25zdHJ1Y3RvcigpID09IGNhbGxI b3N0RnVuY3Rpb25Bc0NvbnN0cnVjdG9yKQorICAgICAgICAgICAgcmV0dXJuIENvbnN0cnVjdFR5 cGU6Ok5vbmU7CiAgICAgICAgIGNvbnN0cnVjdERhdGEubmF0aXZlLmZ1bmN0aW9uID0gdGhpc09i amVjdC0+bmF0aXZlQ29uc3RydWN0b3IoKTsKICAgICAgICAgcmV0dXJuIENvbnN0cnVjdFR5cGU6 Okhvc3Q7CiAgICAgfQo= 291599 2016-10-14 02:14:42 -0700 2016-10-14 11:16:42 -0700 [PATCH] Proposed Fix is-constructor-2.patch text/plain 7210 joepeck ZGlmZiAtLWdpdCBhL0pTVGVzdHMvQ2hhbmdlTG9nIGIvSlNUZXN0cy9DaGFuZ2VMb2cKaW5kZXgg YmY3N2ZkMS4uNmFlYjQzNCAxMDA2NDQKLS0tIGEvSlNUZXN0cy9DaGFuZ2VMb2cKKysrIGIvSlNU ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMCBAQAogMjAxNi0xMC0xNCAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCisgICAgICAgIHRlc3QyNjI6IEBpc0NvbnN0cnVj dG9yIGluY29ycmVjdGx5IHRoaW5rcyBNYXRoLmNvcyBpcyBhIGNvbnN0cnVjdG9yCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjM0MzcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy9pcy1jb25z dHJ1Y3Rvci5qczogQWRkZWQuCisgICAgICAgIChhc3NlcnQpOgorICAgICAgICAocHJvdG90eXBl LmFzc2VydCk6CisgICAgICAgIE5ldyB0ZXN0IHRvIGNvdmVyIHRoZSBAaXNDb25zdHJ1Y3RvciBi dWlsdGluLgorCisgICAgICAgICogdGVzdDI2Mi55YW1sOgorICAgICAgICBUZXN0IG5vdyBwYXNz ZXMuCisKKzIwMTYtMTAtMTQgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4K KwogICAgICAgICB0ZXN0MjYyOiBGYWlsdXJlIHdpdGggUmVnRXhwLnByb3RvdHlwZS5jb21waWxl IHdoZW4gcGF0dGVybiBpcyB1bmRlZmluZWQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE2MzQzMQogCmRpZmYgLS1naXQgYS9KU1Rlc3RzL3N0cmVzcy9p cy1jb25zdHJ1Y3Rvci5qcyBiL0pTVGVzdHMvc3RyZXNzL2lzLWNvbnN0cnVjdG9yLmpzCm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjBiOGJjMzQKLS0tIC9kZXYvbnVsbAorKysg Yi9KU1Rlc3RzL3N0cmVzcy9pcy1jb25zdHJ1Y3Rvci5qcwpAQCAtMCwwICsxLDk5IEBACitmdW5j dGlvbiBhc3NlcnQoeCkgeworICAgIGlmICgheCkKKyAgICAgICAgdGhyb3cgRXJyb3IoIkJhZCIp OworfQorCitsZXQgaXNDb25zdHJ1Y3RvciA9IGNyZWF0ZUJ1aWx0aW4oIihmdW5jdGlvbihjKSB7 IHJldHVybiBAaXNDb25zdHJ1Y3RvcihjKTsgfSkiKTsKKworLy8gRnVuY3Rpb25zLgorYXNzZXJ0 KGlzQ29uc3RydWN0b3IoYXNzZXJ0KSk7Cithc3NlcnQoaXNDb25zdHJ1Y3RvcihjbGFzc3t9KSk7 Cithc3NlcnQoaXNDb25zdHJ1Y3RvcihmdW5jdGlvbigpe30pKTsKKworLy8gUHJveHkgZnVuY3Rp b25zLgorYXNzZXJ0KGlzQ29uc3RydWN0b3IobmV3IFByb3h5KGFzc2VydCwge30pKSk7Cithc3Nl cnQoaXNDb25zdHJ1Y3RvcihuZXcgUHJveHkoY2xhc3N7fSwge30pKSk7Cithc3NlcnQoaXNDb25z dHJ1Y3RvcihuZXcgUHJveHkoZnVuY3Rpb24oKXt9LCB7fSkpKTsKKworLy8gQm91bmQgZnVuY3Rp b25zLgorYXNzZXJ0KGlzQ29uc3RydWN0b3IoYXNzZXJ0LmJpbmQobnVsbCksIHt9KSk7Cithc3Nl cnQoaXNDb25zdHJ1Y3RvcigoY2xhc3N7fSkuYmluZChudWxsKSwge30pKTsKK2Fzc2VydChpc0Nv bnN0cnVjdG9yKGZ1bmN0aW9uKCl7fS5iaW5kKG51bGwpLCB7fSkpOworCisvLyBCdWlsdGluIGNv bnN0cnVjdG9ycy4KK2Fzc2VydChpc0NvbnN0cnVjdG9yKEFycmF5KSk7Cithc3NlcnQoaXNDb25z dHJ1Y3RvcihBcnJheUJ1ZmZlcikpOworYXNzZXJ0KGlzQ29uc3RydWN0b3IoQm9vbGVhbikpOwor YXNzZXJ0KGlzQ29uc3RydWN0b3IoRGF0ZSkpOworYXNzZXJ0KGlzQ29uc3RydWN0b3IoRXJyb3Ip KTsKK2Fzc2VydChpc0NvbnN0cnVjdG9yKEZ1bmN0aW9uKSk7Cithc3NlcnQoaXNDb25zdHJ1Y3Rv cihNYXApKTsKK2Fzc2VydChpc0NvbnN0cnVjdG9yKE51bWJlcikpOworYXNzZXJ0KGlzQ29uc3Ry dWN0b3IoT2JqZWN0KSk7Cithc3NlcnQoaXNDb25zdHJ1Y3RvcihQcm9taXNlKSk7Cithc3NlcnQo aXNDb25zdHJ1Y3RvcihQcm94eSkpOworYXNzZXJ0KGlzQ29uc3RydWN0b3IoUmVnRXhwKSk7Cith c3NlcnQoaXNDb25zdHJ1Y3RvcihTZXQpKTsKK2Fzc2VydChpc0NvbnN0cnVjdG9yKFN0cmluZykp OworYXNzZXJ0KGlzQ29uc3RydWN0b3IoV2Vha01hcCkpOworYXNzZXJ0KGlzQ29uc3RydWN0b3Io V2Vha1NldCkpOworCisvLyBOb24tZnVuY3Rpb24gdmFsdWVzLgorYXNzZXJ0KCFpc0NvbnN0cnVj dG9yKHVuZGVmaW5lZCkpOworYXNzZXJ0KCFpc0NvbnN0cnVjdG9yKG51bGwpKTsKK2Fzc2VydCgh aXNDb25zdHJ1Y3Rvcih0cnVlKSk7Cithc3NlcnQoIWlzQ29uc3RydWN0b3IoZmFsc2UpKTsKK2Fz c2VydCghaXNDb25zdHJ1Y3RvcigwKSk7Cithc3NlcnQoIWlzQ29uc3RydWN0b3IoMSkpOworYXNz ZXJ0KCFpc0NvbnN0cnVjdG9yKDEuMSkpOworYXNzZXJ0KCFpc0NvbnN0cnVjdG9yKC0xKSk7Cith c3NlcnQoIWlzQ29uc3RydWN0b3IoRGF0ZS5ub3coKSkpOworYXNzZXJ0KCFpc0NvbnN0cnVjdG9y KG5ldyBEYXRlKSk7Cithc3NlcnQoIWlzQ29uc3RydWN0b3IoSW5maW5pdHkpKTsKK2Fzc2VydCgh aXNDb25zdHJ1Y3RvcihOYU4pKTsKK2Fzc2VydCghaXNDb25zdHJ1Y3RvcigiIikpOworYXNzZXJ0 KCFpc0NvbnN0cnVjdG9yKCJ0ZXN0IikpOworYXNzZXJ0KCFpc0NvbnN0cnVjdG9yKFtdKSk7Cith c3NlcnQoIWlzQ29uc3RydWN0b3Ioe30pKTsKK2Fzc2VydCghaXNDb25zdHJ1Y3RvcigvcmVnZXgv KSk7Cithc3NlcnQoIWlzQ29uc3RydWN0b3IoTWF0aCkpOworYXNzZXJ0KCFpc0NvbnN0cnVjdG9y KEpTT04pKTsKK2Fzc2VydCghaXNDb25zdHJ1Y3RvcihTeW1ib2woKSkpOworYXNzZXJ0KCFpc0Nv bnN0cnVjdG9yKG5ldyBFcnJvcikpOworYXNzZXJ0KCFpc0NvbnN0cnVjdG9yKG5ldyBQcm94eSh7 fSwge30pKSk7Cithc3NlcnQoIWlzQ29uc3RydWN0b3IoQXJyYXkucHJvdG90eXBlKSk7CisKKy8v IFN5bWJvbCBpcyBub3QgYSBjb25zdHJ1Y3Rvci4KK2Fzc2VydCghaXNDb25zdHJ1Y3RvcihTeW1i b2wpKTsKKworLy8gR2V0dGVycyAvIHNldHRlcnMgYXJlIG5vdCBjb25zdHJ1Y3RvcnMuCithc3Nl cnQoIWlzQ29uc3RydWN0b3IoT2JqZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvcih7Z2V0IGYo KXt9fSwgImYiKS5nZXQpKTsKK2Fzc2VydCghaXNDb25zdHJ1Y3RvcihPYmplY3QuZ2V0T3duUHJv cGVydHlEZXNjcmlwdG9yKHtzZXQgZih4KXt9fSwgImYiKS5zZXQpKTsKKworLy8gQXJyb3cgZnVu Y3Rpb25zIGFyZSBub3QgY29uc3RydWN0b3JzLgorYXNzZXJ0KCFpc0NvbnN0cnVjdG9yKCgpPT57 fSkpOworCisvLyBHZW5lcmF0b3JzIGFyZSBub3QgY29uc3RydWN0b3JzLgorYXNzZXJ0KCFpc0Nv bnN0cnVjdG9yKGZ1bmN0aW9uKigpe30pKTsKKworLy8gTmF0aXZlIGJ1aWx0aW5zIGFyZSBub3Qg Y29uc3RydWN0b3JzLgorYXNzZXJ0KCFpc0NvbnN0cnVjdG9yKGlzQ29uc3RydWN0b3IpKTsKKwor Ly8gaHR0cHM6Ly90YzM5LmdpdGh1Yi5pby9lY21hMjYyLyNzZWMtYnVpbHQtaW4tZnVuY3Rpb24t b2JqZWN0cworLy8gQnVpbHQtaW4gZnVuY3Rpb24gb2JqZWN0cyB0aGF0IGFyZSBub3QgaWRlbnRp ZmllZCBhcyBjb25zdHJ1Y3RvcnMgZG8gbm90CisvLyBpbXBsZW1lbnQgdGhlIFtbQ29uc3RydWN0 XV0gaW50ZXJuYWwgbWV0aG9kIHVubGVzcyBvdGhlcndpc2Ugc3BlY2lmaWVkIGluCisvLyB0aGUg ZGVzY3JpcHRpb24gb2YgYSBwYXJ0aWN1bGFyIGZ1bmN0aW9uLgorYXNzZXJ0KCFpc0NvbnN0cnVj dG9yKEFycmF5Lm9mKSk7Cithc3NlcnQoIWlzQ29uc3RydWN0b3IoT2JqZWN0LmdldE93blByb3Bl cnR5RGVzY3JpcHRvcikpOworYXNzZXJ0KCFpc0NvbnN0cnVjdG9yKERhdGUubm93KSk7Cithc3Nl cnQoIWlzQ29uc3RydWN0b3IoTWF0aC5jb3MpKTsKK2Fzc2VydCghaXNDb25zdHJ1Y3RvcihKU09O LnN0cmluZ2lmeSkpOworYXNzZXJ0KCFpc0NvbnN0cnVjdG9yKFByb21pc2UuYWxsKSk7Cithc3Nl cnQoIWlzQ29uc3RydWN0b3IoU3ltYm9sLmZvcikpOworYXNzZXJ0KCFpc0NvbnN0cnVjdG9yKEFy cmF5LnByb3RvdHlwZS5wdXNoKSk7CisKKy8vIFByb3h5IGFuZCBib3VuZCBmdW5jdGlvbnMgY2Fy cnkgZm9yd2FyZCBub24tY29uc3RydWN0b3ItbmVzcy4KK2Fzc2VydCghaXNDb25zdHJ1Y3Rvcihu ZXcgUHJveHkoU3ltYm9sLCB7fSkpKTsKK2Fzc2VydCghaXNDb25zdHJ1Y3RvcihuZXcgUHJveHko TWF0aC5jb3MsIHt9KSkpOworYXNzZXJ0KCFpc0NvbnN0cnVjdG9yKFN5bWJvbC5iaW5kKG51bGwp KSk7Cithc3NlcnQoIWlzQ29uc3RydWN0b3IoTWF0aC5jb3MuYmluZChudWxsKSkpOwpkaWZmIC0t Z2l0IGEvSlNUZXN0cy90ZXN0MjYyLnlhbWwgYi9KU1Rlc3RzL3Rlc3QyNjIueWFtbAppbmRleCBl YWQ2MGU1Li4zYjUxYjYwIDEwMDY0NAotLS0gYS9KU1Rlc3RzL3Rlc3QyNjIueWFtbAorKysgYi9K U1Rlc3RzL3Rlc3QyNjIueWFtbApAQCAtMzA1NCw5ICszMDU0LDkgQEAKIC0gcGF0aDogdGVzdDI2 Mi90ZXN0L2J1aWx0LWlucy9BcnJheS9vZi9yZXR1cm4tYS1jdXN0b20taW5zdGFuY2UuanMKICAg Y21kOiBydW5UZXN0MjYyIDpub3JtYWwsICJOb0V4Y2VwdGlvbiIsIFsiLi4vLi4vLi4vLi4vaGFy bmVzcy9hc3NlcnQuanMiLCAiLi4vLi4vLi4vLi4vaGFybmVzcy9zdGEuanMiXSwgWzpzdHJpY3Rd CiAtIHBhdGg6IHRlc3QyNjIvdGVzdC9idWlsdC1pbnMvQXJyYXkvb2YvcmV0dXJuLWEtbmV3LWFy cmF5LW9iamVjdC5qcwotICBjbWQ6IHJ1blRlc3QyNjIgOmZhaWwsICJOb0V4Y2VwdGlvbiIsIFsi Li4vLi4vLi4vLi4vaGFybmVzcy9hc3NlcnQuanMiLCAiLi4vLi4vLi4vLi4vaGFybmVzcy9zdGEu anMiXSwgW10KKyAgY21kOiBydW5UZXN0MjYyIDpub3JtYWwsICJOb0V4Y2VwdGlvbiIsIFsiLi4v Li4vLi4vLi4vaGFybmVzcy9hc3NlcnQuanMiLCAiLi4vLi4vLi4vLi4vaGFybmVzcy9zdGEuanMi XSwgW10KIC0gcGF0aDogdGVzdDI2Mi90ZXN0L2J1aWx0LWlucy9BcnJheS9vZi9yZXR1cm4tYS1u ZXctYXJyYXktb2JqZWN0LmpzCi0gIGNtZDogcnVuVGVzdDI2MiA6ZmFpbCwgIk5vRXhjZXB0aW9u IiwgWyIuLi8uLi8uLi8uLi9oYXJuZXNzL2Fzc2VydC5qcyIsICIuLi8uLi8uLi8uLi9oYXJuZXNz L3N0YS5qcyJdLCBbOnN0cmljdF0KKyAgY21kOiBydW5UZXN0MjYyIDpub3JtYWwsICJOb0V4Y2Vw dGlvbiIsIFsiLi4vLi4vLi4vLi4vaGFybmVzcy9hc3NlcnQuanMiLCAiLi4vLi4vLi4vLi4vaGFy bmVzcy9zdGEuanMiXSwgWzpzdHJpY3RdCiAtIHBhdGg6IHRlc3QyNjIvdGVzdC9idWlsdC1pbnMv QXJyYXkvb2YvcmV0dXJuLWFicnVwdC1mcm9tLWNvbnRydWN0b3IuanMKICAgY21kOiBydW5UZXN0 MjYyIDpub3JtYWwsICJOb0V4Y2VwdGlvbiIsIFsiLi4vLi4vLi4vLi4vaGFybmVzcy9hc3NlcnQu anMiLCAiLi4vLi4vLi4vLi4vaGFybmVzcy9zdGEuanMiXSwgW10KIC0gcGF0aDogdGVzdDI2Mi90 ZXN0L2J1aWx0LWlucy9BcnJheS9vZi9yZXR1cm4tYWJydXB0LWZyb20tY29udHJ1Y3Rvci5qcwpk aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggYmFiNTJkYi4uZDczNWMyYSAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAgQEAKIDIwMTYtMTAtMTQgIEpvc2VwaCBQZWNvcmFy byAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICB0ZXN0MjYyOiBAaXNDb25zdHJ1Y3Rv ciBpbmNvcnJlY3RseSB0aGlua3MgTWF0aC5jb3MgaXMgYSBjb25zdHJ1Y3RvcgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzNDM3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBydW50aW1lL0pTRnVuY3Rp b24uY3BwOgorICAgICAgICAoSlNDOjpKU0Z1bmN0aW9uOjpnZXRDb25zdHJ1Y3REYXRhKToKKyAg ICAgICAgQnkgZGVmYXVsdCwgSG9zdCBKU0Z1bmN0aW9ucyBhcmUgbm90IGNvbnN0cnVjdGFibGUu IFRoZXkgZ2V0CisgICAgICAgIHRoZSBkZWZhdWx0IGNhbGxIb3N0RnVuY3Rpb25Bc0NvbnN0cnVj dG9yIG5hdGl2ZSBjb25zdHJ1Y3Rvci4KKyAgICAgICAgV2hlbiBnZXR0aW5nIGNvbnN0cnVjdCBk YXRhIHdlIGNhbiByZXR1cm4gQ29uc3RydWN0VHlwZTo6Tm9uZQorICAgICAgICBpbiB0aGVzZSBj YXNlcyBpbnN0ZWFkIG9mIGluZGljYXRpbmcgaXQgbWlnaHQgYmUgY29uc3RydWN0YWJsZQorICAg ICAgICBhbmQgbGF0ZXIgdGhyb3dpbmcgYW4gZXhjZXB0aW9uIHdoZW4gY29uc3RydWN0aW9uIGlz IGF0dGVtcHRlZC4KKworMjAxNi0xMC0xNCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBw bGUuY29tPgorCiAgICAgICAgIHRlc3QyNjI6IEZhaWx1cmUgd2l0aCBSZWdFeHAucHJvdG90eXBl LmNvbXBpbGUgd2hlbiBwYXR0ZXJuIGlzIHVuZGVmaW5lZAogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzNDMxCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTRnVuY3Rpb24uY3BwIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvSlNGdW5jdGlvbi5jcHAKaW5kZXggNGQyMTA2YS4uMGMwMGY2MyAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNGdW5jdGlvbi5jcHAKKysrIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNGdW5jdGlvbi5jcHAKQEAgLTU3Myw2ICs1 NzMsOCBAQCBDb25zdHJ1Y3RUeXBlIEpTRnVuY3Rpb246OmdldENvbnN0cnVjdERhdGEoSlNDZWxs KiBjZWxsLCBDb25zdHJ1Y3REYXRhJiBjb25zdHJ1YwogICAgIEpTRnVuY3Rpb24qIHRoaXNPYmpl Y3QgPSBqc0Nhc3Q8SlNGdW5jdGlvbio+KGNlbGwpOwogCiAgICAgaWYgKHRoaXNPYmplY3QtPmlz SG9zdEZ1bmN0aW9uKCkpIHsKKyAgICAgICAgaWYgKHRoaXNPYmplY3QtPm5hdGl2ZUNvbnN0cnVj dG9yKCkgPT0gY2FsbEhvc3RGdW5jdGlvbkFzQ29uc3RydWN0b3IpCisgICAgICAgICAgICByZXR1 cm4gQ29uc3RydWN0VHlwZTo6Tm9uZTsKICAgICAgICAgY29uc3RydWN0RGF0YS5uYXRpdmUuZnVu Y3Rpb24gPSB0aGlzT2JqZWN0LT5uYXRpdmVDb25zdHJ1Y3RvcigpOwogICAgICAgICByZXR1cm4g Q29uc3RydWN0VHlwZTo6SG9zdDsKICAgICB9Cg==