163435 2016-10-14 01:49:56 -0700 preprocessor.pm: cl.exe outputs processing filenames if Windows Perl is used 2016-10-17 10:35:03 -0700 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 fujii webkit-unassigned achristensen bfulgham cdumez commit-queue pvollan oldest_to_newest 1240163 0 fujii 2016-10-14 01:49:56 -0700 Use open3 instead of open2. A following bug changed open3 to open2 in Windows Perl. Bug 91548 – Use cl to preprocess IDL for Chromium Windows generate_supplemental_dependency A following bug introduced open3 for cl.exe. Bug 143219 – Allow building on Windows without Cygwin IPC::Open3 - perldoc.perl.org http://perldoc.perl.org/IPC/Open3.html 1240191 1 291601 fujii 2016-10-14 02:22:24 -0700 Created attachment 291601 Patch 1240874 2 fujii 2016-10-16 22:58:44 -0700 WinCairo port uses Windows Perl. For example, this problem can be observed in a following build log: https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/61992/steps/compile-webkit/logs/stdio > [7/408] Generating ../../DerivedSources/WebCore/JSCSSStyleSheet.cpp, ../../DerivedSources/WebCore/JSCSSStyleSheet.h > [8/408] Generating ../../DerivedSources/WebCore/JSCSSSupportsRule.cpp, ../../DerivedSources/WebCore/JSCSSSupportsRule.h > [9/408] Generating ../../DerivedSources/WebCore/JSCSSCharsetRule.cpp, ../../DerivedSources/WebCore/JSCSSCharsetRule.h > [10/408] Generating ../../DerivedSources/WebCore/JSCSSValue.cpp, ../../DerivedSources/WebCore/JSCSSValue.h > [11/408] Generating ../../DerivedSources/WebCore/JSCSSPrimitiveValue.cpp, ../../DerivedSources/WebCore/JSCSSPrimitiveValue.h > [12/408] Generating ../../DerivedSources/WebCore/JSCSSRule.cpp, ../../DerivedSources/WebCore/JSCSSRule.h > [13/408] Generating ../../DerivedSources/WebCore/JSCSSStyleDeclaration.cpp, ../../DerivedSources/WebCore/JSCSSStyleDeclaration.h > [14/408] Generating ../../DerivedSources/WebCore/JSFontFace.cpp, ../../DerivedSources/WebCore/JSFontFace.h > [15/408] Generating ../../DerivedSources/WebCore/JSCSSMediaRule.cpp, ../../DerivedSources/WebCore/JSCSSMediaRule.h > [16/408] Generating ../../DerivedSources/WebCore/JSMediaList.cpp, ../../DerivedSources/WebCore/JSMediaList.h > [17/408] Generating ../../DerivedSources/WebCore/JSFontFaceSet.cpp, ../../DerivedSources/WebCore/JSFontFaceSet.h > [18/408] Generating ../../DerivedSources/WebCore/JSWebKitCSSMatrix.cpp, ../../DerivedSources/WebCore/JSWebKitCSSMatrix.h > CSSValue.idl > > CSSMediaRule.idl > > CSSRule.idl > > WebKitCSSMatrix.idl > > CSSSupportsRule.idl > > CSSRule.idl > > CSSRule.idl > > MediaList.idl > > FontFace.idl > > FontFace.idl > > CSSStyleDeclaration.idl > > CSSCharsetRule.idl > > CSSRule.idl > > CSSStyleSheet.idl > > StyleSheet.idl > > CSSPrimitiveValue.idl > > CSSValue.idl > > FontFaceSet.idl > > EventTarget.idl > > FontFace.idl 1241006 3 291601 commit-queue 2016-10-17 10:34:59 -0700 Comment on attachment 291601 Patch Clearing flags on attachment: 291601 Committed r207412: <http://trac.webkit.org/changeset/207412> 1241007 4 commit-queue 2016-10-17 10:35:03 -0700 All reviewed patches have been landed. Closing bug. 291601 2016-10-14 02:22:24 -0700 2016-10-17 10:34:59 -0700 Patch bug-163435-20161014181906.patch text/plain 1736 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3MzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjY3MTVjNzM0MjVjMTUw MzEwMjg0MmI5MDkzYzcwYTZkNTg5NTFhMS4uZDM4YThhN2I5YjY3N2JlOTFkNjliMjM1ZjM2YWU4 OTAzYWIxZTI4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTEwLTE0ICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIHByZXByb2Nl c3Nvci5wbTogY2wuZXhlIG91dHB1dHMgcHJvY2Vzc2luZyBmaWxlbmFtZXMgaWYgV2luZG93cyBQ ZXJsIGlzIHVzZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE2MzQzNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIGNsLmV4ZSBvdXRwdXRzIHByb2Nlc3NpbmcgZmlsZW5hbWVzIHRvIHN0ZGVyci4gU3VwcHJl c3MgdGhpcworICAgICAgICBhbm5veWluZyBtZXNzYWdlcyBieSB1c2luZyBvcGVuMyBpbnN0ZWFk IG9mIG9wZW4yLgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9wcmVwcm9jZXNzb3IucG06 CisgICAgICAgIChhcHBseVByZXByb2Nlc3Nvcik6IFVzZSBvcGVuMyBpbiBjYXNlIG9mIFdpbmRv d3MgUGVybC4KKwogMjAxNi0xMC0xMyAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3 ZWJraXQub3JnPgogCiAgICAgICAgIEZpeCBBUEkgdGVzdCBhZnRlciByMjA3MzE4LgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9wcmVwcm9jZXNzb3IucG0gYi9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3ByZXByb2Nlc3Nvci5wbQppbmRleCBhMzRl ODQ2MWI3YjkxZmVhYWI3N2FmNDdkMzY2NTE3N2U5MmM2OTY0Li4yMzIxZDUxOTFhMGE3YmExODc2 NDM1OTRhNDQ5YWM0Y2U4YTI5YWIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9zY3JpcHRzL3ByZXByb2Nlc3Nvci5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9z Y3JpcHRzL3ByZXByb2Nlc3Nvci5wbQpAQCAtOTksNyArOTksMTAgQEAgc3ViIGFwcGx5UHJlcHJv Y2Vzc29yCiAgICAgICAgICAgICB9CiAgICAgICAgIH07CiAgICAgfSBlbHNpZiAoJENvbmZpZzo6 Q29uZmlneyJvc25hbWUifSBlcSAiTVNXaW4zMiIpIHsKLSAgICAgICAgJHBpZCA9IG9wZW4yKFwq UFBfT1VULCBcKlBQX0lOLCAkcHJlcHJvY2Vzc29yLCBAYXJncywgQG1hY3JvcywgJGZpbGVOYW1l KTsKKyAgICAgICAgIyBTdXBwcmVzcyBTVERFUlIgc28gdGhhdCBpZiB3ZSdyZSB1c2luZyBjbC5l eGUsIHRoZSBvdXRwdXQKKyAgICAgICAgIyBuYW1lIGlzbid0IG5lZWRsZXNzbHkgZWNob2VkLgor ICAgICAgICB1c2UgU3ltYm9sICdnZW5zeW0nOyBteSAkZXJyID0gZ2Vuc3ltOworICAgICAgICAk cGlkID0gb3BlbjMoXCpQUF9JTiwgXCpQUF9PVVQsICRlcnIsICRwcmVwcm9jZXNzb3IsIEBhcmdz LCBAbWFjcm9zLCAkZmlsZU5hbWUpOwogICAgIH0gZWxzZSB7CiAgICAgICAgICRwaWQgPSBvcGVu MihcKlBQX09VVCwgXCpQUF9JTiwgc3BsaXQoJyAnLCAkcHJlcHJvY2Vzc29yKSwgQGFyZ3MsIEBt YWNyb3MsICRmaWxlTmFtZSk7CiAgICAgfQo=