163432 2016-10-14 00:52:00 -0700 [css-grid] Disable CSS Grid Layout runtime flag by default 2016-10-18 06:05:55 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60731 1 rego rego cgarcia commit-queue dino jfernandez joepeck rego svillar oldest_to_newest 1240153 0 rego 2016-10-14 00:52:00 -0700 In r201042 the runtime flags were enabled by default as Safari Technology Preview was lacking a UI to modify them. Now that it has a UI to enable/disable the flags we don't need that Grid Layout is enabled by default anymore. 1240154 1 291588 rego 2016-10-14 00:55:00 -0700 Created attachment 291588 Patch 1240881 2 291588 commit-queue 2016-10-17 00:25:48 -0700 Comment on attachment 291588 Patch Clearing flags on attachment: 291588 Committed r207402: <http://trac.webkit.org/changeset/207402> 1240882 3 commit-queue 2016-10-17 00:25:52 -0700 All reviewed patches have been landed. Closing bug. 1241244 4 joepeck 2016-10-17 16:37:19 -0700 This change caused some buttons in Web Inspector to break their position!! That said, I don't think we should roll this out, I think this is just exposing an issue that this runtime flag is affecting some things that it should be affecting. I'll investigate. 1241417 5 svillar 2016-10-18 05:40:49 -0700 (In reply to comment #4) > This change caused some buttons in Web Inspector to break their position!! > That said, I don't think we should roll this out, I think this is just > exposing an issue that this runtime flag is affecting some things that it > should be affecting. I'll investigate. Is web inspector using grid layout? Sounds weird specially because we have not shipped it yet. 1241426 6 jfernandez 2016-10-18 06:05:55 -0700 (In reply to comment #5) > (In reply to comment #4) > > This change caused some buttons in Web Inspector to break their position!! > > That said, I don't think we should roll this out, I think this is just > > exposing an issue that this runtime flag is affecting some things that it > > should be affecting. I'll investigate. > > Is web inspector using grid layout? Sounds weird specially because we have > not shipped it yet. The bug #163572 has been filed precisely to track this issue. The problem is not grid itself, but the CSS Box Alignment properties it shares with Flexbox. Due to the different behavior of the new syntax, we need to use the runtime and compile flags to implement both code paths. BTW, there is already a proposed fix for bug #163572, so we can continue discussing the details there. 291588 2016-10-14 00:55:00 -0700 2016-10-17 00:25:48 -0700 Patch bug-163432-20161014095132.patch text/plain 2042 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2OTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjAyYzUwOWUwZjQ0NTIw YjZhOTQ2M2FhMjFlNTlhMzU3YWIxZjA1Yi4uNzdkOGY2ZGIyYjU4MmY0NTMxMjc5M2I1NTRjZTFj ZDA3ZWYzNDIyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTEwLTE0ICBNYW51 ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtjc3MtZ3Jp ZF0gRGlzYWJsZSBDU1MgR3JpZCBMYXlvdXQgcnVudGltZSBmbGFnIGJ5IGRlZmF1bHQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MzQzMgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEl0IHdhcyBlbmFibGVk IGluIHIyMDEwNDIsIGJ1dCBub3cgU2FmYXJpIFRlY2hub2xvZ3kgUHJldmlldworICAgICAgICBo YXMgYSBVSSB0byBzd2l0Y2ggcnVudGltZSBmbGFncyBzbyBpdCBkb2Vzbid0IG5lZWQgdG8gYmUg ZW5hYmxlZAorICAgICAgICBieSBkZWZhdWx0IGFueW1vcmUuCisKKyAgICAgICAgKiBTaGFyZWQv V2ViUHJlZmVyZW5jZXNEZWZpbml0aW9ucy5oOiBEaXNhYmxlIGdyaWQgbGF5b3V0IHJ1bnRpbWUg ZmxhZworICAgICAgICBieSBkZWZhdWx0LgorCiAyMDE2LTEwLTA2ICBNaWNoYWVsIENhdGFuemFy byAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBFeHBvc2UgV2ViS2l0 RE9NSFRNTElucHV0RWxlbWVudCBBUElzIGZvciBmb3JtIGF1dG9maWxsCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViUHJlZmVyZW5jZXNEZWZpbml0aW9ucy5oIGIvU291cmNl L1dlYktpdDIvU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVmaW5pdGlvbnMuaAppbmRleCA4ZTJhNWUy NmQ4ZTFkNDU3ZDllNjAyMzlkMGQ2YjAyOGVmMDEyZWJjLi40YmMxZDUyZjNhOWZlNWE4NzI4YWNi NTMyYzY0MDRiZTFlY2U3NDAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2Vi UHJlZmVyZW5jZXNEZWZpbml0aW9ucy5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJQ cmVmZXJlbmNlc0RlZmluaXRpb25zLmgKQEAgLTI4Niw3ICsyODYsNyBAQAogLy8gLSBUaGV5IHNo b3VsZCBiZSBmYWxzZSBieSBkZWZhdWx0LCBhbHRob3VnaCB0aGV5IGFyZSBjdXJyZW50bHkgc2V0 IHRvIHRydWUgd2hpbGUgd2UgZGV2ZWxvcCBjbGllbnQgVUkuCiAKICNkZWZpbmUgRk9SX0VBQ0hf V0VCS0lUX0VYUEVSSU1FTlRBTF9GRUFUVVJFX1BSRUZFUkVOQ0UobWFjcm8pIFwKLSAgICBtYWNy byhDU1NHcmlkTGF5b3V0RW5hYmxlZCwgY3NzR3JpZExheW91dEVuYWJsZWQsIEJvb2wsIGJvb2ws IHRydWUsICJDU1MgR3JpZCIsICJDU1MgR3JpZCBMYXlvdXQgTW9kdWxlIHN1cHBvcnQiKSBcCisg ICAgbWFjcm8oQ1NTR3JpZExheW91dEVuYWJsZWQsIGNzc0dyaWRMYXlvdXRFbmFibGVkLCBCb29s LCBib29sLCBmYWxzZSwgIkNTUyBHcmlkIiwgIkNTUyBHcmlkIExheW91dCBNb2R1bGUgc3VwcG9y dCIpIFwKICAgICBtYWNybyhTcHJpbmdUaW1pbmdGdW5jdGlvbkVuYWJsZWQsIHNwcmluZ1RpbWlu Z0Z1bmN0aW9uRW5hYmxlZCwgQm9vbCwgYm9vbCwgdHJ1ZSwgIkNTUyBTcHJpbmcgQW5pbWF0aW9u cyIsICJDU1MgU3ByaW5nIEFuaW1hdGlvbiBwcm90b3R5cGUiKSBcCiAgICAgbWFjcm8oQ3VzdG9t RWxlbWVudHNFbmFibGVkLCBjdXN0b21FbGVtZW50c0VuYWJsZWQsIEJvb2wsIGJvb2wsIHRydWUs ICJDdXN0b20gRWxlbWVudHMiLCAiSFRNTCBDdXN0b20gRWxlbWVudHMgcHJvdG90eXBlIikgXAog ICAgIG1hY3JvKEdhbWVwYWRzRW5hYmxlZCwgZ2FtZXBhZHNFbmFibGVkLCBCb29sLCBib29sLCBm YWxzZSwgIkdhbWVwYWRzIiwgIldlYiBHYW1lcGFkIEFQSSBzdXBwb3J0IikgXAo=