163431 2016-10-14 00:33:08 -0700 test262: Failure with RegExp.prototype.compile when pattern is undefined 2016-10-14 03:07:24 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1240145 0 joepeck 2016-10-14 00:33:08 -0700 test262: Failure with RegExp.prototype.compile when pattern is undefined regexp.compile(undefined) should be the same as regexp.compile("") Currently we treat it like regexp.compile("undefined") > esid: sec-regexp.prototype.compile > es6id: B.2.5.1 > description: Behavior when pattern is undefined > info: | > [...] > 3. If Type(pattern) is Object and pattern has a [[RegExpMatcher]] internal > slot, then > [...] > 4. Else, > a. Let P be pattern. > b. Let F be flags. > 5. Return ? RegExpInitialize(O, P, F). > > 21.2.3.2.2 Runtime Semantics: RegExpInitialize > > 1. If pattern is undefined, let P be the empty String. > [...] 1240148 1 291585 joepeck 2016-10-14 00:36:48 -0700 Created attachment 291585 [PATCH] Proposed Fix 1240150 2 291585 ysuzuki 2016-10-14 00:42:39 -0700 Comment on attachment 291585 [PATCH] Proposed Fix r=me 1240205 3 291585 commit-queue 2016-10-14 03:07:20 -0700 Comment on attachment 291585 [PATCH] Proposed Fix Clearing flags on attachment: 291585 Committed r207334: <http://trac.webkit.org/changeset/207334> 1240206 4 commit-queue 2016-10-14 03:07:24 -0700 All reviewed patches have been landed. Closing bug. 291585 2016-10-14 00:36:48 -0700 2016-10-14 03:07:20 -0700 [PATCH] Proposed Fix compile-1.patch text/plain 5750 joepeck ZGlmZiAtLWdpdCBhL0pTVGVzdHMvQ2hhbmdlTG9nIGIvSlNUZXN0cy9DaGFuZ2VMb2cKaW5kZXgg YTQ2NDIxMi4uYmY3N2ZkMSAxMDA2NDQKLS0tIGEvSlNUZXN0cy9DaGFuZ2VMb2cKKysrIGIvSlNU ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxNi0xMC0xNCAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIHRlc3QyNjI6IEZhaWx1cmUgd2l0 aCBSZWdFeHAucHJvdG90eXBlLmNvbXBpbGUgd2hlbiBwYXR0ZXJuIGlzIHVuZGVmaW5lZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzNDMxCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB0ZXN0MjYyLnlh bWw6CisKIDIwMTYtMTAtMTMgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4K IAogICAgICAgICBFeGNlcHRpb24gbWVzc2FnZSBmb3IgZXhwcmVzc2lvbnMgd2l0aCBtdWx0aXBs ZSBicmFja2V0IGFjY2Vzc2VzIGlzIGluY29uc2lzdGVudCAvIGluY29ycmVjdApkaWZmIC0tZ2l0 IGEvSlNUZXN0cy90ZXN0MjYyLnlhbWwgYi9KU1Rlc3RzL3Rlc3QyNjIueWFtbAppbmRleCA4ZmQx NDVjLi5lYWQ2MGU1IDEwMDY0NAotLS0gYS9KU1Rlc3RzL3Rlc3QyNjIueWFtbAorKysgYi9KU1Rl c3RzL3Rlc3QyNjIueWFtbApAQCAtNDQ4LDkgKzQ0OCw5IEBACiAtIHBhdGg6IHRlc3QyNjIvdGVz dC9hbm5leEIvYnVpbHQtaW5zL1JlZ0V4cC9wcm90b3R5cGUvY29tcGlsZS9wYXR0ZXJuLXRvLXN0 cmluZy1lcnIuanMKICAgY21kOiBydW5UZXN0MjYyIDpub3JtYWwsICJOb0V4Y2VwdGlvbiIsIFsi Li4vLi4vLi4vLi4vLi4vLi4vaGFybmVzcy9hc3NlcnQuanMiLCAiLi4vLi4vLi4vLi4vLi4vLi4v aGFybmVzcy9zdGEuanMiXSwgWzpzdHJpY3RdCiAtIHBhdGg6IHRlc3QyNjIvdGVzdC9hbm5leEIv YnVpbHQtaW5zL1JlZ0V4cC9wcm90b3R5cGUvY29tcGlsZS9wYXR0ZXJuLXVuZGVmaW5lZC5qcwot ICBjbWQ6IHJ1blRlc3QyNjIgOmZhaWwsICJOb0V4Y2VwdGlvbiIsIFsiLi4vLi4vLi4vLi4vLi4v Li4vaGFybmVzcy9hc3NlcnQuanMiLCAiLi4vLi4vLi4vLi4vLi4vLi4vaGFybmVzcy9zdGEuanMi XSwgW10KKyAgY21kOiBydW5UZXN0MjYyIDpub3JtYWwsICJOb0V4Y2VwdGlvbiIsIFsiLi4vLi4v Li4vLi4vLi4vLi4vaGFybmVzcy9hc3NlcnQuanMiLCAiLi4vLi4vLi4vLi4vLi4vLi4vaGFybmVz cy9zdGEuanMiXSwgW10KIC0gcGF0aDogdGVzdDI2Mi90ZXN0L2FubmV4Qi9idWlsdC1pbnMvUmVn RXhwL3Byb3RvdHlwZS9jb21waWxlL3BhdHRlcm4tdW5kZWZpbmVkLmpzCi0gIGNtZDogcnVuVGVz dDI2MiA6ZmFpbCwgIk5vRXhjZXB0aW9uIiwgWyIuLi8uLi8uLi8uLi8uLi8uLi9oYXJuZXNzL2Fz c2VydC5qcyIsICIuLi8uLi8uLi8uLi8uLi8uLi9oYXJuZXNzL3N0YS5qcyJdLCBbOnN0cmljdF0K KyAgY21kOiBydW5UZXN0MjYyIDpub3JtYWwsICJOb0V4Y2VwdGlvbiIsIFsiLi4vLi4vLi4vLi4v Li4vLi4vaGFybmVzcy9hc3NlcnQuanMiLCAiLi4vLi4vLi4vLi4vLi4vLi4vaGFybmVzcy9zdGEu anMiXSwgWzpzdHJpY3RdCiAtIHBhdGg6IHRlc3QyNjIvdGVzdC9hbm5leEIvYnVpbHQtaW5zL1Jl Z0V4cC9wcm90b3R5cGUvY29tcGlsZS90aGlzLW5vdC1vYmplY3QuanMKICAgY21kOiBydW5UZXN0 MjYyIDpub3JtYWwsICJOb0V4Y2VwdGlvbiIsIFsiLi4vLi4vLi4vLi4vLi4vLi4vaGFybmVzcy9h c3NlcnQuanMiLCAiLi4vLi4vLi4vLi4vLi4vLi4vaGFybmVzcy9zdGEuanMiXSwgW10KIC0gcGF0 aDogdGVzdDI2Mi90ZXN0L2FubmV4Qi9idWlsdC1pbnMvUmVnRXhwL3Byb3RvdHlwZS9jb21waWxl L3RoaXMtbm90LW9iamVjdC5qcwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDhiMDZkZDUuLjBiMWRjMzcgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNi0xMC0xNCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgorCisgICAgICAgIHRlc3QyNjI6IEZhaWx1cmUgd2l0aCBSZWdFeHAucHJvdG90eXBlLmNv bXBpbGUgd2hlbiBwYXR0ZXJuIGlzIHVuZGVmaW5lZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzNDMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBqcy9yZWdleHAtY29tcGlsZS1leHBlY3RlZC50eHQ6 CisgICAgICAgICoganMvc2NyaXB0LXRlc3RzL3JlZ2V4cC1jb21waWxlLmpzOgorCiAyMDE2LTEw LTEzICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgRXhj ZXB0aW9uIG1lc3NhZ2UgZm9yIGV4cHJlc3Npb25zIHdpdGggbXVsdGlwbGUgYnJhY2tldCBhY2Nl c3NlcyBpcyBpbmNvbnNpc3RlbnQgLyBpbmNvcnJlY3QKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2pzL3JlZ2V4cC1jb21waWxlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2pzL3JlZ2V4cC1j b21waWxlLWV4cGVjdGVkLnR4dAppbmRleCAwYjI4NmE3Li4wZmJjNjhmIDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9qcy9yZWdleHAtY29tcGlsZS1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVz dHMvanMvcmVnZXhwLWNvbXBpbGUtZXhwZWN0ZWQudHh0CkBAIC0xNyw5ICsxNywxMCBAQCBQQVNT IHJlLnRvU3RyaW5nKCkgaXMgJy9jL2knCiBQQVNTIHJlLmNvbXBpbGUobmV3IFJlZ0V4cCgnYycp LCAnaScpOyB0aHJldyBleGNlcHRpb24gVHlwZUVycm9yOiBDYW5ub3Qgc3VwcGx5IGZsYWdzIHdo ZW4gY29uc3RydWN0aW5nIG9uZSBSZWdFeHAgZnJvbSBhbm90aGVyLi4KIFBBU1MgcmUudG9TdHJp bmcoKSBpcyAnL2MvaScKIFBBU1MgcmUuY29tcGlsZShuZXcgUmVnRXhwKCcrJykpOyB0aHJldyBl eGNlcHRpb24gU3ludGF4RXJyb3I6IEludmFsaWQgcmVndWxhciBleHByZXNzaW9uOiBub3RoaW5n IHRvIHJlcGVhdC4KLVBBU1MgcmUudG9TdHJpbmcoKSBpcyAnL3VuZGVmaW5lZC8nCitQQVNTIHJl LnRvU3RyaW5nKCkgaXMgJy8oPzopLycKK1BBU1MgcmUudG9TdHJpbmcoKSBpcyAnLyg/OikvJwor UEFTUyByZS50b1N0cmluZygpIGlzICcvKD86KS8nCiBQQVNTIHJlLnRvU3RyaW5nKCkgaXMgJy9u dWxsLycKLVBBU1MgcmUudG9TdHJpbmcoKSBpcyAnLyg/OikvJwogUEFTUyByZS50b1N0cmluZygp IGlzICcvei8nCiBQQVNTIHJlLmxhc3RJbmRleCBpcyAwCiBQQVNTIHJlLmxhc3RJbmRleCBpcyAx CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9qcy9zY3JpcHQtdGVzdHMvcmVnZXhwLWNvbXBpbGUu anMgYi9MYXlvdXRUZXN0cy9qcy9zY3JpcHQtdGVzdHMvcmVnZXhwLWNvbXBpbGUuanMKaW5kZXgg NDM1MmU5NC4uY2M3MDA0NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvanMvc2NyaXB0LXRlc3Rz L3JlZ2V4cC1jb21waWxlLmpzCisrKyBiL0xheW91dFRlc3RzL2pzL3NjcmlwdC10ZXN0cy9yZWdl eHAtY29tcGlsZS5qcwpAQCAtMzEsMTUgKzMxLDE2IEBAIHNob3VsZEJlKCJyZS50b1N0cmluZygp IiwgIicvYy9pJyIpOwogCiBzaG91bGRUaHJvdygicmUuY29tcGlsZShuZXcgUmVnRXhwKCcrJykp OyIpOwogCityZS5jb21waWxlKCk7CitzaG91bGRCZSgicmUudG9TdHJpbmcoKSIsICInLyg/Oikv JyIpOwogcmUuY29tcGlsZSh1bmRlZmluZWQpOwotc2hvdWxkQmUoInJlLnRvU3RyaW5nKCkiLCAi Jy91bmRlZmluZWQvJyIpOworc2hvdWxkQmUoInJlLnRvU3RyaW5nKCkiLCAiJy8oPzopLyciKTsK K3JlLmNvbXBpbGUoIiIpOworc2hvdWxkQmUoInJlLnRvU3RyaW5nKCkiLCAiJy8oPzopLyciKTsK IAogcmUuY29tcGlsZShudWxsKTsKIHNob3VsZEJlKCJyZS50b1N0cmluZygpIiwgIicvbnVsbC8n Iik7CiAKLXJlLmNvbXBpbGUoKTsKLXNob3VsZEJlKCJyZS50b1N0cmluZygpIiwgIicvKD86KS8n Iik7Ci0KIHJlLmNvbXBpbGUoInoiLCB1bmRlZmluZWQpOwogc2hvdWxkQmUoInJlLnRvU3RyaW5n KCkiLCAiJy96LyciKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5n ZUxvZyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggOWRhZjFmMC4uYmFi NTJkYiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTYtMTAt MTQgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICB0ZXN0 MjYyOiBGYWlsdXJlIHdpdGggUmVnRXhwLnByb3RvdHlwZS5jb21waWxlIHdoZW4gcGF0dGVybiBp cyB1bmRlZmluZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE2MzQzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIElmIHBhdHRlcm4gaXMgdW5kZWZpbmVkIGxldCBQIGJlIHRoZSBlbXB0eSBTdHJpbmcuCisg ICAgICAgIGh0dHBzOi8vdGMzOS5naXRodWIuaW8vZWNtYTI2Mi8jc2VjLXJlZ2V4cGluaXRpYWxp emUKKworICAgICAgICAqIHJ1bnRpbWUvUmVnRXhwUHJvdG90eXBlLmNwcDoKKyAgICAgICAgKEpT Qzo6cmVnRXhwUHJvdG9GdW5jQ29tcGlsZSk6CisKIDIwMTYtMTAtMTMgIEpvc2VwaCBQZWNvcmFy byAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBFeGNlcHRpb24gbWVzc2FnZSBmb3Ig ZXhwcmVzc2lvbnMgd2l0aCBtdWx0aXBsZSBicmFja2V0IGFjY2Vzc2VzIGlzIGluY29uc2lzdGVu dCAvIGluY29ycmVjdApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv UmVnRXhwUHJvdG90eXBlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1JlZ0V4 cFByb3RvdHlwZS5jcHAKaW5kZXggOTBiNDA4NC4uYWRmMDZmOSAxMDA2NDQKLS0tIGEvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUmVnRXhwUHJvdG90eXBlLmNwcAorKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9SZWdFeHBQcm90b3R5cGUuY3BwCkBAIC0xNTgsNyArMTU4 LDcgQEAgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCByZWdFeHBQcm90b0Z1bmNDb21waWxl KEV4ZWNTdGF0ZSogZXhlYykKICAgICAgICAgICAgIHJldHVybiB0aHJvd1ZNVHlwZUVycm9yKGV4 ZWMsIHNjb3BlLCBBU0NJSUxpdGVyYWwoIkNhbm5vdCBzdXBwbHkgZmxhZ3Mgd2hlbiBjb25zdHJ1 Y3Rpbmcgb25lIFJlZ0V4cCBmcm9tIGFub3RoZXIuIikpOwogICAgICAgICByZWdFeHAgPSBhc1Jl Z0V4cE9iamVjdChhcmcwKS0+cmVnRXhwKCk7CiAgICAgfSBlbHNlIHsKLSAgICAgICAgU3RyaW5n IHBhdHRlcm4gPSAhZXhlYy0+YXJndW1lbnRDb3VudCgpID8gZW1wdHlTdHJpbmcoKSA6IGFyZzAu dG9TdHJpbmcoZXhlYyktPnZhbHVlKGV4ZWMpOworICAgICAgICBTdHJpbmcgcGF0dGVybiA9IGFy ZzAuaXNVbmRlZmluZWQoKSA/IGVtcHR5U3RyaW5nKCkgOiBhcmcwLnRvU3RyaW5nKGV4ZWMpLT52 YWx1ZShleGVjKTsKICAgICAgICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgZW5jb2RlZEpT VmFsdWUoKSk7CiAKICAgICAgICAgUmVnRXhwRmxhZ3MgZmxhZ3MgPSBOb0ZsYWdzOwo=