16342 2007-12-07 08:17:59 -0800 Build Warning and Error fixes in WebCore GTK+ 2007-12-12 09:27:43 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.4 RESOLVED FIXED Gtk P2 Normal --- 0 dobey webkit-unassigned christian mrowe oldest_to_newest 63588 0 dobey 2007-12-07 08:17:59 -0800 There are multiple errors of the following type in platform/gtk: ../../../WebCore/platform/gtk/PlatformScrollBarGtk.cpp:76: error: ISO C++ forbids casting between pointer-to-function and pointer-to-object ../../../WebCore/platform/gtk/PlatformScrollBarGtk.cpp:77: error: ISO C++ forbids casting between pointer-to-function and pointer-to-object There are also a couple of warnings about other casts as well. The attached patch fixes these problems. 63600 1 mrowe 2007-12-07 10:35:52 -0800 Did you mean to attach a patch? 63603 2 17775 dobey 2007-12-07 11:14:38 -0800 Created attachment 17775 Patch to fix warnings and errors Here's the patch. Had to update, get lunch, and tweak a few things. :) 63681 3 mrowe 2007-12-08 11:19:32 -0800 Is there a compiler flag that we can use to disable the warning about casting a function-pointer to an object-pointer? That would be much cleaner than introducing C-style casts. What does moving the initialization of m_adjustment out of the initialization list fix? 63842 4 17822 dobey 2007-12-10 11:17:36 -0800 Created attachment 17822 Updated patch Here's an updated patch without the m_adjustment change. I just tried to get the warning again, and it's not appearing. I have no idea why. I also don't know what the warning flag would be for the ISO C++ warnings. 64010 5 17822 mjs 2007-12-12 04:56:10 -0800 Comment on attachment 17822 Updated patch r=me The C-style casts are probably not that big a deal for extreme casting like this. 64034 6 alp 2007-12-12 09:27:43 -0800 Landed in r28654 with minor style fixes (remove excess parentheses). 17775 2007-12-07 11:14:38 -0800 2007-12-10 11:17:36 -0800 Patch to fix warnings and errors webkit-sb-fix.patch text/plain 3733 dobey SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3RrL1RocmVhZGluZ0d0ay5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9wbGF0Zm9ybS9ndGsvVGhyZWFkaW5nR3RrLmNwcAkocmV2aXNpb24gMjg1MjEp CisrKyBXZWJDb3JlL3BsYXRmb3JtL2d0ay9UaHJlYWRpbmdHdGsuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0zOSw3ICszOSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogc3RhdGljIGdib29sZWFu IGNhbGxGdW5jdGlvbk9uTWFpblRocmVhZChncG9pbnRlciBkYXRhKQogewotICAgIHZvaWQgKCpm dW5jdGlvbikoKSA9IHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCgqKSgpPihkYXRhKTsKKyAgICB2b2lk ICgqZnVuY3Rpb24pKCkgPSAodm9pZCgqKSgpKShkYXRhKTsKICAgICBmdW5jdGlvbigpOwogICAg IHJldHVybiBGQUxTRTsKIH0KQEAgLTQ3LDcgKzQ3LDcgQEAgc3RhdGljIGdib29sZWFuIGNhbGxG dW5jdGlvbk9uTWFpblRocmVhZAogdm9pZCBjYWxsT25NYWluVGhyZWFkKHZvaWQgKCpmdW5jdGlv bikoKSkKIHsKICAgICBBU1NFUlQoZnVuY3Rpb24pOwotICAgIGdfdGltZW91dF9hZGQoMCwgY2Fs bEZ1bmN0aW9uT25NYWluVGhyZWFkLCByZWludGVycHJldF9jYXN0PGdwb2ludGVyPihmdW5jdGlv bikpOworICAgIGdfdGltZW91dF9hZGQoMCwgY2FsbEZ1bmN0aW9uT25NYWluVGhyZWFkLCAoZ3Bv aW50ZXIpKGZ1bmN0aW9uKSk7CiB9CiAKIHZvaWQgaW5pdGlhbGl6ZVRocmVhZGluZygpCkluZGV4 OiBXZWJDb3JlL3BsYXRmb3JtL2d0ay9QbGF0Zm9ybVNjcm9sbEJhckd0ay5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUGxhdGZvcm1TY3JvbGxCYXJHdGsuY3BwCShyZXZp c2lvbiAyODUyMSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3RrL1BsYXRmb3JtU2Nyb2xsQmFyR3Rr LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDgsOCArNDgsOSBAQCBzdGF0aWMgZ2Jvb2xlYW4gZ3Rr U2Nyb2xsRXZlbnRDYWxsYmFjayhHCiBQbGF0Zm9ybVNjcm9sbGJhcjo6UGxhdGZvcm1TY3JvbGxi YXIoU2Nyb2xsYmFyQ2xpZW50KiBjbGllbnQsIFNjcm9sbGJhck9yaWVudGF0aW9uIG9yaWVudGF0 aW9uLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFNjcm9sbGJhckNvbnRy b2xTaXplIGNvbnRyb2xTaXplKQogICAgIDogU2Nyb2xsYmFyKGNsaWVudCwgb3JpZW50YXRpb24s IGNvbnRyb2xTaXplKQotICAgICwgbV9hZGp1c3RtZW50KEdUS19BREpVU1RNRU5UKGd0a19hZGp1 c3RtZW50X25ldygwLjAsIDAuMCwgMC4wLCAwLjAsIDAuMCwgMC4wKSkpCi17IAoreworICAgIG1f YWRqdXN0bWVudCA9IEdUS19BREpVU1RNRU5UKGd0a19hZGp1c3RtZW50X25ldygwLjAsIDAuMCwg MC4wLCAwLjAsIDAuMCwgMC4wKSk7CisKICAgICBHdGtTY3JvbGxiYXIqIHNjcm9sbEJhciA9IG9y aWVudGF0aW9uID09IEhvcml6b250YWxTY3JvbGxiYXIgPwogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgR1RLX1NDUk9MTEJBUig6Omd0a19oc2Nyb2xsYmFyX25ldyhtX2FkanVzdG1lbnQp KSA6CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBHVEtfU0NST0xMQkFSKDo6Z3RrX3Zz Y3JvbGxiYXJfbmV3KG1fYWRqdXN0bWVudCkpOwpAQCAtNzMsOCArNzQsOCBAQCBQbGF0Zm9ybVNj cm9sbGJhcjo6flBsYXRmb3JtU2Nyb2xsYmFyKCkKICAgICAvKgogICAgICAqIHRoZSBXaWRnZXQg ZG9lcyBub3QgdGFrZSBvdmVyIG93bmVyc2hpcC4KICAgICAgKi8KLSAgICBnX3NpZ25hbF9oYW5k bGVyc19kaXNjb25uZWN0X2J5X2Z1bmMoR19PQkpFQ1QoZ3RrV2lkZ2V0KCkpLCByZWludGVycHJl dF9jYXN0PGdwb2ludGVyPihQbGF0Zm9ybVNjcm9sbGJhcjo6Z3RrVmFsdWVDaGFuZ2VkKSwgdGhp cyk7Ci0gICAgZ19zaWduYWxfaGFuZGxlcnNfZGlzY29ubmVjdF9ieV9mdW5jKEdfT0JKRUNUKGd0 a1dpZGdldCgpKSwgcmVpbnRlcnByZXRfY2FzdDxncG9pbnRlcj4oZ3RrU2Nyb2xsRXZlbnRDYWxs YmFjayksIHRoaXMpOworICAgIGdfc2lnbmFsX2hhbmRsZXJzX2Rpc2Nvbm5lY3RfYnlfZnVuYyhH X09CSkVDVChndGtXaWRnZXQoKSksIChncG9pbnRlcikoUGxhdGZvcm1TY3JvbGxiYXI6Omd0a1Zh bHVlQ2hhbmdlZCksIHRoaXMpOworICAgIGdfc2lnbmFsX2hhbmRsZXJzX2Rpc2Nvbm5lY3RfYnlf ZnVuYyhHX09CSkVDVChndGtXaWRnZXQoKSksIChncG9pbnRlcikoZ3RrU2Nyb2xsRXZlbnRDYWxs YmFjayksIHRoaXMpOwogICAgIGdfb2JqZWN0X3VucmVmKEdfT0JKRUNUKGd0a1dpZGdldCgpKSk7 CiB9CiAKQEAgLTEzNiw3ICsxMzcsNyBAQCB2b2lkIFBsYXRmb3JtU2Nyb2xsYmFyOjpnZW9tZXRy eUNoYW5nZWQoCiAKIHZvaWQgUGxhdGZvcm1TY3JvbGxiYXI6Omd0a1ZhbHVlQ2hhbmdlZChHdGtB ZGp1c3RtZW50KiwgUGxhdGZvcm1TY3JvbGxiYXIqIHRoYXQpCiB7Ci0gICAgdGhhdC0+c2V0VmFs dWUoZ3RrX2FkanVzdG1lbnRfZ2V0X3ZhbHVlKHRoYXQtPm1fYWRqdXN0bWVudCkpOworICAgIHRo YXQtPnNldFZhbHVlKHN0YXRpY19jYXN0PGludD4oZ3RrX2FkanVzdG1lbnRfZ2V0X3ZhbHVlKHRo YXQtPm1fYWRqdXN0bWVudCkpKTsKIH0KIAogc3RhdGljIGludCBzY3JvbGxiYXJTaXplKCkKSW5k ZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9nCShy ZXZpc2lvbiAyODUyMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMjEgQEAKKzIwMDctMTItMDcgIFJvZG5leSBEYXdlcyAgPGRvYmV5QHdheW9mdGhlbW9u a2V5LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhISkKKworICAgICAg ICBVc2UgQy1zdHlsZSBjYXN0cyBmb3IgY2FzdGluZyBmdW5jdGlvbiBwb2ludGVycyB0byBncG9p bnRlcgorICAgICAgICBJbml0aWFsaXplIG1fYWRqdXN0bWVudCBpbnNpZGUgdGhlIG1ldGhvZCBy YXRoZXIgdGhhbiB3aXRoIGEKKyAgICAgICAgQysrLXN0eWxlIGluaXRpYWxpemVyIHRvIGZpeCBh IHdhcm5pbmcKKyAgICAgICAgVXNlIHN0YXRpY19jYXN0PGludD4gdG8gY2FzdCBhIGZsb2F0IHRv IGludCB0byBmaXggYSB3YXJuaW5nCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE2MzQyCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvUGxhdGZvcm1TY3Jv bGxCYXJHdGsuY3BwOgorICAgICAgICAoUGxhdGZvcm1TY3JvbGxiYXI6OlBsYXRmb3JtU2Nyb2xs YmFyKToKKyAgICAgICAgKFBsYXRmb3JtU2Nyb2xsYmFyOjp+UGxhdGZvcm1TY3JvbGxiYXIpOgor ICAgICAgICAoUGxhdGZvcm1TY3JvbGxiYXI6Omd0a1ZhbHVlQ2hhbmdlZCk6CisgICAgICAgICog cGxhdGZvcm0vZ3RrL1RocmVhZGluZ0d0ay5jcHA6CisgICAgICAgIChjYWxsRnVuY3Rpb25Pbk1h aW5UaHJlYWQpOgorICAgICAgICAoY2FsbE9uTWFpblRocmVhZCk6CisKIDIwMDctMTItMDcgIERh cmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFudHRp IEtvaXZpc3RvIGFuZCBLZXZpbiBEZWNrZXIuCg== 17822 2007-12-10 11:17:36 -0800 2007-12-12 04:56:10 -0800 Updated patch webkit-sb-fix.patch text/plain 2922 dobey SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3RrL1RocmVhZGluZ0d0ay5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9wbGF0Zm9ybS9ndGsvVGhyZWFkaW5nR3RrLmNwcAkocmV2aXNpb24gMjg1MjEp CisrKyBXZWJDb3JlL3BsYXRmb3JtL2d0ay9UaHJlYWRpbmdHdGsuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0zOSw3ICszOSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogc3RhdGljIGdib29sZWFu IGNhbGxGdW5jdGlvbk9uTWFpblRocmVhZChncG9pbnRlciBkYXRhKQogewotICAgIHZvaWQgKCpm dW5jdGlvbikoKSA9IHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCgqKSgpPihkYXRhKTsKKyAgICB2b2lk ICgqZnVuY3Rpb24pKCkgPSAodm9pZCgqKSgpKShkYXRhKTsKICAgICBmdW5jdGlvbigpOwogICAg IHJldHVybiBGQUxTRTsKIH0KQEAgLTQ3LDcgKzQ3LDcgQEAgc3RhdGljIGdib29sZWFuIGNhbGxG dW5jdGlvbk9uTWFpblRocmVhZAogdm9pZCBjYWxsT25NYWluVGhyZWFkKHZvaWQgKCpmdW5jdGlv bikoKSkKIHsKICAgICBBU1NFUlQoZnVuY3Rpb24pOwotICAgIGdfdGltZW91dF9hZGQoMCwgY2Fs bEZ1bmN0aW9uT25NYWluVGhyZWFkLCByZWludGVycHJldF9jYXN0PGdwb2ludGVyPihmdW5jdGlv bikpOworICAgIGdfdGltZW91dF9hZGQoMCwgY2FsbEZ1bmN0aW9uT25NYWluVGhyZWFkLCAoZ3Bv aW50ZXIpKGZ1bmN0aW9uKSk7CiB9CiAKIHZvaWQgaW5pdGlhbGl6ZVRocmVhZGluZygpCkluZGV4 OiBXZWJDb3JlL3BsYXRmb3JtL2d0ay9QbGF0Zm9ybVNjcm9sbEJhckd0ay5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUGxhdGZvcm1TY3JvbGxCYXJHdGsuY3BwCShyZXZp c2lvbiAyODUyMSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3RrL1BsYXRmb3JtU2Nyb2xsQmFyR3Rr LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzMsOCArNzQsOCBAQCBQbGF0Zm9ybVNjcm9sbGJhcjo6 flBsYXRmb3JtU2Nyb2xsYmFyKCkKICAgICAvKgogICAgICAqIHRoZSBXaWRnZXQgZG9lcyBub3Qg dGFrZSBvdmVyIG93bmVyc2hpcC4KICAgICAgKi8KLSAgICBnX3NpZ25hbF9oYW5kbGVyc19kaXNj b25uZWN0X2J5X2Z1bmMoR19PQkpFQ1QoZ3RrV2lkZ2V0KCkpLCByZWludGVycHJldF9jYXN0PGdw b2ludGVyPihQbGF0Zm9ybVNjcm9sbGJhcjo6Z3RrVmFsdWVDaGFuZ2VkKSwgdGhpcyk7Ci0gICAg Z19zaWduYWxfaGFuZGxlcnNfZGlzY29ubmVjdF9ieV9mdW5jKEdfT0JKRUNUKGd0a1dpZGdldCgp KSwgcmVpbnRlcnByZXRfY2FzdDxncG9pbnRlcj4oZ3RrU2Nyb2xsRXZlbnRDYWxsYmFjayksIHRo aXMpOworICAgIGdfc2lnbmFsX2hhbmRsZXJzX2Rpc2Nvbm5lY3RfYnlfZnVuYyhHX09CSkVDVChn dGtXaWRnZXQoKSksIChncG9pbnRlcikoUGxhdGZvcm1TY3JvbGxiYXI6Omd0a1ZhbHVlQ2hhbmdl ZCksIHRoaXMpOworICAgIGdfc2lnbmFsX2hhbmRsZXJzX2Rpc2Nvbm5lY3RfYnlfZnVuYyhHX09C SkVDVChndGtXaWRnZXQoKSksIChncG9pbnRlcikoZ3RrU2Nyb2xsRXZlbnRDYWxsYmFjayksIHRo aXMpOwogICAgIGdfb2JqZWN0X3VucmVmKEdfT0JKRUNUKGd0a1dpZGdldCgpKSk7CiB9CiAKQEAg LTEzNiw3ICsxMzcsNyBAQCB2b2lkIFBsYXRmb3JtU2Nyb2xsYmFyOjpnZW9tZXRyeUNoYW5nZWQo CiAKIHZvaWQgUGxhdGZvcm1TY3JvbGxiYXI6Omd0a1ZhbHVlQ2hhbmdlZChHdGtBZGp1c3RtZW50 KiwgUGxhdGZvcm1TY3JvbGxiYXIqIHRoYXQpCiB7Ci0gICAgdGhhdC0+c2V0VmFsdWUoZ3RrX2Fk anVzdG1lbnRfZ2V0X3ZhbHVlKHRoYXQtPm1fYWRqdXN0bWVudCkpOworICAgIHRoYXQtPnNldFZh bHVlKHN0YXRpY19jYXN0PGludD4oZ3RrX2FkanVzdG1lbnRfZ2V0X3ZhbHVlKHRoYXQtPm1fYWRq dXN0bWVudCkpKTsKIH0KIAogc3RhdGljIGludCBzY3JvbGxiYXJTaXplKCkKSW5kZXg6IFdlYkNv cmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAy ODUyMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkg QEAKKzIwMDctMTItMDcgIFJvZG5leSBEYXdlcyAgPGRvYmV5QHdheW9mdGhlbW9ua2V5LmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhISkKKworICAgICAgICBVc2UgQy1z dHlsZSBjYXN0cyBmb3IgY2FzdGluZyBmdW5jdGlvbiBwb2ludGVycyB0byBncG9pbnRlcgorICAg ICAgICBVc2Ugc3RhdGljX2Nhc3Q8aW50PiB0byBjYXN0IGEgZmxvYXQgdG8gaW50IHRvIGZpeCBh IHdhcm5pbmcKKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTYzNDIKKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9QbGF0Zm9ybVNjcm9sbEJhckd0ay5jcHA6 CisgICAgICAgIChQbGF0Zm9ybVNjcm9sbGJhcjo6UGxhdGZvcm1TY3JvbGxiYXIpOgorICAgICAg ICAoUGxhdGZvcm1TY3JvbGxiYXI6On5QbGF0Zm9ybVNjcm9sbGJhcik6CisgICAgICAgIChQbGF0 Zm9ybVNjcm9sbGJhcjo6Z3RrVmFsdWVDaGFuZ2VkKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsv VGhyZWFkaW5nR3RrLmNwcDoKKyAgICAgICAgKGNhbGxGdW5jdGlvbk9uTWFpblRocmVhZCk6Cisg ICAgICAgIChjYWxsT25NYWluVGhyZWFkKToKKwogMjAwNy0xMi0wNyAgRGFyaW4gQWRsZXIgIDxk YXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW50dGkgS29pdmlzdG8gYW5k IEtldmluIERlY2tlci4K