163408 2016-10-13 15:18:33 -0700 Web Inspector: Call RuntimeAgent.disableTypeProfiler when Type Profiler is turned off 2016-11-11 12:42:07 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=163407 InRadar P2 Normal --- 1 nvasilyev nvasilyev bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1239976 0 nvasilyev 2016-10-13 15:18:33 -0700 Disabling Type Profiler by clicking the [T] button should signal the backend to stop collecting the data by calling RuntimeAgent.disableTypeProfiler method. RuntimeAgent.disableTypeProfiler is currently unused. 1239977 1 webkit-bug-importer 2016-10-13 15:18:53 -0700 <rdar://problem/28764269> 1249881 2 nvasilyev 2016-11-10 11:38:16 -0800 There's a comment in _setTypeTokenAnnotatorEnabledState method: // Because we disable type profiling when exiting the inspector, there is no need to call // RuntimeAgent.disableTypeProfiler() here. If we were to call it here, JavaScriptCore would // compile out all the necessary type profiling information, so if a user were to quickly press then // unpress the type profiling button, we wouldn't be able to re-show type information which would // provide a confusing user experience. Sometimes I disable Type Profiler to read code with less distractions and then turn it back on. Unlike Code Coverage, enabling Type Profiler adds tokens that take up space. I think it makes a lot of sense to call RuntimeAgent.disableControlFlowProfiler() when turning off Code Coverage by clicking [C] icon. Disabling Type Profiler, however, has drawbacks. Any opinions? 1250329 3 294517 nvasilyev 2016-11-11 12:03:49 -0800 Created attachment 294517 Patch Here's a patch that makes Type Profiler consistent with Code Coverage. 1250342 4 294517 commit-queue 2016-11-11 12:42:03 -0800 Comment on attachment 294517 Patch Clearing flags on attachment: 294517 Committed r208604: <http://trac.webkit.org/changeset/208604> 1250343 5 commit-queue 2016-11-11 12:42:07 -0800 All reviewed patches have been landed. Closing bug. 294517 2016-11-11 12:03:49 -0800 2016-11-11 12:42:03 -0800 Patch patch.txt text/plain 2197 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDI1OWI1ZmQuLjJlMDVjY2EgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE2LTExLTExICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgogCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IENhbGwg UnVudGltZUFnZW50LmRpc2FibGVDb250cm9sRmxvd1Byb2ZpbGVyIHdoZW4gQ29kZSBDb3ZlcmFn ZSBQcm9maWxlciBpcyB0dXJuZWQgb2ZmCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNjM0MDcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI4NzY0MjMw PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFR1cm5p bmcgVHlwZSBQcm9maWxlciBvZmYgYnkgY2xpY2tpbmcgW1RdIGljb24gbm93IGRpc2FibGVzIGl0 cyBiYWNrZW5kIGJ5IGNhbGxpbmcgUnVudGltZUFnZW50LmRpc2FibGVUeXBlUHJvZmlsZXIoKS4K KworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvU291cmNlQ29kZVRleHRFZGl0b3IuanM6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuU291cmNlQ29kZVRleHRFZGl0b3IucHJvdG90eXBlLl9z ZXRUeXBlVG9rZW5Bbm5vdGF0b3JFbmFibGVkU3RhdGUpOgorCisyMDE2LTExLTExICBOaWtpdGEg VmFzaWx5ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6 IFNldHRpbmdzIHRhYjogbWFrZSB0aGUgaGVhZGVyIHNtYWxsZXIgdG8gZml0IG1vcmUgY29udGVu dAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY0NjEz CiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yOTIwNjAwNz4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZUNvZGVUZXh0RWRpdG9yLmpz IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU291cmNlQ29kZVRl eHRFZGl0b3IuanMKaW5kZXggMGM0MjQ1Yi4uOGFiNTg5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU291cmNlQ29kZVRleHRFZGl0b3IuanMK KysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU291cmNlQ29k ZVRleHRFZGl0b3IuanMKQEAgLTE4NzYsMTIgKzE4NzYsNyBAQCBXZWJJbnNwZWN0b3IuU291cmNl Q29kZVRleHRFZGl0b3IgPSBjbGFzcyBTb3VyY2VDb2RlVGV4dEVkaXRvciBleHRlbmRzIFdlYklu c3BlYwogICAgICAgICAgICAgaWYgKCF0aGlzLl90eXBlVG9rZW5TY3JvbGxIYW5kbGVyKQogICAg ICAgICAgICAgICAgIHRoaXMuX2VuYWJsZVNjcm9sbEV2ZW50c0ZvclR5cGVUb2tlbkFubm90YXRv cigpOwogICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgLy8gQmVjYXVzZSB3ZSBkaXNhYmxl IHR5cGUgcHJvZmlsaW5nIHdoZW4gZXhpdGluZyB0aGUgaW5zcGVjdG9yLCB0aGVyZSBpcyBubyBu ZWVkIHRvIGNhbGwKLSAgICAgICAgICAgIC8vIFJ1bnRpbWVBZ2VudC5kaXNhYmxlVHlwZVByb2Zp bGVyKCkgaGVyZS4gIElmIHdlIHdlcmUgdG8gY2FsbCBpdCBoZXJlLCBKYXZhU2NyaXB0Q29yZSB3 b3VsZAotICAgICAgICAgICAgLy8gY29tcGlsZSBvdXQgYWxsIHRoZSBuZWNlc3NhcnkgdHlwZSBw cm9maWxpbmcgaW5mb3JtYXRpb24sIHNvIGlmIGEgdXNlciB3ZXJlIHRvIHF1aWNrbHkgcHJlc3Mg dGhlbgotICAgICAgICAgICAgLy8gdW5wcmVzcyB0aGUgdHlwZSBwcm9maWxpbmcgYnV0dG9uLCB3 ZSB3b3VsZG4ndCBiZSBhYmxlIHRvIHJlLXNob3cgdHlwZSBpbmZvcm1hdGlvbiB3aGljaCB3b3Vs ZAotICAgICAgICAgICAgLy8gcHJvdmlkZSBhIGNvbmZ1c2luZyB1c2VyIGV4cGVyaWVuY2UuCi0K KyAgICAgICAgICAgIFJ1bnRpbWVBZ2VudC5kaXNhYmxlVHlwZVByb2ZpbGVyKCk7CiAgICAgICAg ICAgICB0aGlzLl90eXBlVG9rZW5Bbm5vdGF0b3IuY2xlYXIoKTsKIAogICAgICAgICAgICAgaWYg KHRoaXMuX3R5cGVUb2tlblNjcm9sbEhhbmRsZXIpCg==