163405 2016-10-13 15:03:40 -0700 Uncaught Exception: TypeError: this.positionToOffset is not a function - seen hovering expressions with Type Profiler enabled 2016-10-14 00:12:42 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue joepeck mattbaker nvasilyev saam timothy webkit-bug-importer oldest_to_newest 1239967 0 joepeck 2016-10-13 15:03:40 -0700 * STEPS TO REPRODUCE 1. Enable Type Profiler 2. Attempt to get type details hovering an sub-expression like "obj.foo" => Error dialog ------- Uncaught Exceptions: - TypeError: this.positionToOffset is not a function. (In 'this.positionToOffset({line: range.start.line, ch: range.start.ch})', 'this.positionToOffset' is undefined) (at SourceCodeTextEditor.js:1523:43) _tokenTrackingControllerHighlightedJavaScriptTypeInformation @ SourceCodeTextEditor.js:1523:43 tokenTrackingControllerNewHighlightCandidate @ SourceCodeTextEditor.js:1454:78 _processNewHoveredToken @ CodeMirrorTokenTrackingController.js:448:72 _processNewHoveredToken @ [native code] ------- 1239969 1 webkit-bug-importer 2016-10-13 15:04:24 -0700 <rdar://problem/28763953> 1239970 2 nvasilyev 2016-10-13 15:06:43 -0700 Could you attach file:///Users/pecoraro/Desktop/control-flow.html? :) 1239971 3 291524 joepeck 2016-10-13 15:10:26 -0700 Created attachment 291524 [PATCH] Proposed Fix 1240140 4 291524 commit-queue 2016-10-14 00:12:38 -0700 Comment on attachment 291524 [PATCH] Proposed Fix Clearing flags on attachment: 291524 Committed r207329: <http://trac.webkit.org/changeset/207329> 1240141 5 commit-queue 2016-10-14 00:12:42 -0700 All reviewed patches have been landed. Closing bug. 291524 2016-10-13 15:10:26 -0700 2016-10-14 00:12:38 -0700 [PATCH] Proposed Fix fix-1.patch text/plain 1830 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGJmYmI2OGYuLjRkNmYyYWQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE2LTEwLTEzICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgVW5jYXVnaHQgRXhjZXB0aW9uOiBU eXBlRXJyb3I6IHRoaXMucG9zaXRpb25Ub09mZnNldCBpcyBub3QgYSBmdW5jdGlvbiAtIHNlZW4g aG92ZXJpbmcgZXhwcmVzc2lvbnMgd2l0aCBUeXBlIFByb2ZpbGVyIGVuYWJsZWQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MzQwNQorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vMjg3NjM5NTM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZUNvZGVUZXh0RWRp dG9yLmpzOgorICAgICAgICBVc2UgY29ycmVjdCBtZXRob2QgbmFtZSwgdGhlIG9sZCBvbmUgbXVz dCBoYXZlIGdvbmUgYXdheS4KKworMjAxNi0xMC0xMyAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jh cm9AYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IERyYWdnaW5nIHRvIGRlbGV0 ZSBhIEJyZWFrcG9pbnQgc2hvdWxkIG5ldmVyIHRyaWdnZXIgYSBDb250ZW50VmlldyBjaGFuZ2UK ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MzQwMwog ICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjg3NjI5MzA+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Tb3VyY2VDb2RlVGV4dEVkaXRvci5qcyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZUNvZGVUZXh0 RWRpdG9yLmpzCmluZGV4IGVlODc2MjYuLjM2YzQ2ZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZUNvZGVUZXh0RWRpdG9yLmpzCisr KyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZUNvZGVU ZXh0RWRpdG9yLmpzCkBAIC0xNTIwLDcgKzE1MjAsNyBAQCBXZWJJbnNwZWN0b3IuU291cmNlQ29k ZVRleHRFZGl0b3IgPSBjbGFzcyBTb3VyY2VDb2RlVGV4dEVkaXRvciBleHRlbmRzIFdlYkluc3Bl YwogICAgICAgICB2YXIgc291cmNlQ29kZSA9IHRoaXMuX3NvdXJjZUNvZGU7CiAgICAgICAgIHZh ciBzb3VyY2VJRCA9IHNvdXJjZUNvZGUgaW5zdGFuY2VvZiBXZWJJbnNwZWN0b3IuU2NyaXB0ID8g c291cmNlQ29kZS5pZCA6IHNvdXJjZUNvZGUuc2NyaXB0c1swXS5pZDsKICAgICAgICAgdmFyIHJh bmdlID0gY2FuZGlkYXRlLmhvdmVyZWRUb2tlblJhbmdlOwotICAgICAgICB2YXIgb2Zmc2V0ID0g dGhpcy5wb3NpdGlvblRvT2Zmc2V0KHtsaW5lOiByYW5nZS5zdGFydC5saW5lLCBjaDogcmFuZ2Uu c3RhcnQuY2h9KTsKKyAgICAgICAgdmFyIG9mZnNldCA9IHRoaXMuY3VycmVudFBvc2l0aW9uVG9P cmlnaW5hbE9mZnNldChyYW5nZS5zdGFydCk7CiAKICAgICAgICAgdmFyIGFsbFJlcXVlc3RzID0g W3sKICAgICAgICAgICAgIHR5cGVJbmZvcm1hdGlvbkRlc2NyaXB0b3I6IFdlYkluc3BlY3Rvci5T Y3JpcHRTeW50YXhUcmVlLlR5cGVQcm9maWxlclNlYXJjaERlc2NyaXB0b3IuTm9ybWFsRXhwcmVz c2lvbiwK