163395 2016-10-13 11:00:56 -0700 Web Inspector: Unused Breakpoint getter/setter for "id" - should be "identifier" 2016-10-14 15:27:51 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1239840 0 joepeck 2016-10-13 11:00:56 -0700 Unused Breakpoint getter/setter for "id" - should be "identifier". Nobody gets or sets "breakpoint.id" only DebuggerManager gets + sets "breakpoint.identifier". Rename to match usage. 1239842 1 291497 joepeck 2016-10-13 11:02:20 -0700 Created attachment 291497 [PATCH] Proposed Fix 1240433 2 291497 commit-queue 2016-10-14 15:27:48 -0700 Comment on attachment 291497 [PATCH] Proposed Fix Clearing flags on attachment: 291497 Committed r207356: <http://trac.webkit.org/changeset/207356> 1240434 3 commit-queue 2016-10-14 15:27:51 -0700 All reviewed patches have been landed. Closing bug. 291497 2016-10-13 11:02:20 -0700 2016-10-14 15:27:48 -0700 [PATCH] Proposed Fix breakpoint-1.patch text/plain 1528 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGRkZmY1NWQuLjJlMzQyODAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTEwLTEzICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVW51c2Vk IEJyZWFrcG9pbnQgZ2V0dGVyL3NldHRlciBmb3IgImlkIiAtIHNob3VsZCBiZSAiaWRlbnRpZmll ciIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MzM5 NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNl ckludGVyZmFjZS9Nb2RlbHMvQnJlYWtwb2ludC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5C cmVha3BvaW50LnByb3RvdHlwZS5nZXQgaWRlbnRpZmllcik6IFJlbmFtZWQuCisgICAgICAgIChX ZWJJbnNwZWN0b3IuQnJlYWtwb2ludC5wcm90b3R5cGUuc2V0IGlkZW50aWZpZXIpOiBSZW5hbWVk LgorICAgICAgICBUaGUgb25seSB1c2VyIGlzIERlYnVnZ2VyTWFuYWdlciB3aGljaCBzZXRzIGFu ZCBnZXRzLiBQcmV2aW91c2x5CisgICAgICAgIGl0IHdhcyB1bmV4cGVjdGVkbHkgc2V0dGluZyBh IGRpcmVjdCBwcm9wZXJ0eSBvbiB0aGUgQnJlYWtwb2ludAorICAgICAgICBpbnN0ZWFkIG9mIHVz aW5nIHRoZXNlIG1ldGhvZHMgdG8gc2V0IHRoZSBtZW1iZXIgdmFyaWFibGUuCisKIDIwMTYtMTAt MTIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIg SW5zcGVjdG9yOiBSZW1vdmUgdXNlcyBvZiBkZWxldGUgaW4gU291cmNlQ29kZVRleHRFZGl0b3IK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9C cmVha3BvaW50LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxz L0JyZWFrcG9pbnQuanMKaW5kZXggNDA5MGI3My4uZjAyZjdkZiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0JyZWFrcG9pbnQuanMKKysrIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0JyZWFrcG9pbnQuanMK QEAgLTY3LDEyICs2NywxMiBAQCBXZWJJbnNwZWN0b3IuQnJlYWtwb2ludCA9IGNsYXNzIEJyZWFr cG9pbnQgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuT2JqZWN0CiAKICAgICAvLyBQdWJsaWMKIAotICAg IGdldCBpZCgpCisgICAgZ2V0IGlkZW50aWZpZXIoKQogICAgIHsKICAgICAgICAgcmV0dXJuIHRo aXMuX2lkOwogICAgIH0KIAotICAgIHNldCBpZChpZCkKKyAgICBzZXQgaWRlbnRpZmllcihpZCkK ICAgICB7CiAgICAgICAgIHRoaXMuX2lkID0gaWQgfHwgbnVsbDsKICAgICB9Cg==