163393 2016-10-13 10:18:25 -0700 REGRESSION(r206189): logs error statements when API::URLRequest is canceled 2016-10-17 10:51:59 -0700 1 1 1 Unclassified WebKit WebKit2 Other PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply commit-queue koivisto krollin mcatanzaro oldest_to_newest 1239820 0 mcatanzaro 2016-10-13 10:18:25 -0700 r206189 "Add new logging for network resource loading" added a new error in WebLoaderStrategy::loadResource: RELEASE_LOG_ERROR_IF_ALLOWED(frame, "loadResource: Unable to create SubresourceLoader (frame = %p", &frame); However, this error statement is hit during normal operation when there is no error, whenever a load is canceled by changing the URL of an API::URLRequest to NULL during a willSendRequestForFrame callback (see InjectedBundlePageResourceLoadClient::willSendRequestForFrame). For example, the error statement is printed once each time Epiphany's adblocker blocks an ad. Either (a) WebLoaderStrategy::loadResource should never be called when the load has already been canceled, or (b) WebLoaderStrategy::loadResource should not print an error in this case. Not sure which way is correct, but I don't plan to investigate (a) so here is a patch to do (b). 1239822 1 291489 mcatanzaro 2016-10-13 10:19:49 -0700 Created attachment 291489 Patch 1239833 2 krollin 2016-10-13 10:35:20 -0700 Makes sense to me. Looking deeper, I can see that there are many checks in the creation of a SubresourceLoader that could cause it to return false/null. Adding Antti, who reviewed the original patch. 1241015 3 291489 commit-queue 2016-10-17 10:51:56 -0700 Comment on attachment 291489 Patch Clearing flags on attachment: 291489 Committed r207414: <http://trac.webkit.org/changeset/207414> 1241017 4 commit-queue 2016-10-17 10:51:59 -0700 All reviewed patches have been landed. Closing bug. 291489 2016-10-13 10:19:49 -0700 2016-10-17 10:51:56 -0700 Patch bug-163393-20161013121623.patch text/plain 1635 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3Mjg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTY0MjVmZTc3YjFmZGVh ZDFlZTVlZmE0YzY0NTNkYThjNWM4ZTg2My4uMWRhNTljZTMxZmU1NzRlNzUwZGFjZWY3ZTY1Yjc1 YTRhNWJiZGI2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTEwLTEzICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNT SU9OKHIyMDYxODkpOiBsb2dzIGVycm9yIHN0YXRlbWVudHMgd2hlbiBBUEk6OlVSTFJlcXVlc3Qg aXMgY2FuY2VsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE2MzM5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFByaW50IHRoaXMgY2FzZSBhdCBub3JtYWwgbG9nZ2luZyBsZXZlbCwgbm90IGFzIGFuIGVy cm9yLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYkxvYWRlclN0cmF0ZWd5LmNw cDoKKyAgICAgICAgKFdlYktpdDo6V2ViTG9hZGVyU3RyYXRlZ3k6OmxvYWRSZXNvdXJjZSk6CisK IDIwMTYtMTAtMTIgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBb V2ViIElETF0gRHJvcCBzdXBwb3J0IGZvciBsZWdhY3kgW0NvbnN0cnVjdG9yQ29uZGl0aW9uYWw9 Kl0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvTmV0d29yay9XZWJMb2Fk ZXJTdHJhdGVneS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05ldHdvcmsvV2ViTG9h ZGVyU3RyYXRlZ3kuY3BwCmluZGV4IDUzZWQ1MzZlMGRhMTIxZGZhMzRiY2E1NGE1MDJmMWU3ZTZl MjlkMGYuLjllNjQwY2RiMjRjOGRmNDBhNDUzMjA2OWM0YTY0OWZhZWViYzAxY2MgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvTmV0d29yay9XZWJMb2FkZXJTdHJhdGVneS5j cHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYkxvYWRlclN0cmF0 ZWd5LmNwcApAQCAtNzcsNyArNzcsNyBAQCBSZWZQdHI8U3VicmVzb3VyY2VMb2FkZXI+IFdlYkxv YWRlclN0cmF0ZWd5Ojpsb2FkUmVzb3VyY2UoRnJhbWUmIGZyYW1lLCBDYWNoZWRSZQogICAgIGlm IChsb2FkZXIpCiAgICAgICAgIHNjaGVkdWxlTG9hZCgqbG9hZGVyLCAmcmVzb3VyY2UsIGZyYW1l LmRvY3VtZW50KCktPnJlZmVycmVyUG9saWN5KCkgPT0gUmVmZXJyZXJQb2xpY3k6OkRlZmF1bHQp OwogICAgIGVsc2UKLSAgICAgICAgUkVMRUFTRV9MT0dfRVJST1JfSUZfQUxMT1dFRChmcmFtZSwg ImxvYWRSZXNvdXJjZTogVW5hYmxlIHRvIGNyZWF0ZSBTdWJyZXNvdXJjZUxvYWRlciAoZnJhbWUg PSAlcCIsICZmcmFtZSk7CisgICAgICAgIFJFTEVBU0VfTE9HX0lGX0FMTE9XRUQoZnJhbWUsICJs b2FkUmVzb3VyY2U6IFVuYWJsZSB0byBjcmVhdGUgU3VicmVzb3VyY2VMb2FkZXIgKGZyYW1lID0g JXAiLCAmZnJhbWUpOwogICAgIHJldHVybiBsb2FkZXI7CiB9CiAK