163392 2016-10-13 09:48:03 -0700 [SOUP] SHOULD NEVER BE REACHED ../../Source/WebCore/platform/URL.cpp(1291) : void WebCore::URL::parse(const WTF::String&) 2016-10-13 11:14:11 -0700 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED P2 Blocker --- 1 mcatanzaro mcatanzaro achristensen bugs-noreply commit-queue mcatanzaro oldest_to_newest 1239800 0 mcatanzaro 2016-10-13 09:48:03 -0700 Since URLParser was enabled, the network process crashes when loading any URL: SHOULD NEVER BE REACHED ../../Source/WebCore/platform/URL.cpp(1291) : void WebCore::URL::parse(const WTF::String&) 1 0x7f4e5f306696 /home/mcatanzaro/src/jhbuild/install/lib/libjavascriptcoregtk-4.0.so.18(WTFCrash+0x1e) [0x7f4e5f306696] 2 0x7f4e666011db /home/mcatanzaro/src/jhbuild/install/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore3URL5parseERKN3WTF6StringE+0x45) [0x7f4e666011db] 3 0x7f4e66e9fd7f /home/mcatanzaro/src/jhbuild/install/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore3URLC2EP8_SoupURI+0x89) [0x7f4e66e9fd7f] 4 0x7f4e66e98cbd /home/mcatanzaro/src/jhbuild/install/lib/libwebkit2gtk-4.0.so.37(_ZN7WebCore16ResourceResponse21updateFromSoupMessageEP12_SoupMessage+0x3b) [0x7f4e66e98cbd] 5 0x7f4e66e90eb1 /home/mcatanzaro/src/jhbuild/install/lib/libwebkit2gtk-4.0.so.37(+0x698feb1) [0x7f4e66e90eb1] 6 0x7f4e577548f1 /home/mcatanzaro/src/jhbuild/install/lib/libgobject-2.0.so.0(g_cclosure_marshal_VOID__VOID+0xc2) [0x7f4e577548f1] 7 0x7f4e577518da /home/mcatanzaro/src/jhbuild/install/lib/libgobject-2.0.so.0(g_closure_invoke+0x18a) [0x7f4e577518da] 8 0x7f4e5776dcbe /home/mcatanzaro/src/jhbuild/install/lib/libgobject-2.0.so.0(+0x2ccbe) [0x7f4e5776dcbe] 9 0x7f4e5776d00c /home/mcatanzaro/src/jhbuild/install/lib/libgobject-2.0.so.0(g_signal_emit_valist+0x117b) [0x7f4e5776d00c] 10 0x7f4e5776d54e /home/mcatanzaro/src/jhbuild/install/lib/libgobject-2.0.so.0(g_signal_emit+0xa6) [0x7f4e5776d54e] 11 0x7f4e567438b4 /home/mcatanzaro/src/jhbuild/install/lib/libsoup-2.4.so.1(soup_message_got_headers+0x2a) [0x7f4e567438b4] 12 0x7f4e56749dcd /home/mcatanzaro/src/jhbuild/install/lib/libsoup-2.4.so.1(+0x7cdcd) [0x7f4e56749dcd] 13 0x7f4e5674a986 /home/mcatanzaro/src/jhbuild/install/lib/libsoup-2.4.so.1(+0x7d986) [0x7f4e5674a986] 14 0x7f4e5674aeff /home/mcatanzaro/src/jhbuild/install/lib/libsoup-2.4.so.1(+0x7deff) [0x7f4e5674aeff] 15 0x7f4e5675fd56 /home/mcatanzaro/src/jhbuild/install/lib/libsoup-2.4.so.1(+0x92d56) [0x7f4e5675fd56] 16 0x7f4e5675fd12 /home/mcatanzaro/src/jhbuild/install/lib/libsoup-2.4.so.1(+0x92d12) [0x7f4e5675fd12] 17 0x7f4e5674a202 /home/mcatanzaro/src/jhbuild/install/lib/libsoup-2.4.so.1(+0x7d202) [0x7f4e5674a202] 18 0x7f4e5746a1ee /home/mcatanzaro/src/jhbuild/install/lib/libglib-2.0.so.0(+0x541ee) [0x7f4e5746a1ee] 19 0x7f4e5746b070 /home/mcatanzaro/src/jhbuild/install/lib/libglib-2.0.so.0(g_main_context_dispatch+0x33) [0x7f4e5746b070] 20 0x7f4e5746b254 /home/mcatanzaro/src/jhbuild/install/lib/libglib-2.0.so.0(+0x55254) [0x7f4e5746b254] 21 0x7f4e5746b67a /home/mcatanzaro/src/jhbuild/install/lib/libglib-2.0.so.0(g_main_loop_run+0x1d5) [0x7f4e5746b67a] 22 0x7f4e5f3692c4 /home/mcatanzaro/src/jhbuild/install/lib/libjavascriptcoregtk-4.0.so.18(_ZN3WTF7RunLoop3runEv+0xac) [0x7f4e5f3692c4] 23 0x7f4e6550ab74 /home/mcatanzaro/src/jhbuild/install/lib/libwebkit2gtk-4.0.so.37(_ZN6WebKit16ChildProcessMainINS_14NetworkProcessENS_20ChildProcessMainBaseEEEiiPPc+0x87) [0x7f4e6550ab74] 24 0x7f4e6550aadc /home/mcatanzaro/src/jhbuild/install/lib/libwebkit2gtk-4.0.so.37(NetworkProcessMainUnix+0x20) [0x7f4e6550aadc] 25 0x400c2a /home/mcatanzaro/src/jhbuild/install/libexec/webkit2gtk-4.0/WebKitNetworkProcess(main+0x34) [0x400c2a] 26 0x7f4e52431731 /lib64/libc.so.6(__libc_start_main+0xf1) [0x7f4e52431731] 27 0x400b29 /home/mcatanzaro/src/jhbuild/install/libexec/webkit2gtk-4.0/WebKitNetworkProcess(_start+0x29) [0x400b29] 1239808 1 mcatanzaro 2016-10-13 09:57:51 -0700 Since URLParser is unconditionally enabled now, and all the non-URLParser codepaths are dead code, I suggest cleaning this up properly, but for now here is the fix to make soup ports work again. 1239810 2 291487 mcatanzaro 2016-10-13 09:59:05 -0700 Created attachment 291487 Patch 1239819 3 achristensen 2016-10-13 10:17:44 -0700 Sorry about that :( 1239851 4 291487 commit-queue 2016-10-13 11:14:07 -0700 Comment on attachment 291487 Patch Clearing flags on attachment: 291487 Committed r207293: <http://trac.webkit.org/changeset/207293> 1239852 5 commit-queue 2016-10-13 11:14:11 -0700 All reviewed patches have been landed. Closing bug. 291487 2016-10-13 09:59:05 -0700 2016-10-13 11:14:07 -0700 Patch bug-163392-20161013115539.patch text/plain 1604 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3Mjg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTRmOTlkOTVlMGRmYjI0 NDA4YWEwNGUyMmRlODU5ZmU2Y2M0M2NmMi4uZWViNDBlYmE3MjZkYzdlOTEzNjNhOGY1YzNjY2Ex NTczYWI1OTdkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTEwLTEzICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbU09VUF0g U0hPVUxEIE5FVkVSIEJFIFJFQUNIRUQgLi4vLi4vU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVVJM LmNwcCgxMjkxKSA6IHZvaWQgV2ViQ29yZTo6VVJMOjpwYXJzZShjb25zdCBXVEY6OlN0cmluZyYp CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjMzOTIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggdGhl IFVSTCBjb25zdHJ1Y3RvciB0byB3b3JrIHdpdGggVVJMUGFyc2VyLgorCisgICAgICAgICogcGxh dGZvcm0vc291cC9VUkxTb3VwLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlVSTDo6VVJMKToKKwog MjAxNi0xMC0xMyAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAg U2hhcmUgaW5saW5lIHN0eWxlc2hlZXRzIGJldHdlZW4gc2hhZG93IHRyZWVzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9zb3VwL1VSTFNvdXAuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vc291cC9VUkxTb3VwLmNwcAppbmRleCAwNjQwOTBkNjM5NjI2YjZhZTg5NTFl YWQ3ZmQ0OTU1YWEyYTg1NDY5Li43YTczMWFlMTQyNmUyNjQ1MDY2MjBkM2QzZDA0ZTUyN2I3YTJm M2NiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9zb3VwL1VSTFNvdXAuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3NvdXAvVVJMU291cC5jcHAKQEAgLTI5LDYg KzI5LDcgQEAKIAogI2luY2x1ZGUgIlVSTC5oIgogCisjaW5jbHVkZSAiVVJMUGFyc2VyLmgiCiAj aW5jbHVkZSA8bGlic291cC9zb3VwLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvQ1N0cmluZy5oPgog CkBAIC00Miw3ICs0MywxMiBAQCBVUkw6OlVSTChTb3VwVVJJKiBzb3VwVVJJKQogICAgIH0KIAog ICAgIEdVbmlxdWVQdHI8Z2NoYXI+IHVybFN0cmluZyhzb3VwX3VyaV90b19zdHJpbmcoc291cFVS SSwgRkFMU0UpKTsKLSAgICBwYXJzZShTdHJpbmc6OmZyb21VVEY4KHVybFN0cmluZy5nZXQoKSkp OworICAgIGlmIChVUkxQYXJzZXI6OmVuYWJsZWQoKSkgeworICAgICAgICBVUkxQYXJzZXIgcGFy c2VyKFN0cmluZzo6ZnJvbVVURjgodXJsU3RyaW5nLmdldCgpKSk7CisgICAgICAgICp0aGlzID0g cGFyc2VyLnJlc3VsdCgpOworICAgIH0gZWxzZQorICAgICAgICBwYXJzZShTdHJpbmc6OmZyb21V VEY4KHVybFN0cmluZy5nZXQoKSkpOworCiAgICAgaWYgKCFpc1ZhbGlkKCkpCiAgICAgICAgIHJl dHVybjsKIAo=