163379 2016-10-12 22:05:18 -0700 Web Inspector: Remove uses of delete in SourceCodeTextEditor 2016-10-14 15:13:36 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1239689 0 joepeck 2016-10-12 22:05:18 -0700 Summary: Remove uses of delete in SourceCodeTextEditor One of the uses was deleting the wrong thing. 1239690 1 291455 joepeck 2016-10-12 22:12:30 -0700 Created attachment 291455 [PATCH] Proposed Fix 1240426 2 291455 commit-queue 2016-10-14 15:13:33 -0700 Comment on attachment 291455 [PATCH] Proposed Fix Clearing flags on attachment: 291455 Committed r207354: <http://trac.webkit.org/changeset/207354> 1240427 3 commit-queue 2016-10-14 15:13:36 -0700 All reviewed patches have been landed. Closing bug. 291455 2016-10-12 22:12:30 -0700 2016-10-14 15:13:33 -0700 [PATCH] Proposed Fix delete-1.patch text/plain 5693 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGJlYTY3MTguLmRkZmY1NWQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDE2LTEwLTEyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVtb3Zl IHVzZXMgb2YgZGVsZXRlIGluIFNvdXJjZUNvZGVUZXh0RWRpdG9yCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjMzNzkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgdXNlcyBvZiBkZWxldGUgYW5k IGJldHRlciBncm91cCBtZW1iZXIgdmFyaWFibGVzLgorICAgICAgICBPbmUgb2YgdGhlIGRlbGV0 ZXMgd2FzIGRlbGV0aW5nIGFuIGluY29ycmVjdCBwcm9wZXJ0eS4KKworICAgICAgICAqIFVzZXJJ bnRlcmZhY2UvVmlld3MvU291cmNlQ29kZVRleHRFZGl0b3IuanM6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuU291cmNlQ29kZVRleHRFZGl0b3IpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNvdXJj ZUNvZGVUZXh0RWRpdG9yLnByb3RvdHlwZS50ZXh0RWRpdG9yQnJlYWtwb2ludEFkZGVkKToKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5Tb3VyY2VDb2RlVGV4dEVkaXRvci5wcm90b3R5cGUudGV4dEVk aXRvckJyZWFrcG9pbnRSZW1vdmVkKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Tb3VyY2VDb2Rl VGV4dEVkaXRvci5wcm90b3R5cGUudGV4dEVkaXRvckJyZWFrcG9pbnRNb3ZlZCk6CisgICAgICAg IChXZWJJbnNwZWN0b3IuU291cmNlQ29kZVRleHRFZGl0b3IucHJvdG90eXBlLl90b2tlblRyYWNr aW5nQ29udHJvbGxlckhpZ2hsaWdodGVkTWFya2VkRXhwcmVzc2lvbik6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuU291cmNlQ29kZVRleHRFZGl0b3IucHJvdG90eXBlLl9kaXNtaXNzRWRpdGluZ0Nv bnRyb2xsZXIpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNvdXJjZUNvZGVUZXh0RWRpdG9yLnBy b3RvdHlwZS5lZGl0aW5nQ29udHJvbGxlckRpZEZpbmlzaEVkaXRpbmcpOgorCisyMDE2LTEwLTEy ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIElu c3BlY3RvcjogSW1wcm92ZSBzdXBwb3J0IGZvciBsb2dnaW5nIFByb3h5IG9iamVjdHMgaW4gY29u c29sZQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYz MzIzCiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yODQzMjU1Mz4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZUNvZGVUZXh0RWRpdG9y LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU291cmNlQ29k ZVRleHRFZGl0b3IuanMKaW5kZXggYTc4MjkwOC4uYzU2MTAyMSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU291cmNlQ29kZVRleHRFZGl0b3Iu anMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU291cmNl Q29kZVRleHRFZGl0b3IuanMKQEAgLTM5LDE3ICszOSwyMyBAQCBXZWJJbnNwZWN0b3IuU291cmNl Q29kZVRleHRFZGl0b3IgPSBjbGFzcyBTb3VyY2VDb2RlVGV4dEVkaXRvciBleHRlbmRzIFdlYklu c3BlYwogICAgICAgICB0aGlzLl93aWRnZXRNYXAgPSBuZXcgTWFwOwogICAgICAgICB0aGlzLl9j b250ZW50UG9wdWxhdGVkID0gZmFsc2U7CiAgICAgICAgIHRoaXMuX2ludmFsaWRMaW5lTnVtYmVy cyA9IHswOiB0cnVlfTsKLSAgICAgICAgdGhpcy5faWdub3JlQ29udGVudERpZENoYW5nZSA9IDA7 CiAgICAgICAgIHRoaXMuX3JlcXVlc3RpbmdTY3JpcHRDb250ZW50ID0gZmFsc2U7CiAgICAgICAg IHRoaXMuX2FjdGl2ZUNhbGxGcmFtZVNvdXJjZUNvZGVMb2NhdGlvbiA9IG51bGw7CiAKICAgICAg ICAgdGhpcy5fdHlwZVRva2VuU2Nyb2xsSGFuZGxlciA9IG51bGw7CiAgICAgICAgIHRoaXMuX3R5 cGVUb2tlbkFubm90YXRvciA9IG51bGw7CiAgICAgICAgIHRoaXMuX2Jhc2ljQmxvY2tBbm5vdGF0 b3IgPSBudWxsOworICAgICAgICB0aGlzLl9lZGl0aW5nQ29udHJvbGxlciA9IG51bGw7CiAKICAg ICAgICAgdGhpcy5fYXV0b0Zvcm1hdCA9IGZhbHNlOwogICAgICAgICB0aGlzLl9pc1Byb2JhYmx5 TWluaWZpZWQgPSBmYWxzZTsKIAorICAgICAgICB0aGlzLl9pZ25vcmVDb250ZW50RGlkQ2hhbmdl ID0gMDsKKyAgICAgICAgdGhpcy5faWdub3JlTG9jYXRpb25VcGRhdGVCcmVha3BvaW50ID0gbnVs bDsKKyAgICAgICAgdGhpcy5faWdub3JlQnJlYWtwb2ludEFkZGVkQnJlYWtwb2ludCA9IG51bGw7 CisgICAgICAgIHRoaXMuX2lnbm9yZUJyZWFrcG9pbnRSZW1vdmVkQnJlYWtwb2ludCA9IG51bGw7 CisgICAgICAgIHRoaXMuX2lnbm9yZUFsbEJyZWFrcG9pbnRMb2NhdGlvblVwZGF0ZXMgPSBmYWxz ZTsKKwogICAgICAgICAvLyBGSVhNRTogQ3VycmVudGx5IHRoaXMganVzdCBqdW1wcyBiZXR3ZWVu IHJlc291cmNlcyBhbmQgcmVsYXRlZCBzb3VyY2UgbWFwIHJlc291cmNlcy4gSXQgZG9lc24ndCAi anVtcCB0byBzeW1ib2wiIHlldC4KICAgICAgICAgdGhpcy5fdXBkYXRlVG9rZW5UcmFja2luZ0Nv bnRyb2xsZXJTdGF0ZSgpOwogCkBAIC0xMDk4LDExICsxMTA0LDEwIEBAIFdlYkluc3BlY3Rvci5T b3VyY2VDb2RlVGV4dEVkaXRvciA9IGNsYXNzIFNvdXJjZUNvZGVUZXh0RWRpdG9yIGV4dGVuZHMg V2ViSW5zcGVjCiAgICAgICAgIHRoaXMuX2FkZEJyZWFrcG9pbnRXaXRoRWRpdG9yTGluZUluZm8o YnJlYWtwb2ludCwgbGluZUluZm8pOwogCiAgICAgICAgIHRoaXMuX2lnbm9yZUJyZWFrcG9pbnRB ZGRlZEJyZWFrcG9pbnQgPSBicmVha3BvaW50OwotCiAgICAgICAgIHZhciBzaG91bGRTa2lwRXZl bnREaXNwYXRjaCA9IGZhbHNlOwogICAgICAgICB2YXIgc2hvdWxkU3BlY3VsYXRpdmVseVJlc29s dmVCcmVha3BvaW50ID0gdHJ1ZTsKICAgICAgICAgV2ViSW5zcGVjdG9yLmRlYnVnZ2VyTWFuYWdl ci5hZGRCcmVha3BvaW50KGJyZWFrcG9pbnQsIHNob3VsZFNraXBFdmVudERpc3BhdGNoLCBzaG91 bGRTcGVjdWxhdGl2ZWx5UmVzb2x2ZUJyZWFrcG9pbnQpOwotICAgICAgICBkZWxldGUgdGhpcy5f aWdub3JlQnJlYWtwb2ludEFkZGVkQnJlYWtwb2ludDsKKyAgICAgICAgdGhpcy5faWdub3JlQnJl YWtwb2ludEFkZGVkQnJlYWtwb2ludCA9IG51bGw7CiAKICAgICAgICAgLy8gUmV0dXJuIHRoZSBt b3JlIGFjY3VyYXRlIGxvY2F0aW9uIGFuZCBicmVha3BvaW50IGluZm8uCiAgICAgICAgIHJldHVy biB7CkBAIC0xMTI4LDcgKzExMzMsNyBAQCBXZWJJbnNwZWN0b3IuU291cmNlQ29kZVRleHRFZGl0 b3IgPSBjbGFzcyBTb3VyY2VDb2RlVGV4dEVkaXRvciBleHRlbmRzIFdlYkluc3BlYwogCiAgICAg ICAgIHRoaXMuX2lnbm9yZUJyZWFrcG9pbnRSZW1vdmVkQnJlYWtwb2ludCA9IGJyZWFrcG9pbnQ7 CiAgICAgICAgIFdlYkluc3BlY3Rvci5kZWJ1Z2dlck1hbmFnZXIucmVtb3ZlQnJlYWtwb2ludChi cmVha3BvaW50KTsKLSAgICAgICAgZGVsZXRlIHRoaXMuX2lnbm9yZUJyZWFrcG9pbnRBZGRlZEJy ZWFrcG9pbnQ7CisgICAgICAgIHRoaXMuX2lnbm9yZUJyZWFrcG9pbnRSZW1vdmVkQnJlYWtwb2lu dCA9IG51bGw7CiAgICAgfQogCiAgICAgdGV4dEVkaXRvckJyZWFrcG9pbnRNb3ZlZCh0ZXh0RWRp dG9yLCBvbGRMaW5lTnVtYmVyLCBvbGRDb2x1bW5OdW1iZXIsIG5ld0xpbmVOdW1iZXIsIG5ld0Nv bHVtbk51bWJlcikKQEAgLTExNDksNyArMTE1NCw3IEBAIFdlYkluc3BlY3Rvci5Tb3VyY2VDb2Rl VGV4dEVkaXRvciA9IGNsYXNzIFNvdXJjZUNvZGVUZXh0RWRpdG9yIGV4dGVuZHMgV2ViSW5zcGVj CiAgICAgICAgIHZhciB1bmZvcm1hdHRlZE5ld0xpbmVJbmZvID0gdGhpcy5fdW5mb3JtYXR0ZWRM aW5lSW5mb0ZvckVkaXRvckxpbmVJbmZvKG5ld0xpbmVJbmZvKTsKICAgICAgICAgdGhpcy5faWdu b3JlTG9jYXRpb25VcGRhdGVCcmVha3BvaW50ID0gYnJlYWtwb2ludDsKICAgICAgICAgYnJlYWtw b2ludC5zb3VyY2VDb2RlTG9jYXRpb24udXBkYXRlKHRoaXMuX3NvdXJjZUNvZGUsIHVuZm9ybWF0 dGVkTmV3TGluZUluZm8ubGluZU51bWJlciwgdW5mb3JtYXR0ZWROZXdMaW5lSW5mby5jb2x1bW5O dW1iZXIpOwotICAgICAgICBkZWxldGUgdGhpcy5faWdub3JlTG9jYXRpb25VcGRhdGVCcmVha3Bv aW50OworICAgICAgICB0aGlzLl9pZ25vcmVMb2NhdGlvblVwZGF0ZUJyZWFrcG9pbnQgPSBudWxs OwogCiAgICAgICAgIHZhciBhY2N1cmF0ZU5ld0xpbmVJbmZvID0gdGhpcy5fZWRpdG9yTGluZUlu Zm9Gb3JTb3VyY2VDb2RlTG9jYXRpb24oYnJlYWtwb2ludC5zb3VyY2VDb2RlTG9jYXRpb24pOwog ICAgICAgICB0aGlzLl9hZGRCcmVha3BvaW50V2l0aEVkaXRvckxpbmVJbmZvKGJyZWFrcG9pbnQs IGFjY3VyYXRlTmV3TGluZUluZm8pOwpAQCAtMTc3MSw3ICsxNzc2LDcgQEAgV2ViSW5zcGVjdG9y LlNvdXJjZUNvZGVUZXh0RWRpdG9yID0gY2xhc3MgU291cmNlQ29kZVRleHRFZGl0b3IgZXh0ZW5k cyBXZWJJbnNwZWMKICAgICAgICAgICAgIHZhciBjb2xvciA9IHRoaXMuX2VkaXRpbmdDb250cm9s bGVyLnZhbHVlOwogICAgICAgICAgICAgaWYgKCFjb2xvciB8fCAhY29sb3IudmFsaWQpIHsKICAg ICAgICAgICAgICAgICBlZGl0YWJsZU1hcmtlci5jbGVhcigpOwotICAgICAgICAgICAgICAgIGRl bGV0ZSB0aGlzLl9lZGl0aW5nQ29udHJvbGxlcjsKKyAgICAgICAgICAgICAgICB0aGlzLl9lZGl0 aW5nQ29udHJvbGxlciA9IG51bGw7CiAgICAgICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICAg ICAgfQogICAgICAgICB9CkBAIC0xNzg2LDcgKzE3OTEsNyBAQCBXZWJJbnNwZWN0b3IuU291cmNl Q29kZVRleHRFZGl0b3IgPSBjbGFzcyBTb3VyY2VDb2RlVGV4dEVkaXRvciBleHRlbmRzIFdlYklu c3BlYwogICAgICAgICAgICAgdGhpcy5fZWRpdGluZ0NvbnRyb2xsZXIuZGlzbWlzc0hvdmVyTWVu dShkaXNjcmV0ZSk7CiAKICAgICAgICAgdGhpcy50b2tlblRyYWNraW5nQ29udHJvbGxlci5ob3Zl cmVkTWFya2VyID0gbnVsbDsKLSAgICAgICAgZGVsZXRlIHRoaXMuX2VkaXRpbmdDb250cm9sbGVy OworICAgICAgICB0aGlzLl9lZGl0aW5nQ29udHJvbGxlciA9IG51bGw7CiAgICAgfQogCiAgICAg Ly8gQ29kZU1pcnJvckVkaXRpbmdDb250cm9sbGVyIERlbGVnYXRlCkBAIC0xODExLDcgKzE4MTYs NyBAQCBXZWJJbnNwZWN0b3IuU291cmNlQ29kZVRleHRFZGl0b3IgPSBjbGFzcyBTb3VyY2VDb2Rl VGV4dEVkaXRvciBleHRlbmRzIFdlYkluc3BlYwogCiAgICAgICAgIHRoaXMuX2lnbm9yZUNvbnRl bnREaWRDaGFuZ2UtLTsKIAotICAgICAgICBkZWxldGUgdGhpcy5fZWRpdGluZ0NvbnRyb2xsZXI7 CisgICAgICAgIHRoaXMuX2VkaXRpbmdDb250cm9sbGVyID0gbnVsbDsKICAgICB9CiAKICAgICBf c2V0VHlwZVRva2VuQW5ub3RhdG9yRW5hYmxlZFN0YXRlKHNob3VsZEFjdGl2YXRlKQo=