163377 2016-10-12 19:43:22 -0700 The bindings generator should provide a better error message when it does not find a dictionary definition 2016-10-12 22:23:56 -0700 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez cdumez cgarcia commit-queue darin jiewen_tan rniwa sam simon.fraser oldest_to_newest 1239649 0 cdumez 2016-10-12 19:43:22 -0700 The bindings generator should provide a better error message when it does not find a dictionary definition. 1239650 1 291444 cdumez 2016-10-12 19:45:51 -0700 Created attachment 291444 Patch 1239694 2 291444 commit-queue 2016-10-12 22:23:51 -0700 Comment on attachment 291444 Patch Clearing flags on attachment: 291444 Committed r207278: <http://trac.webkit.org/changeset/207278> 1239695 3 commit-queue 2016-10-12 22:23:56 -0700 All reviewed patches have been landed. Closing bug. 291444 2016-10-12 19:45:51 -0700 2016-10-12 22:23:51 -0700 Patch bug-163377-20161012194226.patch text/plain 5531 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3MjY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTY3Y2FkZTYxMWVjMDkx YTRjMjFkYzNmNDMzYWEwNmU1MzI1ZjY0NC4uYzQwYzdjMGIzMjJmZGRjNjQyZDc2OWE0YTViZWM1 MGM1MzE4MjI2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE2LTEwLTEyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgVGhlIGJpbmRpbmdzIGdlbmVy YXRvciBzaG91bGQgcHJvdmlkZSBhIGJldHRlciBlcnJvciBtZXNzYWdlIHdoZW4gaXQgZG9lcyBu b3QgZmluZCBhIGRpY3Rpb25hcnkgZGVmaW5pdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzMzc3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGJpbmRpbmdzIGdlbmVyYXRvciBzaG91bGQgcHJv dmlkZSBhIGJldHRlciBlcnJvciBtZXNzYWdlIHdoZW4gaXQgZG9lcworICAgICAgICBub3QgZmlu ZCBhIGRpY3Rpb25hcnkgZGVmaW5pdGlvbi4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMv Q29kZUdlbmVyYXRvci5wbToKKyAgICAgICAgKEdldERpY3Rpb25hcnlCeU5hbWUpOgorICAgICAg ICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtOgorICAgICAgICAoYXNzZXJ0 KToKKyAgICAgICAgKEdlbmVyYXRlRGljdGlvbmFyeUltcGxlbWVudGF0aW9uQ29udGVudCk6Cisg ICAgICAgIChHZW5lcmF0ZUhlYWRlcik6CisgICAgICAgIChHZW5lcmF0ZURpY3Rpb25hcnlIZWFk ZXIpOgorCiAyMDE2LTEwLTEyICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtp dC5vcmc+CiAKICAgICAgICAgTWFpbCBuZWVkcyBub25zcGVjaWFsIFVSTHMgdG8ga2VlcCBjYXNl IGluIGhvc3QgYW5kIG5vdCBoYXZlIHNsYXNoIGFmdGVyIGhvc3QKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvci5wbSBiL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvci5wbQppbmRleCA1OWJlMjRjZmRlZTM2 OTQ5NmFkMzUyMDNmODk4NmNiYjZmN2ZmOTVjLi43MGVkZmU4NTgzYmMzYmQ0MmYxNTk1MDFkODky NmE0ZTFlMGMwM2U4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRz L0NvZGVHZW5lcmF0b3IucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9D b2RlR2VuZXJhdG9yLnBtCkBAIC00NzQsNyArNDc0LDcgQEAgc3ViIEdldEVudW1JbXBsZW1lbnRh dGlvbk5hbWVPdmVycmlkZQogc3ViIEdldERpY3Rpb25hcnlCeU5hbWUKIHsKICAgICBteSAoJG9i amVjdCwgJG5hbWUpID0gQF87Ci0gICAgcmV0dXJuIHVubGVzcyBkZWZpbmVkKCRuYW1lKTsKKyAg ICBkaWUgIkdldERpY3Rpb25hcnlCeU5hbWUoKSB3YXMgY2FsbGVkIHdpdGggYW4gdW5kZWZpbmVk IGRpY3Rpb25hcnkgbmFtZSIgdW5sZXNzIGRlZmluZWQoJG5hbWUpOwogCiAgICAgZm9yIG15ICRk aWN0aW9uYXJ5IChAeyR1c2VEb2N1bWVudC0+ZGljdGlvbmFyaWVzfSkgewogICAgICAgICByZXR1 cm4gJGRpY3Rpb25hcnkgaWYgJGRpY3Rpb25hcnktPm5hbWUgZXEgJG5hbWU7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbSBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCmluZGV4IDg2 OWE0NTRhMGU4MjA0MmE1NmExZTkxZTVkYmE2ODlkMDI0YjBiYmMuLmQzNTA1ODEyZTAxYTgxYjU1 MWMwMjEwNTBmMzI3OTExNDQ4ZGEwNmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCkBAIC0zMyw2ICszMyw4IEBAIHBhY2thZ2Ug Q29kZUdlbmVyYXRvckpTOwogCiB1c2Ugc3RyaWN0OwogdXNlIGNvbnN0YW50IEZpbGVOYW1lUHJl Zml4ID0+ICJKUyI7Cit1c2UgQ2FycCBxdzxsb25nbWVzcz47Cit1c2UgRGF0YTo6RHVtcGVyOwog dXNlIEhhc2hlcjsKIAogbXkgJGNvZGVHZW5lcmF0b3I7CkBAIC0xMDcsNiArMTA5LDE2IEBAIG15 ICRoZWFkZXJUZW1wbGF0ZSA9IDw8ICJFT0YiOwogKi8KIEVPRgogCitzdWIgYXNzZXJ0Cit7Cisg ICAgbXkgJG1lc3NhZ2UgPSBzaGlmdDsKKworICAgIG15ICRtZXNzID0gbG9uZ21lc3MoKTsKKyAg ICBwcmludCBEdW1wZXIoJG1lc3MpOworCisgICAgZGllICRtZXNzYWdlOworfQorCiAjIERlZmF1 bHQgY29uc3RydWN0b3IKIHN1YiBuZXcKIHsKQEAgLTEwOTIsMTAgKzExMDQsMTIgQEAgc3ViIEdl bmVyYXRlRGljdGlvbmFyeUltcGxlbWVudGF0aW9uQ29udGVudAogICAgICMgNC4gTGV0IGRpY3Rp b25hcmllcyBiZSBhIGxpc3QgY29uc2lzdGluZyBvZiBEIGFuZCBhbGwgb2YgROKAmXMgaW5oZXJp dGVkIGRpY3Rpb25hcmllcywgaW4gb3JkZXIgZnJvbSBsZWFzdCB0byBtb3N0IGRlcml2ZWQuCiAg ICAgbXkgQGRpY3Rpb25hcmllczsKICAgICBwdXNoKEBkaWN0aW9uYXJpZXMsICRkaWN0aW9uYXJ5 KTsKLSAgICBteSAkcGFyZW50RGljdGlvbmFyeSA9ICRjb2RlR2VuZXJhdG9yLT5HZXREaWN0aW9u YXJ5QnlOYW1lKCRkaWN0aW9uYXJ5LT5wYXJlbnQpOwotICAgIHdoaWxlIChkZWZpbmVkKCRwYXJl bnREaWN0aW9uYXJ5KSkgeworICAgIG15ICRwYXJlbnROYW1lID0gJGRpY3Rpb25hcnktPnBhcmVu dDsKKyAgICB3aGlsZSAoZGVmaW5lZCgkcGFyZW50TmFtZSkpIHsKKyAgICAgICAgbXkgJHBhcmVu dERpY3Rpb25hcnkgPSAkY29kZUdlbmVyYXRvci0+R2V0RGljdGlvbmFyeUJ5TmFtZSgkcGFyZW50 TmFtZSk7CisgICAgICAgIGFzc2VydCgiVW5hYmxlIHRvIGZpbmQgZGVmaW5pdGlvbiBmb3IgZGlj dGlvbmFyeSBuYW1lZCAnIiAuICRwYXJlbnROYW1lIC4gIichIikgdW5sZXNzIGRlZmluZWQoJHBh cmVudERpY3Rpb25hcnkpOwogICAgICAgICB1bnNoaWZ0KEBkaWN0aW9uYXJpZXMsICRwYXJlbnRE aWN0aW9uYXJ5KTsKLSAgICAgICAgJHBhcmVudERpY3Rpb25hcnkgPSAkY29kZUdlbmVyYXRvci0+ R2V0RGljdGlvbmFyeUJ5TmFtZSgkcGFyZW50RGljdGlvbmFyeS0+cGFyZW50KTsKKyAgICAgICAg JHBhcmVudE5hbWUgPSAkcGFyZW50RGljdGlvbmFyeS0+cGFyZW50OwogICAgIH0KIAogICAgIG15 ICRhcmd1bWVudHMgPSAiIjsKQEAgLTE3NDEsMTAgKzE3NTUsMTIgQEAgc3ViIEdlbmVyYXRlSGVh ZGVyCiAgICAgICAgICAgICBwdXNoKEBhbmNlc3RvcnMsICRjdXJyZW50SW50ZXJmYWNlLT5uYW1l KTsKICAgICAgICAgfSwgMCk7CiAgICAgICAgIGZvciBteSAkZGljdGlvbmFyeSAoQCRkaWN0aW9u YXJpZXMpIHsKLSAgICAgICAgICAgIG15ICRwYXJlbnREaWN0aW9uYXJ5ID0gJGRpY3Rpb25hcnkt PnBhcmVudDsKLSAgICAgICAgICAgIHdoaWxlIChkZWZpbmVkKCRwYXJlbnREaWN0aW9uYXJ5KSkg ewotICAgICAgICAgICAgICAgIHB1c2goQGFuY2VzdG9ycywgJHBhcmVudERpY3Rpb25hcnkpIGlm ICRjb2RlR2VuZXJhdG9yLT5Jc0V4dGVybmFsRGljdGlvbmFyeVR5cGUoJHBhcmVudERpY3Rpb25h cnkpOwotICAgICAgICAgICAgICAgICRwYXJlbnREaWN0aW9uYXJ5ID0gJGNvZGVHZW5lcmF0b3It PkdldERpY3Rpb25hcnlCeU5hbWUoJHBhcmVudERpY3Rpb25hcnkpLT5wYXJlbnQ7CisgICAgICAg ICAgICBteSAkcGFyZW50TmFtZSA9ICRkaWN0aW9uYXJ5LT5wYXJlbnQ7CisgICAgICAgICAgICB3 aGlsZSAoZGVmaW5lZCgkcGFyZW50TmFtZSkpIHsKKyAgICAgICAgICAgICAgICBwdXNoKEBhbmNl c3RvcnMsICRwYXJlbnROYW1lKSBpZiAkY29kZUdlbmVyYXRvci0+SXNFeHRlcm5hbERpY3Rpb25h cnlUeXBlKCRwYXJlbnROYW1lKTsKKyAgICAgICAgICAgICAgICBteSAkcGFyZW50RGljdGlvbmFy eSA9ICRjb2RlR2VuZXJhdG9yLT5HZXREaWN0aW9uYXJ5QnlOYW1lKCRwYXJlbnROYW1lKTsKKyAg ICAgICAgICAgICAgICBhc3NlcnQoIlVuYWJsZSB0byBmaW5kIGRlZmluaXRpb24gZm9yIGRpY3Rp b25hcnkgbmFtZWQgJyIgLiAkcGFyZW50TmFtZSAuICInISIpIHVubGVzcyBkZWZpbmVkKCRwYXJl bnREaWN0aW9uYXJ5KTsKKyAgICAgICAgICAgICAgICAkcGFyZW50TmFtZSA9ICRwYXJlbnREaWN0 aW9uYXJ5LT5wYXJlbnQ7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICAgICAgcHVzaChA ZGVwc0NvbnRlbnQsICIkY2xhc3NOYW1lLmggOiAiLCBqb2luKCIgIiwgbWFwIHsgIiRfLmlkbCIg fSBAYW5jZXN0b3JzKSwgIlxuIik7CkBAIC00Mzc1LDEwICs0MzkxLDEyIEBAIHN1YiBHZW5lcmF0 ZURpY3Rpb25hcnlIZWFkZXIKICAgICAjIC0gR2VuZXJhdGUgZGVwZW5kZW5jaWVzLgogICAgIGlm ICgkd3JpdGVEZXBlbmRlbmNpZXMpIHsKICAgICAgICAgbXkgQGFuY2VzdG9yczsKLSAgICAgICAg bXkgJHBhcmVudERpY3Rpb25hcnkgPSAkZGljdGlvbmFyeS0+cGFyZW50OwotICAgICAgICB3aGls ZSAoZGVmaW5lZCgkcGFyZW50RGljdGlvbmFyeSkpIHsKLSAgICAgICAgICAgIHB1c2goQGFuY2Vz dG9ycywgJHBhcmVudERpY3Rpb25hcnkpIGlmICRjb2RlR2VuZXJhdG9yLT5Jc0V4dGVybmFsRGlj dGlvbmFyeVR5cGUoJHBhcmVudERpY3Rpb25hcnkpOwotICAgICAgICAgICAgJHBhcmVudERpY3Rp b25hcnkgPSAkY29kZUdlbmVyYXRvci0+R2V0RGljdGlvbmFyeUJ5TmFtZSgkcGFyZW50RGljdGlv bmFyeSktPnBhcmVudDsKKyAgICAgICAgbXkgJHBhcmVudE5hbWUgPSAkZGljdGlvbmFyeS0+cGFy ZW50OworICAgICAgICB3aGlsZSAoZGVmaW5lZCgkcGFyZW50TmFtZSkpIHsKKyAgICAgICAgICAg IHB1c2goQGFuY2VzdG9ycywgJHBhcmVudE5hbWUpIGlmICRjb2RlR2VuZXJhdG9yLT5Jc0V4dGVy bmFsRGljdGlvbmFyeVR5cGUoJHBhcmVudE5hbWUpOworICAgICAgICAgICAgbXkgJHBhcmVudERp Y3Rpb25hcnkgPSAkY29kZUdlbmVyYXRvci0+R2V0RGljdGlvbmFyeUJ5TmFtZSgkcGFyZW50TmFt ZSk7CisgICAgICAgICAgICBhc3NlcnQoIlVuYWJsZSB0byBmaW5kIGRlZmluaXRpb24gZm9yIGRp Y3Rpb25hcnkgbmFtZWQgJyIgLiAkcGFyZW50TmFtZSAuICInISIpIHVubGVzcyAkcGFyZW50RGlj dGlvbmFyeTsKKyAgICAgICAgICAgICRwYXJlbnROYW1lID0gJHBhcmVudERpY3Rpb25hcnktPnBh cmVudDsKICAgICAgICAgfQogICAgICAgICBwdXNoKEBkZXBzQ29udGVudCwgIiRjbGFzc05hbWUu aCA6ICIsIGpvaW4oIiAiLCBtYXAgeyAiJF8uaWRsIiB9IEBhbmNlc3RvcnMpLCAiXG4iKTsKICAg ICAgICAgcHVzaChAZGVwc0NvbnRlbnQsIG1hcCB7ICIkXy5pZGwgOlxuIiB9IEBhbmNlc3RvcnMp Owo=