163358 2016-10-12 14:18:37 -0700 Update HTMLSelectElement::recalcListItems() to ignore nested optgroup elements 2016-10-12 21:16:31 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 163296 1 cdumez cdumez achristensen cdumez commit-queue darin rniwa sam tkent oldest_to_newest 1239505 0 cdumez 2016-10-12 14:18:37 -0700 Update HTMLSelectElement::recalcListItems() to ignore nested optgroup elements. As per the specification, we only want optgroup elements that are direct children of the select element. 1239544 1 cdumez 2016-10-12 15:35:47 -0700 test case: https://jsfiddle.net/varkv40b/10/ 1239548 2 cdumez 2016-10-12 15:40:44 -0700 (In reply to comment #1) > test case: > https://jsfiddle.net/varkv40b/10/ Better: https://jsfiddle.net/varkv40b/16/ 1239549 3 291410 cdumez 2016-10-12 15:48:33 -0700 Created attachment 291410 Patch 1239677 4 291410 commit-queue 2016-10-12 21:16:26 -0700 Comment on attachment 291410 Patch Clearing flags on attachment: 291410 Committed r207276: <http://trac.webkit.org/changeset/207276> 1239678 5 commit-queue 2016-10-12 21:16:31 -0700 All reviewed patches have been landed. Closing bug. 291410 2016-10-12 15:48:33 -0700 2016-10-12 21:16:26 -0700 Patch bug-163358-20161012154508.patch text/plain 4723 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3MjM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDVhOGM0ZDY1ODhlYWMw NzBlNmUzY2JlYzBiZTZlMTAyOGQ2NGYyOS4uNjA0MGNhOTQ0OTIxODU4NzMwNzJmNmQzNWM4YjQ4 YmVmZTlhMTQ3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE2LTEwLTEyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgVXBkYXRlIEhUTUxTZWxlY3RF bGVtZW50OjpyZWNhbGNMaXN0SXRlbXMoKSB0byBpZ25vcmUgbmVzdGVkIG9wdGdyb3VwIGVsZW1l bnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjMz NTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRh dGUgSFRNTFNlbGVjdEVsZW1lbnQ6OnJlY2FsY0xpc3RJdGVtcygpIHRvIGlnbm9yZSBuZXN0ZWQg b3B0Z3JvdXAgZWxlbWVudHMuCisgICAgICAgIEFzIHBlciB0aGUgc3BlY2lmaWNhdGlvbiwgd2Ug b25seSB3YW50IG9wdGdyb3VwIGVsZW1lbnRzIHRoYXQgYXJlIGRpcmVjdAorICAgICAgICBjaGls ZHJlbiBvZiB0aGUgc2VsZWN0IGVsZW1lbnQuIFRoaXMgYWxzbyBtYXRjaGVzIHRoZSBiZWhhdmlv ciBvZiBDaHJvbWUuCisKKyAgICAgICAgVGVzdDogZmFzdC9kb20vSFRNTFNlbGVjdEVsZW1lbnQv bmVzdGVkLW9wdGdyb3VwLmh0bWwKKworICAgICAgICAqIGh0bWwvSFRNTFNlbGVjdEVsZW1lbnQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFNlbGVjdEVsZW1lbnQ6OnJlY2FsY0xpc3RJdGVt cyk6CisKIDIwMTYtMTAtMTIgIFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+ CiAKICAgICAgICAgW0RPTUpJVF1bSlNDXSBFeHBsb3JlIHRoZSB3YXkgdG8gZW1iZWQgbm9kZVR5 cGUgaW50byBKU0M6OkpTVHlwZSBpbiBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFNl bGVjdEVsZW1lbnQuY3BwCmluZGV4IGUxM2VhOThkZDFmNmMxYTc4MDI1MDNlYWY1MTdhOTUxNDI1 YTEzMjMuLjNiMmYwNWU2OGFmODlmMzM3MmIwZGI3OGZmYjc1ZTIxZjhmYmUxMmQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFNlbGVjdEVsZW1lbnQuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTFNlbGVjdEVsZW1lbnQuY3BwCkBAIC03NzAsMTAgKzc3MCw4IEBA IHZvaWQgSFRNTFNlbGVjdEVsZW1lbnQ6OnJlY2FsY0xpc3RJdGVtcyhib29sIHVwZGF0ZVNlbGVj dGVkU3RhdGVzKSBjb25zdAogICAgICAgICB9CiAgICAgICAgIEhUTUxFbGVtZW50JiBjdXJyZW50 ID0gZG93bmNhc3Q8SFRNTEVsZW1lbnQ+KCpjdXJyZW50RWxlbWVudCk7CiAKLSAgICAgICAgLy8g b3B0Z3JvdXAgdGFncyBtYXkgbm90IG5lc3QuIEhvd2V2ZXIsIGJvdGggRmlyZUZveCBhbmQgSUUg d2lsbAotICAgICAgICAvLyBmbGF0dGVuIHRoZSB0cmVlIGF1dG9tYXRpY2FsbHksIHNvIHdlIGZv bGxvdyBzdWl0LgotICAgICAgICAvLyAoaHR0cDovL3d3dy53My5vcmcvVFIvaHRtbDQwMS9pbnRl cmFjdC9mb3Jtcy5odG1sI2gtMTcuNikKLSAgICAgICAgaWYgKGlzPEhUTUxPcHRHcm91cEVsZW1l bnQ+KGN1cnJlbnQpKSB7CisgICAgICAgIC8vIE9ubHkgY29uc2lkZXIgb3B0Z3JvdXAgZWxlbWVu dHMgdGhhdCBhcmUgZGlyZWN0IGNoaWxkcmVuIG9mIHRoZSBzZWxlY3QgZWxlbWVudC4KKyAgICAg ICAgaWYgKGlzPEhUTUxPcHRHcm91cEVsZW1lbnQ+KGN1cnJlbnQpICYmIGN1cnJlbnQucGFyZW50 Tm9kZSgpID09IHRoaXMpIHsKICAgICAgICAgICAgIG1fbGlzdEl0ZW1zLmFwcGVuZCgmY3VycmVu dCk7CiAgICAgICAgICAgICBpZiAoRWxlbWVudCogbmV4dEVsZW1lbnQgPSBFbGVtZW50VHJhdmVy c2FsOjpmaXJzdFdpdGhpbihjdXJyZW50KSkgewogICAgICAgICAgICAgICAgIGN1cnJlbnRFbGVt ZW50ID0gbmV4dEVsZW1lbnQ7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMjIxZGYzYzcwNmQ1ZDAyZWYyNTNiNzVkNjE2NzQy NDgxZTcyNDcyNC4uZjIwMmZhNjk5OTVmY2E0M2ZkOWIyNWIyMjI4OGUwY2RhNmRhM2NiMiAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTEwLTEyICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBs ZS5jb20+CisKKyAgICAgICAgVXBkYXRlIEhUTUxTZWxlY3RFbGVtZW50OjpyZWNhbGNMaXN0SXRl bXMoKSB0byBpZ25vcmUgbmVzdGVkIG9wdGdyb3VwIGVsZW1lbnRzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjMzNTgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgbGF5b3V0IHRlc3QgY292ZXJhZ2Uu CisKKyAgICAgICAgKiBmYXN0L2RvbS9IVE1MU2VsZWN0RWxlbWVudC9uZXN0ZWQtb3B0Z3JvdXAt ZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS9IVE1MU2VsZWN0RWxlbWVu dC9uZXN0ZWQtb3B0Z3JvdXAuaHRtbDogQWRkZWQuCisKIDIwMTYtMTAtMTIgIFl1c3VrZSBTdXp1 a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAgW0RPTUpJVF1bSlNDXSBFeHBs b3JlIHRoZSB3YXkgdG8gZW1iZWQgbm9kZVR5cGUgaW50byBKU0M6OkpTVHlwZSBpbiBXZWJDb3Jl CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MU2VsZWN0RWxlbWVudC9uZXN0 ZWQtb3B0Z3JvdXAtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTFNlbGVj dEVsZW1lbnQvbmVzdGVkLW9wdGdyb3VwLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi40ZjNiZDAz ZmViM2JhN2IyZDk3MDExNGY1YzU4NzFlOWQwYzA3ZjY0Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvZmFzdC9kb20vSFRNTFNlbGVjdEVsZW1lbnQvbmVzdGVkLW9wdGdyb3VwLWV4cGVj dGVkLnR4dApAQCAtMCwwICsxLDEwIEBACitUZXN0IHRoYXQgb3B0aW9ucyBpbiBuZXN0ZWQgb3B0 Z3JvdXAgZWxlbWVudHMgY2Fubm90IGJlIHNlbGVjdGVkLgorCitPbiBzdWNjZXNzLCB5b3Ugd2ls bCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01Q TEVURSIuCisKKworUEFTUyBzZWxlY3QudmFsdWUgaXMgIlBBU1MiCitQQVNTIHN1Y2Nlc3NmdWxs eVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvZmFzdC9kb20vSFRNTFNlbGVjdEVsZW1lbnQvbmVzdGVkLW9wdGdyb3VwLmh0bWwgYi9MYXlv dXRUZXN0cy9mYXN0L2RvbS9IVE1MU2VsZWN0RWxlbWVudC9uZXN0ZWQtb3B0Z3JvdXAuaHRtbApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwLi5hOTVkMzNlYTBkZmZlZTZkMzlkMzA5ZTE5MGYwZmY1MDVmMWYwMWVjCi0tLSAv ZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTFNlbGVjdEVsZW1lbnQvbmVz dGVkLW9wdGdyb3VwLmh0bWwKQEAgLTAsMCArMSwyOCBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRt bD4KKzxib2R5PgorPHNlbGVjdCBpZD0idGVzdFNlbGVjdCI+CisgIDxvcHRpb24+RkFJTDwvb3B0 aW9uPgorICA8b3B0Z3JvdXAgaWQ9InRvcEdyb3VwIiBsYWJlbD0iVG9wIGdyb3VwIj48L29wdGdy b3VwPgorICA8b3B0aW9uPlBBU1M8L29wdGlvbj4KKzwvc2VsZWN0PgorPHNjcmlwdCBzcmM9Ii4u Ly4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0PgorZGVz Y3JpcHRpb24oIlRlc3QgdGhhdCBvcHRpb25zIGluIG5lc3RlZCBvcHRncm91cCBlbGVtZW50cyBj YW5ub3QgYmUgc2VsZWN0ZWQuIik7CisKK3ZhciBzZWxlY3QgPSBkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgidGVzdFNlbGVjdCIpOwordmFyIHRvcGdyb3VwID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoInRvcEdyb3VwIik7CisKK3ZhciBuZXN0ZWRHcm91cCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1l bnQoIm9wdGdyb3VwIik7CituZXN0ZWRHcm91cC5sYWJlbCA9ICJOZXN0ZWQgZ3JvdXAiOwordmFy IG9wdGlvbiA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoIm9wdGlvbiIpOworb3B0aW9uLmFwcGVu ZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKCJGQUlMIikpOworbmVzdGVkR3JvdXAuYXBw ZW5kQ2hpbGQob3B0aW9uKTsKK3RvcEdyb3VwLmFwcGVuZENoaWxkKG5lc3RlZEdyb3VwKTsKKwor c2VsZWN0LnNlbGVjdGVkSW5kZXggPSAxOworc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJzZWxlY3Qu dmFsdWUiLCAiUEFTUyIpOworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vcmVzb3Vy Y2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==