163352 2016-10-12 13:31:25 -0700 [Web IDL] Generated bindings include the wrong header when ImplementedAs is used on a dictionary 2016-10-12 14:12:28 -0700 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez cdumez cgarcia commit-queue darin esprehn+autocc jiewen_tan kondapallykalyan rniwa sam simon.fraser oldest_to_newest 1239457 0 cdumez 2016-10-12 13:31:25 -0700 Generated bindings include the wrong header when ImplementedAs is used on a dictionary. 1239459 1 291388 cdumez 2016-10-12 13:33:30 -0700 Created attachment 291388 Patch 1239461 2 291388 jiewen_tan 2016-10-12 13:37:51 -0700 Comment on attachment 291388 Patch Thanks Chris for making this fix so quickly. Will it be good to keep the old TestStandaloneDictionary test case as well? 1239498 3 291388 commit-queue 2016-10-12 14:12:23 -0700 Comment on attachment 291388 Patch Clearing flags on attachment: 291388 Committed r207243: <http://trac.webkit.org/changeset/207243> 1239499 4 commit-queue 2016-10-12 14:12:28 -0700 All reviewed patches have been landed. Closing bug. 291388 2016-10-12 13:33:30 -0700 2016-10-12 14:12:23 -0700 Patch bug-163352-20161012133006.patch text/plain 5774 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3MjM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2M3ZTgyZmYyYjNiNGZj MzNmMGU2NjlmYjJiZjBhNTY4NDhjYWFhYi4uNzAyOTdlYjNiZTE3OWM1MTYzZDk3OTA4NWQwNzI1 NThkNGQzMmYxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE2LTEwLTEyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYiBJRExdIEdlbmVyYXRl ZCBiaW5kaW5ncyBpbmNsdWRlIHRoZSB3cm9uZyBoZWFkZXIgd2hlbiBJbXBsZW1lbnRlZEFzIGlz IHVzZWQgb24gYSBkaWN0aW9uYXJ5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNjMzNTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBHZW5lcmF0ZWQgYmluZGluZ3MgaW5jbHVkZSB0aGUgd3JvbmcgaGVhZGVy IHdoZW4gSW1wbGVtZW50ZWRBcyBpcyB1c2VkCisgICAgICAgIG9uIGEgZGljdGlvbmFyeS4KKwor ICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtOgorICAgICAgICAo R2VuZXJhdGVEaWN0aW9uYXJ5SGVhZGVyKToKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL3Rl c3QvSlMvSlNUZXN0T2JqLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmpzVGVzdE9ialByb3RvdHlw ZUZ1bmN0aW9uT3BlcmF0aW9uV2l0aEV4dGVybmFsRGljdGlvbmFyeVBhcmFtZXRlckNhbGxlcik6 CisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pTVGVzdFN0YW5kYWxvbmVEaWN0 aW9uYXJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNvbnZlcnREaWN0aW9uYXJ5PERpY3Rpb25h cnlJbXBsTmFtZT4pOgorICAgICAgICAoV2ViQ29yZTo6Y29udmVydERpY3Rpb25hcnk8VGVzdFN0 YW5kYWxvbmVEaWN0aW9uYXJ5Pik6IERlbGV0ZWQuCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0 cy90ZXN0L0pTL0pTVGVzdFN0YW5kYWxvbmVEaWN0aW9uYXJ5Lmg6CisgICAgICAgICogYmluZGlu Z3Mvc2NyaXB0cy90ZXN0L1Rlc3RTdGFuZGFsb25lRGljdGlvbmFyeS5pZGw6CisKIDIwMTYtMTAt MTIgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgRG9j dW1lbnQ6OmV4aXN0aW5nQVhPYmplY3RDYWNoZSgpIGZhc3Qgd2l0aCBhY2Nlc3NpYmlsaXR5IGRp c2FibGVkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2Rl R2VuZXJhdG9ySlMucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5l cmF0b3JKUy5wbQppbmRleCBiNDI5MzI1MWY3YzE2NDhlZDA0ZDY0N2UwZDQ3ZDRjODI1MDcwMGE1 Li5iMmM4MzViMTFlNWJmNWFkYTI4YTE1ODFkNjY3MTEyYzkyYmNmODJkIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQorKysgYi9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQpAQCAtNDMz NCw3ICs0MzM0LDcgQEAgc3ViIEdlbmVyYXRlRGljdGlvbmFyeUhlYWRlcgogICAgICMgLSBBZGQg ZGVmYXVsdCBoZWFkZXIgdGVtcGxhdGUgYW5kIGhlYWRlciBwcm90ZWN0aW9uLgogICAgIHB1c2go QGhlYWRlckNvbnRlbnRIZWFkZXIsIEdlbmVyYXRlSGVhZGVyQ29udGVudEhlYWRlcigkZGljdGlv bmFyeSkpOwogCi0gICAgJGhlYWRlckluY2x1ZGVzeyIkZGljdGlvbmFyeU5hbWUuaCJ9ID0gMTsK KyAgICAkaGVhZGVySW5jbHVkZXN7IiRjbGFzc05hbWUuaCJ9ID0gMTsKICAgICAkaGVhZGVySW5j bHVkZXN7IkpTRE9NQ29udmVydC5oIn0gPSAxOwogCiAgICAgcHVzaChAaGVhZGVyQ29udGVudCwg IlxubmFtZXNwYWNlIFdlYkNvcmUge1xuXG4iKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RPYmouY3BwIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pTVGVzdE9iai5jcHAKaW5kZXggNDhkYTY0NmViNzAx NDYxMzU4NDk0NmFmMzE4YjNiYTE4YTkwMDJmNS4uNjE3OGFiNTY2OGZmOTI5ZDgwNDkyZGJmZGNj MGY3YjlmOTg0YjQ4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy90ZXN0L0pTL0pTVGVzdE9iai5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2Ny aXB0cy90ZXN0L0pTL0pTVGVzdE9iai5jcHAKQEAgLTc3MTMsNyArNzcxMyw3IEBAIHN0YXRpYyBp bmxpbmUgSlNDOjpFbmNvZGVkSlNWYWx1ZSBqc1Rlc3RPYmpQcm90b3R5cGVGdW5jdGlvbk9wZXJh dGlvbldpdGhFeHRlcm5hCiAgICAgYXV0byYgaW1wbCA9IGNhc3RlZFRoaXMtPndyYXBwZWQoKTsK ICAgICBpZiAoVU5MSUtFTFkoc3RhdGUtPmFyZ3VtZW50Q291bnQoKSA8IDEpKQogICAgICAgICBy ZXR1cm4gdGhyb3dWTUVycm9yKHN0YXRlLCB0aHJvd1Njb3BlLCBjcmVhdGVOb3RFbm91Z2hBcmd1 bWVudHNFcnJvcihzdGF0ZSkpOwotICAgIGF1dG8gZGljdCA9IGNvbnZlcnQ8SURMRGljdGlvbmFy eTxUZXN0U3RhbmRhbG9uZURpY3Rpb25hcnk+Pigqc3RhdGUsIHN0YXRlLT51bmNoZWNrZWRBcmd1 bWVudCgwKSk7CisgICAgYXV0byBkaWN0ID0gY29udmVydDxJRExEaWN0aW9uYXJ5PERpY3Rpb25h cnlJbXBsTmFtZT4+KCpzdGF0ZSwgc3RhdGUtPnVuY2hlY2tlZEFyZ3VtZW50KDApKTsKICAgICBS RVRVUk5fSUZfRVhDRVBUSU9OKHRocm93U2NvcGUsIGVuY29kZWRKU1ZhbHVlKCkpOwogICAgIGlt cGwub3BlcmF0aW9uV2l0aEV4dGVybmFsRGljdGlvbmFyeVBhcmFtZXRlcihkaWN0LnZhbHVlKCkp OwogICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNVbmRlZmluZWQoKSk7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0U3RhbmRhbG9u ZURpY3Rpb25hcnkuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pT L0pTVGVzdFN0YW5kYWxvbmVEaWN0aW9uYXJ5LmNwcAppbmRleCAwZTkzMmE4OTgwOWUwYWY0ZWE4 NjdmNjIwMzBlZDIyNmMxMWE0OWM1Li5mOWYyNjI1NTRhYzY0MzVmMWE2YzVlOWNkMDI1NjNiM2U0 ZjEyN2RhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3Qv SlMvSlNUZXN0U3RhbmRhbG9uZURpY3Rpb25hcnkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RTdGFuZGFsb25lRGljdGlvbmFyeS5jcHAKQEAg LTI2LDcgKzI2LDcgQEAgdXNpbmcgbmFtZXNwYWNlIEpTQzsKIAogbmFtZXNwYWNlIFdlYkNvcmUg ewogCi10ZW1wbGF0ZTw+IE9wdGlvbmFsPFRlc3RTdGFuZGFsb25lRGljdGlvbmFyeT4gY29udmVy dERpY3Rpb25hcnk8VGVzdFN0YW5kYWxvbmVEaWN0aW9uYXJ5PihFeGVjU3RhdGUmIHN0YXRlLCBK U1ZhbHVlIHZhbHVlKQordGVtcGxhdGU8PiBPcHRpb25hbDxEaWN0aW9uYXJ5SW1wbE5hbWU+IGNv bnZlcnREaWN0aW9uYXJ5PERpY3Rpb25hcnlJbXBsTmFtZT4oRXhlY1N0YXRlJiBzdGF0ZSwgSlNW YWx1ZSB2YWx1ZSkKIHsKICAgICBWTSYgdm0gPSBzdGF0ZS52bSgpOwogICAgIGF1dG8gdGhyb3dT Y29wZSA9IERFQ0xBUkVfVEhST1dfU0NPUEUodm0pOwpAQCAtNDAsNyArNDAsNyBAQCB0ZW1wbGF0 ZTw+IE9wdGlvbmFsPFRlc3RTdGFuZGFsb25lRGljdGlvbmFyeT4gY29udmVydERpY3Rpb25hcnk8 VGVzdFN0YW5kYWxvbmVEaQogICAgICAgICB0aHJvd1R5cGVFcnJvcigmc3RhdGUsIHRocm93U2Nv cGUpOwogICAgICAgICByZXR1cm4gTnVsbG9wdDsKICAgICB9Ci0gICAgVGVzdFN0YW5kYWxvbmVE aWN0aW9uYXJ5IHJlc3VsdDsKKyAgICBEaWN0aW9uYXJ5SW1wbE5hbWUgcmVzdWx0OwogICAgIEpT VmFsdWUgYm9vbE1lbWJlclZhbHVlID0gaXNOdWxsT3JVbmRlZmluZWQgPyBqc1VuZGVmaW5lZCgp IDogb2JqZWN0LT5nZXQoJnN0YXRlLCBJZGVudGlmaWVyOjpmcm9tU3RyaW5nKCZzdGF0ZSwgImJv b2xNZW1iZXIiKSk7CiAgICAgaWYgKCFib29sTWVtYmVyVmFsdWUuaXNVbmRlZmluZWQoKSkgewog ICAgICAgICByZXN1bHQuYm9vbE1lbWJlciA9IGNvbnZlcnQ8SURMQm9vbGVhbj4oc3RhdGUsIGJv b2xNZW1iZXJWYWx1ZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3Jp cHRzL3Rlc3QvSlMvSlNUZXN0U3RhbmRhbG9uZURpY3Rpb25hcnkuaCBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RTdGFuZGFsb25lRGljdGlvbmFyeS5oCmlu ZGV4IDBjM2UxZDY1ZmJkMzliOTM5MDQwNzVmYTNjMDhkMzc2NGE0NTRhODIuLmYzOWFiYmE1Y2Yx NGYyOGVjYTg0YzI2MDU2ZGY5NzRmYzRkNjdiMDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RTdGFuZGFsb25lRGljdGlvbmFyeS5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RTdGFuZGFs b25lRGljdGlvbmFyeS5oCkBAIC0yMCwxMSArMjAsMTEgQEAKIAogI3ByYWdtYSBvbmNlCiAKKyNp bmNsdWRlICJEaWN0aW9uYXJ5SW1wbE5hbWUuaCIKICNpbmNsdWRlICJKU0RPTUNvbnZlcnQuaCIK LSNpbmNsdWRlICJUZXN0U3RhbmRhbG9uZURpY3Rpb25hcnkuaCIKIAogbmFtZXNwYWNlIFdlYkNv cmUgewogCi10ZW1wbGF0ZTw+IE9wdGlvbmFsPFRlc3RTdGFuZGFsb25lRGljdGlvbmFyeT4gY29u dmVydERpY3Rpb25hcnk8VGVzdFN0YW5kYWxvbmVEaWN0aW9uYXJ5PihKU0M6OkV4ZWNTdGF0ZSYs IEpTQzo6SlNWYWx1ZSk7Cit0ZW1wbGF0ZTw+IE9wdGlvbmFsPERpY3Rpb25hcnlJbXBsTmFtZT4g Y29udmVydERpY3Rpb25hcnk8RGljdGlvbmFyeUltcGxOYW1lPihKU0M6OkV4ZWNTdGF0ZSYsIEpT Qzo6SlNWYWx1ZSk7CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9UZXN0U3RhbmRhbG9uZURpY3Rpb25hcnku aWRsIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Rlc3RTdGFuZGFsb25l RGljdGlvbmFyeS5pZGwKaW5kZXggN2MzM2FmNjYyMmI1MmE5MjkzNTllNmYyM2QwNGZkMmUwMjM0 OTM5YS4uOTU4OTdlYTJhY2U0MzI1MmY0MWQxZGJiMTg4NDQ2MjRlZjI5YzJhMyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Rlc3RTdGFuZGFsb25lRGlj dGlvbmFyeS5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Rl c3RTdGFuZGFsb25lRGljdGlvbmFyeS5pZGwKQEAgLTI2LDcgKzI2LDkgQEAKICAqIFRISVMgU09G VFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0Uu CiAgKi8KIAotZGljdGlvbmFyeSBUZXN0U3RhbmRhbG9uZURpY3Rpb25hcnkgeworWworICAgIElt cGxlbWVudGVkQXM9RGljdGlvbmFyeUltcGxOYW1lLAorXSBkaWN0aW9uYXJ5IFRlc3RTdGFuZGFs b25lRGljdGlvbmFyeSB7CiAgICAgYm9vbGVhbiBib29sTWVtYmVyOwogICAgIERPTVN0cmluZyBz dHJpbmdNZW1iZXI7CiB9Owo=