163346 2016-10-12 11:30:48 -0700 GTK and EFL on Mac fail to compile WebTextChecker due to missing definition of WKTextCheckerClientBase 2016-10-13 11:56:28 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=161919 https://bugs.webkit.org/show_bug.cgi?id=162493 P2 Normal --- 1 jeremyhu jbedard andersca ap cdumez commit-queue dbates jbedard lforschler rniwa sam oldest_to_newest 1239380 0 jeremyhu 2016-10-12 11:30:48 -0700 With trunk r207192 and the buildfix for bug #163340, I'm hitting a compile failure now in WebTextChecker.cpp and WebTextCheckerClient.cpp regarding WKTextCheckerClientBase being unknown. Given that WebTextChecker.cpp hasn't changed in almost two years and WebTextCheckerClient.cpp hasn't in almost three, it's likely a change to one of their header files Source/WebKit2/UIProcess/WebTextChecker.cpp:46:38: error: unknown type name 'WKTextCheckerClientBase'; did you mean 'WebCore::TextCheckerClient'? void WebTextChecker::setClient(const WKTextCheckerClientBase* client) ^~~~~~~~~~~~~~~~~~~~~~~ WebCore::TextCheckerClient and similarly in WebTextCheckerClient.cpp: Source/WebKit2/UIProcess/WebTextCheckerClient.cpp:27: Source/WebKit2/UIProcess/WebTextCheckerClient.h:36:32: error: unknown type name 'WKTextCheckerClientBase'; did you mean 'WebCore::TextCheckerClient'? template<> struct ClientTraits<WKTextCheckerClientBase> { ^~~~~~~~~~~~~~~~~~~~~~~ WebCore::TextCheckerClient --- It's defined in Source/WebKit2/UIProcess/API/C/WKTextChecker.h, and that was modified a few weeks ago as part of bug #161919, r206261. Looking at that commit, it looks VERY wrong. There's a ton of defined(__APPLE__) checks which are clearly incorrect. The changes look related to toolkit, not platform. 1239489 1 jbedard 2016-10-12 13:57:59 -0700 What is the build configuration? Bug #163340 adds access for the TextChecker for testing, which should be in a file named WKTextChecker.h. What existed in WKTextChecker.h at the time should really be in a file named WKWebTextChecker.h, but renaming this file would be changing API. WKTextChecker as of bug #163340 is essentially a combination of the two headers. It breaks convention to preserve API. In all of our builds, WebTextChecker is never used on Apple's systems, and this is the reason for the defined(__APPLE__). I'm curious what you're doing to build WebTextChecker while on a system which would, at least to my understanding, usually not support it. 1239497 2 jeremyhu 2016-10-12 14:06:43 -0700 Those files are included unconditionally in PlatformGTK.cmake The configuration in question is PLATFORM(GTK) && OS(DARWIN) 1239518 3 jbedard 2016-10-12 14:55:49 -0700 I didn't know that was valid platform combination. Again, to preserve API, this patch will use #ifdefs. Since we don't usually include our platform differentiation header, those macros will not be available. This is also the method other API headers use when faced with this type of problem. I don't have a GTK on Darwin build set up on any of my local machines, and I know our automation doesn't test this configuration either (otherwise we would have caught this bug weeks ago) so I would appreciate if you could confirm that this patch fixes your problem, I'm fairly certain it will. I'll post the patch as soon as I confirm it at least builds locally for me. 1239583 4 291424 jbedard 2016-10-12 16:58:21 -0700 Created attachment 291424 Patch 1239593 5 jeremyhu 2016-10-12 17:05:22 -0700 Thanks. I'll test that and provide feedback or an updated patch. 1239648 6 jeremyhu 2016-10-12 19:41:12 -0700 Tested, looks good. Thanks. 1239823 7 291424 dbates 2016-10-13 10:20:01 -0700 Comment on attachment 291424 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=291424&action=review > Source/WebKit2/ChangeLog:3 > + [GTK] trunk r207192 fails to compile WebTextChecker* due to missing definition of WKTextCheckerClientBase Can we come up with a more descriptive title that explains that r207192 broke both GTK and EFL for Mac? > Source/WebKit2/UIProcess/API/C/WKTextChecker.cpp:30 > +#if defined(BUILDING_EFL__) || defined(BUILDING_GTK__) || !defined(__APPLE__) Is the disjunct !defined(__APPLE__) needed? It seems sufficient to omit this disjunct and it may be good to force new WebKit2 ports that make use of these functions to add to this list of defines in the hopes that when this happens they will consider separating the platform-independent functionality from the platform-specific functionality in this file. > Source/WebKit2/UIProcess/API/C/WKTextChecker.h:37 > +#if defined(BUILDING_EFL__) || defined(BUILDING_GTK__) || !defined(__APPLE__) Ditto. 1239824 8 291490 jbedard 2016-10-13 10:21:43 -0700 Created attachment 291490 Patch 1239825 9 291490 dbates 2016-10-13 10:23:01 -0700 Comment on attachment 291490 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=291490&action=review > Source/WebKit2/ChangeLog:3 > + [GTK] trunk r207192 fails to compile WebTextChecker* due to missing definition of WKTextCheckerClientBase Can we come up with a more descriptive title? See my remark in comment 7 for more details. 1239827 10 291491 jbedard 2016-10-13 10:26:59 -0700 Created attachment 291491 Patch 1239828 11 291492 jbedard 2016-10-13 10:28:02 -0700 Created attachment 291492 Patch 1239878 12 291492 commit-queue 2016-10-13 11:56:22 -0700 Comment on attachment 291492 Patch Clearing flags on attachment: 291492 Committed r207296: <http://trac.webkit.org/changeset/207296> 1239879 13 commit-queue 2016-10-13 11:56:28 -0700 All reviewed patches have been landed. Closing bug. 291424 2016-10-12 16:58:21 -0700 2016-10-13 10:21:39 -0700 Patch bug-163346-20161012165456.patch text/plain 2111 jbedard SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNzI0MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE2LTEwLTEyICBKb25hdGhh biBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBbR1RLXSB0cnVuayByMjA3 MTkyIGZhaWxzIHRvIGNvbXBpbGUgV2ViVGV4dENoZWNrZXIqIGR1ZSB0byBtaXNzaW5nIGRlZmlu aXRpb24gb2YgV0tUZXh0Q2hlY2tlckNsaWVudEJhc2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MzM0NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9DL1dLVGV4dENoZWNrZXIu Y3BwOiBGaXhlZCAjaWZkZWZzIGZvciBHVEsgYW5kIEVGTCBidWlsZHMgb24gRGFyd2luIG1hY2hp bmVzLgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQy9XS1RleHRDaGVja2VyLmg6IERpdHRvLgor CiAyMDE2LTEwLTEyICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgRml4IGFzc2VydGlvbiBhZnRlciBzd2l0Y2hpbmcgdG8gVVJMUGFyc2VyCklu ZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tUZXh0Q2hlY2tlci5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLVGV4dENoZWNrZXIu Y3BwCShyZXZpc2lvbiAyMDcyNDMpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0Mv V0tUZXh0Q2hlY2tlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI3LDcgKzI3LDcgQEAKICNpbmNs dWRlICJXS1RleHRDaGVja2VyLmgiCiAjaW5jbHVkZSAiVGV4dENoZWNrZXIuaCIKIAotI2lmICFk ZWZpbmVkKF9fQVBQTEVfXykKKyNpZiBkZWZpbmVkKEJVSUxESU5HX0VGTF9fKSB8fCBkZWZpbmVk KEJVSUxESU5HX0dUS19fKSB8fCAhZGVmaW5lZChfX0FQUExFX18pCiAjaW5jbHVkZSAiV0tBUElD YXN0LmgiCiAjaW5jbHVkZSAiV2ViUGFnZVByb3h5LmgiCiAjaW5jbHVkZSAiV2ViVGV4dENoZWNr ZXIuaCIKQEAgLTQwLDcgKzQwLDcgQEAgdm9pZCBXS1RleHRDaGVja2VyU2V0VGVzdGluZ01vZGUo Ym9vbCBlbgogICAgIFRleHRDaGVja2VyOjpzZXRUZXN0aW5nTW9kZShlbmFibGVkKTsKIH0KIAot I2lmICFkZWZpbmVkKF9fQVBQTEVfXykKKyNpZiBkZWZpbmVkKEJVSUxESU5HX0VGTF9fKSB8fCBk ZWZpbmVkKEJVSUxESU5HX0dUS19fKSB8fCAhZGVmaW5lZChfX0FQUExFX18pCiAKIHZvaWQgV0tU ZXh0Q2hlY2tlclNldENsaWVudChjb25zdCBXS1RleHRDaGVja2VyQ2xpZW50QmFzZSogd2tDbGll bnQpCiB7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tUZXh0Q2hlY2tl ci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1RleHRD aGVja2VyLmgJKHJldmlzaW9uIDIwNzI0MykKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvQy9XS1RleHRDaGVja2VyLmgJKHdvcmtpbmcgY29weSkKQEAgLTM0LDcgKzM0LDcgQEAgZXh0 ZXJuICJDIiB7CiAKIFdLX0VYUE9SVCB2b2lkIFdLVGV4dENoZWNrZXJTZXRUZXN0aW5nTW9kZShi b29sIGVuYWJsZWQpOwogCi0jaWYgIWRlZmluZWQoX19BUFBMRV9fKQorI2lmIGRlZmluZWQoQlVJ TERJTkdfRUZMX18pIHx8IGRlZmluZWQoQlVJTERJTkdfR1RLX18pIHx8ICFkZWZpbmVkKF9fQVBQ TEVfXykKIAogLy8gVGV4dENoZWNrZXIgQ2xpZW50CiB0eXBlZGVmIGJvb2wgKCpXS1RleHRDaGVj a2VyQ29udGlub3VzU3BlbGxDaGVja2luZ0FsbG93ZWQpKGNvbnN0IHZvaWQgKmNsaWVudEluZm8p Owo= 291490 2016-10-13 10:21:43 -0700 2016-10-13 10:26:55 -0700 Patch bug-163346-20161013101817.patch text/plain 2042 jbedard SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNzI0MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE2LTEwLTEyICBKb25hdGhh biBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBbR1RLXSB0cnVuayByMjA3 MTkyIGZhaWxzIHRvIGNvbXBpbGUgV2ViVGV4dENoZWNrZXIqIGR1ZSB0byBtaXNzaW5nIGRlZmlu aXRpb24gb2YgV0tUZXh0Q2hlY2tlckNsaWVudEJhc2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MzM0NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9DL1dLVGV4dENoZWNrZXIu Y3BwOiBGaXhlZCAjaWZkZWZzIGZvciBHVEsgYW5kIEVGTCBidWlsZHMgb24gRGFyd2luIG1hY2hp bmVzLgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQy9XS1RleHRDaGVja2VyLmg6IERpdHRvLgor CiAyMDE2LTEwLTEyICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgRml4IGFzc2VydGlvbiBhZnRlciBzd2l0Y2hpbmcgdG8gVVJMUGFyc2VyCklu ZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tUZXh0Q2hlY2tlci5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLVGV4dENoZWNrZXIu Y3BwCShyZXZpc2lvbiAyMDcyNDMpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0Mv V0tUZXh0Q2hlY2tlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI3LDcgKzI3LDcgQEAKICNpbmNs dWRlICJXS1RleHRDaGVja2VyLmgiCiAjaW5jbHVkZSAiVGV4dENoZWNrZXIuaCIKIAotI2lmICFk ZWZpbmVkKF9fQVBQTEVfXykKKyNpZiBkZWZpbmVkKEJVSUxESU5HX0VGTF9fKSB8fCBkZWZpbmVk KEJVSUxESU5HX0dUS19fKQogI2luY2x1ZGUgIldLQVBJQ2FzdC5oIgogI2luY2x1ZGUgIldlYlBh Z2VQcm94eS5oIgogI2luY2x1ZGUgIldlYlRleHRDaGVja2VyLmgiCkBAIC00MCw3ICs0MCw3IEBA IHZvaWQgV0tUZXh0Q2hlY2tlclNldFRlc3RpbmdNb2RlKGJvb2wgZW4KICAgICBUZXh0Q2hlY2tl cjo6c2V0VGVzdGluZ01vZGUoZW5hYmxlZCk7CiB9CiAKLSNpZiAhZGVmaW5lZChfX0FQUExFX18p CisjaWYgZGVmaW5lZChCVUlMRElOR19FRkxfXykgfHwgZGVmaW5lZChCVUlMRElOR19HVEtfXykK IAogdm9pZCBXS1RleHRDaGVja2VyU2V0Q2xpZW50KGNvbnN0IFdLVGV4dENoZWNrZXJDbGllbnRC YXNlKiB3a0NsaWVudCkKIHsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9X S1RleHRDaGVja2VyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9DL1dLVGV4dENoZWNrZXIuaAkocmV2aXNpb24gMjA3MjQzKQorKysgU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9DL1dLVGV4dENoZWNrZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMzQsNyAr MzQsNyBAQCBleHRlcm4gIkMiIHsKIAogV0tfRVhQT1JUIHZvaWQgV0tUZXh0Q2hlY2tlclNldFRl c3RpbmdNb2RlKGJvb2wgZW5hYmxlZCk7CiAKLSNpZiAhZGVmaW5lZChfX0FQUExFX18pCisjaWYg ZGVmaW5lZChCVUlMRElOR19FRkxfXykgfHwgZGVmaW5lZChCVUlMRElOR19HVEtfXykKIAogLy8g VGV4dENoZWNrZXIgQ2xpZW50CiB0eXBlZGVmIGJvb2wgKCpXS1RleHRDaGVja2VyQ29udGlub3Vz U3BlbGxDaGVja2luZ0FsbG93ZWQpKGNvbnN0IHZvaWQgKmNsaWVudEluZm8pOwo= 291491 2016-10-13 10:26:59 -0700 2016-10-13 10:27:58 -0700 Patch bug-163346-20161013102333.patch text/plain 2039 jbedard SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNzI0MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE2LTEwLTEyICBKb25hdGhh biBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBHVEsgYW5kIEVGTCBvbiBN YWMgZmFpbCB0byBjb21waWxlIFdlYlRleHRDaGVja2VyIGR1ZSB0byBtaXNzaW5nIGRlZmluaXRp b24gb2YgV0tUZXh0Q2hlY2tlckNsaWVudEJhc2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MzM0NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9DL1dLVGV4dENoZWNrZXIuY3Bw OiBGaXhlZCAjaWZkZWZzIGZvciBHVEsgYW5kIEVGTCBidWlsZHMgb24gRGFyd2luIG1hY2hpbmVz LgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQy9XS1RleHRDaGVja2VyLmg6IERpdHRvLgorCiAy MDE2LTEwLTEyICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgRml4IGFzc2VydGlvbiBhZnRlciBzd2l0Y2hpbmcgdG8gVVJMUGFyc2VyCkluZGV4 OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tUZXh0Q2hlY2tlci5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLVGV4dENoZWNrZXIuY3Bw CShyZXZpc2lvbiAyMDcyNDMpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tU ZXh0Q2hlY2tlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI3LDcgKzI3LDcgQEAKICNpbmNsdWRl ICJXS1RleHRDaGVja2VyLmgiCiAjaW5jbHVkZSAiVGV4dENoZWNrZXIuaCIKIAotI2lmICFkZWZp bmVkKF9fQVBQTEVfXykKKyNpZiBkZWZpbmVkKEJVSUxESU5HX0VGTF9fKSB8fCBkZWZpbmVkKEJV SUxESU5HX0dUS19fKQogI2luY2x1ZGUgIldLQVBJQ2FzdC5oIgogI2luY2x1ZGUgIldlYlBhZ2VQ cm94eS5oIgogI2luY2x1ZGUgIldlYlRleHRDaGVja2VyLmgiCkBAIC00MCw3ICs0MCw3IEBAIHZv aWQgV0tUZXh0Q2hlY2tlclNldFRlc3RpbmdNb2RlKGJvb2wgZW4KICAgICBUZXh0Q2hlY2tlcjo6 c2V0VGVzdGluZ01vZGUoZW5hYmxlZCk7CiB9CiAKLSNpZiAhZGVmaW5lZChfX0FQUExFX18pCisj aWYgZGVmaW5lZChCVUlMRElOR19FRkxfXykgfHwgZGVmaW5lZChCVUlMRElOR19HVEtfXykKIAog dm9pZCBXS1RleHRDaGVja2VyU2V0Q2xpZW50KGNvbnN0IFdLVGV4dENoZWNrZXJDbGllbnRCYXNl KiB3a0NsaWVudCkKIHsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1Rl eHRDaGVja2VyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9D L1dLVGV4dENoZWNrZXIuaAkocmV2aXNpb24gMjA3MjQzKQorKysgU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9DL1dLVGV4dENoZWNrZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMzQsNyArMzQs NyBAQCBleHRlcm4gIkMiIHsKIAogV0tfRVhQT1JUIHZvaWQgV0tUZXh0Q2hlY2tlclNldFRlc3Rp bmdNb2RlKGJvb2wgZW5hYmxlZCk7CiAKLSNpZiAhZGVmaW5lZChfX0FQUExFX18pCisjaWYgZGVm aW5lZChCVUlMRElOR19FRkxfXykgfHwgZGVmaW5lZChCVUlMRElOR19HVEtfXykKIAogLy8gVGV4 dENoZWNrZXIgQ2xpZW50CiB0eXBlZGVmIGJvb2wgKCpXS1RleHRDaGVja2VyQ29udGlub3VzU3Bl bGxDaGVja2luZ0FsbG93ZWQpKGNvbnN0IHZvaWQgKmNsaWVudEluZm8pOwo= 291492 2016-10-13 10:28:02 -0700 2016-10-13 11:56:22 -0700 Patch bug-163346-20161013102436.patch text/plain 2037 jbedard SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNzI0MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE2LTEwLTEyICBKb25hdGhh biBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBHVEsgYW5kIEVGTCBvbiBN YWMgZmFpbCB0byBjb21waWxlIFdlYlRleHRDaGVja2VyIGR1ZSB0byBtaXNzaW5nIGRlZmluaXRp b24gb2YgV0tUZXh0Q2hlY2tlckNsaWVudEJhc2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MzM0NgorCisgICAgICAgIFJldmlld2VkIGJ5IERhbmll bCBCYXRlcy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQy9XS1RleHRDaGVja2VyLmNwcDog Rml4ZWQgI2lmZGVmcyBmb3IgR1RLIGFuZCBFRkwgYnVpbGRzIG9uIERhcndpbiBtYWNoaW5lcy4K KyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0MvV0tUZXh0Q2hlY2tlci5oOiBEaXR0by4KKwogMjAx Ni0xMC0xMiAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAg ICAgICAgIEZpeCBhc3NlcnRpb24gYWZ0ZXIgc3dpdGNoaW5nIHRvIFVSTFBhcnNlcgpJbmRleDog U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLVGV4dENoZWNrZXIuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1RleHRDaGVja2VyLmNwcAko cmV2aXNpb24gMjA3MjQzKQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLVGV4 dENoZWNrZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNyw3ICsyNyw3IEBACiAjaW5jbHVkZSAi V0tUZXh0Q2hlY2tlci5oIgogI2luY2x1ZGUgIlRleHRDaGVja2VyLmgiCiAKLSNpZiAhZGVmaW5l ZChfX0FQUExFX18pCisjaWYgZGVmaW5lZChCVUlMRElOR19FRkxfXykgfHwgZGVmaW5lZChCVUlM RElOR19HVEtfXykKICNpbmNsdWRlICJXS0FQSUNhc3QuaCIKICNpbmNsdWRlICJXZWJQYWdlUHJv eHkuaCIKICNpbmNsdWRlICJXZWJUZXh0Q2hlY2tlci5oIgpAQCAtNDAsNyArNDAsNyBAQCB2b2lk IFdLVGV4dENoZWNrZXJTZXRUZXN0aW5nTW9kZShib29sIGVuCiAgICAgVGV4dENoZWNrZXI6OnNl dFRlc3RpbmdNb2RlKGVuYWJsZWQpOwogfQogCi0jaWYgIWRlZmluZWQoX19BUFBMRV9fKQorI2lm IGRlZmluZWQoQlVJTERJTkdfRUZMX18pIHx8IGRlZmluZWQoQlVJTERJTkdfR1RLX18pCiAKIHZv aWQgV0tUZXh0Q2hlY2tlclNldENsaWVudChjb25zdCBXS1RleHRDaGVja2VyQ2xpZW50QmFzZSog d2tDbGllbnQpCiB7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tUZXh0 Q2hlY2tlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9X S1RleHRDaGVja2VyLmgJKHJldmlzaW9uIDIwNzI0MykKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvQy9XS1RleHRDaGVja2VyLmgJKHdvcmtpbmcgY29weSkKQEAgLTM0LDcgKzM0LDcg QEAgZXh0ZXJuICJDIiB7CiAKIFdLX0VYUE9SVCB2b2lkIFdLVGV4dENoZWNrZXJTZXRUZXN0aW5n TW9kZShib29sIGVuYWJsZWQpOwogCi0jaWYgIWRlZmluZWQoX19BUFBMRV9fKQorI2lmIGRlZmlu ZWQoQlVJTERJTkdfRUZMX18pIHx8IGRlZmluZWQoQlVJTERJTkdfR1RLX18pCiAKIC8vIFRleHRD aGVja2VyIENsaWVudAogdHlwZWRlZiBib29sICgqV0tUZXh0Q2hlY2tlckNvbnRpbm91c1NwZWxs Q2hlY2tpbmdBbGxvd2VkKShjb25zdCB2b2lkICpjbGllbnRJbmZvKTsK