163340 2016-10-12 10:05:45 -0700 [SOUP] trunk r207192 fails to compile due to missing std::function being unavailable (missing #include <functional>) 2016-10-12 12:21:39 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=162910 P2 Normal --- 1 jeremyhu webkit-unassigned berto cgarcia commit-queue danw gustavo mcatanzaro mrobinson oldest_to_newest 1239340 0 jeremyhu 2016-10-12 10:05:45 -0700 In file included from Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:30: /opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-91ef51ea3f538ade6f168a1d701dab90bfbee4db/Source/WebCore/platform/network/soup/SoupNetworkSession.h:67:60: error: no template named 'function' in namespace 'std'; did you mean 'Function'? static void checkTLSErrors(SoupRequest*, SoupMessage*, std::function<void (const ResourceError&)>&&); ^~~~~~~~~~~~~ Function Source/WTF/wtf/Forward.h:70:12: note: 'Function' declared here using WTF::Function; ^ Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:330:26: error: out-of-line definition of 'checkTLSErrors' does not match any declaration in 'WebCore::SoupNetworkSession' void SoupNetworkSession::checkTLSErrors(SoupRequest* soupRequest, SoupMessage* message, std::function<void (const ResourceError&)>&& completionHandler) ^~~~~~~~~~~~~~ 2 errors generated. --- It looks like a missing #include <functional> in r206807, https://bugs.webkit.org/show_bug.cgi?id=162910 1239343 1 291365 jeremyhu 2016-10-12 10:13:13 -0700 Created attachment 291365 0001-Fix-a-build-failure-with-clang-due-to-std-function-u.patch 1239345 2 291365 cgarcia 2016-10-12 10:17:09 -0700 Comment on attachment 291365 0001-Fix-a-build-failure-with-clang-due-to-std-function-u.patch View in context: https://bugs.webkit.org/attachment.cgi?id=291365&action=review Thanks > Source/WebCore/ChangeLog:4 > + Fix a build failure with clang due to std::function usage without #include <functional> > + https://bugs.webkit.org/show_bug.cgi?id=163340 Please, use the bug title here, prepare-changelog should do that for you. 1239354 3 jeremyhu 2016-10-12 10:33:53 -0700 Oh cool. I thought it just created a template in the ChangeLog that I fill out with the title and the URL. I didn't realize I could pass args to it to do the dirty work for me! I need to head out, but I'll get an update later today. 1239368 4 291370 jeremyhu 2016-10-12 11:16:09 -0700 Created attachment 291370 0001-SOUP-trunk-r207192-fails-to-compile-due-to-missing-s.patch Updated ChangeLog to match title of the bug report 1239423 5 291370 commit-queue 2016-10-12 12:21:35 -0700 Comment on attachment 291370 0001-SOUP-trunk-r207192-fails-to-compile-due-to-missing-s.patch Clearing flags on attachment: 291370 Committed r207232: <http://trac.webkit.org/changeset/207232> 1239424 6 commit-queue 2016-10-12 12:21:39 -0700 All reviewed patches have been landed. Closing bug. 291365 2016-10-12 10:13:13 -0700 2016-10-12 11:16:09 -0700 0001-Fix-a-build-failure-with-clang-due-to-std-function-u.patch 0001-Fix-a-build-failure-with-clang-due-to-std-function-u.patch text/plain 1694 jeremyhu RnJvbSA2Y2I2Mjk1MTQzNzhlYTk0Mzk2MTcwODFmZWJiNGFhMWVjOWZhMzVmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZXJlbXkgSHVkZGxlc3RvbiBTZXF1b2lhIDxqZXJlbXlodUBh cHBsZS5jb20+CkRhdGU6IFdlZCwgMTIgT2N0IDIwMTYgMTA6MDY6NDcgLTA3MDAKU3ViamVjdDog W1BBVENIXSBGaXggYSBidWlsZCBmYWlsdXJlIHdpdGggY2xhbmcgZHVlIHRvIHN0ZDo6ZnVuY3Rp b24gdXNhZ2UKIHdpdGhvdXQgI2luY2x1ZGUgPGZ1bmN0aW9uYWw+CgpodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzMzQwCgpTaWduZWQtb2ZmLWJ5OiBKZXJlbXkgSHVk ZGxlc3RvbiBTZXF1b2lhIDxqZXJlbXlodUBhcHBsZS5jb20+Ci0tLQogU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgOSArKysrKysrKysK IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9Tb3VwTmV0d29ya1Nlc3Npb24u aCB8IDEgKwogMiBmaWxlcyBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4 IDlkMzA1MjMuLjk4Y2MzNTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwor KysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxNi0xMC0x MiAgSmVyZW15IEh1ZGRsZXN0b24gU2VxdW9pYSAgPGplcmVteWh1QGFwcGxlLmNvbT4KKworICAg ICAgICBGaXggYSBidWlsZCBmYWlsdXJlIHdpdGggY2xhbmcgZHVlIHRvIHN0ZDo6ZnVuY3Rpb24g dXNhZ2Ugd2l0aG91dCAjaW5jbHVkZSA8ZnVuY3Rpb25hbD4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MzM0MAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9zb3VwL1NvdXBO ZXR3b3JrU2Vzc2lvbi5oOiBBZGQgbWlzc2luZyAjaW5jbHVkZSA8ZnVuY3Rpb25hbD4KKwogMjAx Ni0xMC0xMiAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgQXR0 cmlidXRlIHNldHRlciBiaW5kaW5nIGdlbmVyYXRlZCBjb2RlIHNob3VsZCB1c2UgbW9yZSByZWZl cmVuY2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAv U291cE5ldHdvcmtTZXNzaW9uLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3Nv dXAvU291cE5ldHdvcmtTZXNzaW9uLmgKaW5kZXggOWYxYzE4My4uMDEzMmNiNCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1NvdXBOZXR3b3JrU2Vzc2lv bi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9Tb3VwTmV0d29y a1Nlc3Npb24uaApAQCAtMjYsNiArMjYsNyBAQAogI2lmbmRlZiBTb3VwTmV0d29ya1Nlc3Npb25f aAogI2RlZmluZSBTb3VwTmV0d29ya1Nlc3Npb25faAogCisjaW5jbHVkZSA8ZnVuY3Rpb25hbD4K ICNpbmNsdWRlIDx3dGYvTm9uY29weWFibGUuaD4KICNpbmNsdWRlIDx3dGYvVmVjdG9yLmg+CiAj aW5jbHVkZSA8d3RmL2dsaWIvR1JlZlB0ci5oPgotLSAKMi4xMC4xCgo= 291370 2016-10-12 11:16:09 -0700 2016-10-12 12:21:35 -0700 0001-SOUP-trunk-r207192-fails-to-compile-due-to-missing-s.patch 0001-SOUP-trunk-r207192-fails-to-compile-due-to-missing-s.patch text/plain 1752 jeremyhu RnJvbSBhNTAxZTc0ZTdhY2RkYjRhZGM2Mzg4MDllOTVkYmY4OTQyN2M0YjhmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZXJlbXkgSHVkZGxlc3RvbiBTZXF1b2lhIDxqZXJlbXlodUBh cHBsZS5jb20+CkRhdGU6IFdlZCwgMTIgT2N0IDIwMTYgMTE6MTE6NDYgLTA3MDAKU3ViamVjdDog W1BBVENIXSBbU09VUF0gdHJ1bmsgcjIwNzE5MiBmYWlscyB0byBjb21waWxlIGR1ZSB0byBtaXNz aW5nCiBzdGQ6OmZ1bmN0aW9uIGJlaW5nIHVuYXZhaWxhYmxlIChtaXNzaW5nICNpbmNsdWRlIDxm dW5jdGlvbmFsPikKCmh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjMz NDAKClNpZ25lZC1vZmYtYnk6IEplcmVteSBIdWRkbGVzdG9uIFNlcXVvaWEgPGplcmVteWh1QGFw cGxlLmNvbT4KLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCA5ICsrKysrKysrKwogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9zb3VwL1NvdXBOZXR3b3JrU2Vzc2lvbi5oIHwgMSArCiAyIGZpbGVzIGNoYW5nZWQsIDEw IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWQzMDUyMy4uNzVmMDY2OCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDEyIEBACisyMDE2LTEwLTEyICBKZXJlbXkgSHVkZGxlc3RvbiBTZXF1b2lh ICA8amVyZW15aHVAYXBwbGUuY29tPgorCisgICAgICAgIFtTT1VQXSB0cnVuayByMjA3MTkyIGZh aWxzIHRvIGNvbXBpbGUgZHVlIHRvIG1pc3Npbmcgc3RkOjpmdW5jdGlvbiBiZWluZyB1bmF2YWls YWJsZSAobWlzc2luZyAjaW5jbHVkZSA8ZnVuY3Rpb25hbD4pCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjMzNDAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9Tb3Vw TmV0d29ya1Nlc3Npb24uaDogQWRkIG1pc3NpbmcgI2luY2x1ZGUgPGZ1bmN0aW9uYWw+CisKIDIw MTYtMTAtMTIgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIEF0 dHJpYnV0ZSBzZXR0ZXIgYmluZGluZyBnZW5lcmF0ZWQgY29kZSBzaG91bGQgdXNlIG1vcmUgcmVm ZXJlbmNlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3Vw L1NvdXBOZXR3b3JrU2Vzc2lvbi5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9z b3VwL1NvdXBOZXR3b3JrU2Vzc2lvbi5oCmluZGV4IDlmMWMxODMuLjAxMzJjYjQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9Tb3VwTmV0d29ya1Nlc3Np b24uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvU291cE5ldHdv cmtTZXNzaW9uLmgKQEAgLTI2LDYgKzI2LDcgQEAKICNpZm5kZWYgU291cE5ldHdvcmtTZXNzaW9u X2gKICNkZWZpbmUgU291cE5ldHdvcmtTZXNzaW9uX2gKIAorI2luY2x1ZGUgPGZ1bmN0aW9uYWw+ CiAjaW5jbHVkZSA8d3RmL05vbmNvcHlhYmxlLmg+CiAjaW5jbHVkZSA8d3RmL1ZlY3Rvci5oPgog I2luY2x1ZGUgPHd0Zi9nbGliL0dSZWZQdHIuaD4KLS0gCjIuMTAuMQoK