163317 2016-10-11 21:57:19 -0700 Annotate bots in contributors.json and don't show them on webkit.org/team 2016-10-14 11:29:59 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser ap commit-queue dbates glenn lforschler simon.fraser timothy oldest_to_newest 1239177 0 simon.fraser 2016-10-11 21:57:19 -0700 Annotate bots in contributors.json and don't show them on webkit.org/team 1240105 1 291568 simon.fraser 2016-10-13 22:27:51 -0700 Created attachment 291568 Patch 1240107 2 commit-queue 2016-10-13 22:30:00 -0700 Attachment 291568 did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1240335 3 291568 dbates 2016-10-14 10:41:19 -0700 Comment on attachment 291568 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=291568&action=review > Tools/ChangeLog:16 > + (Reviewer.__init__): Deleted. This was not deleted. This is a bug in prepare-ChangeLog assuming you used prepare-ChangeLog to generate this change log. Please file a bug for this and attach this patch. 1240366 4 simon.fraser 2016-10-14 11:29:59 -0700 https://trac.webkit.org/r207350 291568 2016-10-13 22:27:51 -0700 2016-10-14 10:41:19 -0700 Patch bug-163317-20161013222425.patch text/plain 5494 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3MzIxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTc1Zjg4MWE5NjQ4M2JhNzAzZDE2YTRlZDJhMGJlZWQw MjU4YTk5Mi4uNWI4NDczYzlkODliOTUzMjM4YjMwOTYwZjdiMzBmNzZhMWI3ZTU3OCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDE2LTEwLTEzICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgor CisgICAgICAgIEFubm90YXRlIGJvdHMgaW4gY29udHJpYnV0b3JzLmpzb24gYW5kIGRvbid0IHNo b3cgdGhlbSBvbiB3ZWJraXQub3JnL3RlYW0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE2MzMxNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorICAgICAgICAKKyAgICAgICAgQWRkICJjbGFzcyIgOiAiYm90IiBmb3Igbm9uLWh1 bWFucyBpbiBjb250cmlidXRvcnMuanNvbiBhbmQgcm91bmQtdHJpcCBpdC4KKworICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9jb21taXR0ZXJzLnB5OgorICAgICAgICAo Q29udHJpYnV0b3IuX19pbml0X18pOgorICAgICAgICAoQ29udHJpYnV0b3IuYXNfZGljdCk6Cisg ICAgICAgIChCb3QpOgorICAgICAgICAoQm90Ll9faW5pdF9fKToKKyAgICAgICAgKENvbW1pdHRl ckxpc3QubG9hZF9qc29uKToKKyAgICAgICAgKFJldmlld2VyLl9faW5pdF9fKTogRGVsZXRlZC4K KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvY29udHJpYnV0b3JzLmpz b246CisKIDIwMTYtMTAtMTMgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0 Lm9yZz4KIAogICAgICAgICBIb3N0cyBvZiBVUkxzIHdpdGggbm9uLXNwZWNpYWwgc2NoZW1lcyBz aG91bGQgYmUgY2FzZS1zZW5zaXRpdmUsIGFuZCBub24tQVNDSUkgY2hhcmFjdGVycyBpbiBzdWNo IGhvc3RzIHNob3VsZCBiZSBwdW55Y29kZS1lbmNvZGVkCmRpZmYgLS1naXQgYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvY29tbWl0dGVycy5weSBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvY29tbW9uL2NvbmZpZy9jb21taXR0ZXJzLnB5CmluZGV4IGFjNGZiYmNmMWIxM2I0 MzExZDhiMGE1Nzk3ZjQxZjU4ZWU2NGExMDkuLjQ5Y2I0M2U2M2NlYzlmMWFkYTY2OTA4ZTc1OTI3 NDEyOTEwZDM0Y2MgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2Nv bmZpZy9jb21taXR0ZXJzLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2Nv bmZpZy9jb21taXR0ZXJzLnB5CkBAIC02Miw2ICs2Miw3IEBAIGNsYXNzIENvbnRyaWJ1dG9yKG9i amVjdCk6CiAgICAgICAgIHNlbGYuZXhwZXJ0aXNlID0gZXhwZXJ0aXNlCiAgICAgICAgIHNlbGYu Y2FuX2NvbW1pdCA9IEZhbHNlCiAgICAgICAgIHNlbGYuY2FuX3JldmlldyA9IEZhbHNlCisgICAg ICAgIHNlbGYuaXNfYm90ID0gRmFsc2UKIAogICAgIGRlZiBidWd6aWxsYV9lbWFpbChzZWxmKToK ICAgICAgICAgIyBGSVhNRTogV2UncmUgYXNzdW1pbmcgdGhlIGZpcnN0IGVtYWlsIGlzIGEgdmFs aWQgYnVnemlsbGEgZW1haWwsCkBAIC0xNDYsNiArMTQ3LDkgQEAgY2xhc3MgQ29udHJpYnV0b3Io b2JqZWN0KToKICAgICAgICAgaWYgc2VsZi5leHBlcnRpc2U6CiAgICAgICAgICAgICBpbmZvWyJl eHBlcnRpc2UiXSA9IHNlbGYuZXhwZXJ0aXNlCiAKKyAgICAgICAgaWYgc2VsZi5pc19ib3Q6Cisg ICAgICAgICAgICBpbmZvWyJjbGFzcyJdID0gImJvdCIKKwogICAgICAgICByZXR1cm4gaW5mbwog CiAKQEAgLTE2MSw2ICsxNjUsMTEgQEAgY2xhc3MgUmV2aWV3ZXIoQ29tbWl0dGVyKToKICAgICAg ICAgc2VsZi5jYW5fcmV2aWV3ID0gVHJ1ZQogCiAKK2NsYXNzIEJvdChDb250cmlidXRvcik6Cisg ICAgZGVmIF9faW5pdF9fKHNlbGYsIG5hbWUsIGVtYWlsX29yX2VtYWlscywgaXJjX25pY2tuYW1l PU5vbmUsIGFsaWFzX29yX2FsaWFzZXM9Tm9uZSwgZXhwZXJ0aXNlPU5vbmUpOgorICAgICAgICBD b250cmlidXRvci5fX2luaXRfXyhzZWxmLCBuYW1lLCBlbWFpbF9vcl9lbWFpbHMsIGlyY19uaWNr bmFtZSwgYWxpYXNfb3JfYWxpYXNlcywgZXhwZXJ0aXNlKQorICAgICAgICBzZWxmLmlzX2JvdCA9 IFRydWUKKwogY2xhc3MgQ29tbWl0dGVyTGlzdChvYmplY3QpOgogCiAgICAgIyBDb21taXR0ZXJz IGFuZCByZXZpZXdlcnMgYXJlIHBhc3NlZCBpbiB0byBhbGxvdyBlYXN5IHRlc3RpbmcKQEAgLTE5 OSw2ICsyMDgsOCBAQCBjbGFzcyBDb21taXR0ZXJMaXN0KG9iamVjdCk6CiAgICAgICAgICAgICBl bGlmIHN0YXR1cyA9PSAiY29tbWl0dGVyIjoKICAgICAgICAgICAgICAgICBjb250cmlidXRvciA9 IENvbW1pdHRlcihuYW1lLCBkYXRhLmdldCgnZW1haWxzJyksIGRhdGEuZ2V0KCduaWNrcycpLCBk YXRhLmdldCgnYWxpYXNlcycpLCBkYXRhLmdldCgnZXhwZXJ0aXNlJykpCiAgICAgICAgICAgICAg ICAgc2VsZi5fY29tbWl0dGVycy5hcHBlbmQoY29udHJpYnV0b3IpCisgICAgICAgICAgICBlbGlm IGRhdGEuZ2V0KCdjbGFzcycpID09ICdib3QnOgorICAgICAgICAgICAgICAgIGNvbnRyaWJ1dG9y ID0gQm90KG5hbWUsIGRhdGEuZ2V0KCdlbWFpbHMnKSwgZGF0YS5nZXQoJ25pY2tzJyksIGRhdGEu Z2V0KCdhbGlhc2VzJyksIGRhdGEuZ2V0KCdleHBlcnRpc2UnKSkKICAgICAgICAgICAgIGVsc2U6 CiAgICAgICAgICAgICAgICAgY29udHJpYnV0b3IgPSBDb250cmlidXRvcihuYW1lLCBkYXRhLmdl dCgnZW1haWxzJyksIGRhdGEuZ2V0KCduaWNrcycpLCBkYXRhLmdldCgnYWxpYXNlcycpLCBkYXRh LmdldCgnZXhwZXJ0aXNlJykpCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv Y29tbW9uL2NvbmZpZy9jb250cmlidXRvcnMuanNvbiBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv Y29tbW9uL2NvbmZpZy9jb250cmlidXRvcnMuanNvbgppbmRleCAyMGM1ZjFkNjgzNDJkNjU2YmY4 MTA5NDhjY2M4ODgyOGJiMGI0YjY0Li4yYTFjMDhkYWY4NzU2ZGYxNzNlODBhZDc0YjJiNjJhMDgz ZjhmNzJiIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcv Y29udHJpYnV0b3JzLmpzb24KKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29u ZmlnL2NvbnRyaWJ1dG9ycy5qc29uCkBAIC0xNDksNiArMTQ5LDcgQEAKICAgICAgICJzdGF0dXMi IDogImNvbW1pdHRlciIKICAgIH0sCiAgICAiQWRvYmUgQnVnIFRyYWNrZXIiIDogeworICAgICAg ImNsYXNzIiA6ICJib3QiLAogICAgICAgImVtYWlscyIgOiBbCiAgICAgICAgICAiV2Via2l0QnVn VHJhY2tlckBhZG9iZS5jb20iCiAgICAgICBdCkBAIC0xMjU4LDYgKzEyNTksNyBAQAogICAgICAg InN0YXR1cyIgOiAiY29tbWl0dGVyIgogICAgfSwKICAgICJDb21taXQgUXVldWUiIDogeworICAg ICAgImNsYXNzIiA6ICJib3QiLAogICAgICAgImVtYWlscyIgOiBbCiAgICAgICAgICAiY29tbWl0 LXF1ZXVlQHdlYmtpdC5vcmciCiAgICAgICBdCkBAIC00NTEzLDYgKzQ1MTUsNyBAQAogICAgICAg InN0YXR1cyIgOiAiY29tbWl0dGVyIgogICAgfSwKICAgICJSYWRhciBXZWJLaXQgQnVnIEltcG9y dGVyIiA6IHsKKyAgICAgICJjbGFzcyIgOiAiYm90IiwKICAgICAgICJlbWFpbHMiIDogWwogICAg ICAgICAgIndlYmtpdC1idWctaW1wb3J0ZXJAZ3JvdXAuYXBwbGUuY29tIgogICAgICAgXQpAQCAt NTQ2MCw2ICs1NDYzLDcgQEAKICAgICAgIF0KICAgIH0sCiAgICAiV2ViS2l0IFJldmlldyBCb3Qi IDogeworICAgICAgImNsYXNzIiA6ICJib3QiLAogICAgICAgImVtYWlscyIgOiBbCiAgICAgICAg ICAid2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tIgogICAgICAgXSwKQEAgLTU0NjgsNiArNTQ3 Miw3IEBACiAgICAgICBdCiAgICB9LAogICAgIldlYktpdEdUSysgQnVncyIgOiB7CisgICAgICAi Y2xhc3MiIDogImJvdCIsCiAgICAgICAiZW1haWxzIiA6IFsKICAgICAgICAgICJidWdzLW5vcmVw bHlAd2Via2l0Z3RrLm9yZyIKICAgICAgIF0KZGlmZiAtLWdpdCBhL1dlYnNpdGVzL3dlYmtpdC5v cmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvd2Via2l0Lm9yZy9DaGFuZ2VMb2cKaW5kZXggNmNlMTNk ODE2NjhiYWUwMGU4ODlkZDcyMWRiNDMwMGIyZmMzYTE4Yi4uZDg1NzEyY2M2OWViYzZiYTc0YWZi NWUyMWQ4ZDcyNjkzZmIwOTA2MSAxMDA2NDQKLS0tIGEvV2Vic2l0ZXMvd2Via2l0Lm9yZy9DaGFu Z2VMb2cKKysrIGIvV2Vic2l0ZXMvd2Via2l0Lm9yZy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBA QAorMjAxNi0xMC0xMyAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKwor ICAgICAgICBBbm5vdGF0ZSBib3RzIGluIGNvbnRyaWJ1dG9ycy5qc29uIGFuZCBkb24ndCBzaG93 IHRoZW0gb24gd2Via2l0Lm9yZy90ZWFtCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNjMzMTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKyAgICAgICAgCisgICAgICAgIERvbid0IHNob3cgYm90cy4KKworICAgICAgICAqIHdw LWNvbnRlbnQvdGhlbWVzL3dlYmtpdC90ZWFtLnBocDoKKwogMjAxNi0xMC0xMiAgS2VpdGggTWls bGVyICA8a2VpdGhfbWlsbGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBCMyBuZWVkcyBhIHNwZWNp YWwgV2FzbUJvdW5kc0NoZWNrIE9wY29kZQpkaWZmIC0tZ2l0IGEvV2Vic2l0ZXMvd2Via2l0Lm9y Zy93cC1jb250ZW50L3RoZW1lcy93ZWJraXQvdGVhbS5waHAgYi9XZWJzaXRlcy93ZWJraXQub3Jn L3dwLWNvbnRlbnQvdGhlbWVzL3dlYmtpdC90ZWFtLnBocAppbmRleCA1NTgxZDk2NjRmNDZlZGRj YzBmZWFlMjFlMDcxNDBiM2VkMWQ5ZjM1Li44NDA4MGYwNDA1ZWIyYjlhMGFhM2NmNjYwYmViNDk0 NDEwZjg1M2E3IDEwMDY0NAotLS0gYS9XZWJzaXRlcy93ZWJraXQub3JnL3dwLWNvbnRlbnQvdGhl bWVzL3dlYmtpdC90ZWFtLnBocAorKysgYi9XZWJzaXRlcy93ZWJraXQub3JnL3dwLWNvbnRlbnQv dGhlbWVzL3dlYmtpdC90ZWFtLnBocApAQCAtMTM1LDYgKzEzNSw4IEBAIGZ1bmN0aW9uIHBhcnNl Q29udHJpYnV0b3JzSlNPTih0ZXh0KSB7CiAKICAgICBmb3IgKHZhciBjb250cmlidXRvciBpbiBj b250cmlidXRvcnNKU09OKSB7CiAgICAgICAgIHZhciBkYXRhID0gY29udHJpYnV0b3JzSlNPTltj b250cmlidXRvcl07CisgICAgICAgIGlmIChkYXRhLmNsYXNzID09ICJib3QiKQorICAgICAgICAg ICAgY29udGludWU7CiAgICAgICAgIGNvbnRyaWJ1dG9ycy5wdXNoKHsKICAgICAgICAgICAgIG5h bWU6IGNvbnRyaWJ1dG9yLAogICAgICAgICAgICAga2luZDogZGF0YS5zdGF0dXMgPyBkYXRhLnN0 YXR1cyA6ICdjb250cmlidXRvcicsCg==