163311 2016-10-11 19:47:25 -0700 Update DeviceProximityEvent to stop using legacy [ConstructorTemplate=Event] 2016-10-11 21:49:41 -0700 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez cdumez commit-queue darin esprehn+autocc kondapallykalyan rniwa sam oldest_to_newest 1239142 0 cdumez 2016-10-11 19:47:25 -0700 Update DeviceProximityEvent to stop using legacy [ConstructorTemplate=Event] and use a regular constructor instead, as in the specification: - https://www.w3.org/TR/2015/WD-proximity-20150903/#deviceproximityevent-interface 1239143 1 291328 cdumez 2016-10-11 19:48:58 -0700 Created attachment 291328 Patch 1239169 2 291328 rniwa 2016-10-11 21:27:09 -0700 Comment on attachment 291328 Patch Does anyone enable this API? 1239171 3 cdumez 2016-10-11 21:30:45 -0700 (In reply to comment #2) > Comment on attachment 291328 [details] > Patch > > Does anyone enable this API? Not that I know but I figured I would update all events just in case. 1239173 4 291328 commit-queue 2016-10-11 21:49:36 -0700 Comment on attachment 291328 Patch Clearing flags on attachment: 291328 Committed r207187: <http://trac.webkit.org/changeset/207187> 1239174 5 commit-queue 2016-10-11 21:49:41 -0700 All reviewed patches have been landed. Closing bug. 291328 2016-10-11 19:48:58 -0700 2016-10-11 21:49:36 -0700 Patch bug-163311-20161011194535.patch text/plain 5567 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3MTg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmVkOTRjZGQzNTAwODgw NTQ2ZWY1MjdkY2Y4NTk2MWQxOGVkNjcyNC4uNGUzNWMzMmRkNzA5ZjVkMGRiZTdhZWMzNWZhZDhk NjdmNTNiMTBmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE2LTEwLTExICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgVXBkYXRlIERldmljZVByb3hp bWl0eUV2ZW50IHRvIHN0b3AgdXNpbmcgbGVnYWN5IFtDb25zdHJ1Y3RvclRlbXBsYXRlPUV2ZW50 XQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzMzEx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRl IERldmljZVByb3hpbWl0eUV2ZW50IHRvIHN0b3AgdXNpbmcgbGVnYWN5IFtDb25zdHJ1Y3RvclRl bXBsYXRlPUV2ZW50XQorICAgICAgICBhbmQgdXNlIGEgcmVndWxhciBjb25zdHJ1Y3RvciBpbnN0 ZWFkLCBhcyBpbiB0aGUgc3BlY2lmaWNhdGlvbjoKKyAgICAgICAgLSBodHRwczovL3d3dy53My5v cmcvVFIvMjAxNS9XRC1wcm94aW1pdHktMjAxNTA5MDMvI2RldmljZXByb3hpbWl0eWV2ZW50LWlu dGVyZmFjZQorCisgICAgICAgICogTW9kdWxlcy9wcm94aW1pdHkvRGV2aWNlUHJveGltaXR5RXZl bnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RGV2aWNlUHJveGltaXR5RXZlbnQ6OkRldmljZVBy b3hpbWl0eUV2ZW50KToKKyAgICAgICAgKiBNb2R1bGVzL3Byb3hpbWl0eS9EZXZpY2VQcm94aW1p dHlFdmVudC5oOgorICAgICAgICAoV2ViQ29yZTo6RGV2aWNlUHJveGltaXR5RXZlbnQ6OmNyZWF0 ZSk6CisgICAgICAgIChXZWJDb3JlOjpEZXZpY2VQcm94aW1pdHlFdmVudEluaXQ6OkRldmljZVBy b3hpbWl0eUV2ZW50SW5pdCk6IERlbGV0ZWQuCisgICAgICAgICogTW9kdWxlcy9wcm94aW1pdHkv RGV2aWNlUHJveGltaXR5RXZlbnQuaWRsOgorCiAyMDE2LTEwLTExICBHeXV5b3VuZyBLaW0gIDxn eXV5b3VuZy5raW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCBFRkwgYnVpbGQg Zml4IGJlY2F1c2Ugb2YgcjIwNzE3My4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvcHJveGltaXR5L0RldmljZVByb3hpbWl0eUV2ZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvcHJveGltaXR5L0RldmljZVByb3hpbWl0eUV2ZW50LmNwcAppbmRleCBlMzJjMGNiNmQ2 ZmM5YmRiOWVkNDY3OWE1NThkODU0NGRlYWY4ZDk3Li4wNmJmMDFlYjk1Yzg5OWM5ZWJiYjhmNGQ2 ZjcyMmM4ZjE4MjQ4OTI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3Byb3hp bWl0eS9EZXZpY2VQcm94aW1pdHlFdmVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxl cy9wcm94aW1pdHkvRGV2aWNlUHJveGltaXR5RXZlbnQuY3BwCkBAIC0zOSwxMSArMzksMTEgQEAg RGV2aWNlUHJveGltaXR5RXZlbnQ6OkRldmljZVByb3hpbWl0eUV2ZW50KGNvbnN0IEF0b21pY1N0 cmluZyYgZXZlbnRUeXBlLCBjb25zdAogewogfQogCi1EZXZpY2VQcm94aW1pdHlFdmVudDo6RGV2 aWNlUHJveGltaXR5RXZlbnQoY29uc3QgQXRvbWljU3RyaW5nJiBldmVudFR5cGUsIGNvbnN0IERl dmljZVByb3hpbWl0eUV2ZW50SW5pdCYgaW5pdGlhbGl6ZXIpCi0gICAgOiBFdmVudChldmVudFR5 cGUsIGluaXRpYWxpemVyKQotICAgICwgbV92YWx1ZShpbml0aWFsaXplci52YWx1ZSkKLSAgICAs IG1fbWluKGluaXRpYWxpemVyLm1pbikKLSAgICAsIG1fbWF4KGluaXRpYWxpemVyLm1heCkKK0Rl dmljZVByb3hpbWl0eUV2ZW50OjpEZXZpY2VQcm94aW1pdHlFdmVudChjb25zdCBBdG9taWNTdHJp bmcmIGV2ZW50VHlwZSwgY29uc3QgSW5pdCYgaW5pdGlhbGl6ZXIsIElzVHJ1c3RlZCBpc1RydXN0 ZWQpCisgICAgOiBFdmVudChldmVudFR5cGUsIGluaXRpYWxpemVyLCBpc1RydXN0ZWQpCisgICAg LCBtX3ZhbHVlKGluaXRpYWxpemVyLnZhbHVlID8gKmluaXRpYWxpemVyLnZhbHVlIDogc3RkOjpu dW1lcmljX2xpbWl0czxkb3VibGU+OjppbmZpbml0eSgpKQorICAgICwgbV9taW4oaW5pdGlhbGl6 ZXIubWluID8gKmluaXRpYWxpemVyLm1pbiA6IC1zdGQ6Om51bWVyaWNfbGltaXRzPGRvdWJsZT46 OmluZmluaXR5KCkpCisgICAgLCBtX21heChpbml0aWFsaXplci5tYXggPyAqaW5pdGlhbGl6ZXIu bWF4IDogc3RkOjpudW1lcmljX2xpbWl0czxkb3VibGU+OjppbmZpbml0eSgpKQogewogfQogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3Byb3hpbWl0eS9EZXZpY2VQcm94aW1p dHlFdmVudC5oIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9wcm94aW1pdHkvRGV2aWNlUHJveGlt aXR5RXZlbnQuaAppbmRleCBlMjk3YzZlODQwNmQ5MjlhNzRmNjVmOTIwNzAzYjkzN2I0N2RiN2M0 Li45NTkyY2JmNWU3Y2MwMGZjMjI4NGQwZDhmOGExNzY0NDRmMDExMDQ5IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3Byb3hpbWl0eS9EZXZpY2VQcm94aW1pdHlFdmVudC5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvcHJveGltaXR5L0RldmljZVByb3hpbWl0eUV2ZW50 LmgKQEAgLTI2LDIyICsyNiw2IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotc3RydWN0IERl dmljZVByb3hpbWl0eUV2ZW50SW5pdCA6IHB1YmxpYyBFdmVudEluaXQgewotICAgIERldmljZVBy b3hpbWl0eUV2ZW50SW5pdCgpCi0gICAgICAgIDogdmFsdWUoc3RkOjpudW1lcmljX2xpbWl0czxk b3VibGU+OjppbmZpbml0eSgpKQotICAgICAgICAsIG1pbigtc3RkOjpudW1lcmljX2xpbWl0czxk b3VibGU+OjppbmZpbml0eSgpKQotICAgICAgICAsIG1heChzdGQ6Om51bWVyaWNfbGltaXRzPGRv dWJsZT46OmluZmluaXR5KCkpCi0gICAgewotICAgICAgICAvLyBEZWZhdWx0IHZhbHVlIG9mIGJ1 YmJsZXMgaXMgdHJ1ZSBieSB0aGUgUHJveGltaXR5IEV2ZW50cyBzcGVjLgotICAgICAgICAvLyBo dHRwOi8vd3d3LnczLm9yZy9UUi9wcm94aW1pdHkvI2RldmljZXByb3hpbWl0eWV2ZW50LWludGVy ZmFjZQotICAgICAgICBidWJibGVzID0gdHJ1ZTsKLSAgICB9OwotCi0gICAgZG91YmxlIHZhbHVl OwotICAgIGRvdWJsZSBtaW47Ci0gICAgZG91YmxlIG1heDsKLX07Ci0KIGNsYXNzIERldmljZVBy b3hpbWl0eUV2ZW50IDogcHVibGljIEV2ZW50IHsKIHB1YmxpYzoKICAgICB+RGV2aWNlUHJveGlt aXR5RXZlbnQoKSB7IH0KQEAgLTU2LDkgKzQwLDE1IEBAIHB1YmxpYzoKICAgICAgICAgcmV0dXJu IGFkb3B0UmVmKCpuZXcgRGV2aWNlUHJveGltaXR5RXZlbnQoZXZlbnRUeXBlLCB2YWx1ZSwgbWlu LCBtYXgpKTsKICAgICB9CiAKLSAgICBzdGF0aWMgUmVmPERldmljZVByb3hpbWl0eUV2ZW50PiBj cmVhdGUoY29uc3QgQXRvbWljU3RyaW5nJiB0eXBlLCBjb25zdCBEZXZpY2VQcm94aW1pdHlFdmVu dEluaXQmIGluaXRpYWxpemVyKQorICAgIHN0cnVjdCBJbml0IDogRXZlbnRJbml0IHsKKyAgICAg ICAgT3B0aW9uYWw8ZG91YmxlPiB2YWx1ZTsKKyAgICAgICAgT3B0aW9uYWw8ZG91YmxlPiBtaW47 CisgICAgICAgIE9wdGlvbmFsPGRvdWJsZT4gbWF4OworICAgIH07CisKKyAgICBzdGF0aWMgUmVm PERldmljZVByb3hpbWl0eUV2ZW50PiBjcmVhdGUoY29uc3QgQXRvbWljU3RyaW5nJiB0eXBlLCBj b25zdCBJbml0JiBpbml0aWFsaXplciwgSXNUcnVzdGVkIGlzVHJ1c3RlZCA9IElzVHJ1c3RlZDo6 Tm8pCiAgICAgewotICAgICAgICByZXR1cm4gYWRvcHRSZWYoKm5ldyBEZXZpY2VQcm94aW1pdHlF dmVudCh0eXBlLCBpbml0aWFsaXplcikpOworICAgICAgICByZXR1cm4gYWRvcHRSZWYoKm5ldyBE ZXZpY2VQcm94aW1pdHlFdmVudCh0eXBlLCBpbml0aWFsaXplciwgaXNUcnVzdGVkKSk7CiAgICAg fQogCiAgICAgZG91YmxlIHZhbHVlKCkgeyByZXR1cm4gbV92YWx1ZTsgfQpAQCAtNzAsNyArNjAs NyBAQCBwdWJsaWM6CiBwcml2YXRlOgogICAgIERldmljZVByb3hpbWl0eUV2ZW50KCk7CiAgICAg RGV2aWNlUHJveGltaXR5RXZlbnQoY29uc3QgQXRvbWljU3RyaW5nJiBldmVudFR5cGUsIGNvbnN0 IGRvdWJsZSB2YWx1ZSwgY29uc3QgZG91YmxlIG1pbiwgY29uc3QgZG91YmxlIG1heCk7Ci0gICAg RGV2aWNlUHJveGltaXR5RXZlbnQoY29uc3QgQXRvbWljU3RyaW5nJiBldmVudFR5cGUsIGNvbnN0 IERldmljZVByb3hpbWl0eUV2ZW50SW5pdCYpOworICAgIERldmljZVByb3hpbWl0eUV2ZW50KGNv bnN0IEF0b21pY1N0cmluZyYgZXZlbnRUeXBlLCBjb25zdCBJbml0JiwgSXNUcnVzdGVkKTsKIAog ICAgIGRvdWJsZSBtX3ZhbHVlOwogICAgIGRvdWJsZSBtX21pbjsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvcHJveGltaXR5L0RldmljZVByb3hpbWl0eUV2ZW50LmlkbCBiL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvcHJveGltaXR5L0RldmljZVByb3hpbWl0eUV2ZW50LmlkbApp bmRleCA0MzU0ZmM4ZGQ0NTZhYzVjNWI4NjFiZWE1MmYzZDUzMDVkZjUxNGFmLi43ZWNiZmU3OGVi MzEyYjQyZDIzOWNkMGFmZmVhM2NhNmYxNGRkM2ZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL3Byb3hpbWl0eS9EZXZpY2VQcm94aW1pdHlFdmVudC5pZGwKKysrIGIvU291cmNl L1dlYkNvcmUvTW9kdWxlcy9wcm94aW1pdHkvRGV2aWNlUHJveGltaXR5RXZlbnQuaWRsCkBAIC0x OSwxMCArMTksMTUgQEAKIAogWwogICAgIENvbmRpdGlvbmFsPVBST1hJTUlUWV9FVkVOVFMsCi0g ICAgQ29uc3RydWN0b3JUZW1wbGF0ZT1FdmVudCwKKyAgICBDb25zdHJ1Y3RvcihET01TdHJpbmcg dHlwZSwgb3B0aW9uYWwgRGV2aWNlUHJveGltaXR5RXZlbnRJbml0IGV2ZW50SW5pdERpY3QpLAog XSBpbnRlcmZhY2UgRGV2aWNlUHJveGltaXR5RXZlbnQgOiBFdmVudCB7Ci0gICAgW0luaXRpYWxp emVkQnlFdmVudENvbnN0cnVjdG9yXSByZWFkb25seSBhdHRyaWJ1dGUgdW5yZXN0cmljdGVkIGRv dWJsZSB2YWx1ZTsKLSAgICBbSW5pdGlhbGl6ZWRCeUV2ZW50Q29uc3RydWN0b3JdIHJlYWRvbmx5 IGF0dHJpYnV0ZSB1bnJlc3RyaWN0ZWQgZG91YmxlIG1pbjsKLSAgICBbSW5pdGlhbGl6ZWRCeUV2 ZW50Q29uc3RydWN0b3JdIHJlYWRvbmx5IGF0dHJpYnV0ZSB1bnJlc3RyaWN0ZWQgZG91YmxlIG1h eDsKKyAgICByZWFkb25seSBhdHRyaWJ1dGUgdW5yZXN0cmljdGVkIGRvdWJsZSB2YWx1ZTsKKyAg ICByZWFkb25seSBhdHRyaWJ1dGUgdW5yZXN0cmljdGVkIGRvdWJsZSBtaW47CisgICAgcmVhZG9u bHkgYXR0cmlidXRlIHVucmVzdHJpY3RlZCBkb3VibGUgbWF4OwogfTsKIAorZGljdGlvbmFyeSBE ZXZpY2VQcm94aW1pdHlFdmVudEluaXQgOiBFdmVudEluaXQgeworICAgIGRvdWJsZSB2YWx1ZTsK KyAgICBkb3VibGUgbWluOworICAgIGRvdWJsZSBtYXg7Cit9Owo=