163300 2016-10-11 15:00:28 -0700 Web Inspector: Whole program sometimes highlighted instead of just first statement 2016-10-12 11:46:00 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1239026 0 joepeck 2016-10-11 15:00:28 -0700 Summary: Whole program sometimes highlighted instead of just first statement Test: <script> debugger; var a = 1; var b = 1; var c = 1; </script> Steps to Reproduce: 1. Inspect test page 2. Reload to pause on debugger statement => entire program is highlighted instead of just the first statement Notes: - Esprima says the program starts at the same place as the debugger statement! 1239027 1 webkit-bug-importer 2016-10-11 15:00:56 -0700 <rdar://problem/28723162> 1239031 2 291301 joepeck 2016-10-11 15:02:39 -0700 Created attachment 291301 [PATCH] Proposed Fix 1239399 3 291301 commit-queue 2016-10-12 11:45:56 -0700 Comment on attachment 291301 [PATCH] Proposed Fix Clearing flags on attachment: 291301 Committed r207227: <http://trac.webkit.org/changeset/207227> 1239400 4 commit-queue 2016-10-12 11:46:00 -0700 All reviewed patches have been landed. Closing bug. 291301 2016-10-11 15:02:39 -0700 2016-10-12 11:45:56 -0700 [PATCH] Proposed Fix program-1.patch text/plain 3602 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDM4NGEzYzUuLmI3YjIyZDUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDE2LTEwLTExICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogV2hvbGUg cHJvZ3JhbSBzb21ldGltZXMgaGlnaGxpZ2h0ZWQgaW5zdGVhZCBvZiBqdXN0IGZpcnN0IHN0YXRl bWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYz MzAwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yODcyMzE2Mj4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvU291 cmNlQ29kZVRleHRFZGl0b3IuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU291cmNlQ29kZVRl eHRFZGl0b3IucHJvdG90eXBlLnRleHRFZGl0b3JFeGVjdXRpb25IaWdobGlnaHRSYW5nZSk6Cisg ICAgICAgIEF2b2lkIGhpZ2hsaWdodGluZyB0aGUgZW50aXJlIHByb2dyYW0gYnkgc2tpcHBpbmcg YSBQcm9ncmFtIHR5cGUgTm9kZS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVGV4 dEVkaXRvci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yLnByb3RvdHlwZS5z ZXRFeGVjdXRpb25MaW5lQW5kQ29sdW1uKToKKyAgICAgICAgQXZvaWQgdW5uZWNlc3Nhcnkgd29y ayBiZWZvcmUgY29udGVudCBoYXMgbG9hZGVkLgorCisgICAgICAgIChXZWJJbnNwZWN0b3IuVGV4 dEVkaXRvci5wcm90b3R5cGUuY3VycmVudFBvc2l0aW9uVG9PcmlnaW5hbE9mZnNldCk6CisgICAg ICAgIEF2b2lkIHVubmVjZXNzYXJ5IGluZGlyZWN0aW9uIHRvIGdldCB0aGUgQ29kZU1pcnJvciBl ZGl0b3IuCisKKzIwMTYtMTAtMTEgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNv bT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBSZW1vdmUgbGluZSBoaWdobGlnaHQgb24gcHJp bWFyeSBleGVjdXRpb24gbGluZSB3aGlsZSBzdGVwcGluZyBiZWNhdXNlIGl0IGlzIGRpc3RyYWN0 aW5nCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjMy OTQKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI4NzIxMTc2PgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU291cmNlQ29kZVRleHRFZGl0b3Iu anMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Tb3VyY2VDb2Rl VGV4dEVkaXRvci5qcwppbmRleCA2MjkwYzRmLi40YTlmYTlkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Tb3VyY2VDb2RlVGV4dEVkaXRvci5q cworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Tb3VyY2VD b2RlVGV4dEVkaXRvci5qcwpAQCAtMTIzNSw5ICsxMjM1LDEwIEBAIFdlYkluc3BlY3Rvci5Tb3Vy Y2VDb2RlVGV4dEVkaXRvciA9IGNsYXNzIFNvdXJjZUNvZGVUZXh0RWRpdG9yIGV4dGVuZHMgV2Vi SW5zcGVjCiAgICAgICAgICAgICB9CiAKICAgICAgICAgICAgIC8vIEZpbmQgYSBub2RlIHN0YXJ0 aW5nIGF0IHRoaXMgb2Zmc2V0LgorICAgICAgICAgICAgLy8gQXZvaWQgaGlnaGxpZ2h0aW5nIHRo ZSBlbnRpcmUgcHJvZ3JhbSBpZiB0aGlzIGlzIHRoZSBzdGFydCBvZiB0aGUgZmlyc3Qgc3RhdGVt ZW50LgogICAgICAgICAgICAgZm9yIChsZXQgbm9kZSBvZiBub2RlcykgewogICAgICAgICAgICAg ICAgIGxldCBzdGFydE9mZnNldCA9IG5vZGUucmFuZ2VbMF07Ci0gICAgICAgICAgICAgICAgaWYg KHN0YXJ0T2Zmc2V0ID09PSBvZmZzZXQpIHsKKyAgICAgICAgICAgICAgICBpZiAoc3RhcnRPZmZz ZXQgPT09IG9mZnNldCAmJiBub2RlLnR5cGUgIT09IFdlYkluc3BlY3Rvci5TY3JpcHRTeW50YXhU cmVlLk5vZGVUeXBlLlByb2dyYW0pIHsKICAgICAgICAgICAgICAgICAgICAgY2FsbGJhY2soY29u dmVydFJhbmdlT2Zmc2V0c1RvU291cmNlQ29kZU9mZnNldHMobm9kZS5yYW5nZSkpOwogICAgICAg ICAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgICAgICAgICAgfQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGV4dEVkaXRvci5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RleHRFZGl0b3IuanMKaW5k ZXggMGQwMzNmNi4uYmE2NGNjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvVGV4dEVkaXRvci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9UZXh0RWRpdG9yLmpzCkBAIC0zMzYsOCArMzM2LDEwIEBA IFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yID0gY2xhc3MgVGV4dEVkaXRvciBleHRlbmRzIFdlYklu c3BlY3Rvci5WaWV3CiAgICAgICAgIHRoaXMuX2V4ZWN1dGlvbkxpbmVOdW1iZXIgPSBsaW5lTnVt YmVyOwogICAgICAgICB0aGlzLl9leGVjdXRpb25Db2x1bW5OdW1iZXIgPSBjb2x1bW5OdW1iZXI7 CiAKLSAgICAgICAgdGhpcy5fdXBkYXRlRXhlY3V0aW9uTGluZSgpOwotICAgICAgICB0aGlzLl91 cGRhdGVFeGVjdXRpb25SYW5nZUhpZ2hsaWdodCgpOworICAgICAgICBpZiAoIXRoaXMuX2luaXRp YWxTdHJpbmdOb3RTZXQpIHsKKyAgICAgICAgICAgIHRoaXMuX3VwZGF0ZUV4ZWN1dGlvbkxpbmUo KTsKKyAgICAgICAgICAgIHRoaXMuX3VwZGF0ZUV4ZWN1dGlvblJhbmdlSGlnaGxpZ2h0KCk7Cisg ICAgICAgIH0KIAogICAgICAgICAvLyBTdGlsbCBkaXNwYXRjaCB0aGUgZXZlbnQgZXZlbiBpZiB0 aGUgbnVtYmVyIGRpZG4ndCBjaGFuZ2UuIFRoZSBleGVjdXRpb24gc3RhdGUgc3RpbGwKICAgICAg ICAgLy8gY291bGQgaGF2ZSBjaGFuZ2VkIChlLmcuIGNvbnRpbnVpbmcgaW4gYSBsb29wIHdpdGgg YSBicmVha3BvaW50IGluc2lkZSkuCkBAIC03MDMsNyArNzA1LDcgQEAgV2ViSW5zcGVjdG9yLlRl eHRFZGl0b3IgPSBjbGFzcyBUZXh0RWRpdG9yIGV4dGVuZHMgV2ViSW5zcGVjdG9yLlZpZXcKICAg ICAgICAgaWYgKHRoaXMuX2Zvcm1hdHRlclNvdXJjZU1hcCkKICAgICAgICAgICAgIG9mZnNldCA9 IHRoaXMuX2Zvcm1hdHRlclNvdXJjZU1hcC5mb3JtYXR0ZWRUb09yaWdpbmFsT2Zmc2V0KHBvc2l0 aW9uLmxpbmUsIHBvc2l0aW9uLmNoKTsKICAgICAgICAgZWxzZQotICAgICAgICAgICAgb2Zmc2V0 ID0gdGhpcy50b2tlblRyYWNraW5nQ29udHJvbGxlci5fY29kZU1pcnJvci5nZXREb2MoKS5pbmRl eEZyb21Qb3MocG9zaXRpb24pOworICAgICAgICAgICAgb2Zmc2V0ID0gdGhpcy5fY29kZU1pcnJv ci5nZXREb2MoKS5pbmRleEZyb21Qb3MocG9zaXRpb24pOwogCiAgICAgICAgIHJldHVybiBvZmZz ZXQ7CiAgICAgfQo=