163293 2016-10-11 12:50:04 -0700 Update CloseEvent to stop using legacy [ConstructorTemplate=Event] 2016-10-11 15:05:44 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez cdumez commit-queue darin rniwa sam oldest_to_newest 1238964 0 cdumez 2016-10-11 12:50:04 -0700 Update CloseEvent to stop using legacy [ConstructorTemplate=Event] and use a regular constructor as in the specification: - https://html.spec.whatwg.org/multipage/comms.html#the-closeevent-interfaces 1239004 1 291296 cdumez 2016-10-11 14:19:15 -0700 Created attachment 291296 Patch 1239033 2 291296 commit-queue 2016-10-11 15:05:40 -0700 Comment on attachment 291296 Patch Clearing flags on attachment: 291296 Committed r207169: <http://trac.webkit.org/changeset/207169> 1239034 3 commit-queue 2016-10-11 15:05:44 -0700 All reviewed patches have been landed. Closing bug. 291296 2016-10-11 14:19:15 -0700 2016-10-11 15:05:40 -0700 Patch bug-163293-20161011141552.patch text/plain 6949 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3MTU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDkwYWFjZmE1NTU4ZDM1 YzAzYzc2MzYyYzdmNDBlYTViMWM1Y2QxNC4uMzZjMWZjMmJjNTFhYjhjMGQyMTcwMDlhNzI3ZDY5 OWMxNmZkOGNlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE2LTEwLTExICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgVXBkYXRlIENsb3NlRXZlbnQg dG8gc3RvcCB1c2luZyBsZWdhY3kgW0NvbnN0cnVjdG9yVGVtcGxhdGU9RXZlbnRdCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjMyOTMKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgQ2xvc2VFdmVu dCB0byBzdG9wIHVzaW5nIGxlZ2FjeSBbQ29uc3RydWN0b3JUZW1wbGF0ZT1FdmVudF0gYW5kCisg ICAgICAgIHVzZSBhIHJlZ3VsYXIgY29uc3RydWN0b3IgYXMgaW4gdGhlIHNwZWNpZmljYXRpb246 CisgICAgICAgIC0gaHR0cHM6Ly9odG1sLnNwZWMud2hhdHdnLm9yZy9tdWx0aXBhZ2UvY29tbXMu aHRtbCN0aGUtY2xvc2VldmVudC1pbnRlcmZhY2VzCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCB1 cGRhdGVkIGV4aXN0aW5nIHRlc3QuCisKKyAgICAgICAgKiBNb2R1bGVzL3dlYnNvY2tldHMvQ2xv c2VFdmVudC5oOgorICAgICAgICAoV2ViQ29yZTo6Q2xvc2VFdmVudDo6Y3JlYXRlKToKKyAgICAg ICAgKFdlYkNvcmU6OkNsb3NlRXZlbnQ6OkNsb3NlRXZlbnQpOgorICAgICAgICAqIE1vZHVsZXMv d2Vic29ja2V0cy9DbG9zZUV2ZW50LmlkbDoKKwogMjAxNi0xMC0xMSAgQWxleCBDaHJpc3RlbnNl biAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIEZpeCBiaW5kaW5ncyB0ZXN0 cyBhZnRlciByMjA3MTUwLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJz b2NrZXRzL0Nsb3NlRXZlbnQuaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2Vic29ja2V0cy9D bG9zZUV2ZW50LmgKaW5kZXggMTU0OTdjYWEyZjBlMjQwNGMzMjYwY2E4N2U4NmRlMTY2NzQwMDRm MS4uNjViNTZjNzNiNWJiNzU0YzdhNjkwMDk2Yzc1ZWY2MDFlMmU4NDY4NiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJzb2NrZXRzL0Nsb3NlRXZlbnQuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL3dlYnNvY2tldHMvQ2xvc2VFdmVudC5oCkBAIC0zNiwxMiArMzYs NiBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLXN0cnVjdCBDbG9zZUV2ZW50SW5pdCA6IHB1 YmxpYyBFdmVudEluaXQgewotICAgIGJvb2wgd2FzQ2xlYW4geyBmYWxzZSB9OwotICAgIHVuc2ln bmVkIHNob3J0IGNvZGUgeyAwIH07Ci0gICAgU3RyaW5nIHJlYXNvbjsKLX07Ci0KIGNsYXNzIENs b3NlRXZlbnQgOiBwdWJsaWMgRXZlbnQgewogcHVibGljOgogICAgIHN0YXRpYyBSZWY8Q2xvc2VF dmVudD4gY3JlYXRlKGJvb2wgd2FzQ2xlYW4sIHVuc2lnbmVkIHNob3J0IGNvZGUsIGNvbnN0IFN0 cmluZyYgcmVhc29uKQpAQCAtNDksOSArNDMsMTUgQEAgcHVibGljOgogICAgICAgICByZXR1cm4g YWRvcHRSZWYoKm5ldyBDbG9zZUV2ZW50KHdhc0NsZWFuLCBjb2RlLCByZWFzb24pKTsKICAgICB9 CiAKLSAgICBzdGF0aWMgUmVmPENsb3NlRXZlbnQ+IGNyZWF0ZUZvckJpbmRpbmdzKGNvbnN0IEF0 b21pY1N0cmluZyYgdHlwZSwgY29uc3QgQ2xvc2VFdmVudEluaXQmIGluaXRpYWxpemVyKQorICAg IHN0cnVjdCBJbml0IDogRXZlbnRJbml0IHsKKyAgICAgICAgYm9vbCB3YXNDbGVhbiB7IGZhbHNl IH07CisgICAgICAgIHVuc2lnbmVkIHNob3J0IGNvZGUgeyAwIH07CisgICAgICAgIFN0cmluZyBy ZWFzb247CisgICAgfTsKKworICAgIHN0YXRpYyBSZWY8Q2xvc2VFdmVudD4gY3JlYXRlKGNvbnN0 IEF0b21pY1N0cmluZyYgdHlwZSwgY29uc3QgSW5pdCYgaW5pdGlhbGl6ZXIsIElzVHJ1c3RlZCBp c1RydXN0ZWQgPSBJc1RydXN0ZWQ6Ok5vKQogICAgIHsKLSAgICAgICAgcmV0dXJuIGFkb3B0UmVm KCpuZXcgQ2xvc2VFdmVudCh0eXBlLCBpbml0aWFsaXplcikpOworICAgICAgICByZXR1cm4gYWRv cHRSZWYoKm5ldyBDbG9zZUV2ZW50KHR5cGUsIGluaXRpYWxpemVyLCBpc1RydXN0ZWQpKTsKICAg ICB9CiAKICAgICBib29sIHdhc0NsZWFuKCkgY29uc3QgeyByZXR1cm4gbV93YXNDbGVhbjsgfQpA QCAtNzAsOCArNzAsOCBAQCBwcml2YXRlOgogICAgIHsKICAgICB9CiAKLSAgICBDbG9zZUV2ZW50 KGNvbnN0IEF0b21pY1N0cmluZyYgdHlwZSwgY29uc3QgQ2xvc2VFdmVudEluaXQmIGluaXRpYWxp emVyKQotICAgICAgICA6IEV2ZW50KHR5cGUsIGluaXRpYWxpemVyKQorICAgIENsb3NlRXZlbnQo Y29uc3QgQXRvbWljU3RyaW5nJiB0eXBlLCBjb25zdCBJbml0JiBpbml0aWFsaXplciwgSXNUcnVz dGVkIGlzVHJ1c3RlZCkKKyAgICAgICAgOiBFdmVudCh0eXBlLCBpbml0aWFsaXplciwgaXNUcnVz dGVkKQogICAgICAgICAsIG1fd2FzQ2xlYW4oaW5pdGlhbGl6ZXIud2FzQ2xlYW4pCiAgICAgICAg ICwgbV9jb2RlKGluaXRpYWxpemVyLmNvZGUpCiAgICAgICAgICwgbV9yZWFzb24oaW5pdGlhbGl6 ZXIucmVhc29uKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJzb2NrZXRz L0Nsb3NlRXZlbnQuaWRsIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJzb2NrZXRzL0Nsb3Nl RXZlbnQuaWRsCmluZGV4IDc1N2MwNzA1ZDdjNjc3NjBmMGFjOTRlN2U5N2YwZGNjZjk4MWUwYzku LmRiNTM2YzIyNzk3MTk2NjU1ZTY2MTkwNzI5MGJjNDdlNTE2ZDhmNDYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvd2Vic29ja2V0cy9DbG9zZUV2ZW50LmlkbAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL3dlYnNvY2tldHMvQ2xvc2VFdmVudC5pZGwKQEAgLTI4LDExICsy OCwxNyBAQAogICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NT SUJJTElUWSBPRiBTVUNIIERBTUFHRS4KICAqLwogCisvLyBGSVhNRTogVGhpcyBzaG91bGQgYmUg ZXhwb3NlZCB0byB3b3JrZXJzIGFzIHdlbGwuCiBbCi0gICAgQ29uc3RydWN0b3JUZW1wbGF0ZT1F dmVudAorICAgIENvbnN0cnVjdG9yKERPTVN0cmluZyB0eXBlLCBvcHRpb25hbCBDbG9zZUV2ZW50 SW5pdCBldmVudEluaXREaWN0KSwKIF0gaW50ZXJmYWNlIENsb3NlRXZlbnQgOiBFdmVudCB7Ci0g ICAgW0luaXRpYWxpemVkQnlFdmVudENvbnN0cnVjdG9yXSByZWFkb25seSBhdHRyaWJ1dGUgYm9v bGVhbiB3YXNDbGVhbjsKLSAgICBbSW5pdGlhbGl6ZWRCeUV2ZW50Q29uc3RydWN0b3JdIHJlYWRv bmx5IGF0dHJpYnV0ZSB1bnNpZ25lZCBzaG9ydCBjb2RlOwotICAgIFtJbml0aWFsaXplZEJ5RXZl bnRDb25zdHJ1Y3Rvcl0gcmVhZG9ubHkgYXR0cmlidXRlIFVTVlN0cmluZyByZWFzb247CisgICAg cmVhZG9ubHkgYXR0cmlidXRlIGJvb2xlYW4gd2FzQ2xlYW47CisgICAgcmVhZG9ubHkgYXR0cmli dXRlIHVuc2lnbmVkIHNob3J0IGNvZGU7CisgICAgcmVhZG9ubHkgYXR0cmlidXRlIFVTVlN0cmlu ZyByZWFzb247CiB9OwogCitkaWN0aW9uYXJ5IENsb3NlRXZlbnRJbml0IDogRXZlbnRJbml0IHsK KyAgICBib29sZWFuIHdhc0NsZWFuID0gZmFsc2U7CisgICAgdW5zaWduZWQgc2hvcnQgY29kZSA9 IDA7CisgICAgVVNWU3RyaW5nIHJlYXNvbiA9ICIiOworfTsKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA3MGI4NTY2MzVhMzQ3 NWIwZjA2YjBkYTRiMWY5ZDE0MjRhNGVjYTY5Li43MGYyM2M0YzY5OWRjNTA1MjI2ZmIzMDExNGRm YjU0MjVjYzg2MmMyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTYtMTAtMTEgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBVcGRhdGUgQ2xvc2VFdmVudCB0byBz dG9wIHVzaW5nIGxlZ2FjeSBbQ29uc3RydWN0b3JUZW1wbGF0ZT1FdmVudF0KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MzI5MworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZSBleGlzdGluZyB0ZXN0 IHRvIHJlZmxlY3QgYSBzbWFsbCBiZWhhdmlvciBjaGFuZ2UuIFBhc3NpbmcgYW4gZXhwbGljaXQK KyAgICAgICAgdW5kZWZpbmVkIGFzICdyZWFzb24nIG1lbWJlcnMgbm93IGluaXRpYWxpemVzIHRo ZSBhdHRyaWJ1dGUgdG8gdGhlIGVtcHR5CisgICAgICAgIHN0cmluZyAodGhlIG1lbWJlcidzIGRl ZmF1bHQgdmFsdWUpIGluc3RlYWQgb2YgdGhlIHN0cmluZyAidW5kZWZpbmVkIi4gVGhpcworICAg ICAgICBuZXcgYmVoYXZpb3IgbWF0Y2hlcyBDaHJvbWUgYW5kIEZpcmVmb3guCisKKyAgICAgICAg KiBmYXN0L2V2ZW50cy9jb25zdHJ1Y3RvcnMvY2xvc2UtZXZlbnQtY29uc3RydWN0b3ItZXhwZWN0 ZWQudHh0OgorICAgICAgICAqIGZhc3QvZXZlbnRzL2NvbnN0cnVjdG9ycy9jbG9zZS1ldmVudC1j b25zdHJ1Y3Rvci5odG1sOgorCiAyMDE2LTEwLTEwICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5v cmc+CiAKICAgICAgICAgVXNlIElETFR5cGVzIGluIG1vcmUgcGxhY2VzCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9jb25zdHJ1Y3RvcnMvY2xvc2UtZXZlbnQtY29uc3RydWN0 b3ItZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvY29uc3RydWN0b3JzL2Ns b3NlLWV2ZW50LWNvbnN0cnVjdG9yLWV4cGVjdGVkLnR4dAppbmRleCA1YzcxYTEwNDlkZTdjYjlh NTcyOThmNWUzYjJiMjhmNTQ4NWEwOTZjLi4zM2NkYWM0NzA4ZTkzYmMyMTg5ZmQ2YjIxNDgyMTI3 NDNhNDYxNTdjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9jb25zdHJ1Y3Rv cnMvY2xvc2UtZXZlbnQtY29uc3RydWN0b3ItZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3Rz L2Zhc3QvZXZlbnRzL2NvbnN0cnVjdG9ycy9jbG9zZS1ldmVudC1jb25zdHJ1Y3Rvci1leHBlY3Rl ZC50eHQKQEAgLTE2LDcgKzE2LDcgQEAgUEFTUyBuZXcgQ2xvc2VFdmVudCgnZXZlbnRUeXBlJywg eyB3YXNDbGVhbjogZmFsc2UgfSkud2FzQ2xlYW4gaXMgZmFsc2UKIFBBU1MgbmV3IENsb3NlRXZl bnQoJ2V2ZW50VHlwZScsIHsgd2FzQ2xlYW46IHRydWUgfSkud2FzQ2xlYW4gaXMgdHJ1ZQogUEFT UyBuZXcgQ2xvc2VFdmVudCgnZXZlbnRUeXBlJywgeyByZWFzb246ICdrb2FrdW1hJyB9KS5yZWFz b24gaXMgImtvYWt1bWEiCiBQQVNTIG5ldyBDbG9zZUV2ZW50KCdldmVudFR5cGUnLCB7IHJlYXNv bjogJycgfSkucmVhc29uIGlzICIiCi1QQVNTIG5ldyBDbG9zZUV2ZW50KCdldmVudFR5cGUnLCB7 IHJlYXNvbjogdW5kZWZpbmVkIH0pLnJlYXNvbiBpcyAidW5kZWZpbmVkIgorUEFTUyBuZXcgQ2xv c2VFdmVudCgnZXZlbnRUeXBlJywgeyByZWFzb246IHVuZGVmaW5lZCB9KS5yZWFzb24gaXMgIiIK IFBBU1MgbmV3IENsb3NlRXZlbnQoJ2V2ZW50VHlwZScsIHsgcmVhc29uOiBudWxsIH0pLnJlYXNv biBpcyAibnVsbCIKIFBBU1MgbmV3IENsb3NlRXZlbnQoJ2V2ZW50VHlwZScsIHsgcmVhc29uOiBm YWxzZSB9KS5yZWFzb24gaXMgImZhbHNlIgogUEFTUyBuZXcgQ2xvc2VFdmVudCgnZXZlbnRUeXBl JywgeyByZWFzb246IHRydWUgfSkucmVhc29uIGlzICJ0cnVlIgpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvZmFzdC9ldmVudHMvY29uc3RydWN0b3JzL2Nsb3NlLWV2ZW50LWNvbnN0cnVjdG9yLmh0 bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9jb25zdHJ1Y3RvcnMvY2xvc2UtZXZlbnQtY29u c3RydWN0b3IuaHRtbAppbmRleCA3ZTY0YzkxYTc2MWYzNzRhOTM5MjNkM2Y1OWY1ODY4ZDk2M2Q1 YWYxLi41ZWZhNjA4ZjRjN2UxYjRhZGRkNTIxMTkwYjlkOGJmNjQyNTljMTljIDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9jb25zdHJ1Y3RvcnMvY2xvc2UtZXZlbnQtY29uc3Ry dWN0b3IuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9jb25zdHJ1Y3RvcnMvY2xv c2UtZXZlbnQtY29uc3RydWN0b3IuaHRtbApAQCAtMzMsNyArMzMsNyBAQCBzaG91bGRCZUVxdWFs VG9TdHJpbmcoIm5ldyBDbG9zZUV2ZW50KCdldmVudFR5cGUnLCB7IHJlYXNvbjogJ2tvYWt1bWEn IH0pLnJlYXNvbgogc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJuZXcgQ2xvc2VFdmVudCgnZXZlbnRU eXBlJywgeyByZWFzb246ICcnIH0pLnJlYXNvbiIsICIiKTsKIAogLy8gTm9uLXN0cmluZ3MuCi1z aG91bGRCZUVxdWFsVG9TdHJpbmcoIm5ldyBDbG9zZUV2ZW50KCdldmVudFR5cGUnLCB7IHJlYXNv bjogdW5kZWZpbmVkIH0pLnJlYXNvbiIsICJ1bmRlZmluZWQiKTsKK3Nob3VsZEJlRXF1YWxUb1N0 cmluZygibmV3IENsb3NlRXZlbnQoJ2V2ZW50VHlwZScsIHsgcmVhc29uOiB1bmRlZmluZWQgfSku cmVhc29uIiwgIiIpOwogc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJuZXcgQ2xvc2VFdmVudCgnZXZl bnRUeXBlJywgeyByZWFzb246IG51bGwgfSkucmVhc29uIiwgIm51bGwiKTsKIHNob3VsZEJlRXF1 YWxUb1N0cmluZygibmV3IENsb3NlRXZlbnQoJ2V2ZW50VHlwZScsIHsgcmVhc29uOiBmYWxzZSB9 KS5yZWFzb24iLCAiZmFsc2UiKTsKIHNob3VsZEJlRXF1YWxUb1N0cmluZygibmV3IENsb3NlRXZl bnQoJ2V2ZW50VHlwZScsIHsgcmVhc29uOiB0cnVlIH0pLnJlYXNvbiIsICJ0cnVlIik7Cg==