163260 2016-10-10 17:41:11 -0700 Change ArrayPrototype.cpp's putLength() and setLength() to take a VM& so that we can use vm.propertyNames. 2016-10-10 17:48:49 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam commit-queue keith_miller msaboff saam oldest_to_newest 1238656 0 mark.lam 2016-10-10 17:41:11 -0700 In call cases where we call these, we already have the VM& anyway. 1238659 1 291199 mark.lam 2016-10-10 17:44:46 -0700 Created attachment 291199 proposed patch. 1238660 2 mark.lam 2016-10-10 17:48:49 -0700 Thanks for the review. Landed in r207036: <http://trac.webkit.org/r207036>. 291199 2016-10-10 17:44:46 -0700 2016-10-10 17:46:44 -0700 proposed patch. bug-163260.patch text/plain 5023 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA3MDM1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBA CisyMDE2LTEwLTEwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBD aGFuZ2UgQXJyYXlQcm90b3R5cGUuY3BwJ3MgcHV0TGVuZ3RoKCkgYW5kIHNldExlbmd0aCgpIHRv IHRha2UgYSBWTSYgc28gdGhhdCB3ZSBjYW4gdXNlIHZtLnByb3BlcnR5TmFtZXMuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjMyNjAKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiBhbGwgY2FzZXMgd2hl cmUgd2UgY2FsbCB0aGVzZSwgd2UgYWxyZWFkeSBoYXZlIHRoZSBWTSYgYW55d2F5LgorCisgICAg ICAgICogcnVudGltZS9BcnJheVByb3RvdHlwZS5jcHA6CisgICAgICAgIChKU0M6OnB1dExlbmd0 aCk6CisgICAgICAgIChKU0M6OnNldExlbmd0aCk6CisgICAgICAgIChKU0M6OmFycmF5UHJvdG9G dW5jUG9wKToKKyAgICAgICAgKEpTQzo6YXJyYXlQcm90b0Z1bmNQdXNoKToKKyAgICAgICAgKEpT Qzo6YXJyYXlQcm90b0Z1bmNTaGlmdCk6CisgICAgICAgIChKU0M6OmFycmF5UHJvdG9GdW5jU2xp Y2UpOgorICAgICAgICAoSlNDOjphcnJheVByb3RvRnVuY1NwbGljZSk6CisgICAgICAgIChKU0M6 OmFycmF5UHJvdG9GdW5jVW5TaGlmdCk6CisKIDIwMTYtMTAtMTAgIE1hcmsgTGFtICA8bWFyay5s YW1AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbmFtZSB0aGUgU3RyaWN0TW9kZVJlYWRvbmx5UHJv cGVydHlXcml0ZUVycm9yIHN0cmluZyB0byBSZWFkb25seVByb3BlcnR5V3JpdGVFcnJvci4KSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0FycmF5UHJvdG90eXBlLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9BcnJheVByb3RvdHlwZS5j cHAJKHJldmlzaW9uIDIwNzAzNSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0Fy cmF5UHJvdG90eXBlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTYzLDE3ICsxNjMsMTcgQEAgc3Rh dGljIEFMV0FZU19JTkxJTkUgSlNWYWx1ZSBnZXRQcm9wZXJ0eQogICAgIHJldHVybiBzbG90Lmdl dFZhbHVlKGV4ZWMsIGluZGV4KTsKIH0KIAotc3RhdGljIEFMV0FZU19JTkxJTkUgdm9pZCBwdXRM ZW5ndGgoRXhlY1N0YXRlKiBleGVjLCBKU09iamVjdCogb2JqLCBKU1ZhbHVlIHZhbHVlKQorc3Rh dGljIEFMV0FZU19JTkxJTkUgdm9pZCBwdXRMZW5ndGgoRXhlY1N0YXRlKiBleGVjLCBWTSYgdm0s IEpTT2JqZWN0KiBvYmosIEpTVmFsdWUgdmFsdWUpCiB7CiAgICAgUHV0UHJvcGVydHlTbG90IHNs b3Qob2JqKTsKLSAgICBvYmotPm1ldGhvZFRhYmxlKCktPnB1dChvYmosIGV4ZWMsIGV4ZWMtPnBy b3BlcnR5TmFtZXMoKS5sZW5ndGgsIHZhbHVlLCBzbG90KTsKKyAgICBvYmotPm1ldGhvZFRhYmxl KCktPnB1dChvYmosIGV4ZWMsIHZtLnByb3BlcnR5TmFtZXMtPmxlbmd0aCwgdmFsdWUsIHNsb3Qp OwogfQogCi1zdGF0aWMgQUxXQVlTX0lOTElORSB2b2lkIHNldExlbmd0aChFeGVjU3RhdGUqIGV4 ZWMsIEpTT2JqZWN0KiBvYmosIHVuc2lnbmVkIHZhbHVlKQorc3RhdGljIEFMV0FZU19JTkxJTkUg dm9pZCBzZXRMZW5ndGgoRXhlY1N0YXRlKiBleGVjLCBWTSYgdm0sIEpTT2JqZWN0KiBvYmosIHVu c2lnbmVkIHZhbHVlKQogewogICAgIGlmIChpc0pTQXJyYXkob2JqKSkKICAgICAgICAganNDYXN0 PEpTQXJyYXkqPihvYmopLT5zZXRMZW5ndGgoZXhlYywgdmFsdWUpOwotICAgIHB1dExlbmd0aChl eGVjLCBvYmosIGpzTnVtYmVyKHZhbHVlKSk7CisgICAgcHV0TGVuZ3RoKGV4ZWMsIHZtLCBvYmos IGpzTnVtYmVyKHZhbHVlKSk7CiB9CiAKIGlubGluZSBib29sIHNwZWNpZXNXYXRjaHBvaW50c1Zh bGlkKEV4ZWNTdGF0ZSogZXhlYywgSlNPYmplY3QqIHRoaXNPYmplY3QpCkBAIC02NzksNyArNjc5 LDcgQEAgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBhcnJheVByb3RvRgogCiAgICAgSlNW YWx1ZSByZXN1bHQ7CiAgICAgaWYgKGxlbmd0aCA9PSAwKSB7Ci0gICAgICAgIHB1dExlbmd0aChl eGVjLCB0aGlzT2JqLCBqc051bWJlcihsZW5ndGgpKTsKKyAgICAgICAgcHV0TGVuZ3RoKGV4ZWMs IHZtLCB0aGlzT2JqLCBqc051bWJlcihsZW5ndGgpKTsKICAgICAgICAgcmVzdWx0ID0ganNVbmRl ZmluZWQoKTsKICAgICB9IGVsc2UgewogICAgICAgICByZXN1bHQgPSB0aGlzT2JqLT5nZXQoZXhl YywgbGVuZ3RoIC0gMSk7CkBAIC02ODgsNyArNjg4LDcgQEAgRW5jb2RlZEpTVmFsdWUgSlNDX0hP U1RfQ0FMTCBhcnJheVByb3RvRgogICAgICAgICAgICAgdGhyb3dUeXBlRXJyb3IoZXhlYywgc2Nv cGUsIEFTQ0lJTGl0ZXJhbCgiVW5hYmxlIHRvIGRlbGV0ZSBwcm9wZXJ0eS4iKSk7CiAgICAgICAg ICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzVW5kZWZpbmVkKCkpOwogICAgICAgICB9Ci0g ICAgICAgIHB1dExlbmd0aChleGVjLCB0aGlzT2JqLCBqc051bWJlcihsZW5ndGggLSAxKSk7Cisg ICAgICAgIHB1dExlbmd0aChleGVjLCB2bSwgdGhpc09iaiwganNOdW1iZXIobGVuZ3RoIC0gMSkp OwogICAgIH0KICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKHJlc3VsdCk7CiB9CkBAIC03MjQs NyArNzI0LDcgQEAgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBhcnJheVByb3RvRgogICAg IH0KICAgICAKICAgICBKU1ZhbHVlIG5ld0xlbmd0aChzdGF0aWNfY2FzdDxpbnQ2NF90PihsZW5n dGgpICsgc3RhdGljX2Nhc3Q8aW50NjRfdD4oZXhlYy0+YXJndW1lbnRDb3VudCgpKSk7Ci0gICAg cHV0TGVuZ3RoKGV4ZWMsIHRoaXNPYmosIG5ld0xlbmd0aCk7CisgICAgcHV0TGVuZ3RoKGV4ZWMs IHZtLCB0aGlzT2JqLCBuZXdMZW5ndGgpOwogICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUobmV3 TGVuZ3RoKTsKIH0KIApAQCAtODI2LDEzICs4MjYsMTMgQEAgRW5jb2RlZEpTVmFsdWUgSlNDX0hP U1RfQ0FMTCBhcnJheVByb3RvRgogCiAgICAgSlNWYWx1ZSByZXN1bHQ7CiAgICAgaWYgKGxlbmd0 aCA9PSAwKSB7Ci0gICAgICAgIHB1dExlbmd0aChleGVjLCB0aGlzT2JqLCBqc051bWJlcihsZW5n dGgpKTsKKyAgICAgICAgcHV0TGVuZ3RoKGV4ZWMsIHZtLCB0aGlzT2JqLCBqc051bWJlcihsZW5n dGgpKTsKICAgICAgICAgcmVzdWx0ID0ganNVbmRlZmluZWQoKTsKICAgICB9IGVsc2UgewogICAg ICAgICByZXN1bHQgPSB0aGlzT2JqLT5nZXRJbmRleChleGVjLCAwKTsKICAgICAgICAgc2hpZnQ8 SlNBcnJheTo6U2hpZnRDb3VudEZvclNoaWZ0PihleGVjLCB0aGlzT2JqLCAwLCAxLCAwLCBsZW5n dGgpOwogICAgICAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCBlbmNvZGVkSlNWYWx1ZSgp KTsKLSAgICAgICAgcHV0TGVuZ3RoKGV4ZWMsIHRoaXNPYmosIGpzTnVtYmVyKGxlbmd0aCAtIDEp KTsKKyAgICAgICAgcHV0TGVuZ3RoKGV4ZWMsIHZtLCB0aGlzT2JqLCBqc051bWJlcihsZW5ndGgg LSAxKSk7CiAgICAgfQogICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUocmVzdWx0KTsKIH0KQEAg LTg3Niw3ICs4NzYsNyBAQCBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGFycmF5UHJvdG9G CiAgICAgICAgIGlmICh2KQogICAgICAgICAgICAgcmVzdWx0LT5wdXREaXJlY3RJbmRleChleGVj LCBuLCB2KTsKICAgICB9Ci0gICAgc2V0TGVuZ3RoKGV4ZWMsIHJlc3VsdCwgbik7CisgICAgc2V0 TGVuZ3RoKGV4ZWMsIHZtLCByZXN1bHQsIG4pOwogICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUo cmVzdWx0KTsKIH0KIApAQCAtOTA2LDggKzkwNiw4IEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NU X0NBTEwgYXJyYXlQcm90b0YKICAgICAgICAgICAgIFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUs IGVuY29kZWRKU1ZhbHVlKCkpOwogICAgICAgICB9CiAKLSAgICAgICAgc2V0TGVuZ3RoKGV4ZWMs IHJlc3VsdCwgMCk7Ci0gICAgICAgIHNldExlbmd0aChleGVjLCB0aGlzT2JqLCBsZW5ndGgpOwor ICAgICAgICBzZXRMZW5ndGgoZXhlYywgdm0sIHJlc3VsdCwgMCk7CisgICAgICAgIHNldExlbmd0 aChleGVjLCB2bSwgdGhpc09iaiwgbGVuZ3RoKTsKICAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVu Y29kZShyZXN1bHQpOwogICAgIH0KIApAQCAtOTcyLDcgKzk3Miw3IEBAIEVuY29kZWRKU1ZhbHVl IEpTQ19IT1NUX0NBTEwgYXJyYXlQcm90b0YKICAgICAgICAgUkVUVVJOX0lGX0VYQ0VQVElPTihz Y29wZSwgZW5jb2RlZEpTVmFsdWUoKSk7CiAgICAgfQogICAgIAotICAgIHNldExlbmd0aChleGVj LCB0aGlzT2JqLCBsZW5ndGggLSBkZWxldGVDb3VudCArIGFkZGl0aW9uYWxBcmdzKTsKKyAgICBz ZXRMZW5ndGgoZXhlYywgdm0sIHRoaXNPYmosIGxlbmd0aCAtIGRlbGV0ZUNvdW50ICsgYWRkaXRp b25hbEFyZ3MpOwogICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUocmVzdWx0KTsKIH0KIApAQCAt OTk4LDcgKzk5OCw3IEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgYXJyYXlQcm90b0YK ICAgICAgICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgZW5jb2RlZEpTVmFsdWUoKSk7CiAg ICAgfQogICAgIEpTVmFsdWUgcmVzdWx0ID0ganNOdW1iZXIobGVuZ3RoICsgbnJBcmdzKTsKLSAg ICBwdXRMZW5ndGgoZXhlYywgdGhpc09iaiwgcmVzdWx0KTsKKyAgICBwdXRMZW5ndGgoZXhlYywg dm0sIHRoaXNPYmosIHJlc3VsdCk7CiAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShyZXN1bHQp OwogfQogCg==