163251 2016-10-10 16:18:12 -0700 Update my name in contributors.json 2016-10-11 13:26:27 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eoconnor eoconnor commit-queue glenn lforschler simon.fraser oldest_to_newest 1238594 0 eoconnor 2016-10-10 16:18:12 -0700 I should update my name in contributors.json. 1238595 1 291179 eoconnor 2016-10-10 16:19:44 -0700 Created attachment 291179 Update my name in contributors.json Changed my name in contributors.json. Moved old name to be an alias. 1238596 2 commit-queue 2016-10-10 16:22:28 -0700 Attachment 291179 did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5] Total errors found: 1 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style. 1238624 3 291179 simon.fraser 2016-10-10 16:52:53 -0700 Comment on attachment 291179 Update my name in contributors.json View in context: https://bugs.webkit.org/attachment.cgi?id=291179&action=review > Tools/Scripts/webkitpy/common/config/contributors.json:5139 > + "Edward O'Connor" You should add "Tess O'Connor" here too. 1238627 4 291189 eoconnor 2016-10-10 16:57:28 -0700 Created attachment 291189 Patch 1238630 5 commit-queue 2016-10-10 16:59:37 -0700 Attachment 291189 did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5] Total errors found: 1 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style. 1238649 6 291189 commit-queue 2016-10-10 17:21:46 -0700 Comment on attachment 291189 Patch Rejecting attachment 291189 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 291189, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 207033 = e09428a719bbf7d656fe7c55276924f43f28208e r207034 = 030126092e4957504a33f3fbb6f4dca6775f622e r207035 = f0ad2cd43a4296421030530127dd35431937ec00 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/2258809 1238847 7 simon.fraser 2016-10-11 08:10:58 -0700 All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html 1238961 8 291290 eoconnor 2016-10-11 12:45:42 -0700 Created attachment 291290 Patch 1238962 9 commit-queue 2016-10-11 12:48:46 -0700 Attachment 291290 did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1238976 10 291290 commit-queue 2016-10-11 13:26:23 -0700 Comment on attachment 291290 Patch Clearing flags on attachment: 291290 Committed r207161: <http://trac.webkit.org/changeset/207161> 1238977 11 commit-queue 2016-10-11 13:26:27 -0700 All reviewed patches have been landed. Closing bug. 291179 2016-10-10 16:19:44 -0700 2016-10-10 16:57:23 -0700 Update my name in contributors.json bug-163251.patch text/plain 918 eoconnor SW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9jb250cmlidXRvcnMu anNvbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcv Y29udHJpYnV0b3JzLmpzb24JKHJldmlzaW9uIDIwNzAxNykKKysrIFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvY29tbW9uL2NvbmZpZy9jb250cmlidXRvcnMuanNvbgkod29ya2luZyBjb3B5KQpAQCAt MTc2NiwxNCArMTc2Niw2IEBACiAgICAgICBdLAogICAgICAgInN0YXR1cyIgOiAiY29tbWl0dGVy IgogICAgfSwKLSAgICJFZHdhcmQgTydDb25ub3IiIDogewotICAgICAgImVtYWlscyIgOiBbCi0g ICAgICAgICAiZW9jb25ub3JAYXBwbGUuY29tIgotICAgICAgXSwKLSAgICAgICJuaWNrcyIgOiBb Ci0gICAgICAgICAiaG9iZXIiCi0gICAgICBdCi0gICB9LAogICAgIkVsaSBGaWRsZXIiIDogewog ICAgICAgImVtYWlscyIgOiBbCiAgICAgICAgICAiZWZpZGxlckByaW0uY29tIiwKQEAgLTUxNDIs NiArNTEzNCwxNyBAQAogICAgICAgXSwKICAgICAgICJzdGF0dXMiIDogImNvbW1pdHRlciIKICAg IH0sCisgICAiVGhlcmVzYSBPJ0Nvbm5vciIgOiB7CisgICAgICAiYWxpYXNlcyIgOiBbCisgICAg ICAgICAiRWR3YXJkIE8nQ29ubm9yIgorICAgICAgXSwKKyAgICAgICJlbWFpbHMiIDogWworICAg ICAgICAgImVvY29ubm9yQGFwcGxlLmNvbSIKKyAgICAgIF0sCisgICAgICAibmlja3MiIDogWwor ICAgICAgICAgImhvYmVyIgorICAgICAgXQorICAgfSwKICAgICJUaGlhZ28gTWFyY29zIFAuIFNh bnRvcyIgOiB7CiAgICAgICAiZW1haWxzIiA6IFsKICAgICAgICAgICJ0bXBzYW50b3NAZ21haWwu Y29tIiwK 291189 2016-10-10 16:57:28 -0700 2016-10-11 12:45:39 -0700 Patch bug-163251-20161010165407.patch text/plain 971 eoconnor SW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9jb250cmlidXRvcnMu anNvbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcv Y29udHJpYnV0b3JzLmpzb24JKHJldmlzaW9uIDIwNzAxNykKKysrIFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvY29tbW9uL2NvbmZpZy9jb250cmlidXRvcnMuanNvbgkod29ya2luZyBjb3B5KQpAQCAt MTc2NiwxNCArMTc2Niw2IEBACiAgICAgICBdLAogICAgICAgInN0YXR1cyIgOiAiY29tbWl0dGVy IgogICAgfSwKLSAgICJFZHdhcmQgTydDb25ub3IiIDogewotICAgICAgImVtYWlscyIgOiBbCi0g ICAgICAgICAiZW9jb25ub3JAYXBwbGUuY29tIgotICAgICAgXSwKLSAgICAgICJuaWNrcyIgOiBb Ci0gICAgICAgICAiaG9iZXIiCi0gICAgICBdCi0gICB9LAogICAgIkVsaSBGaWRsZXIiIDogewog ICAgICAgImVtYWlscyIgOiBbCiAgICAgICAgICAiZWZpZGxlckByaW0uY29tIiwKQEAgLTUxNDIs NiArNTEzNCwxOSBAQAogICAgICAgXSwKICAgICAgICJzdGF0dXMiIDogImNvbW1pdHRlciIKICAg IH0sCisgICAiVGhlcmVzYSBPJ0Nvbm5vciIgOiB7CisgICAgICAiYWxpYXNlcyIgOiBbCisgICAg ICAgICAiRWR3YXJkIE8nQ29ubm9yIiwKKyAgICAgICAgICJUZWQgTydDb25ub3IiLAorICAgICAg ICAgIlRlc3MgTydDb25ub3IiCisgICAgICBdLAorICAgICAgImVtYWlscyIgOiBbCisgICAgICAg ICAiZW9jb25ub3JAYXBwbGUuY29tIgorICAgICAgXSwKKyAgICAgICJuaWNrcyIgOiBbCisgICAg ICAgICAiaG9iZXIiCisgICAgICBdCisgICB9LAogICAgIlRoaWFnbyBNYXJjb3MgUC4gU2FudG9z IiA6IHsKICAgICAgICJlbWFpbHMiIDogWwogICAgICAgICAgInRtcHNhbnRvc0BnbWFpbC5jb20i LAo= 291290 2016-10-11 12:45:42 -0700 2016-10-11 13:26:23 -0700 Patch bug-163251-20161011124219.patch text/plain 1511 eoconnor SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwNzE1NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE2LTEwLTExICBFZHdhcmQgTydDb25ub3IgIDxlb2Nvbm5vckBhcHBsZS5j b20+CisKKyAgICAgICAgVXBkYXRlIG15IG5hbWUgaW4gY29udHJpYnV0b3JzLmpzb24KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MzI1MQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS9jb21tb24vY29uZmlnL2NvbnRyaWJ1dG9ycy5qc29uOgorCiAyMDE2LTEwLTExICBTYWlk IEFib3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIFN5 bmNocm9uaXplZEZpeGVkUXVldWUgY2xhc3MKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv Y29tbW9uL2NvbmZpZy9jb250cmlidXRvcnMuanNvbgo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvY29udHJpYnV0b3JzLmpzb24JKHJldmlzaW9uIDIw NzE1NykKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9jb250cmlidXRv cnMuanNvbgkod29ya2luZyBjb3B5KQpAQCAtMTc2NiwxNCArMTc2Niw2IEBACiAgICAgICBdLAog ICAgICAgInN0YXR1cyIgOiAiY29tbWl0dGVyIgogICAgfSwKLSAgICJFZHdhcmQgTydDb25ub3Ii IDogewotICAgICAgImVtYWlscyIgOiBbCi0gICAgICAgICAiZW9jb25ub3JAYXBwbGUuY29tIgot ICAgICAgXSwKLSAgICAgICJuaWNrcyIgOiBbCi0gICAgICAgICAiaG9iZXIiCi0gICAgICBdCi0g ICB9LAogICAgIkVsaSBGaWRsZXIiIDogewogICAgICAgImVtYWlscyIgOiBbCiAgICAgICAgICAi ZWZpZGxlckByaW0uY29tIiwKQEAgLTUxNDIsNiArNTEzNCwxOSBAQAogICAgICAgXSwKICAgICAg ICJzdGF0dXMiIDogImNvbW1pdHRlciIKICAgIH0sCisgICAiVGhlcmVzYSBPJ0Nvbm5vciIgOiB7 CisgICAgICAiYWxpYXNlcyIgOiBbCisgICAgICAgICAiRWR3YXJkIE8nQ29ubm9yIiwKKyAgICAg ICAgICJUZWQgTydDb25ub3IiLAorICAgICAgICAgIlRlc3MgTydDb25ub3IiCisgICAgICBdLAor ICAgICAgImVtYWlscyIgOiBbCisgICAgICAgICAiZW9jb25ub3JAYXBwbGUuY29tIgorICAgICAg XSwKKyAgICAgICJuaWNrcyIgOiBbCisgICAgICAgICAiaG9iZXIiCisgICAgICBdCisgICB9LAog ICAgIlRoaWFnbyBNYXJjb3MgUC4gU2FudG9zIiA6IHsKICAgICAgICJlbWFpbHMiIDogWwogICAg ICAgICAgInRtcHNhbnRvc0BnbWFpbC5jb20iLAo=