163249 2016-10-10 15:39:34 -0700 [mac] LayoutTest media/modern-media-controls/play-pause-button/play-pause-button.html is a flaky failure 2016-10-14 01:15:13 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=163248 P2 Normal --- 1 ryanhaddad graouts commit-queue dino graouts graouts oldest_to_newest 1238575 0 ryanhaddad 2016-10-10 15:39:34 -0700 LayoutTest media/modern-media-controls/play-pause-button/play-pause-button.html is a flaky failure https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK1%20(Tests)/r207023%20(449)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fplay-pause-button%2Fplay-pause-button.html --- /Volumes/Data/slave/sierra-debug-tests-wk1/build/layout-test-results/media/modern-media-controls/play-pause-button/play-pause-button-expected.txt +++ /Volumes/Data/slave/sierra-debug-tests-wk1/build/layout-test-results/media/modern-media-controls/play-pause-button/play-pause-button-actual.txt @@ -10,12 +10,12 @@ PASS playButton.playing is false PASS pauseButton.playing is true PASS pauseButton.iconName is "pause" -PASS playButton.element.style.webkitMaskImage.includes("macOS/play@") is true +FAIL playButton.element.style.webkitMaskImage.includes("macOS/play@") should be true. Was false. PASS pauseButton.element.style.webkitMaskImage.includes("macOS/pause@") is true -PASS iOSPlayButton.element.style.webkitMaskImage.includes("iOS/play@") is true -PASS iOSPauseButton.element.style.webkitMaskImage.includes("iOS/pause@") is true -PASS fullscreenPlayButton.element.style.webkitMaskImage.includes("macOS/play-fullscreen@") is true -PASS fullscreenPauseButton.element.style.webkitMaskImage.includes("macOS/pause-fullscreen@") is true +FAIL iOSPlayButton.element.style.webkitMaskImage.includes("iOS/play@") should be true. Was false. +FAIL iOSPauseButton.element.style.webkitMaskImage.includes("iOS/pause@") should be true. Was false. +FAIL fullscreenPlayButton.element.style.webkitMaskImage.includes("macOS/play-fullscreen@") should be true. Was false. +FAIL fullscreenPauseButton.element.style.webkitMaskImage.includes("macOS/pause-fullscreen@") should be true. Was false. PASS successfullyParsed is true TEST COMPLETE 1238577 1 ryanhaddad 2016-10-10 15:40:09 -0700 Test was added with https://trac.webkit.org/changeset/207015 1238827 2 291254 graouts 2016-10-11 06:38:52 -0700 Created attachment 291254 Patch 1238833 3 291254 commit-queue 2016-10-11 07:20:52 -0700 Comment on attachment 291254 Patch Rejecting attachment 291254 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 291254, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: reset by peer M LayoutTests/media/modern-media-controls/airplay-button/airplay-button.html M LayoutTests/ChangeLog M LayoutTests/TestExpectations r207135 = ecf248e570d658ebd2f61e5e69cce8fa02f89afd (refs/remotes/origin/master) M Source/WebCore/platform/spi/win/CoreTextSPIWin.h M Source/WebCore/ChangeLog r207136 = 75998878933c335ec15213b2750a714a2d8f4f3e (refs/remotes/origin/master) First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/2262436 1238834 4 291255 graouts 2016-10-11 07:25:08 -0700 Created attachment 291255 Patch for landing 1238841 5 291255 commit-queue 2016-10-11 08:00:30 -0700 Comment on attachment 291255 Patch for landing Clearing flags on attachment: 291255 Committed r207138: <http://trac.webkit.org/changeset/207138> 1238842 6 commit-queue 2016-10-11 08:00:34 -0700 All reviewed patches have been landed. Closing bug. 291254 2016-10-11 06:38:52 -0700 2016-10-11 07:25:01 -0700 Patch bug-163249-20161011153529.patch text/plain 2562 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3MTExCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMjU4YWI3OTZjNWEyYTc5YTU4MmNk OWEwMjhiODc0MGExMDBiNjUwOS4uYmVjNzVhNGIyZDI3M2Y1NWVjYmJiMTc4OWJiZTQxMjg0NDQ2 ZWI4ZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE2LTEwLTExICBBbnRvaW5lIFF1aW50ICA8 Z3Jhb3V0c0BhcHBsZS5jb20+CiAKKyAgICAgICAgW21hY10gTGF5b3V0VGVzdCBtZWRpYS9tb2Rl cm4tbWVkaWEtY29udHJvbHMvcGxheS1wYXVzZS1idXR0b24vcGxheS1wYXVzZS1idXR0b24uaHRt bCBpcyBhIGZsYWt5IGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE2MzI0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFdhaXQgdW50aWwgYWxsIGljb24gaW1hZ2VzIGFyZSBsb2FkZWQgYmVmb3Jl IHJ1bm5pbmcgdGhlIGFzc2VydGlvbnMuIFdlIGNhbiBkZXRlcm1pbmUgd2hldGhlcgorICAgICAg ICBhIGJ1dHRvbidzIGljb24gaW1hZ2UgaXMgbG9hZGVkIGJ5IGNoZWNraW5nIGl0J3MgYmVlbiBz aXplZC4KKworICAgICAgICAqIFRlc3RFeHBlY3RhdGlvbnM6CisgICAgICAgICogbWVkaWEvbW9k ZXJuLW1lZGlhLWNvbnRyb2xzL3BsYXktcGF1c2UtYnV0dG9uL3BsYXktcGF1c2UtYnV0dG9uLmh0 bWw6CisKKzIwMTYtMTAtMTEgIEFudG9pbmUgUXVpbnQgIDxncmFvdXRzQGFwcGxlLmNvbT4KKwog ICAgICAgICBbTW9kZXJuIE1lZGlhIENvbnRyb2xzXSBCdXR0b25zIGNvbnRhaW5lcgogICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzMjM4CiAgICAgICAg IDxyZGFyOi8vcHJvYmxlbS8yODcwMTg2ND4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL1Rlc3RF eHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDA4ODgyNzJm MzBhNTI2YjU4NjVmNWRiOTAwMDA1YTVhODFiNjIzOWMuLmY1MzE2OGE3MDI5N2I3YWM4YWJmYjBi ZGUzYmFmZTcwYjA0Y2ZmODcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlv bnMKKysrIGIvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucwpAQCAtOTg3LDQgKzk4NywzIEBA IHdlYmtpdC5vcmcvYi8xNjI0MTQgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9yZXNv dXJjZS10aW1pbmcvaWRsaGFybmVzcy5oCiBmYXN0L3RleHQvbGV0dGVycHJlc3MtZGlmZmVyZW50 Lmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIAogd2Via2l0Lm9yZy9iLzE2MzI0OCBtZWRpYS9t b2Rlcm4tbWVkaWEtY29udHJvbHMvYWlycGxheS1idXR0b24vYWlycGxheS1idXR0b24uaHRtbCBb IEZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzE2MzI0OSBtZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJv bHMvcGxheS1wYXVzZS1idXR0b24vcGxheS1wYXVzZS1idXR0b24uaHRtbCBbIEZhaWx1cmUgXQpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL3BsYXkt cGF1c2UtYnV0dG9uL3BsYXktcGF1c2UtYnV0dG9uLmh0bWwgYi9MYXlvdXRUZXN0cy9tZWRpYS9t b2Rlcm4tbWVkaWEtY29udHJvbHMvcGxheS1wYXVzZS1idXR0b24vcGxheS1wYXVzZS1idXR0b24u aHRtbAppbmRleCA4ZDk2NDNmMzg2MzM4NTJlMTY3N2FkMmI1ZjZhYWU3YmNlZDBlYmMwLi40NWI5 YjU5OTA3YmM1YzQ1Y2FkYTQyMzQ4NTQxMWMzYjlkZGM3ZDQ1IDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9tZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvcGxheS1wYXVzZS1idXR0b24vcGxheS1w YXVzZS1idXR0b24uaHRtbAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS9tb2Rlcm4tbWVkaWEtY29u dHJvbHMvcGxheS1wYXVzZS1idXR0b24vcGxheS1wYXVzZS1idXR0b24uaHRtbApAQCAtNDEsNiAr NDEsOSBAQCBpT1NQYXVzZUJ1dHRvbi5wbGF5aW5nID0gdHJ1ZTsKIAogc2NoZWR1bGVyLmZyYW1l RGlkRmlyZSA9IGZ1bmN0aW9uKCkKIHsKKyAgICBpZiAoW3BsYXlCdXR0b24sIHBhdXNlQnV0dG9u LCBpT1NQbGF5QnV0dG9uLCBpT1NQYXVzZUJ1dHRvbiwgZnVsbHNjcmVlblBsYXlCdXR0b24sIGZ1 bGxzY3JlZW5QYXVzZUJ1dHRvbl0uc29tZShidXR0b24gPT4gYnV0dG9uLndpZHRoID09IDApKQor ICAgICAgICByZXR1cm47CisKICAgICBzaG91bGRCZVRydWUoJ3BsYXlCdXR0b24uZWxlbWVudC5z dHlsZS53ZWJraXRNYXNrSW1hZ2UuaW5jbHVkZXMoIm1hY09TL3BsYXlAIiknKTsKICAgICBzaG91 bGRCZVRydWUoJ3BhdXNlQnV0dG9uLmVsZW1lbnQuc3R5bGUud2Via2l0TWFza0ltYWdlLmluY2x1 ZGVzKCJtYWNPUy9wYXVzZUAiKScpOwogICAgIHNob3VsZEJlVHJ1ZSgnaU9TUGxheUJ1dHRvbi5l bGVtZW50LnN0eWxlLndlYmtpdE1hc2tJbWFnZS5pbmNsdWRlcygiaU9TL3BsYXlAIiknKTsK 291255 2016-10-11 07:25:08 -0700 2016-10-14 01:15:13 -0700 Patch for landing bug-163249-20161011162144.patch text/plain 2529 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3MTM2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYTYwYzdlMzRhODhmZDA2MDJmZDZj NjYwYmE3N2QyYTQ1MmZiZTI0Yi4uYzlhNDVmZGYwYjM2M2MxNmFjN2FjNzRmNjhlOWM2OTVhYWYw OTY2MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE2LTEwLTExICBBbnRvaW5lIFF1aW50ICA8 Z3Jhb3V0c0BhcHBsZS5jb20+CiAKKyAgICAgICAgW21hY10gTGF5b3V0VGVzdCBtZWRpYS9tb2Rl cm4tbWVkaWEtY29udHJvbHMvcGxheS1wYXVzZS1idXR0b24vcGxheS1wYXVzZS1idXR0b24uaHRt bCBpcyBhIGZsYWt5IGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE2MzI0OQorCisgICAgICAgIFJldmlld2VkIGJ5IEFudG9pbmUgUXVpbnQu CisKKyAgICAgICAgV2FpdCB1bnRpbCBhbGwgaWNvbiBpbWFnZXMgYXJlIGxvYWRlZCBiZWZvcmUg cnVubmluZyB0aGUgYXNzZXJ0aW9ucy4gV2UgY2FuIGRldGVybWluZSB3aGV0aGVyCisgICAgICAg IGEgYnV0dG9uJ3MgaWNvbiBpbWFnZSBpcyBsb2FkZWQgYnkgY2hlY2tpbmcgaXQncyBiZWVuIHNp emVkLgorCisgICAgICAgICogVGVzdEV4cGVjdGF0aW9uczoKKyAgICAgICAgKiBtZWRpYS9tb2Rl cm4tbWVkaWEtY29udHJvbHMvcGxheS1wYXVzZS1idXR0b24vcGxheS1wYXVzZS1idXR0b24uaHRt bDoKKworMjAxNi0xMC0xMSAgQW50b2luZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29tPgorCiAg ICAgICAgIFttYWNdIExheW91dFRlc3QgbWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL2FpcnBs YXktYnV0dG9uL2FpcnBsYXktYnV0dG9uLmh0bWwgaXMgYSBmbGFreSBmYWlsdXJlCiAgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjMyNDgKIApkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL1Rlc3RFeHBl Y3RhdGlvbnMKaW5kZXggN2JkNDcxY2U2ZWNjMGMzOTM5YjIxNGNiYzU0ZDhiMzE4MGE2ZGEwNy4u YmFlMzA0YTAyMzZjM2ViNjUwMTkzMjc2ZmFlMDJlNzkyNDZmODExYSAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRp b25zCkBAIC05ODYsNCArOTg2LDMgQEAgd2Via2l0Lm9yZy9iLzE2MjQxNCBpbXBvcnRlZC93M2Mv d2ViLXBsYXRmb3JtLXRlc3RzL3Jlc291cmNlLXRpbWluZy9pZGxoYXJuZXNzLmgKICMgT25seSBp T1MgaGFzIGltcGxlbWVudGVkIGxldHRlcHJlc3MuCiBmYXN0L3RleHQvbGV0dGVycHJlc3MtZGlm ZmVyZW50Lmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIAotd2Via2l0Lm9yZy9iLzE2MzI0OSBt ZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvcGxheS1wYXVzZS1idXR0b24vcGxheS1wYXVzZS1i dXR0b24uaHRtbCBbIEZhaWx1cmUgXQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvbW9k ZXJuLW1lZGlhLWNvbnRyb2xzL3BsYXktcGF1c2UtYnV0dG9uL3BsYXktcGF1c2UtYnV0dG9uLmh0 bWwgYi9MYXlvdXRUZXN0cy9tZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvcGxheS1wYXVzZS1i dXR0b24vcGxheS1wYXVzZS1idXR0b24uaHRtbAppbmRleCA4ZDk2NDNmMzg2MzM4NTJlMTY3N2Fk MmI1ZjZhYWU3YmNlZDBlYmMwLi40NWI5YjU5OTA3YmM1YzQ1Y2FkYTQyMzQ4NTQxMWMzYjlkZGM3 ZDQ1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9tZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMv cGxheS1wYXVzZS1idXR0b24vcGxheS1wYXVzZS1idXR0b24uaHRtbAorKysgYi9MYXlvdXRUZXN0 cy9tZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvcGxheS1wYXVzZS1idXR0b24vcGxheS1wYXVz ZS1idXR0b24uaHRtbApAQCAtNDEsNiArNDEsOSBAQCBpT1NQYXVzZUJ1dHRvbi5wbGF5aW5nID0g dHJ1ZTsKIAogc2NoZWR1bGVyLmZyYW1lRGlkRmlyZSA9IGZ1bmN0aW9uKCkKIHsKKyAgICBpZiAo W3BsYXlCdXR0b24sIHBhdXNlQnV0dG9uLCBpT1NQbGF5QnV0dG9uLCBpT1NQYXVzZUJ1dHRvbiwg ZnVsbHNjcmVlblBsYXlCdXR0b24sIGZ1bGxzY3JlZW5QYXVzZUJ1dHRvbl0uc29tZShidXR0b24g PT4gYnV0dG9uLndpZHRoID09IDApKQorICAgICAgICByZXR1cm47CisKICAgICBzaG91bGRCZVRy dWUoJ3BsYXlCdXR0b24uZWxlbWVudC5zdHlsZS53ZWJraXRNYXNrSW1hZ2UuaW5jbHVkZXMoIm1h Y09TL3BsYXlAIiknKTsKICAgICBzaG91bGRCZVRydWUoJ3BhdXNlQnV0dG9uLmVsZW1lbnQuc3R5 bGUud2Via2l0TWFza0ltYWdlLmluY2x1ZGVzKCJtYWNPUy9wYXVzZUAiKScpOwogICAgIHNob3Vs ZEJlVHJ1ZSgnaU9TUGxheUJ1dHRvbi5lbGVtZW50LnN0eWxlLndlYmtpdE1hc2tJbWFnZS5pbmNs dWRlcygiaU9TL3BsYXlAIiknKTsK