163243 2016-10-10 14:41:43 -0700 Update GamepadEvent to stop using legacy [ConstructorTemplate=Event] 2016-10-10 19:58:05 -0700 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED WebExposed P2 Normal --- 1 cdumez cdumez beidson cdumez commit-queue darin esprehn+autocc kondapallykalyan rniwa sam oldest_to_newest 1238550 0 cdumez 2016-10-10 14:41:43 -0700 Update GamepadEvent to stop using legacy [ConstructorTemplate=Event] and use a proper constructor as in the specification: - https://w3c.github.io/gamepad/#gamepadevent-interface 1238571 1 291174 cdumez 2016-10-10 15:26:29 -0700 Created attachment 291174 Patch 1238628 2 cdumez 2016-10-10 16:58:19 -0700 FYI, I am aware that the constructor does not match the specification. It is because the specification is wrong: https://github.com/w3c/gamepad/issues/35 1238700 3 291174 commit-queue 2016-10-10 19:58:01 -0700 Comment on attachment 291174 Patch Clearing flags on attachment: 291174 Committed r207038: <http://trac.webkit.org/changeset/207038> 1238701 4 commit-queue 2016-10-10 19:58:05 -0700 All reviewed patches have been landed. Closing bug. 291174 2016-10-10 15:26:29 -0700 2016-10-10 19:58:01 -0700 Patch bug-163243-20161010152308.patch text/plain 4249 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3MDIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTRjMzdhNTg2N2IwMTI3 MzU0ZjMyNTRjNGUzZTdkOGU5MDg4ODM1YS4uMTIyNGNlYWRkMTA1MDM1Y2NhYTg5MWQ3ODYxYzEw NDcxZDFjYTBkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDE2LTEwLTEwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgVXBkYXRlIEdhbWVwYWRFdmVu dCB0byBzdG9wIHVzaW5nIGxlZ2FjeSBbQ29uc3RydWN0b3JUZW1wbGF0ZT1FdmVudF0KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MzI0MworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZSBHYW1lcGFk RXZlbnQgdG8gc3RvcCB1c2luZyBsZWdhY3kgW0NvbnN0cnVjdG9yVGVtcGxhdGU9RXZlbnRdCisg ICAgICAgIGFuZCB1c2UgYSBwcm9wZXIgY29uc3RydWN0b3IgYXMgaW4gdGhlIHNwZWNpZmljYXRp b246CisgICAgICAgIC0gaHR0cHM6Ly93M2MuZ2l0aHViLmlvL2dhbWVwYWQvI2dhbWVwYWRldmVu dC1pbnRlcmZhY2UKKworICAgICAgICAqIE1vZHVsZXMvZ2FtZXBhZC9HYW1lcGFkRXZlbnQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6R2FtZXBhZEV2ZW50OjpHYW1lcGFkRXZlbnQpOgorICAgICAg ICAqIE1vZHVsZXMvZ2FtZXBhZC9HYW1lcGFkRXZlbnQuaDoKKyAgICAgICAgKFdlYkNvcmU6Okdh bWVwYWRFdmVudDo6Y3JlYXRlKToKKyAgICAgICAgKFdlYkNvcmU6OkdhbWVwYWRFdmVudDo6fkdh bWVwYWRFdmVudCk6IERlbGV0ZWQuCisgICAgICAgICogTW9kdWxlcy9nYW1lcGFkL0dhbWVwYWRF dmVudC5pZGw6CisKKzIwMTYtMTAtMTAgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4K KwogICAgICAgICBBZGQgc3VwcG9ydCBmb3IgTmF2aWdhdG9yLmxhbmd1YWdlcyBhdHRyaWJ1dGUK ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MzIyMAog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2dhbWVwYWQvR2FtZXBhZEV2ZW50 LmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvZ2FtZXBhZC9HYW1lcGFkRXZlbnQuY3BwCmlu ZGV4IDRkZTc1MmMyM2QxYTk1N2RjYmU3YjNjZWQxZmM1YjYxNjE5OTNmYmYuLmE2ODAwYWY2ZGQx OWI2ZDg2NWEyYjM1YTI3NjE2YjI2ZTUzNmEwODIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvZ2FtZXBhZC9HYW1lcGFkRXZlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvZ2FtZXBhZC9HYW1lcGFkRXZlbnQuY3BwCkBAIC0zNSw4ICszNSw4IEBAIEdhbWVwYWRF dmVudDo6R2FtZXBhZEV2ZW50KGNvbnN0IEF0b21pY1N0cmluZyYgZXZlbnRUeXBlLCBHYW1lcGFk JiBnYW1lcGFkKQogewogfQogCi1HYW1lcGFkRXZlbnQ6OkdhbWVwYWRFdmVudChjb25zdCBBdG9t aWNTdHJpbmcmIGV2ZW50VHlwZSwgY29uc3QgR2FtZXBhZEV2ZW50SW5pdCYgaW5pdGlhbGl6ZXIp Ci0gICAgOiBFdmVudChldmVudFR5cGUsIGluaXRpYWxpemVyKQorR2FtZXBhZEV2ZW50OjpHYW1l cGFkRXZlbnQoY29uc3QgQXRvbWljU3RyaW5nJiBldmVudFR5cGUsIGNvbnN0IEluaXQmIGluaXRp YWxpemVyLCBJc1RydXN0ZWQgaXNUcnVzdGVkKQorICAgIDogRXZlbnQoZXZlbnRUeXBlLCBpbml0 aWFsaXplciwgaXNUcnVzdGVkKQogICAgICwgbV9nYW1lcGFkKGluaXRpYWxpemVyLmdhbWVwYWQp CiB7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2dhbWVwYWQvR2FtZXBh ZEV2ZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2dhbWVwYWQvR2FtZXBhZEV2ZW50LmgK aW5kZXggYzQ4OTRlYzMyNjAzMzU3NzI1Mzc5N2E3YzE5ZjgwMTI4MmNkZTI0Mi4uMTNjYWFmYjg4 YzUyZTVkOTdjZGJiYTc3MWQ0OTAwNmU3YzY1ODM3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9nYW1lcGFkL0dhbWVwYWRFdmVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvZ2FtZXBhZC9HYW1lcGFkRXZlbnQuaApAQCAtMzMsMTAgKzMzLDYgQEAKIAogbmFtZXNw YWNlIFdlYkNvcmUgewogCi1zdHJ1Y3QgR2FtZXBhZEV2ZW50SW5pdCA6IHB1YmxpYyBFdmVudElu aXQgewotICAgIFJlZlB0cjxHYW1lcGFkPiBnYW1lcGFkOwotfTsKLQogY2xhc3MgR2FtZXBhZEV2 ZW50IDogcHVibGljIEV2ZW50IHsKIHB1YmxpYzoKICAgICB+R2FtZXBhZEV2ZW50KCkgeyB9CkBA IC00Niw5ICs0MiwxMyBAQCBwdWJsaWM6CiAgICAgICAgIHJldHVybiBhZG9wdFJlZigqbmV3IEdh bWVwYWRFdmVudChldmVudFR5cGUsIGdhbWVwYWQpKTsKICAgICB9CiAKLSAgICBzdGF0aWMgUmVm PEdhbWVwYWRFdmVudD4gY3JlYXRlRm9yQmluZGluZ3MoY29uc3QgQXRvbWljU3RyaW5nJiBldmVu dFR5cGUsIGNvbnN0IEdhbWVwYWRFdmVudEluaXQmIGluaXRpYWxpemVyKQorICAgIHN0cnVjdCBJ bml0IDogRXZlbnRJbml0IHsKKyAgICAgICAgUmVmUHRyPEdhbWVwYWQ+IGdhbWVwYWQ7CisgICAg fTsKKworICAgIHN0YXRpYyBSZWY8R2FtZXBhZEV2ZW50PiBjcmVhdGUoY29uc3QgQXRvbWljU3Ry aW5nJiBldmVudFR5cGUsIGNvbnN0IEluaXQmIGluaXRpYWxpemVyLCBJc1RydXN0ZWQgaXNUcnVz dGVkID0gSXNUcnVzdGVkOjpObykKICAgICB7Ci0gICAgICAgIHJldHVybiBhZG9wdFJlZigqbmV3 IEdhbWVwYWRFdmVudChldmVudFR5cGUsIGluaXRpYWxpemVyKSk7CisgICAgICAgIHJldHVybiBh ZG9wdFJlZigqbmV3IEdhbWVwYWRFdmVudChldmVudFR5cGUsIGluaXRpYWxpemVyLCBpc1RydXN0 ZWQpKTsKICAgICB9CiAKICAgICBHYW1lcGFkKiBnYW1lcGFkKCkgY29uc3QgeyByZXR1cm4gbV9n YW1lcGFkLmdldCgpOyB9CkBAIC01Nyw3ICs1Nyw3IEBAIHB1YmxpYzoKIAogcHJpdmF0ZToKICAg ICBleHBsaWNpdCBHYW1lcGFkRXZlbnQoY29uc3QgQXRvbWljU3RyaW5nJiBldmVudFR5cGUsIEdh bWVwYWQmKTsKLSAgICBHYW1lcGFkRXZlbnQoY29uc3QgQXRvbWljU3RyaW5nJiBldmVudFR5cGUs IGNvbnN0IEdhbWVwYWRFdmVudEluaXQmKTsKKyAgICBHYW1lcGFkRXZlbnQoY29uc3QgQXRvbWlj U3RyaW5nJiBldmVudFR5cGUsIGNvbnN0IEluaXQmLCBJc1RydXN0ZWQpOwogCiAgICAgUmVmUHRy PEdhbWVwYWQ+IG1fZ2FtZXBhZDsKIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL2dhbWVwYWQvR2FtZXBhZEV2ZW50LmlkbCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvZ2Ft ZXBhZC9HYW1lcGFkRXZlbnQuaWRsCmluZGV4IDkwNGFlYjkxY2M2MjUwNWM1NzExMjJjNzNmMmM2 Y2VhODhlOTg3NDUuLmQ5OWIzNzlmOTAwMzI2YmZkNGJkNDc5NTlkNmJjNWNjNDAyMWI3M2MgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvZ2FtZXBhZC9HYW1lcGFkRXZlbnQuaWRs CisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvZ2FtZXBhZC9HYW1lcGFkRXZlbnQuaWRsCkBA IC0yNCwxMCArMjQsMTUgQEAKICAqLwogCiBbCi0gICAgRW5hYmxlZEF0UnVudGltZT1HYW1lcGFk cywKICAgICBDb25kaXRpb25hbD1HQU1FUEFELAotICAgIENvbnN0cnVjdG9yVGVtcGxhdGU9RXZl bnQKKyAgICBDb25zdHJ1Y3RvcihET01TdHJpbmcgdHlwZSwgR2FtZXBhZEV2ZW50SW5pdCBldmVu dEluaXREaWN0KSwKKyAgICBFbmFibGVkQXRSdW50aW1lPUdhbWVwYWRzLAogXSBpbnRlcmZhY2Ug R2FtZXBhZEV2ZW50IDogRXZlbnQgewotICAgIFtJbml0aWFsaXplZEJ5RXZlbnRDb25zdHJ1Y3Rv cl0gcmVhZG9ubHkgYXR0cmlidXRlIEdhbWVwYWQgZ2FtZXBhZDsKKyAgICByZWFkb25seSBhdHRy aWJ1dGUgR2FtZXBhZD8gZ2FtZXBhZDsKIH07CiAKK2RpY3Rpb25hcnkgR2FtZXBhZEV2ZW50SW5p dCA6IEV2ZW50SW5pdCB7CisgICAgLy8gVGhlIHNwZWNpZmljYXRpb24gc2F5cyB0aGlzIG1lbWJl ciBzaG91bGQgYmUgcmVxdWlyZWQgYW5kIG5vbi1udWxsYWJsZS4KKyAgICAvLyBIb3dldmVyLCB0 aGlzIGRvZXMgbm90IG1hdGNoIHRoZSBiZWhhdmlvciBvZiBDaHJvbWUgb3IgRmlyZWZveC4KKyAg ICBHYW1lcGFkPyBnYW1lcGFkID0gbnVsbDsKK307Cg==