163236 2016-10-10 13:00:03 -0700 Address some review feedback from r206979 and r207010 2016-10-10 13:55:32 -0700 1 1 1 Unclassified WebKit UI Events WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 163112 1 wenson_hsieh wenson_hsieh commit-queue oldest_to_newest 1238469 0 wenson_hsieh 2016-10-10 13:00:03 -0700 In TypingCommand.h, some methods on TypingCommand should be marked as final to reflect the fact that they override methods in CompositeEditCommand. Also, HTMLFormControlElement::dispatchFormControlInputEvent does not need to specify HTMLElement::dispatchInputEvent() when calling dispatchInputEvent(). 1238476 1 291150 wenson_hsieh 2016-10-10 13:07:36 -0700 Created attachment 291150 Patch 1238489 2 291150 thorton 2016-10-10 13:19:18 -0700 Comment on attachment 291150 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=291150&action=review > Source/WebCore/html/HTMLFormControlElement.cpp:329 > - HTMLElement::dispatchInputEvent(); > + dispatchInputEvent(); This is a fairly surprising thing to have done unintentionally. Are you sure there isn't a closer implementation that it is trying to skip? 1238490 3 wenson_hsieh 2016-10-10 13:22:54 -0700 (In reply to comment #2) > Comment on attachment 291150 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=291150&action=review > > > Source/WebCore/html/HTMLFormControlElement.cpp:329 > > - HTMLElement::dispatchInputEvent(); > > + dispatchInputEvent(); > > This is a fairly surprising thing to have done unintentionally. Are you sure > there isn't a closer implementation that it is trying to skip? dispatchInputEvent (as a method) is only defined on HTMLElement. 1238506 4 291150 commit-queue 2016-10-10 13:55:29 -0700 Comment on attachment 291150 Patch Clearing flags on attachment: 291150 Committed r207018: <http://trac.webkit.org/changeset/207018> 1238507 5 commit-queue 2016-10-10 13:55:32 -0700 All reviewed patches have been landed. Closing bug. 291150 2016-10-10 13:07:36 -0700 2016-10-10 13:55:29 -0700 Patch bug-163236-20161010130415.patch text/plain 3654 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3MDEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmY1OTVhNjE2ZjQzMmVj MmFlMjEwOWI0NmNlNTNjYjMyYjNkOTIyMC4uMzUwZTlhYjQyYzczNjI0M2ViMWRiYzZjMGE0ZDIx OTZkMDRjM2IzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDE2LTEwLTEwICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCisgICAgICAgIEFkZHJlc3Mgc29t ZSByZXZpZXcgZmVlZGJhY2sgZnJvbSByMjA2OTc5IGFuZCByMjA3MDEwCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjMyMzYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiBUeXBpbmdDb21tYW5kLmgsIHNv bWUgbWV0aG9kcyBvbiBUeXBpbmdDb21tYW5kIHNob3VsZCBiZSBtYXJrZWQgYXMgZmluYWwgdG8g cmVmbGVjdCB0aGUgZmFjdCB0aGF0IHRoZXkKKyAgICAgICAgb3ZlcnJpZGUgbWV0aG9kcyBpbiBD b21wb3NpdGVFZGl0Q29tbWFuZC4gQWxzbywgSFRNTEZvcm1Db250cm9sRWxlbWVudDo6ZGlzcGF0 Y2hGb3JtQ29udHJvbElucHV0RXZlbnQgZG9lcyBub3QKKyAgICAgICAgbmVlZCB0byBzcGVjaWZ5 IEhUTUxFbGVtZW50OjpkaXNwYXRjaElucHV0RXZlbnQoKSB3aGVuIGNhbGxpbmcgZGlzcGF0Y2hJ bnB1dEV2ZW50KCkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBzaW5jZSB0aGVyZSBpcyBubyBi ZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBlZGl0aW5nL1R5cGluZ0NvbW1hbmQuaDoKKyAg ICAgICAgKiBodG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6SFRNTEZvcm1Db250cm9sRWxlbWVudDo6ZGlzcGF0Y2hGb3JtQ29udHJvbElucHV0RXZlbnQp OgorCisyMDE2LTEwLTEwICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgor CiAgICAgICAgIFN1cHBvcnQgSW5wdXRFdmVudC5kYXRhIGZvciB0aGUgbmV3IElucHV0RXZlbnQg c3BlYwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYz MTEzCiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yODY4MTkzNT4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2VkaXRpbmcvVHlwaW5nQ29tbWFuZC5oIGIvU291cmNlL1dlYkNvcmUvZWRpdGlu Zy9UeXBpbmdDb21tYW5kLmgKaW5kZXggZTkwMjBkMjQ2MDVhZjA5MDUyOTM2YzEwMTMzZWJjNWIy MTgxNGE4ZS4uNTY2MTcwYWNlZTBhZmU5NWFlYTFlN2YzODdhN2YyZjNkZTcyNDYyOCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9UeXBpbmdDb21tYW5kLmgKKysrIGIvU291cmNl L1dlYkNvcmUvZWRpdGluZy9UeXBpbmdDb21tYW5kLmgKQEAgLTEwNCwxNiArMTA0LDE2IEBAIHBy aXZhdGU6CiAKICAgICBzdGF0aWMgUmVmUHRyPFR5cGluZ0NvbW1hbmQ+IGxhc3RUeXBpbmdDb21t YW5kSWZTdGlsbE9wZW5Gb3JUeXBpbmcoRnJhbWUmKTsKIAotICAgIHZvaWQgZG9BcHBseSgpOwot ICAgIGJvb2wgaXNUeXBpbmdDb21tYW5kKCkgY29uc3Q7Ci0gICAgYm9vbCBwcmVzZXJ2ZXNUeXBp bmdTdHlsZSgpIGNvbnN0IHsgcmV0dXJuIG1fcHJlc2VydmVzVHlwaW5nU3R5bGU7IH0KLSAgICBi b29sIHNob3VsZFJldGFpbkF1dG9jb3JyZWN0aW9uSW5kaWNhdG9yKCkgY29uc3QKKyAgICB2b2lk IGRvQXBwbHkoKSBmaW5hbDsKKyAgICBib29sIGlzVHlwaW5nQ29tbWFuZCgpIGNvbnN0IGZpbmFs OworICAgIGJvb2wgcHJlc2VydmVzVHlwaW5nU3R5bGUoKSBjb25zdCBmaW5hbCB7IHJldHVybiBt X3ByZXNlcnZlc1R5cGluZ1N0eWxlOyB9CisgICAgYm9vbCBzaG91bGRSZXRhaW5BdXRvY29ycmVj dGlvbkluZGljYXRvcigpIGNvbnN0IGZpbmFsCiAgICAgewogICAgICAgICBBU1NFUlQoaXNUb3BM ZXZlbENvbW1hbmQoKSk7CiAgICAgICAgIHJldHVybiBtX3Nob3VsZFJldGFpbkF1dG9jb3JyZWN0 aW9uSW5kaWNhdG9yOwogICAgIH0KLSAgICB2b2lkIHNldFNob3VsZFJldGFpbkF1dG9jb3JyZWN0 aW9uSW5kaWNhdG9yKGJvb2wgcmV0YWluKSB7IG1fc2hvdWxkUmV0YWluQXV0b2NvcnJlY3Rpb25J bmRpY2F0b3IgPSByZXRhaW47IH0KLSAgICBib29sIHNob3VsZFN0b3BDYXJldEJsaW5raW5nKCkg Y29uc3QgeyByZXR1cm4gdHJ1ZTsgfQorICAgIHZvaWQgc2V0U2hvdWxkUmV0YWluQXV0b2NvcnJl Y3Rpb25JbmRpY2F0b3IoYm9vbCByZXRhaW4pIGZpbmFsIHsgbV9zaG91bGRSZXRhaW5BdXRvY29y cmVjdGlvbkluZGljYXRvciA9IHJldGFpbjsgfQorICAgIGJvb2wgc2hvdWxkU3RvcENhcmV0Qmxp bmtpbmcoKSBjb25zdCBmaW5hbCB7IHJldHVybiB0cnVlOyB9CiAgICAgdm9pZCBzZXRTaG91bGRQ cmV2ZW50U3BlbGxDaGVja2luZyhib29sIHByZXZlbnQpIHsgbV9zaG91bGRQcmV2ZW50U3BlbGxD aGVja2luZyA9IHByZXZlbnQ7IH0KIAogICAgIFN0cmluZyBpbnB1dEV2ZW50VHlwZU5hbWUoKSBj b25zdCBmaW5hbDsKQEAgLTEzMyw4ICsxMzMsOCBAQCBwcml2YXRlOgogICAgIHZvaWQgaW5zZXJ0 UGFyYWdyYXBoU2VwYXJhdG9ySW5RdW90ZWRDb250ZW50QW5kTm90aWZ5QWNjZXNzaWJpbGl0eSgp OwogICAgIHZvaWQgaW5zZXJ0UGFyYWdyYXBoU2VwYXJhdG9yQW5kTm90aWZ5QWNjZXNzaWJpbGl0 eSgpOwogCi0gICAgYm9vbCB3aWxsQXBwbHlDb21tYW5kKCk7Ci0gICAgdm9pZCBkaWRBcHBseUNv bW1hbmQoKTsKKyAgICBib29sIHdpbGxBcHBseUNvbW1hbmQoKSBmaW5hbDsKKyAgICB2b2lkIGRp ZEFwcGx5Q29tbWFuZCgpIGZpbmFsOwogCiAgICAgRVR5cGluZ0NvbW1hbmQgbV9jb21tYW5kVHlw ZTsKICAgICBFZGl0QWN0aW9uIG1fY3VycmVudFR5cGluZ0VkaXRBY3Rpb247CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnQuY3BwIGIvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmNwcAppbmRleCA0MWExZWJhYTZl ZjM1MzQwNjY1ZDk3ZTM0NGE5NzE3ZTZiOGE0ZWViLi5kNTYzYTFhMGI1YWZlN2JhNWZiODE2NDA1 ZmUxZTBmNTI3NDU5ZTQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3Jt Q29udHJvbEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250 cm9sRWxlbWVudC5jcHAKQEAgLTMyNiw3ICszMjYsNyBAQCB2b2lkIEhUTUxGb3JtQ29udHJvbEVs ZW1lbnQ6OmRpc3BhdGNoRm9ybUNvbnRyb2xDaGFuZ2VFdmVudCgpCiB2b2lkIEhUTUxGb3JtQ29u dHJvbEVsZW1lbnQ6OmRpc3BhdGNoRm9ybUNvbnRyb2xJbnB1dEV2ZW50KCkKIHsKICAgICBzZXRD aGFuZ2VkU2luY2VMYXN0Rm9ybUNvbnRyb2xDaGFuZ2VFdmVudCh0cnVlKTsKLSAgICBIVE1MRWxl bWVudDo6ZGlzcGF0Y2hJbnB1dEV2ZW50KCk7CisgICAgZGlzcGF0Y2hJbnB1dEV2ZW50KCk7CiB9 CiAKIGJvb2wgSFRNTEZvcm1Db250cm9sRWxlbWVudDo6aXNEaXNhYmxlZEZvcm1Db250cm9sKCkg Y29uc3QK