163218 2016-10-10 09:38:51 -0700 Added override specifier to PluginViewBase::isPluginViewBase() 2016-10-10 17:02:25 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen annulen achristensen commit-queue mcatanzaro simon.fraser oldest_to_newest 1238335 0 annulen 2016-10-10 09:38:51 -0700 Added override specifier to PluginViewBase::isPluginViewBase() 1238339 1 291114 annulen 2016-10-10 09:43:23 -0700 Created attachment 291114 Patch 1238349 2 291114 andersca 2016-10-10 09:57:15 -0700 Comment on attachment 291114 Patch Sounds good, but please don't move the declaration to the top. 1238357 3 annulen 2016-10-10 10:04:19 -0700 Move it to bottom or keep in place? I think it's better to separate new virtual APIs from inherited from base class 1238599 4 291180 annulen 2016-10-10 16:27:44 -0700 Created attachment 291180 Patch 1238635 5 291180 commit-queue 2016-10-10 17:02:21 -0700 Comment on attachment 291180 Patch Clearing flags on attachment: 291180 Committed r207034: <http://trac.webkit.org/changeset/207034> 1238636 6 commit-queue 2016-10-10 17:02:25 -0700 All reviewed patches have been landed. Closing bug. 291114 2016-10-10 09:43:23 -0700 2016-10-10 16:27:38 -0700 Patch bug-163218-20161010194001.patch text/plain 1731 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2OTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWQ1MTczYmFiMjM3NzZj YzQyNzk5ZDk2OTNjMTk3ODllYWM4ODRlYi4uNWQ5YmQwMjkzZTY2M2RjYzBjNzQxYmJjMjZlMTVi NWQ1OTBhMDRlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE2LTEwLTEwICBLb25z dGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBBZGRlZCBvdmVy cmlkZSBzcGVjaWZpZXIgdG8gUGx1Z2luVmlld0Jhc2U6OmlzUGx1Z2luVmlld0Jhc2UoKQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzMjE4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz IG5lZWRlZC4KKworICAgICAgICAqIHBsdWdpbnMvUGx1Z2luVmlld0Jhc2UuaDoKKwogMjAxNi0x MC0xMCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAg ICAgUkVHUkVTU0lPTihyMjA2NzMxKTogW1NPVVBdIE5ldHdvcmsgcHJvY2VzcyBjcmFzaCBpbiBn b3RIZWFkZXJzQ2FsbGJhY2sKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1 Z2luVmlld0Jhc2UuaCBiL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlld0Jhc2UuaApp bmRleCBlYzNiYjAxODU3ZjYxNDY0NDA0YTE4NmRjZDBiOTA3ZjFmODI5NGNmLi5iMGQ4NzFiYzgx NGYxNDYzNTk2OTExZDFjMDRmZDViYWIzMDRmNThjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbHVnaW5zL1BsdWdpblZpZXdCYXNlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9Q bHVnaW5WaWV3QmFzZS5oCkBAIC00Niw2ICs0Niw4IEBAIGNsYXNzIFNjcm9sbGJhcjsKIC8vIEl0 J3MgaW50ZW5kZWQgYXMgYSBzdG9wZ2FwIG1lYXN1cmUgdW50aWwgd2UgY2FuIG1lcmdlIGFsbCBw bHVnLWluIHZpZXdzIGludG8gYSBzaW5nbGUgcGx1Zy1pbiB2aWV3LgogY2xhc3MgUGx1Z2luVmll d0Jhc2UgOiBwdWJsaWMgV2lkZ2V0IHsKIHB1YmxpYzoKKyAgICBib29sIGlzUGx1Z2luVmlld0Jh c2UoKSBjb25zdCBvdmVycmlkZSB7IHJldHVybiB0cnVlOyB9CisKICAgICB2aXJ0dWFsIFBsYXRm b3JtTGF5ZXIqIHBsYXRmb3JtTGF5ZXIoKSBjb25zdCB7IHJldHVybiAwOyB9CiAjaWYgUExBVEZP Uk0oSU9TKQogICAgIHZpcnR1YWwgYm9vbCB3aWxsUHJvdmlkZVBsdWdpbkxheWVyKCkgY29uc3Qg eyByZXR1cm4gZmFsc2U7IH0KQEAgLTczLDcgKzc1LDYgQEAgcHVibGljOgogCiAgICAgdmlydHVh bCBib29sIHNob3VsZEFsbG93TmF2aWdhdGlvbkZyb21EcmFncygpIGNvbnN0IHsgcmV0dXJuIGZh bHNlOyB9CiAKLSAgICB2aXJ0dWFsIGJvb2wgaXNQbHVnaW5WaWV3QmFzZSgpIGNvbnN0IHsgcmV0 dXJuIHRydWU7IH0KICAgICB2aXJ0dWFsIGJvb2wgc2hvdWxkTm90QWRkTGF5ZXIoKSBjb25zdCB7 IHJldHVybiBmYWxzZTsgfQogCiAgICAgdmlydHVhbCBBdWRpb0hhcmR3YXJlQWN0aXZpdHlUeXBl IGF1ZGlvSGFyZHdhcmVBY3Rpdml0eSgpIGNvbnN0IHsgcmV0dXJuIEF1ZGlvSGFyZHdhcmVBY3Rp dml0eVR5cGU6OlVua25vd247IH0K 291180 2016-10-10 16:27:44 -0700 2016-10-10 17:02:21 -0700 Patch bug-163218-20161011022422.patch text/plain 1391 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2OTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWQ1MTczYmFiMjM3NzZj YzQyNzk5ZDk2OTNjMTk3ODllYWM4ODRlYi4uNWQ5YmQwMjkzZTY2M2RjYzBjNzQxYmJjMjZlMTVi NWQ1OTBhMDRlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE2LTEwLTEwICBLb25z dGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBBZGRlZCBvdmVy cmlkZSBzcGVjaWZpZXIgdG8gUGx1Z2luVmlld0Jhc2U6OmlzUGx1Z2luVmlld0Jhc2UoKQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzMjE4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz IG5lZWRlZC4KKworICAgICAgICAqIHBsdWdpbnMvUGx1Z2luVmlld0Jhc2UuaDoKKwogMjAxNi0x MC0xMCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAg ICAgUkVHUkVTU0lPTihyMjA2NzMxKTogW1NPVVBdIE5ldHdvcmsgcHJvY2VzcyBjcmFzaCBpbiBn b3RIZWFkZXJzQ2FsbGJhY2sKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1 Z2luVmlld0Jhc2UuaCBiL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlld0Jhc2UuaApp bmRleCBlYzNiYjAxODU3ZjYxNDY0NDA0YTE4NmRjZDBiOTA3ZjFmODI5NGNmLi5lYTU0Yjg2ODI0 ZWI1OTViMWI1MWEzZGZjOTFlOTkyMTRhNmMxOGJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbHVnaW5zL1BsdWdpblZpZXdCYXNlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9Q bHVnaW5WaWV3QmFzZS5oCkBAIC03Myw3ICs3Myw3IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwg Ym9vbCBzaG91bGRBbGxvd05hdmlnYXRpb25Gcm9tRHJhZ3MoKSBjb25zdCB7IHJldHVybiBmYWxz ZTsgfQogCi0gICAgdmlydHVhbCBib29sIGlzUGx1Z2luVmlld0Jhc2UoKSBjb25zdCB7IHJldHVy biB0cnVlOyB9CisgICAgYm9vbCBpc1BsdWdpblZpZXdCYXNlKCkgY29uc3Qgb3ZlcnJpZGUgeyBy ZXR1cm4gdHJ1ZTsgfQogICAgIHZpcnR1YWwgYm9vbCBzaG91bGROb3RBZGRMYXllcigpIGNvbnN0 IHsgcmV0dXJuIGZhbHNlOyB9CiAKICAgICB2aXJ0dWFsIEF1ZGlvSGFyZHdhcmVBY3Rpdml0eVR5 cGUgYXVkaW9IYXJkd2FyZUFjdGl2aXR5KCkgY29uc3QgeyByZXR1cm4gQXVkaW9IYXJkd2FyZUFj dGl2aXR5VHlwZTo6VW5rbm93bjsgfQo=