163215 2016-10-10 09:09:16 -0700 compileCheckStringIdent in the FTL is wrong 2016-10-10 13:36:26 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff oliver ticaiolima ysuzuki oldest_to_newest 1238322 0 saam 2016-10-10 09:09:16 -0700 It thinks a value that is a StringImpl is a JSString. 1238399 1 291124 saam 2016-10-10 11:27:56 -0700 Created attachment 291124 patch 1238403 2 291124 mark.lam 2016-10-10 11:28:54 -0700 Comment on attachment 291124 patch r=me Can we have a test? 1238404 3 291124 fpizlo 2016-10-10 11:29:21 -0700 Comment on attachment 291124 patch LValue lowStringIdent(Edge edge, OperandSpeculationMode mode = AutomaticOperandSpeculation) { ASSERT_UNUSED(mode, mode == ManualOperandSpeculation || edge.useKind() == StringIdentUse); LValue string = lowString(edge, mode); LValue stringImpl = m_out.loadPtr(string, m_heaps.JSString_value); speculateStringIdent(edge, string, stringImpl); return stringImpl; } 1238405 4 291124 fpizlo 2016-10-10 11:30:00 -0700 Comment on attachment 291124 patch Of course that's right. I had it backwards. 1238420 5 291128 saam 2016-10-10 11:52:09 -0700 Created attachment 291128 patch for landing 1238421 6 291128 fpizlo 2016-10-10 11:52:53 -0700 Comment on attachment 291128 patch for landing r=me on the test. 1238498 7 291128 commit-queue 2016-10-10 13:36:22 -0700 Comment on attachment 291128 patch for landing Clearing flags on attachment: 291128 Committed r207017: <http://trac.webkit.org/changeset/207017> 1238499 8 commit-queue 2016-10-10 13:36:26 -0700 All reviewed patches have been landed. Closing bug. 291124 2016-10-10 11:27:56 -0700 2016-10-10 11:52:09 -0700 patch a-backup.diff text/plain 1491 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA3MDA4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE2LTEwLTEwICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IGNvbXBpbGVDaGVja1N0cmluZ0lkZW50IGluIHRoZSBGVEwgaXMgd3JvbmcKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MzIxNQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGxvd1N0cmluZ0lkZW50KCkgcmV0 dXJucyB0aGUgU3RyaW5nSW1wbCBwb2ludGVyLiBUaGUgY29tcGlsZUNoZWNrU3RyaW5nSWRlbnQo KQorICAgICAgICB3YXMgdHJlYXRpbmcgaXRzIHJldHVybiB2YWx1ZSBhcyB0aGUgYWN0dWFsIEpT U3RyaW5nLiBUaGlzIGlzIHdyb25nLgorCisgICAgICAgICogZnRsL0ZUTExvd2VyREZHVG9CMy5j cHA6CisgICAgICAgIChKU0M6OkZUTDo6REZHOjpMb3dlckRGR1RvQjM6OmNvbXBpbGVDaGVja1N0 cmluZ0lkZW50KToKKwogMjAxNi0xMC0wOSAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29t PgogCiAgICAgICAgIEFpciBzaG91bGQgZXhwb3NlIEFQSSBmb3IgcGlubmluZyByZWdpc3RlcnMK SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0IzLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9CMy5jcHAJ KHJldmlzaW9uIDIwNzAwOCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJE RkdUb0IzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjYwNiw4ICsyNjA2LDcgQEAgcHJpdmF0ZToK ICAgICB2b2lkIGNvbXBpbGVDaGVja1N0cmluZ0lkZW50KCkKICAgICB7CiAgICAgICAgIFVuaXF1 ZWRTdHJpbmdJbXBsKiB1aWQgPSBtX25vZGUtPnVpZE9wZXJhbmQoKTsKLSAgICAgICAgTFZhbHVl IHN0cmluZyA9IGxvd1N0cmluZ0lkZW50KG1fbm9kZS0+Y2hpbGQxKCkpOwotICAgICAgICBMVmFs dWUgc3RyaW5nSW1wbCA9IG1fb3V0LmxvYWRQdHIoc3RyaW5nLCBtX2hlYXBzLkpTU3RyaW5nX3Zh bHVlKTsKKyAgICAgICAgTFZhbHVlIHN0cmluZ0ltcGwgPSBsb3dTdHJpbmdJZGVudChtX25vZGUt PmNoaWxkMSgpKTsKICAgICAgICAgc3BlY3VsYXRlKEJhZElkZW50LCBub1ZhbHVlKCksIG51bGxw dHIsIG1fb3V0Lm5vdEVxdWFsKHN0cmluZ0ltcGwsIG1fb3V0LmNvbnN0SW50UHRyKHVpZCkpKTsK ICAgICB9CiAK 291128 2016-10-10 11:52:09 -0700 2016-10-10 13:36:22 -0700 patch for landing a-backup.diff text/plain 2049 saam SW5kZXg6IEpTVGVzdHMvc3RyZXNzL2NoZWNrLXN0cmluZy1pZGVudC5qcwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBKU1Rlc3RzL3N0cmVzcy9jaGVjay1zdHJpbmctaWRlbnQuanMJKG5vbmV4aXN0ZW50KQorKysg SlNUZXN0cy9zdHJlc3MvY2hlY2stc3RyaW5nLWlkZW50LmpzCSh3b3JraW5nIGNvcHkpCkBAIC0w LDAgKzEsMTUgQEAKKy8vQCBkZWZhdWx0Tm9FYWdlclJ1bgorCitjb25zdCBvID0geyBiYXo6IDIw IH07CitmdW5jdGlvbiBmb28ocCkgeworICAgIG9bcF0gPSAyMDsKK30KK25vSW5saW5lKGZvbyk7 Citub09TUkV4aXRGdXp6aW5nKGZvbyk7CisKK2ZvciAobGV0IGkgPSAwOyBpIDwgMTAwMDAwMDsg aSsrKSB7CisgICAgZm9vKCJiYXoiKTsKK30KKworaWYgKG51bWJlck9mREZHQ29tcGlsZXMoZm9v KSA+IDEpCisgICAgdGhyb3cgbmV3IEVycm9yKCJXZSBzaG91bGQgbm90IGhhdmUgdG8gY29tcGls ZSB0aGlzIGZ1bmN0aW9uIG1vcmUgdGhhbiBvbmNlLiIpOwpJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMDcwMDgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTYtMTAtMTAgIFNhYW0gQmFy YXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CisKKyAgICAgICAgY29tcGlsZUNoZWNrU3RyaW5nSWRl bnQgaW4gdGhlIEZUTCBpcyB3cm9uZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTYzMjE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTWFyayBMYW0gYW5k IEZpbGlwIFBpemxvLgorCisgICAgICAgIGxvd1N0cmluZ0lkZW50KCkgcmV0dXJucyB0aGUgU3Ry aW5nSW1wbCBwb2ludGVyLiBUaGUgY29tcGlsZUNoZWNrU3RyaW5nSWRlbnQoKQorICAgICAgICB3 YXMgdHJlYXRpbmcgaXRzIHJldHVybiB2YWx1ZSBhcyB0aGUgYWN0dWFsIEpTU3RyaW5nLiBUaGlz IGlzIHdyb25nLgorCisgICAgICAgICogZnRsL0ZUTExvd2VyREZHVG9CMy5jcHA6CisgICAgICAg IChKU0M6OkZUTDo6REZHOjpMb3dlckRGR1RvQjM6OmNvbXBpbGVDaGVja1N0cmluZ0lkZW50KToK KwogMjAxNi0xMC0wOSAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAg IEFpciBzaG91bGQgZXhwb3NlIEFQSSBmb3IgcGlubmluZyByZWdpc3RlcnMKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0IzLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9CMy5jcHAJKHJldmlzaW9uIDIw NzAwOCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0IzLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMjYwNiw4ICsyNjA2LDcgQEAgcHJpdmF0ZToKICAgICB2b2lkIGNv bXBpbGVDaGVja1N0cmluZ0lkZW50KCkKICAgICB7CiAgICAgICAgIFVuaXF1ZWRTdHJpbmdJbXBs KiB1aWQgPSBtX25vZGUtPnVpZE9wZXJhbmQoKTsKLSAgICAgICAgTFZhbHVlIHN0cmluZyA9IGxv d1N0cmluZ0lkZW50KG1fbm9kZS0+Y2hpbGQxKCkpOwotICAgICAgICBMVmFsdWUgc3RyaW5nSW1w bCA9IG1fb3V0LmxvYWRQdHIoc3RyaW5nLCBtX2hlYXBzLkpTU3RyaW5nX3ZhbHVlKTsKKyAgICAg ICAgTFZhbHVlIHN0cmluZ0ltcGwgPSBsb3dTdHJpbmdJZGVudChtX25vZGUtPmNoaWxkMSgpKTsK ICAgICAgICAgc3BlY3VsYXRlKEJhZElkZW50LCBub1ZhbHVlKCksIG51bGxwdHIsIG1fb3V0Lm5v dEVxdWFsKHN0cmluZ0ltcGwsIG1fb3V0LmNvbnN0SW50UHRyKHVpZCkpKTsKICAgICB9CiAK