<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>163204</bug_id>
          
          <creation_ts>2016-10-10 03:58:04 -0700</creation_ts>
          <short_desc>NetworkSession: NetworkDataTask is leaked if download finishes in didReceiveResponse completion handler</short_desc>
          <delta_ts>2016-10-10 22:31:29 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>WebKit Local Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Carlos Garcia Campos">cgarcia</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>achristensen</cc>
    
    <cc>beidson</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1238261</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2016-10-10 03:58:04 -0700</bug_when>
    <thetext>After the completion handler a reference of the NetworkDataTask is saved in m_downloadsAfterDestinationDecided. If the download failed or was canceled DownloadManager::dataTaskBecameDownloadTask is never called and the data task is kept in the download manager forever.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1238262</commentid>
    <comment_count>1</comment_count>
      <attachid>291085</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2016-10-10 04:03:14 -0700</bug_when>
    <thetext>Created attachment 291085
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1238268</commentid>
    <comment_count>2</comment_count>
      <attachid>291090</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2016-10-10 05:13:37 -0700</bug_when>
    <thetext>Created attachment 291090
Try to fix mac builds</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1238328</commentid>
    <comment_count>3</comment_count>
      <attachid>291090</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2016-10-10 09:21:48 -0700</bug_when>
    <thetext>Comment on attachment 291090
Try to fix mac builds

View in context: https://bugs.webkit.org/attachment.cgi?id=291090&amp;action=review

&gt; Source/WebKit2/ChangeLog:11
&gt; +        NetworkDataTask, so that the download manager can check the task state after the co,pletion handler and return

completion

&gt; Source/WebKit2/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:426
&gt; +    ASSERT_NOT_REACHED();
&gt; +    return State::Running;

I know this should be impossible and doesn&apos;t matter, but let&apos;s default to Completed in this case so we won&apos;t do anything.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1238332</commentid>
    <comment_count>4</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2016-10-10 09:27:15 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; Comment on attachment 291090 [details]
&gt; Try to fix mac builds
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=291090&amp;action=review
&gt; 
&gt; &gt; Source/WebKit2/ChangeLog:11
&gt; &gt; +        NetworkDataTask, so that the download manager can check the task state after the co,pletion handler and return
&gt; 
&gt; completion
&gt; 
&gt; &gt; Source/WebKit2/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:426
&gt; &gt; +    ASSERT_NOT_REACHED();
&gt; &gt; +    return State::Running;
&gt; 
&gt; I know this should be impossible and doesn&apos;t matter, but let&apos;s default to
&gt; Completed in this case so we won&apos;t do anything.

Good point</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1238737</commentid>
    <comment_count>5</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2016-10-10 22:31:29 -0700</bug_when>
    <thetext>Committed r207042: &lt;http://trac.webkit.org/changeset/207042&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>291085</attachid>
            <date>2016-10-10 04:03:14 -0700</date>
            <delta_ts>2016-10-10 05:13:37 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>wk2-download-failed-leak.diff</filename>
            <type>text/plain</type>
            <size>3942</size>
            <attacher name="Carlos Garcia Campos">cgarcia</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No
YW5nZUxvZwppbmRleCAyYzNkYWFkLi44ZGIxMzU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjQg
QEAKIDIwMTYtMTAtMTAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t
PgogCisgICAgICAgIE5ldHdvcmtTZXNzaW9uOiBOZXR3b3JrRGF0YVRhc2sgaXMgbGVha2VkIGlm
IGRvd25sb2FkIGZpbmlzaGVzIGluIGRpZFJlY2VpdmVSZXNwb25zZSBjb21wbGV0aW9uIGhhbmRs
ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MzIw
NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFmdGVy
IHRoZSBjb21wbGV0aW9uIGhhbmRsZXIgYSByZWZlcmVuY2Ugb2YgdGhlIE5ldHdvcmtEYXRhVGFz
ayBpcyBzYXZlZCBpbiBtX2Rvd25sb2Fkc0FmdGVyRGVzdGluYXRpb25EZWNpZGVkLgorICAgICAg
ICBJZiB0aGUgZG93bmxvYWQgZmFpbGVkIG9yIHdhcyBjYW5jZWxlZCBEb3dubG9hZE1hbmFnZXI6
OmRhdGFUYXNrQmVjYW1lRG93bmxvYWRUYXNrIGlzIG5ldmVyIGNhbGxlZCBhbmQgdGhlIGRhdGEK
KyAgICAgICAgdGFzayBpcyBrZXB0IGluIHRoZSBkb3dubG9hZCBtYW5hZ2VyIGZvcmV2ZXIuIFRo
aXMgcGF0Y2ggZXhwb3NlcyBOU1VSTFNlc3Npb25UYXNrIHN0YXRlIHByb3BlcnR5IGluCisgICAg
ICAgIE5ldHdvcmtEYXRhVGFzaywgc28gdGhhdCB0aGUgZG93bmxvYWQgbWFuYWdlciBjYW4gY2hl
Y2sgdGhlIHRhc2sgc3RhdGUgYWZ0ZXIgdGhlIGNvLHBsZXRpb24gaGFuZGxlciBhbmQgcmV0dXJu
CisgICAgICAgIGVhcmx5IGlmIHRoZSBkb3dubG9hZCBmaW5pc2hlZCBvciB3YXMgY2FuY2VsbGVk
LgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvRG93bmxvYWRzL0Rvd25sb2FkTWFuYWdlci5j
cHA6CisgICAgICAgIChXZWJLaXQ6OkRvd25sb2FkTWFuYWdlcjo6Y29udGludWVEZWNpZGVQZW5k
aW5nRG93bmxvYWREZXN0aW5hdGlvbik6CisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvTmV0d29y
a0RhdGFUYXNrLmg6CisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya0RhdGFU
YXNrQ29jb2EubW06CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtEYXRhVGFzazo6c3RhdGUpOgor
CisyMDE2LTEwLTEwICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4K
KwogICAgICAgICBOZXR3b3JrU2Vzc2lvbjogZG93bmxvYWRzIHN0YXJ0ZWQgYnkgc3RhcnREb3du
bG9hZCgpIGNhbiBmYWlsIGJlZm9yZSBzdGFydGluZyBmcm9tIHRoZSBBUEkgcG9pbnQgb2Ygdmll
dwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzMTA3
CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL0Rvd25sb2Fkcy9E
b3dubG9hZE1hbmFnZXIuY3BwIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvRG93bmxv
YWRzL0Rvd25sb2FkTWFuYWdlci5jcHAKaW5kZXggNGY2NTdmZC4uNGM3NmVhNSAxMDA2NDQKLS0t
IGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvRG93bmxvYWRzL0Rvd25sb2FkTWFuYWdl
ci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvRG93bmxvYWRzL0Rvd25s
b2FkTWFuYWdlci5jcHAKQEAgLTEyNCw2ICsxMjQsOCBAQCB2b2lkIERvd25sb2FkTWFuYWdlcjo6
Y29udGludWVEZWNpZGVQZW5kaW5nRG93bmxvYWREZXN0aW5hdGlvbihEb3dubG9hZElEIGRvd25s
bwogCiAgICAgICAgIG5ldHdvcmtEYXRhVGFzay0+c2V0UGVuZGluZ0Rvd25sb2FkTG9jYXRpb24o
ZGVzdGluYXRpb24sIHNhbmRib3hFeHRlbnNpb25IYW5kbGUsIGFsbG93T3ZlcndyaXRlKTsKICAg
ICAgICAgY29tcGxldGlvbkhhbmRsZXIoUG9saWN5RG93bmxvYWQpOworICAgICAgICBpZiAobmV0
d29ya0RhdGFUYXNrLT5zdGF0ZSgpID09IE5ldHdvcmtEYXRhVGFzazo6U3RhdGU6OkNhbmNlbGlu
ZyB8fCBuZXR3b3JrRGF0YVRhc2stPnN0YXRlKCkgPT0gTmV0d29ya0RhdGFUYXNrOjpTdGF0ZTo6
Q29tcGxldGVkKQorICAgICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgIGlmIChtX2Rvd25sb2Fk
cy5jb250YWlucyhkb3dubG9hZElEKSkgewogICAgICAgICAgICAgLy8gVGhlIGNvbXBsZXRpb24g
aGFuZGxlciBhbHJlYWR5IGNhbGxlZCBkYXRhVGFza0JlY2FtZURvd25sb2FkVGFzaygpLgpkaWZm
IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0RhdGFUYXNrLmgg
Yi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrRGF0YVRhc2suaAppbmRleCBj
ZTE5ZWE5Li44NzQ5Y2NmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vz
cy9OZXR3b3JrRGF0YVRhc2suaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9O
ZXR3b3JrRGF0YVRhc2suaApAQCAtMTAxLDcgKzEwMSwxNSBAQCBwdWJsaWM6CiAgICAgdm9pZCBz
dXNwZW5kKCk7CiAgICAgdm9pZCBjYW5jZWwoKTsKICAgICB2b2lkIHJlc3VtZSgpOwotICAgIAor
CisgICAgZW51bSBjbGFzcyBTdGF0ZSB7CisgICAgICAgIFJ1bm5pbmcsCisgICAgICAgIFN1c3Bl
bmRlZCwKKyAgICAgICAgQ2FuY2VsaW5nLAorICAgICAgICBDb21wbGV0ZWQKKyAgICB9OworICAg
IFN0YXRlIHN0YXRlKCkgY29uc3Q7CisKICAgICB0eXBlZGVmIHVpbnQ2NF90IFRhc2tJZGVudGlm
aWVyOwogICAgIAogICAgIH5OZXR3b3JrRGF0YVRhc2soKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X
ZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtEYXRhVGFza0NvY29hLm1tIGIvU291
cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya0RhdGFUYXNrQ29jb2EubW0K
aW5kZXggMDA1NzI2Ni4uYTA1YmQ2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvTmV0d29y
a1Byb2Nlc3MvY29jb2EvTmV0d29ya0RhdGFUYXNrQ29jb2EubW0KKysrIGIvU291cmNlL1dlYktp
dDIvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya0RhdGFUYXNrQ29jb2EubW0KQEAgLTQwOSw2
ICs0MDksMjMgQEAgdm9pZCBOZXR3b3JrRGF0YVRhc2s6OnN1c3BlbmQoKQogICAgIFttX3Rhc2sg
c3VzcGVuZF07CiB9CiAKK1N0YXRlIE5ldHdvcmtEYXRhVGFzazo6c3RhdGUoKSBjb25zdAorewor
ICAgIHN3aXRjaCAoW21fdGFzayBzdGF0ZV0pIHsKKyAgICBjYXNlIE5TVVJMU2Vzc2lvblRhc2tT
dGF0ZVJ1bm5pbmc6CisgICAgICAgIHJldHVybiBTdGF0ZTo6UnVubmluZzsKKyAgICBjYXNlIE5T
VVJMU2Vzc2lvblRhc2tTdGF0ZVN1c3BlbmRlZDoKKyAgICAgICAgcmV0dXJuIFN0YXRlOjpTdXNw
ZW5kZWQ7CisgICAgY2FzZSBOU1VSTFNlc3Npb25UYXNrU3RhdGVDYW5jZWxpbmc6CisgICAgICAg
IHJldHVybiBTdGF0ZTo6Q2FuY2VsaW5nOworICAgIGNhc2UgTlNVUkxTZXNzaW9uVGFza1N0YXRl
Q29tcGxldGVkOgorICAgICAgICByZXR1cm4gU3RhdGU6OkNvbXBsZXRlZDsKKyAgICB9CisKKyAg
ICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICByZXR1cm4gU3RhdGU6OlJ1bm5pbmc7Cit9CisK
IFdlYkNvcmU6OkNyZWRlbnRpYWwgc2VydmVyVHJ1c3RDcmVkZW50aWFsKGNvbnN0IFdlYkNvcmU6
OkF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlJiBjaGFsbGVuZ2UpCiB7CiAgICAgcmV0dXJuIFdlYkNv
cmU6OkNyZWRlbnRpYWwoW05TVVJMQ3JlZGVudGlhbCBjcmVkZW50aWFsRm9yVHJ1c3Q6Y2hhbGxl
bmdlLm5zVVJMQXV0aGVudGljYXRpb25DaGFsbGVuZ2UoKS5wcm90ZWN0aW9uU3BhY2Uuc2VydmVy
VHJ1c3RdKTsK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>291090</attachid>
            <date>2016-10-10 05:13:37 -0700</date>
            <delta_ts>2016-10-10 09:21:48 -0700</delta_ts>
            <desc>Try to fix mac builds</desc>
            <filename>wk2-download-failed-leak.diff</filename>
            <type>text/plain</type>
            <size>3959</size>
            <attacher name="Carlos Garcia Campos">cgarcia</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No
YW5nZUxvZwppbmRleCAyYzNkYWFkLi44ZGIxMzU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjQg
QEAKIDIwMTYtMTAtMTAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t
PgogCisgICAgICAgIE5ldHdvcmtTZXNzaW9uOiBOZXR3b3JrRGF0YVRhc2sgaXMgbGVha2VkIGlm
IGRvd25sb2FkIGZpbmlzaGVzIGluIGRpZFJlY2VpdmVSZXNwb25zZSBjb21wbGV0aW9uIGhhbmRs
ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MzIw
NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFmdGVy
IHRoZSBjb21wbGV0aW9uIGhhbmRsZXIgYSByZWZlcmVuY2Ugb2YgdGhlIE5ldHdvcmtEYXRhVGFz
ayBpcyBzYXZlZCBpbiBtX2Rvd25sb2Fkc0FmdGVyRGVzdGluYXRpb25EZWNpZGVkLgorICAgICAg
ICBJZiB0aGUgZG93bmxvYWQgZmFpbGVkIG9yIHdhcyBjYW5jZWxlZCBEb3dubG9hZE1hbmFnZXI6
OmRhdGFUYXNrQmVjYW1lRG93bmxvYWRUYXNrIGlzIG5ldmVyIGNhbGxlZCBhbmQgdGhlIGRhdGEK
KyAgICAgICAgdGFzayBpcyBrZXB0IGluIHRoZSBkb3dubG9hZCBtYW5hZ2VyIGZvcmV2ZXIuIFRo
aXMgcGF0Y2ggZXhwb3NlcyBOU1VSTFNlc3Npb25UYXNrIHN0YXRlIHByb3BlcnR5IGluCisgICAg
ICAgIE5ldHdvcmtEYXRhVGFzaywgc28gdGhhdCB0aGUgZG93bmxvYWQgbWFuYWdlciBjYW4gY2hl
Y2sgdGhlIHRhc2sgc3RhdGUgYWZ0ZXIgdGhlIGNvLHBsZXRpb24gaGFuZGxlciBhbmQgcmV0dXJu
CisgICAgICAgIGVhcmx5IGlmIHRoZSBkb3dubG9hZCBmaW5pc2hlZCBvciB3YXMgY2FuY2VsbGVk
LgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvRG93bmxvYWRzL0Rvd25sb2FkTWFuYWdlci5j
cHA6CisgICAgICAgIChXZWJLaXQ6OkRvd25sb2FkTWFuYWdlcjo6Y29udGludWVEZWNpZGVQZW5k
aW5nRG93bmxvYWREZXN0aW5hdGlvbik6CisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvTmV0d29y
a0RhdGFUYXNrLmg6CisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya0RhdGFU
YXNrQ29jb2EubW06CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtEYXRhVGFzazo6c3RhdGUpOgor
CisyMDE2LTEwLTEwICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4K
KwogICAgICAgICBOZXR3b3JrU2Vzc2lvbjogZG93bmxvYWRzIHN0YXJ0ZWQgYnkgc3RhcnREb3du
bG9hZCgpIGNhbiBmYWlsIGJlZm9yZSBzdGFydGluZyBmcm9tIHRoZSBBUEkgcG9pbnQgb2Ygdmll
dwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzMTA3
CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL0Rvd25sb2Fkcy9E
b3dubG9hZE1hbmFnZXIuY3BwIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvRG93bmxv
YWRzL0Rvd25sb2FkTWFuYWdlci5jcHAKaW5kZXggNGY2NTdmZC4uNGM3NmVhNSAxMDA2NDQKLS0t
IGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvRG93bmxvYWRzL0Rvd25sb2FkTWFuYWdl
ci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvRG93bmxvYWRzL0Rvd25s
b2FkTWFuYWdlci5jcHAKQEAgLTEyNCw2ICsxMjQsOCBAQCB2b2lkIERvd25sb2FkTWFuYWdlcjo6
Y29udGludWVEZWNpZGVQZW5kaW5nRG93bmxvYWREZXN0aW5hdGlvbihEb3dubG9hZElEIGRvd25s
bwogCiAgICAgICAgIG5ldHdvcmtEYXRhVGFzay0+c2V0UGVuZGluZ0Rvd25sb2FkTG9jYXRpb24o
ZGVzdGluYXRpb24sIHNhbmRib3hFeHRlbnNpb25IYW5kbGUsIGFsbG93T3ZlcndyaXRlKTsKICAg
ICAgICAgY29tcGxldGlvbkhhbmRsZXIoUG9saWN5RG93bmxvYWQpOworICAgICAgICBpZiAobmV0
d29ya0RhdGFUYXNrLT5zdGF0ZSgpID09IE5ldHdvcmtEYXRhVGFzazo6U3RhdGU6OkNhbmNlbGlu
ZyB8fCBuZXR3b3JrRGF0YVRhc2stPnN0YXRlKCkgPT0gTmV0d29ya0RhdGFUYXNrOjpTdGF0ZTo6
Q29tcGxldGVkKQorICAgICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgIGlmIChtX2Rvd25sb2Fk
cy5jb250YWlucyhkb3dubG9hZElEKSkgewogICAgICAgICAgICAgLy8gVGhlIGNvbXBsZXRpb24g
aGFuZGxlciBhbHJlYWR5IGNhbGxlZCBkYXRhVGFza0JlY2FtZURvd25sb2FkVGFzaygpLgpkaWZm
IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0RhdGFUYXNrLmgg
Yi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrRGF0YVRhc2suaAppbmRleCBj
ZTE5ZWE5Li44NzQ5Y2NmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vz
cy9OZXR3b3JrRGF0YVRhc2suaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9O
ZXR3b3JrRGF0YVRhc2suaApAQCAtMTAxLDcgKzEwMSwxNSBAQCBwdWJsaWM6CiAgICAgdm9pZCBz
dXNwZW5kKCk7CiAgICAgdm9pZCBjYW5jZWwoKTsKICAgICB2b2lkIHJlc3VtZSgpOwotICAgIAor
CisgICAgZW51bSBjbGFzcyBTdGF0ZSB7CisgICAgICAgIFJ1bm5pbmcsCisgICAgICAgIFN1c3Bl
bmRlZCwKKyAgICAgICAgQ2FuY2VsaW5nLAorICAgICAgICBDb21wbGV0ZWQKKyAgICB9OworICAg
IFN0YXRlIHN0YXRlKCkgY29uc3Q7CisKICAgICB0eXBlZGVmIHVpbnQ2NF90IFRhc2tJZGVudGlm
aWVyOwogICAgIAogICAgIH5OZXR3b3JrRGF0YVRhc2soKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X
ZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtEYXRhVGFza0NvY29hLm1tIGIvU291
cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya0RhdGFUYXNrQ29jb2EubW0K
aW5kZXggMDA1NzI2Ni4uMmRmMjYwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvTmV0d29y
a1Byb2Nlc3MvY29jb2EvTmV0d29ya0RhdGFUYXNrQ29jb2EubW0KKysrIGIvU291cmNlL1dlYktp
dDIvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya0RhdGFUYXNrQ29jb2EubW0KQEAgLTQwOSw2
ICs0MDksMjMgQEAgdm9pZCBOZXR3b3JrRGF0YVRhc2s6OnN1c3BlbmQoKQogICAgIFttX3Rhc2sg
c3VzcGVuZF07CiB9CiAKK05ldHdvcmtEYXRhVGFzazo6U3RhdGUgTmV0d29ya0RhdGFUYXNrOjpz
dGF0ZSgpIGNvbnN0Cit7CisgICAgc3dpdGNoIChbbV90YXNrIHN0YXRlXSkgeworICAgIGNhc2Ug
TlNVUkxTZXNzaW9uVGFza1N0YXRlUnVubmluZzoKKyAgICAgICAgcmV0dXJuIFN0YXRlOjpSdW5u
aW5nOworICAgIGNhc2UgTlNVUkxTZXNzaW9uVGFza1N0YXRlU3VzcGVuZGVkOgorICAgICAgICBy
ZXR1cm4gU3RhdGU6OlN1c3BlbmRlZDsKKyAgICBjYXNlIE5TVVJMU2Vzc2lvblRhc2tTdGF0ZUNh
bmNlbGluZzoKKyAgICAgICAgcmV0dXJuIFN0YXRlOjpDYW5jZWxpbmc7CisgICAgY2FzZSBOU1VS
TFNlc3Npb25UYXNrU3RhdGVDb21wbGV0ZWQ6CisgICAgICAgIHJldHVybiBTdGF0ZTo6Q29tcGxl
dGVkOworICAgIH0KKworICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgIHJldHVybiBTdGF0
ZTo6UnVubmluZzsKK30KKwogV2ViQ29yZTo6Q3JlZGVudGlhbCBzZXJ2ZXJUcnVzdENyZWRlbnRp
YWwoY29uc3QgV2ViQ29yZTo6QXV0aGVudGljYXRpb25DaGFsbGVuZ2UmIGNoYWxsZW5nZSkKIHsK
ICAgICByZXR1cm4gV2ViQ29yZTo6Q3JlZGVudGlhbChbTlNVUkxDcmVkZW50aWFsIGNyZWRlbnRp
YWxGb3JUcnVzdDpjaGFsbGVuZ2UubnNVUkxBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSgpLnByb3Rl
Y3Rpb25TcGFjZS5zZXJ2ZXJUcnVzdF0pOwo=
</data>
<flag name="review"
          id="314233"
          type_id="1"
          status="+"
          setter="achristensen"
    />
          </attachment>
      

    </bug>

</bugzilla>