163190 2016-10-09 17:44:57 -0700 [GTK] 2.14.0 Compile Errors: GTK 3.22.1 2016-10-10 09:19:30 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build PC Linux RESOLVED FIXED P2 Major --- 1 musl100-bes webkit-unassigned bugs-noreply cgarcia commit-queue mcatanzaro oldest_to_newest 1238148 0 musl100-bes 2016-10-09 17:44:57 -0700 Arch Linux. Compiling with -DENABLE_OPENGL=OFF results in: [ 96%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/WebResourceLoadStatisticsStore.cpp.o /tmp/webkit2gtk/src/webkitgtk-2.14.0/Source/WebKit2/UIProcess/AcceleratedDrawingAreaProxy.cpp: In member function ‘void WebKit::AcceleratedDrawingAreaProxy::setNativeSurfaceHandleForCompositing(uint64_t)’: /tmp/webkit2gtk/src/webkitgtk-2.14.0/Source/WebKit2/UIProcess/AcceleratedDrawingAreaProxy.cpp:271:129: error: ‘DispatchMessageEvenWhenWaitingForSyncReply’ is not a member of ‘IPC’ essages::DrawingArea::SetNativeSurfaceHandleForCompositing(handle), m_webPageProxy.pageID(), IPC::DispatchMessageEvenWhenWaitingForSyncReply); ^~~ make[2]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/build.make:12590: Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/AcceleratedDrawingAreaProxy.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [CMakeFiles/Makefile2:1101: Source/WebKit2/CMakeFiles/WebKit2.dir/all] Error 2 make: *** [Makefile:150: all] Error 2 ==> ERROR: A failure occurred in build(). Aborting... ...while compiling with -DENABLE_OPENGL=ON results in: [ 97%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/gtk/InputMethodFilter.cpp.o /tmp/webkit2gtk/src/webkitgtk-2.14.0/Source/WebKit2/UIProcess/gtk/AcceleratedBackingStoreX11.cpp: In lambda function: /tmp/webkit2gtk/src/webkitgtk-2.14.0/Source/WebKit2/UIProcess/gtk/AcceleratedBackingStoreX11.cpp:158:53: error: ‘gtk_widget_queue_draw’ was not declared in this scope gtk_widget_queue_draw(m_webPage.viewWidget()); ^ make[2]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/build.make:14870: Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/gtk/AcceleratedBackingStoreX11.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [CMakeFiles/Makefile2:1143: Source/WebKit2/CMakeFiles/WebKit2.dir/all] Error 2 make: *** [Makefile:150: all] Error 2 ==> ERROR: A failure occurred in build(). Aborting... What is a possoble workaround/resolution? 1238196 1 cgarcia 2016-10-09 23:49:25 -0700 (In reply to comment #0) > Arch Linux. Compiling with -DENABLE_OPENGL=OFF results in: > > [ 96%] Building CXX object > Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/ > WebResourceLoadStatisticsStore.cpp.o > /tmp/webkit2gtk/src/webkitgtk-2.14.0/Source/WebKit2/UIProcess/ > AcceleratedDrawingAreaProxy.cpp: In member function ‘void > WebKit::AcceleratedDrawingAreaProxy:: > setNativeSurfaceHandleForCompositing(uint64_t)’: > /tmp/webkit2gtk/src/webkitgtk-2.14.0/Source/WebKit2/UIProcess/ > AcceleratedDrawingAreaProxy.cpp:271:129: error: > ‘DispatchMessageEvenWhenWaitingForSyncReply’ is not a member of ‘IPC’ > essages::DrawingArea::SetNativeSurfaceHandleForCompositing(handle), > m_webPageProxy.pageID(), IPC::DispatchMessageEvenWhenWaitingForSyncReply); > > ^~~ > make[2]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/build.make:12590: > Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/AcceleratedDrawingAreaProxy. > cpp.o] Error 1 > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [CMakeFiles/Makefile2:1101: > Source/WebKit2/CMakeFiles/WebKit2.dir/all] Error 2 > make: *** [Makefile:150: all] Error 2 > ==> ERROR: A failure occurred in build(). > Aborting... This was already fixed in r206806, and will be merged in 2.14 branch too. > ...while compiling with -DENABLE_OPENGL=ON results in: > > [ 97%] Building CXX object > Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/gtk/InputMethodFilter.cpp.o > /tmp/webkit2gtk/src/webkitgtk-2.14.0/Source/WebKit2/UIProcess/gtk/ > AcceleratedBackingStoreX11.cpp: In lambda function: > /tmp/webkit2gtk/src/webkitgtk-2.14.0/Source/WebKit2/UIProcess/gtk/ > AcceleratedBackingStoreX11.cpp:158:53: error: ‘gtk_widget_queue_draw’ was > not declared in this scope > gtk_widget_queue_draw(m_webPage.viewWidget()); > ^ > make[2]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/build.make:14870: > Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/gtk/ > AcceleratedBackingStoreX11.cpp.o] Error 1 > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [CMakeFiles/Makefile2:1143: > Source/WebKit2/CMakeFiles/WebKit2.dir/all] Error 2 > make: *** [Makefile:150: all] Error 2 > ==> ERROR: A failure occurred in build(). > Aborting... > > What is a possoble workaround/resolution? Here we just need to include gtk.h 1238305 2 291105 cgarcia 2016-10-10 08:18:25 -0700 Created attachment 291105 Patch I guess this should fix the build. 1238326 3 291105 commit-queue 2016-10-10 09:19:27 -0700 Comment on attachment 291105 Patch Clearing flags on attachment: 291105 Committed r206998: <http://trac.webkit.org/changeset/206998> 1238327 4 commit-queue 2016-10-10 09:19:30 -0700 All reviewed patches have been landed. Closing bug. 291105 2016-10-10 08:18:25 -0700 2016-10-10 09:19:27 -0700 Patch wk2-build-fix.diff text/plain 1208 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAyYzNkYWFkLi5kMjQyYTkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQg QEAKIDIwMTYtMTAtMTAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFtHVEtdIDIuMTQuMCBDb21waWxlIEVycm9yczogR1RLIDMuMjIuMQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzMTkwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv Z3RrL0FjY2VsZXJhdGVkQmFja2luZ1N0b3JlWDExLmNwcDogSW5jbHVkZSBndGsuaCBzaW5jZSB3 ZSBhcmUgdXNpbmcgZ3RrX3dpZGdldF9xdWV1ZV9kcmF3KCkuCisKKzIwMTYtMTAtMTAgIENhcmxv cyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCiAgICAgICAgIE5ldHdvcmtT ZXNzaW9uOiBkb3dubG9hZHMgc3RhcnRlZCBieSBzdGFydERvd25sb2FkKCkgY2FuIGZhaWwgYmVm b3JlIHN0YXJ0aW5nIGZyb20gdGhlIEFQSSBwb2ludCBvZiB2aWV3CiAgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjMxMDcKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL2d0ay9BY2NlbGVyYXRlZEJhY2tpbmdTdG9yZVgxMS5jcHAg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL0FjY2VsZXJhdGVkQmFja2luZ1N0b3JlWDEx LmNwcAppbmRleCBhOGJkNjAxLi4xNjAzNTEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvZ3RrL0FjY2VsZXJhdGVkQmFja2luZ1N0b3JlWDExLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL0FjY2VsZXJhdGVkQmFja2luZ1N0b3JlWDExLmNwcApAQCAt MzcsNiArMzcsNyBAQAogI2luY2x1ZGUgPFgxMS9leHRlbnNpb25zL1hkYW1hZ2UuaD4KICNpbmNs dWRlIDxjYWlyby14bGliLmg+CiAjaW5jbHVkZSA8Z2RrL2dka3guaD4KKyNpbmNsdWRlIDxndGsv Z3RrLmg+CiAjaW5jbHVkZSA8d3RmL0hhc2hNYXAuaD4KICNpbmNsdWRlIDx3dGYvTmV2ZXJEZXN0 cm95ZWQuaD4KIAo=