<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>16318</bug_id>
          
          <creation_ts>2007-12-05 20:48:30 -0800</creation_ts>
          <short_desc>Insufficient repaint issues with html embedded in foreignObject</short_desc>
          <delta_ts>2010-01-20 21:36:51 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>SVG</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc>http://starkravingfinkle.org/blog/wp-content/uploads/2007/07/foreignobject-text.svg</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Major</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Oliver Hunt">oliver</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bdakin</cc>
    
    <cc>eric</cc>
    
    <cc>krit</cc>
    
    <cc>zimmermann</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>63404</commentid>
    <comment_count>0</comment_count>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2007-12-05 20:48:30 -0800</bug_when>
    <thetext>If you play around with the selected text in the linked example there are frequent repaint errors</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>63472</commentid>
    <comment_count>1</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2007-12-06 08:18:51 -0800</bug_when>
    <thetext>&lt;rdar://problem/5632991&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>64259</commentid>
    <comment_count>2</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2007-12-15 03:00:38 -0800</bug_when>
    <thetext>I think the way to fix this is to implement a
bool RenderSVGBlock::absolutePosition(int&amp; xPos, int&amp; yPos, bool fixed) const
function which is absoluteTransform() aware.

</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>182893</commentid>
    <comment_count>3</comment_count>
      <attachid>47055</attachid>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2010-01-20 13:06:30 -0800</bug_when>
    <thetext>Created attachment 47055
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>182905</commentid>
    <comment_count>4</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-01-20 13:34:24 -0800</bug_when>
    <thetext>Yay!  Thanks for fixing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>182907</commentid>
    <comment_count>5</comment_count>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2010-01-20 13:37:25 -0800</bug_when>
    <thetext>Committed r53561: &lt;http://trac.webkit.org/changeset/53561&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>182908</commentid>
    <comment_count>6</comment_count>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2010-01-20 13:38:10 -0800</bug_when>
    <thetext>Committed r53561 -- only partial fix, selection for list markers is still borked</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>182910</commentid>
    <comment_count>7</comment_count>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2010-01-20 13:50:11 -0800</bug_when>
    <thetext>Committed r53562: &lt;http://trac.webkit.org/changeset/53562&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>182967</commentid>
    <comment_count>8</comment_count>
      <attachid>47076</attachid>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2010-01-20 16:26:27 -0800</bug_when>
    <thetext>Created attachment 47076
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>183062</commentid>
    <comment_count>9</comment_count>
      <attachid>47096</attachid>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2010-01-20 20:45:20 -0800</bug_when>
    <thetext>Created attachment 47096
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>183070</commentid>
    <comment_count>10</comment_count>
      <attachid>47096</attachid>
    <who name="">mitz</who>
    <bug_when>2010-01-20 21:00:32 -0800</bug_when>
    <thetext>Comment on attachment 47096
Patch

&gt; +IntRect RenderListMarker::localSelectionRect()
&gt; +{
&gt; +    InlineBox* box = inlineBoxWrapper();
&gt; +    if (!box)
&gt; +        return IntRect();
&gt; +    RootInlineBox* root = box-&gt;root();
&gt; +    if (!root)
&gt; +        return IntRect();

No need to null-check root.

&gt; +    IntRect localSelectionRect();

You should use this new function in selectionRectForRepaint() too instead of having duplicated code.

r=me but please do ^ if possible.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>183076</commentid>
    <comment_count>11</comment_count>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2010-01-20 21:36:51 -0800</bug_when>
    <thetext>Committed r53603: &lt;http://trac.webkit.org/changeset/53603&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>47055</attachid>
            <date>2010-01-20 13:06:30 -0800</date>
            <delta_ts>2010-01-20 16:26:22 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-16318-20100120130628.patch</filename>
            <type>text/plain</type>
            <size>3228</size>
            <attacher name="Oliver Hunt">oliver</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
MzVmM2Y1OC4uNzNkNzIxOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wMS0xOSAgT2xpdmVyIEh1bnQg
IDxvbGl2ZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgIEluc3VmZmljaWVudCByZXBhaW50IGlzc3VlcyB3aXRoIGh0bWwgZW1iZWRk
ZWQgaW4gZm9yZWlnbk9iamVjdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9MTYzMTgKKworICAgICAgICBQYXJ0aWFsIGZpeCBmb3Igc2VsZWN0aW9uIHJl
cGFpbnQgaW4gZm9yZWlnbk9iamVjdCwgYmFzaWNhbGx5IHdlCisgICAgICAgIGp1c3QgbmVlZCB0
byBtYWtlIHN1cmUgZm9yZWlnbk9iamVjdCBjb3JyZWN0bHkgYXBwbGllcyB0aGUgc3ZnCisgICAg
ICAgIHRyYW5zZm9ybSB0byB0aGUgc2VsZWN0aW9uIHJlY3QuCisKKyAgICAgICAgKiByZW5kZXJp
bmcvUmVuZGVyQmxvY2suY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6OnBhaW50
U2VsZWN0aW9uKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyRm9yZWlnbk9iamVjdC5jcHA6
CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJGb3JlaWduT2JqZWN0OjptYXBMb2NhbFRvQ29udGFp
bmVyKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyRm9yZWlnbk9iamVjdC5oOgorCiAyMDEw
LTAxLTIwICBEYXZpZCBMZXZpbiAgPGxldmluQGNocm9taXVtLm9yZz4KIAogICAgICAgICBObyBy
ZXZpZXcsIHJvbGxpbmcgb3V0IHI1MzU1Mi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5n
L1JlbmRlckJsb2NrLmNwcCBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAppbmRl
eCAzZmQxMGVhLi42MWE5N2IzIDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJC
bG9jay5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCkBAIC0xOTU3
LDggKzE5NTcsMTAgQEAgdm9pZCBSZW5kZXJCbG9jazo6cGFpbnRTZWxlY3Rpb24oUGFpbnRJbmZv
JiBwYWludEluZm8sIGludCB0eCwgaW50IHR5KQogICAgICAgICBJbnRSZWN0IGdhcFJlY3RzQm91
bmRzID0gZmlsbFNlbGVjdGlvbkdhcHModGhpcywgdHgsIHR5LCB0eCwgdHksIGxhc3RUb3AsIGxh
c3RMZWZ0LCBsYXN0UmlnaHQsICZwYWludEluZm8pOwogICAgICAgICBpZiAoIWdhcFJlY3RzQm91
bmRzLmlzRW1wdHkoKSkgewogICAgICAgICAgICAgaWYgKFJlbmRlckxheWVyKiBsYXllciA9IGVu
Y2xvc2luZ0xheWVyKCkpIHsKLSAgICAgICAgICAgICAgICBJbnRTaXplIG9mZnNldCA9IGhhc0xh
eWVyKCkgPyBJbnRTaXplKCkgOiBvZmZzZXRGcm9tQW5jZXN0b3JDb250YWluZXIobGF5ZXItPnJl
bmRlcmVyKCkpOwotICAgICAgICAgICAgICAgIGdhcFJlY3RzQm91bmRzLm1vdmUob2Zmc2V0IC0g
SW50U2l6ZSh0eCwgdHkpKTsKKyAgICAgICAgICAgICAgICBpZiAoIWhhc0xheWVyKCkpIHsKKyAg
ICAgICAgICAgICAgICAgICAgRmxvYXRSZWN0IGxvY2FsQm91bmRzKGdhcFJlY3RzQm91bmRzKTsK
KyAgICAgICAgICAgICAgICAgICAgZ2FwUmVjdHNCb3VuZHMgPSBsb2NhbFRvQ29udGFpbmVyUXVh
ZChsb2NhbEJvdW5kcywgbGF5ZXItPnJlbmRlcmVyKCkpLmVuY2xvc2luZ0JvdW5kaW5nQm94KCk7
CisgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgIGxheWVyLT5hZGRCbG9ja1NlbGVj
dGlvbkdhcHNCb3VuZHMoZ2FwUmVjdHNCb3VuZHMpOwogICAgICAgICAgICAgfQogICAgICAgICB9
CmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGb3JlaWduT2JqZWN0LmNwcCBi
L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZvcmVpZ25PYmplY3QuY3BwCmluZGV4IDU3M2FlOTYu
LjY1OTc1NTQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZvcmVpZ25PYmpl
Y3QuY3BwCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZvcmVpZ25PYmplY3QuY3BwCkBA
IC0xMjAsNiArMTIwLDExIEBAIGJvb2wgUmVuZGVyRm9yZWlnbk9iamVjdDo6bm9kZUF0UG9pbnQo
Y29uc3QgSGl0VGVzdFJlcXVlc3QmLCBIaXRUZXN0UmVzdWx0JiwgaW50CiAgICAgcmV0dXJuIGZh
bHNlOwogfQogCit2b2lkIFJlbmRlckZvcmVpZ25PYmplY3Q6Om1hcExvY2FsVG9Db250YWluZXIo
UmVuZGVyQm94TW9kZWxPYmplY3QqIHJlcGFpbnRDb250YWluZXIsIGJvb2wgZml4ZWQgLCBib29s
IHVzZVRyYW5zZm9ybXMsIFRyYW5zZm9ybVN0YXRlJiB0cmFuc2Zvcm1TdGF0ZSkgY29uc3QKK3sK
KyAgICBTVkdSZW5kZXJCYXNlOjptYXBMb2NhbFRvQ29udGFpbmVyKHRoaXMsIHJlcGFpbnRDb250
YWluZXIsIGZpeGVkLCB1c2VUcmFuc2Zvcm1zLCB0cmFuc2Zvcm1TdGF0ZSk7Cit9CisKIH0gLy8g
bmFtZXNwYWNlIFdlYkNvcmUKIAogI2VuZGlmIC8vIEVOQUJMRShTVkcpICYmIEVOQUJMRShTVkdf
Rk9SRUlHTl9PQkpFQ1QpCmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGb3Jl
aWduT2JqZWN0LmggYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGb3JlaWduT2JqZWN0LmgKaW5k
ZXggOGFkMjIzZi4uOGNiOWE1NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy
Rm9yZWlnbk9iamVjdC5oCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZvcmVpZ25PYmpl
Y3QuaApAQCAtNTIsNiArNTIsOCBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBib29sIG5vZGVBdFBv
aW50KGNvbnN0IEhpdFRlc3RSZXF1ZXN0JiwgSGl0VGVzdFJlc3VsdCYsIGludCB4LCBpbnQgeSwg
aW50IHR4LCBpbnQgdHksIEhpdFRlc3RBY3Rpb24pOwogICAgIHZpcnR1YWwgYm9vbCBpc1NWR0Zv
cmVpZ25PYmplY3QoKSBjb25zdCB7IHJldHVybiB0cnVlOyB9CiAKKyAgICB2aXJ0dWFsIHZvaWQg
bWFwTG9jYWxUb0NvbnRhaW5lcihSZW5kZXJCb3hNb2RlbE9iamVjdCogcmVwYWludENvbnRhaW5l
ciwgYm9vbCBmaXhlZCAsIGJvb2wgdXNlVHJhbnNmb3JtcywgVHJhbnNmb3JtU3RhdGUmIHRyYW5z
Zm9ybVN0YXRlKSBjb25zdDsKKwogIHByaXZhdGU6CiAgICAgVHJhbnNmb3JtYXRpb25NYXRyaXgg
dHJhbnNsYXRpb25Gb3JBdHRyaWJ1dGVzKCkgY29uc3Q7CiAK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>47076</attachid>
            <date>2010-01-20 16:26:27 -0800</date>
            <delta_ts>2010-01-20 20:45:15 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-16318-20100120162625.patch</filename>
            <type>text/plain</type>
            <size>3281</size>
            <attacher name="Oliver Hunt">oliver</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
ZGFlY2NhMC4uZGJhYzEzNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wMS0xOSAgT2xpdmVyIEh1bnQg
IDxvbGl2ZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWShPT1BTKS4K
KworICAgICAgICBJbnN1ZmZpY2llbnQgcmVwYWludCBpc3N1ZXMgd2l0aCBodG1sIGVtYmVkZGVk
IGluIGZvcmVpZ25PYmplY3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTE2MzE4CisKKyAgICAgICAgUGFydGlhbCBmaXggZm9yIHNlbGVjdGlvbiByZXBh
aW50IGluIGZvcmVpZ25PYmplY3QsIGJhc2ljYWxseSB3ZQorICAgICAgICBqdXN0IG5lZWQgdG8g
bWFrZSBzdXJlIGZvcmVpZ25PYmplY3QgY29ycmVjdGx5IGFwcGxpZXMgdGhlIHN2ZworICAgICAg
ICB0cmFuc2Zvcm0gdG8gdGhlIHNlbGVjdGlvbiByZWN0LgorCisgICAgICAgICogcmVuZGVyaW5n
L1JlbmRlckJsb2NrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjpwYWludFNl
bGVjdGlvbik6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckZvcmVpZ25PYmplY3QuY3BwOgor
ICAgICAgICAoV2ViQ29yZTo6UmVuZGVyRm9yZWlnbk9iamVjdDo6bWFwTG9jYWxUb0NvbnRhaW5l
cik6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckZvcmVpZ25PYmplY3QuaDoKKwogMjAxMC0w
MS0yMCAgR2F2aW4gQmFycmFjbG91Z2ggIDxiYXJyYWNsb3VnaEBhcHBsZS5jb20+CiAKICAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVu
ZGVyQmxvY2suY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCmluZGV4IDNm
ZDEwZWEuLjFiZWE4ZTMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2Nr
LmNwcAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAKQEAgLTE5NTcsOCAr
MTk1NywxMSBAQCB2b2lkIFJlbmRlckJsb2NrOjpwYWludFNlbGVjdGlvbihQYWludEluZm8mIHBh
aW50SW5mbywgaW50IHR4LCBpbnQgdHkpCiAgICAgICAgIEludFJlY3QgZ2FwUmVjdHNCb3VuZHMg
PSBmaWxsU2VsZWN0aW9uR2Fwcyh0aGlzLCB0eCwgdHksIHR4LCB0eSwgbGFzdFRvcCwgbGFzdExl
ZnQsIGxhc3RSaWdodCwgJnBhaW50SW5mbyk7CiAgICAgICAgIGlmICghZ2FwUmVjdHNCb3VuZHMu
aXNFbXB0eSgpKSB7CiAgICAgICAgICAgICBpZiAoUmVuZGVyTGF5ZXIqIGxheWVyID0gZW5jbG9z
aW5nTGF5ZXIoKSkgewotICAgICAgICAgICAgICAgIEludFNpemUgb2Zmc2V0ID0gaGFzTGF5ZXIo
KSA/IEludFNpemUoKSA6IG9mZnNldEZyb21BbmNlc3RvckNvbnRhaW5lcihsYXllci0+cmVuZGVy
ZXIoKSk7Ci0gICAgICAgICAgICAgICAgZ2FwUmVjdHNCb3VuZHMubW92ZShvZmZzZXQgLSBJbnRT
aXplKHR4LCB0eSkpOworICAgICAgICAgICAgICAgIGdhcFJlY3RzQm91bmRzLm1vdmUoSW50U2l6
ZSgtdHgsIC10eSkpOworICAgICAgICAgICAgICAgIGlmICghaGFzTGF5ZXIoKSkgeworICAgICAg
ICAgICAgICAgICAgICBGbG9hdFJlY3QgbG9jYWxCb3VuZHMoZ2FwUmVjdHNCb3VuZHMpOworICAg
ICAgICAgICAgICAgICAgICBnYXBSZWN0c0JvdW5kcyA9IGxvY2FsVG9Db250YWluZXJRdWFkKGxv
Y2FsQm91bmRzLCBsYXllci0+cmVuZGVyZXIoKSkuZW5jbG9zaW5nQm91bmRpbmdCb3goKTsKKyAg
ICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgbGF5ZXItPmFkZEJsb2NrU2VsZWN0aW9u
R2Fwc0JvdW5kcyhnYXBSZWN0c0JvdW5kcyk7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KZGlm
ZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZvcmVpZ25PYmplY3QuY3BwIGIvV2Vi
Q29yZS9yZW5kZXJpbmcvUmVuZGVyRm9yZWlnbk9iamVjdC5jcHAKaW5kZXggNTczYWU5Ni4uNjU5
NzU1NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRm9yZWlnbk9iamVjdC5j
cHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRm9yZWlnbk9iamVjdC5jcHAKQEAgLTEy
MCw2ICsxMjAsMTEgQEAgYm9vbCBSZW5kZXJGb3JlaWduT2JqZWN0Ojpub2RlQXRQb2ludChjb25z
dCBIaXRUZXN0UmVxdWVzdCYsIEhpdFRlc3RSZXN1bHQmLCBpbnQKICAgICByZXR1cm4gZmFsc2U7
CiB9CiAKK3ZvaWQgUmVuZGVyRm9yZWlnbk9iamVjdDo6bWFwTG9jYWxUb0NvbnRhaW5lcihSZW5k
ZXJCb3hNb2RlbE9iamVjdCogcmVwYWludENvbnRhaW5lciwgYm9vbCBmaXhlZCAsIGJvb2wgdXNl
VHJhbnNmb3JtcywgVHJhbnNmb3JtU3RhdGUmIHRyYW5zZm9ybVN0YXRlKSBjb25zdAoreworICAg
IFNWR1JlbmRlckJhc2U6Om1hcExvY2FsVG9Db250YWluZXIodGhpcywgcmVwYWludENvbnRhaW5l
ciwgZml4ZWQsIHVzZVRyYW5zZm9ybXMsIHRyYW5zZm9ybVN0YXRlKTsKK30KKwogfSAvLyBuYW1l
c3BhY2UgV2ViQ29yZQogCiAjZW5kaWYgLy8gRU5BQkxFKFNWRykgJiYgRU5BQkxFKFNWR19GT1JF
SUdOX09CSkVDVCkKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZvcmVpZ25P
YmplY3QuaCBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZvcmVpZ25PYmplY3QuaAppbmRleCA4
YWQyMjNmLi44Y2I5YTU1IDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGb3Jl
aWduT2JqZWN0LmgKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRm9yZWlnbk9iamVjdC5o
CkBAIC01Miw2ICs1Miw4IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIGJvb2wgbm9kZUF0UG9pbnQo
Y29uc3QgSGl0VGVzdFJlcXVlc3QmLCBIaXRUZXN0UmVzdWx0JiwgaW50IHgsIGludCB5LCBpbnQg
dHgsIGludCB0eSwgSGl0VGVzdEFjdGlvbik7CiAgICAgdmlydHVhbCBib29sIGlzU1ZHRm9yZWln
bk9iamVjdCgpIGNvbnN0IHsgcmV0dXJuIHRydWU7IH0KIAorICAgIHZpcnR1YWwgdm9pZCBtYXBM
b2NhbFRvQ29udGFpbmVyKFJlbmRlckJveE1vZGVsT2JqZWN0KiByZXBhaW50Q29udGFpbmVyLCBi
b29sIGZpeGVkICwgYm9vbCB1c2VUcmFuc2Zvcm1zLCBUcmFuc2Zvcm1TdGF0ZSYgdHJhbnNmb3Jt
U3RhdGUpIGNvbnN0OworCiAgcHJpdmF0ZToKICAgICBUcmFuc2Zvcm1hdGlvbk1hdHJpeCB0cmFu
c2xhdGlvbkZvckF0dHJpYnV0ZXMoKSBjb25zdDsKIAo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>47096</attachid>
            <date>2010-01-20 20:45:20 -0800</date>
            <delta_ts>2010-01-20 21:00:31 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-16318-20100120204518.patch</filename>
            <type>text/plain</type>
            <size>3139</size>
            <attacher name="Oliver Hunt">oliver</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
Mzc0NjE4OC4uMDZmZWE5YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wMS0yMCAgT2xpdmVyIEh1bnQg
IDxvbGl2ZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgIEluc3VmZmljaWVudCByZXBhaW50IGlzc3VlcyB3aXRoIGh0bWwgZW1iZWRk
ZWQgaW4gZm9yZWlnbk9iamVjdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9MTYzMTgKKworICAgICAgICBGaW5hbCBwYXJ0IG9mIGZpeCAtLSBub3cgd2Ug
cmVuZGVyIHRoZSBzZWxlY3Rpb24gcmVjdCBvZiBsaXN0CisgICAgICAgIG1hcmtlcnMgaW4gYSB0
cmFuc2Zvcm1lZCBjb250ZXh0LgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxpc3RNYXJr
ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGlzdE1hcmtlcjo6bG9jYWxTZWxlY3Rp
b25SZWN0KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxpc3RNYXJrZXI6OnBhaW50KToKKyAg
ICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGlzdE1hcmtlci5oOgorCiAyMDEwLTAxLTIwICBTdGV2
ZSBGYWxrZW5idXJnICA8c2ZhbGtlbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg
U2FtIFdlaW5pZy4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxpc3RNYXJr
ZXIuY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGlzdE1hcmtlci5jcHAKaW5kZXggNWNl
OWEyMS4uZjQxMzE2YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGlzdE1h
cmtlci5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGlzdE1hcmtlci5jcHAKQEAg
LTc3Miw2ICs3NzIsMTcgQEAgYm9vbCBSZW5kZXJMaXN0TWFya2VyOjppc0ltYWdlKCkgY29uc3QK
ICAgICByZXR1cm4gbV9pbWFnZSAmJiAhbV9pbWFnZS0+ZXJyb3JPY2N1cnJlZCgpOwogfQogCitJ
bnRSZWN0IFJlbmRlckxpc3RNYXJrZXI6OmxvY2FsU2VsZWN0aW9uUmVjdCgpCit7CisgICAgSW5s
aW5lQm94KiBib3ggPSBpbmxpbmVCb3hXcmFwcGVyKCk7CisgICAgaWYgKCFib3gpCisgICAgICAg
IHJldHVybiBJbnRSZWN0KCk7CisgICAgUm9vdElubGluZUJveCogcm9vdCA9IGJveC0+cm9vdCgp
OworICAgIGlmICghcm9vdCkKKyAgICAgICAgcmV0dXJuIEludFJlY3QoKTsKKyAgICByZXR1cm4g
SW50UmVjdCh4KCksIHJvb3QtPnNlbGVjdGlvblRvcCgpIC0geSgpLCB3aWR0aCgpLCByb290LT5z
ZWxlY3Rpb25IZWlnaHQoKSk7Cit9CisKIHZvaWQgUmVuZGVyTGlzdE1hcmtlcjo6cGFpbnQoUGFp
bnRJbmZvJiBwYWludEluZm8sIGludCB0eCwgaW50IHR5KQogewogICAgIGlmIChwYWludEluZm8u
cGhhc2UgIT0gUGFpbnRQaGFzZUZvcmVncm91bmQpCkBAIC04MDAsOCArODExLDkgQEAgdm9pZCBS
ZW5kZXJMaXN0TWFya2VyOjpwYWludChQYWludEluZm8mIHBhaW50SW5mbywgaW50IHR4LCBpbnQg
dHkpCiAjZW5kaWYKICAgICAgICAgY29udGV4dC0+ZHJhd0ltYWdlKG1faW1hZ2UtPmltYWdlKHRo
aXMsIG1hcmtlci5zaXplKCkpLCBzdHlsZSgpLT5jb2xvclNwYWNlKCksIG1hcmtlci5sb2NhdGlv
bigpKTsKICAgICAgICAgaWYgKHNlbGVjdGlvblN0YXRlKCkgIT0gU2VsZWN0aW9uTm9uZSkgewot
ICAgICAgICAgICAgLy8gRklYTUU6IHNlbGVjdGlvblJlY3QoKSBpcyBpbiBhYnNvbHV0ZSwgbm90
IHBhaW50aW5nIGNvb3JkaW5hdGVzLgotICAgICAgICAgICAgY29udGV4dC0+ZmlsbFJlY3Qoc2Vs
ZWN0aW9uUmVjdCgpLCBzZWxlY3Rpb25CYWNrZ3JvdW5kQ29sb3IoKSwgc3R5bGUoKS0+Y29sb3JT
cGFjZSgpKTsKKyAgICAgICAgICAgIEludFJlY3Qgc2VsUmVjdCA9IGxvY2FsU2VsZWN0aW9uUmVj
dCgpOworICAgICAgICAgICAgc2VsUmVjdC5tb3ZlKHR4LCB0eSk7CisgICAgICAgICAgICBjb250
ZXh0LT5maWxsUmVjdChzZWxSZWN0LCBzZWxlY3Rpb25CYWNrZ3JvdW5kQ29sb3IoKSwgc3R5bGUo
KS0+Y29sb3JTcGFjZSgpKTsKICAgICAgICAgfQogICAgICAgICByZXR1cm47CiAgICAgfQpAQCAt
ODEzLDggKzgyNSw5IEBAIHZvaWQgUmVuZGVyTGlzdE1hcmtlcjo6cGFpbnQoUGFpbnRJbmZvJiBw
YWludEluZm8sIGludCB0eCwgaW50IHR5KQogI2VuZGlmCiAKICAgICBpZiAoc2VsZWN0aW9uU3Rh
dGUoKSAhPSBTZWxlY3Rpb25Ob25lKSB7Ci0gICAgICAgIC8vIEZJWE1FOiBzZWxlY3Rpb25SZWN0
KCkgaXMgaW4gYWJzb2x1dGUsIG5vdCBwYWludGluZyBjb29yZGluYXRlcy4KLSAgICAgICAgY29u
dGV4dC0+ZmlsbFJlY3Qoc2VsZWN0aW9uUmVjdCgpLCBzZWxlY3Rpb25CYWNrZ3JvdW5kQ29sb3Io
KSwgc3R5bGUoKS0+Y29sb3JTcGFjZSgpKTsKKyAgICAgICAgSW50UmVjdCBzZWxSZWN0ID0gbG9j
YWxTZWxlY3Rpb25SZWN0KCk7CisgICAgICAgIHNlbFJlY3QubW92ZSh0eCwgdHkpOworICAgICAg
ICBjb250ZXh0LT5maWxsUmVjdChzZWxSZWN0LCBzZWxlY3Rpb25CYWNrZ3JvdW5kQ29sb3IoKSwg
c3R5bGUoKS0+Y29sb3JTcGFjZSgpKTsKICAgICB9CiAKICAgICBjb25zdCBDb2xvciBjb2xvcihz
dHlsZSgpLT5jb2xvcigpKTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxp
c3RNYXJrZXIuaCBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxpc3RNYXJrZXIuaAppbmRleCA1
YjQ2Mjc4Li45NzE4NzdiIDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMaXN0
TWFya2VyLmgKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGlzdE1hcmtlci5oCkBAIC03
Myw2ICs3Myw3IEBAIHByaXZhdGU6CiAgICAgdmlydHVhbCB2b2lkIHN0eWxlRGlkQ2hhbmdlKFN0
eWxlRGlmZmVyZW5jZSwgY29uc3QgUmVuZGVyU3R5bGUqIG9sZFN0eWxlKTsKIAogICAgIEludFJl
Y3QgZ2V0UmVsYXRpdmVNYXJrZXJSZWN0KCk7CisgICAgSW50UmVjdCBsb2NhbFNlbGVjdGlvblJl
Y3QoKTsKIAogICAgIFN0cmluZyBtX3RleHQ7CiAgICAgUmVmUHRyPFN0eWxlSW1hZ2U+IG1faW1h
Z2U7Cg==
</data>
<flag name="review"
          id="29472"
          type_id="1"
          status="+"
          setter="mitz"
    />
          </attachment>
      

    </bug>

</bugzilla>