163154 2016-10-07 16:01:51 -0700 [WK1 Mac] Fix repaints of fixed-background elements in layer-backed WebViews 2016-10-07 17:23:12 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser bdakin commit-queue mitz simon.fraser thorton oldest_to_newest 1237836 0 simon.fraser 2016-10-07 16:01:51 -0700 [WK1 Mac] Fix repaints of fixed-background elements in layer-backed WebViews 1237844 1 290980 simon.fraser 2016-10-07 16:08:42 -0700 Created attachment 290980 Patch 1237846 2 commit-queue 2016-10-07 16:09:51 -0700 Attachment 290980 did not pass style-queue: ERROR: Source/WebKit/mac/WebView/WebClipView.h:0: Use #pragma once header guard. [build/header_guard] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1237847 3 290981 simon.fraser 2016-10-07 16:10:38 -0700 Created attachment 290981 Patch 1237848 4 commit-queue 2016-10-07 16:12:39 -0700 Attachment 290981 did not pass style-queue: ERROR: Source/WebKit/mac/WebView/WebClipView.h:0: Use #pragma once header guard. [build/header_guard] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1237850 5 290980 thorton 2016-10-07 16:14:06 -0700 Comment on attachment 290980 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290980&action=review > Source/WebKit/mac/WebView/WebClipView.mm:51 > @interface NSClipView (WebNSClipViewDetails) Nothing in the () maybe. > Source/WebKit/mac/WebView/WebHTMLView.mm:4115 > - if (_private->inScrollPositionChanged) { > + if (_private->inScrollPositionChanged && [(WebClipView *)[self superview] currentScrollIsBlit]) { Maybe check to be safe? 1237869 6 290986 simon.fraser 2016-10-07 17:13:00 -0700 Created attachment 290986 Patch 1237871 7 commit-queue 2016-10-07 17:14:30 -0700 Attachment 290986 did not pass style-queue: ERROR: Source/WebKit/mac/WebView/WebHTMLView.mm:4122: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebKit/mac/WebView/WebClipView.h:0: Use #pragma once header guard. [build/header_guard] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1237872 8 290986 thorton 2016-10-07 17:15:23 -0700 Comment on attachment 290986 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290986&action=review > Source/WebKit/mac/WebView/WebHTMLView.mm:4122 > - if (_private->inScrollPositionChanged) { > + if (_private->inScrollPositionChanged Do not love this wrapping. 1237873 9 simon.fraser 2016-10-07 17:23:12 -0700 https://trac.webkit.org/r206945 290980 2016-10-07 16:08:42 -0700 2016-10-07 17:12:55 -0700 Patch bug-163154-20161007160526.patch text/plain 4737 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2OTEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggZjQ3OTliYmJi NWZlODg3Mjc0ZWM2NTg2NjVlOGZjY2Q3NzQ1ZjNlYy4uZTVhOWY0MjY1Mjg0YThjNGI0ZDM3NzZm OGFiZDEyZjk2YTBmMDdkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDE2 LTEwLTA3ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAg IFtXSzEgTWFjXSBGaXggcmVwYWludHMgb2YgZml4ZWQtYmFja2dyb3VuZCBlbGVtZW50cyBpbiBs YXllci1iYWNrZWQgV2ViVmlld3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE2MzE1NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorICAgICAgICAKKyAgICAgICAgcjU1MTU5IGFkZGVkIGNvZGUgdG8gY291bnRlcmFjdCBBcHBL aXQncyBhZGp1c3RtZW50IG9mIGRpcnR5IHJlZ2lvbnMgZHVyaW5nIHNjcm9sbGluZywKKyAgICAg ICAgYnkgb2Zmc2V0dGluZyB0aGUgZGlydHkgcmVjdCBpbiAtc2V0TmVlZHNEaXNwbGF5SW5SZWN0 OiBpZiB0aGUgY2FsbCBoYXBwZW5zIGR1cmluZworICAgICAgICB0aGUgTlNWaWV3Qm91bmRzRGlk Q2hhbmdlTm90aWZpY2F0aW9uIGhhbmRsaW5nLgorICAgICAgICAKKyAgICAgICAgSG93ZXZlciwg QXBwS2l0IG9ubHkgZG9lcyBkaXJ0eSByZWdpb24gYWRqdXN0bWVudCBpbiB0aGUgY29kZSBwYXRo IHRoYXQgYmxpdHMgKCJjb3B5CisgICAgICAgIG9uIHNjcm9sbCIpLCBzbyByNTUxNTkgcHJvZHVj ZXMgaW5jb3JyZWN0IGJlaGF2aW9yIGluLCBmb3IgZXhhbXBsZSwgbGF5ZXItYmFja2VkIHZpZXdz LgorICAgICAgICAKKyAgICAgICAgRml4IGJ5IG92ZXJyaWRpbmcgLVtOU0NsaXBWaWV3IF9jYW5D b3B5T25TY3JvbGxGb3JEZWx0YVg6ZGVsdGFZOl0gdG8ga25vdyBpZiBhIHNpbmdsZQorICAgICAg ICBzY3JvbGwgaXMgZ29pbmcgdG8gYmxpdCwgYW5kIG9ubHkgZG8gYWRqdXN0bWVudHMgaW4gLXNl dE5lZWRzRGlzcGxheUluUmVjdDogaWYgaXQgaXMuCisKKyAgICAgICAgKiBXZWJWaWV3L1dlYkNs aXBWaWV3Lmg6CisgICAgICAgICogV2ViVmlldy9XZWJDbGlwVmlldy5tbToKKyAgICAgICAgKC1b V2ViQ2xpcFZpZXcgX2ltbWVkaWF0ZVNjcm9sbFRvUG9pbnQ6XSk6CisgICAgICAgICgtW1dlYkNs aXBWaWV3IF9jYW5Db3B5T25TY3JvbGxGb3JEZWx0YVg6ZGVsdGFZOl0pOgorICAgICAgICAoLVtX ZWJDbGlwVmlldyBjdXJyZW50U2Nyb2xsSXNCbGl0XSk6CisgICAgICAgICogV2ViVmlldy9XZWJI VE1MVmlldy5tbToKKyAgICAgICAgKC1bV2ViSFRNTFZpZXcgc2V0TmVlZHNEaXNwbGF5SW5SZWN0 Ol0pOgorICAgICAgICAoLVtXZWJIVE1MVmlldyBkcmF3UmVjdDpdKToKKwogMjAxNi0xMC0wNiAg WW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgQ2FjaGVkUmVzb3Vy Y2UgY2xpZW50IGhhbmRsaW5nIG1ldGhvZHMgc2hvdWxkIHRha2UgcmVmZXJlbmNlCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkNsaXBWaWV3LmggYi9Tb3VyY2UvV2Vi S2l0L21hYy9XZWJWaWV3L1dlYkNsaXBWaWV3LmgKaW5kZXggNThhYWY3MzY4NWFiNDVhOGVjNWM0 ZGZkMjRkYjQ4NWMxNmY2MTQ2Yi4uMjNiNjI2MjljMGY3MzhkYzBhZDJmZjQ1ZTQ3ZTFhNWEzOWQ5 YTQ3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJDbGlwVmlldy5o CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViQ2xpcFZpZXcuaApAQCAtMzQsOSAr MzQsMTEgQEAKIHsKICAgICBCT09MIF9oYXZlQWRkaXRpb25hbENsaXA7CiAgICAgQk9PTCBfaXNT Y3JvbGxpbmc7CisgICAgQk9PTCBfY3VycmVudFNjcm9sbElzQmxpdDsKICAgICBOU1JlY3QgX2Fk ZGl0aW9uYWxDbGlwOwogfQogCistIChCT09MKWN1cnJlbnRTY3JvbGxJc0JsaXQ7CiAtICh2b2lk KXNldEFkZGl0aW9uYWxDbGlwOihOU1JlY3QpYWRkaXRpb25hbENsaXA7CiAtICh2b2lkKXJlc2V0 QWRkaXRpb25hbENsaXA7CiAtIChCT09MKWhhc0FkZGl0aW9uYWxDbGlwOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJDbGlwVmlldy5tbSBiL1NvdXJjZS9XZWJLaXQv bWFjL1dlYlZpZXcvV2ViQ2xpcFZpZXcubW0KaW5kZXggMjI1NGRlNmVjNTRkMzhhYmRiYmEyMzg2 MTdiYzQ1MzczMWNjNWQyYS4uNTk3NmI1ZWYyM2NmODE1MDQ5MDdmNjQ4MGFkY2Q4NTAxZDNlNzY0 MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJDbGlwVmlldy5tbQor KysgYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkNsaXBWaWV3Lm1tCkBAIC01MCw2ICs1 MCw3IEBAIEBlbmQKIAogQGludGVyZmFjZSBOU0NsaXBWaWV3IChXZWJOU0NsaXBWaWV3RGV0YWls cykKIC0gKHZvaWQpX2ltbWVkaWF0ZVNjcm9sbFRvUG9pbnQ6KE5TUG9pbnQpbmV3T3JpZ2luOwor LSAoQk9PTClfY2FuQ29weU9uU2Nyb2xsRm9yRGVsdGFYOihDR0Zsb2F0KWRlbHRhWCBkZWx0YVk6 KENHRmxvYXQpZGVsdGFZOwogQGVuZAogCiBAaW50ZXJmYWNlIE5TV2luZG93IChXZWJOU1dpbmRv d0RldGFpbHMpCkBAIC0xMDQsNiArMTA1LDcgQEAgLSAoTlNSZWN0KXZpc2libGVSZWN0CiAtICh2 b2lkKV9pbW1lZGlhdGVTY3JvbGxUb1BvaW50OihOU1BvaW50KW5ld09yaWdpbgogewogICAgIF9p c1Njcm9sbGluZyA9IFlFUzsKKyAgICBfY3VycmVudFNjcm9sbElzQmxpdCA9IE5POwogCiAgICAg W1tzZWxmIHdpbmRvd10gX2Rpc2FibGVEZWxheWVkV2luZG93RGlzcGxheV07CiAKQEAgLTEyNiw2 ICsxMjgsMTcgQEAgLSAodm9pZClfaW1tZWRpYXRlU2Nyb2xsVG9Qb2ludDooTlNQb2ludCluZXdP cmlnaW4KICAgICBfaXNTY3JvbGxpbmcgPSBOTzsKIH0KIAorLSAoQk9PTClfY2FuQ29weU9uU2Ny b2xsRm9yRGVsdGFYOihDR0Zsb2F0KWRlbHRhWCBkZWx0YVk6KENHRmxvYXQpZGVsdGFZCit7Cisg ICAgX2N1cnJlbnRTY3JvbGxJc0JsaXQgPSBbc3VwZXIgX2NhbkNvcHlPblNjcm9sbEZvckRlbHRh WDpkZWx0YVggZGVsdGFZOmRlbHRhWV07CisgICAgcmV0dXJuIF9jdXJyZW50U2Nyb2xsSXNCbGl0 OworfQorCistIChCT09MKWN1cnJlbnRTY3JvbGxJc0JsaXQKK3sKKyAgICByZXR1cm4gX2N1cnJl bnRTY3JvbGxJc0JsaXQ7Cit9CisKIC0gKHZvaWQpcmVzZXRBZGRpdGlvbmFsQ2xpcAogewogICAg IEFTU0VSVChfaGF2ZUFkZGl0aW9uYWxDbGlwKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv bWFjL1dlYlZpZXcvV2ViSFRNTFZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dl YkhUTUxWaWV3Lm1tCmluZGV4IGJjZjljNGE5N2U2M2E3YmIzYTQwNzQyNmVlODgzNDhjZGY2MDEw NzIuLjM5ZDBmNzVmYmE2ZjkxYWZkY2RlN2MyNmY0MGJkYzU2M2Q2YWJlNTkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViSFRNTFZpZXcubW0KKysrIGIvU291cmNlL1dl YktpdC9tYWMvV2ViVmlldy9XZWJIVE1MVmlldy5tbQpAQCAtNDExMiw3ICs0MTEyLDcgQEAgLSAo dm9pZClzZXROZWVkc0Rpc3BsYXk6KEJPT0wpZmxhZwogCiAtICh2b2lkKXNldE5lZWRzRGlzcGxh eUluUmVjdDooTlNSZWN0KWludmFsaWRSZWN0CiB7Ci0gICAgaWYgKF9wcml2YXRlLT5pblNjcm9s bFBvc2l0aW9uQ2hhbmdlZCkgeworICAgIGlmIChfcHJpdmF0ZS0+aW5TY3JvbGxQb3NpdGlvbkNo YW5nZWQgJiYgWyhXZWJDbGlwVmlldyAqKVtzZWxmIHN1cGVydmlld10gY3VycmVudFNjcm9sbElz QmxpdF0pIHsKICAgICAgICAgLy8gV2hlbiBzY3JvbGxpbmcsIHRoZSBkaXJ0eSByZWdpb25zIGFy ZSBhZGp1c3RlZCBmb3IgdGhlIHNjcm9sbCBvbmx5CiAgICAgICAgIC8vIGFmdGVyIE5TVmlld0Jv dW5kc0RpZENoYW5nZU5vdGlmaWNhdGlvbiBpcyBzZW50LiBUcmFuc2xhdGUgdGhlIGludmFsaWQK ICAgICAgICAgLy8gcmVjdCB0byBwcmUtc2Nyb2xsZWQgY29vcmRpbmF0ZXMgaW4gb3JkZXIgdG8g Z2V0IHRoZSByaWdodCBkaXJ0eSByZWdpb24KQEAgLTQyMjcsNyArNDIyNyw3IEBAIC0gKHZvaWQp ZHJhd1JlY3Q6KE5TUmVjdClyZWN0CiAgICAgY29uc3QgaW50IGNSZWN0VGhyZXNob2xkID0gMTA7 IAogICAgIGNvbnN0IGZsb2F0IGNXYXN0ZWRTcGFjZVRocmVzaG9sZCA9IDAuNzVmOyAKICAgICBC T09MIHVzZVVuaW9uZWRSZWN0ID0gKGNvdW50IDw9IDEpIHx8IChjb3VudCA+IGNSZWN0VGhyZXNo b2xkKTsgCi0gICAgaWYgKCF1c2VVbmlvbmVkUmVjdCkgeyAKKyAgICBpZiAoIXVzZVVuaW9uZWRS ZWN0KSB7CiAgICAgICAgIC8vIEF0dGVtcHQgdG8gZ3Vlc3Mgd2hldGhlciBvciBub3Qgd2Ugc2hv dWxkIHVzZSB0aGUgdW5pb25lZCByZWN0IG9yIHRoZSBpbmRpdmlkdWFsIHJlY3RzLiAKICAgICAg ICAgLy8gV2UgZG8gdGhpcyBieSBjb21wdXRpbmcgdGhlIHBlcmNlbnRhZ2Ugb2YgIndhc3RlZCBz cGFjZSIgaW4gdGhlIHVuaW9uLiAgSWYgdGhhdCB3YXN0ZWQgc3BhY2UgCiAgICAgICAgIC8vIGlz IHRvbyBsYXJnZSwgdGhlbiB3ZSB3aWxsIGRvIGluZGl2aWR1YWwgcmVjdCBwYWludGluZyBpbnN0 ZWFkLiAK 290981 2016-10-07 16:10:38 -0700 2016-10-07 17:12:57 -0700 Patch bug-163154-20161007160722.patch text/plain 4770 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2OTEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggZjQ3OTliYmJi NWZlODg3Mjc0ZWM2NTg2NjVlOGZjY2Q3NzQ1ZjNlYy4uYzJkNzYzNWU4MjU4MTE3OTU3YTVkOTE3 OWJmOGVkZGM1MTAwNGEzZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDE2 LTEwLTA3ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAg IFtXSzEgTWFjXSBGaXggcmVwYWludHMgb2YgZml4ZWQtYmFja2dyb3VuZCBlbGVtZW50cyBpbiBs YXllci1iYWNrZWQgV2ViVmlld3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE2MzE1NAorICAgICAgICByZGFyOi8vcHJvYmxlbS8yODY3NDIxNgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgcjU1 MTU5IGFkZGVkIGNvZGUgdG8gY291bnRlcmFjdCBBcHBLaXQncyBhZGp1c3RtZW50IG9mIGRpcnR5 IHJlZ2lvbnMgZHVyaW5nIHNjcm9sbGluZywKKyAgICAgICAgYnkgb2Zmc2V0dGluZyB0aGUgZGly dHkgcmVjdCBpbiAtc2V0TmVlZHNEaXNwbGF5SW5SZWN0OiBpZiB0aGUgY2FsbCBoYXBwZW5zIGR1 cmluZworICAgICAgICB0aGUgTlNWaWV3Qm91bmRzRGlkQ2hhbmdlTm90aWZpY2F0aW9uIGhhbmRs aW5nLgorICAgICAgICAKKyAgICAgICAgSG93ZXZlciwgQXBwS2l0IG9ubHkgZG9lcyBkaXJ0eSBy ZWdpb24gYWRqdXN0bWVudCBpbiB0aGUgY29kZSBwYXRoIHRoYXQgYmxpdHMgKCJjb3B5CisgICAg ICAgIG9uIHNjcm9sbCIpLCBzbyByNTUxNTkgcHJvZHVjZXMgaW5jb3JyZWN0IGJlaGF2aW9yIGlu LCBmb3IgZXhhbXBsZSwgbGF5ZXItYmFja2VkIHZpZXdzLgorICAgICAgICAKKyAgICAgICAgRml4 IGJ5IG92ZXJyaWRpbmcgLVtOU0NsaXBWaWV3IF9jYW5Db3B5T25TY3JvbGxGb3JEZWx0YVg6ZGVs dGFZOl0gdG8ga25vdyBpZiBhIHNpbmdsZQorICAgICAgICBzY3JvbGwgaXMgZ29pbmcgdG8gYmxp dCwgYW5kIG9ubHkgZG8gYWRqdXN0bWVudHMgaW4gLXNldE5lZWRzRGlzcGxheUluUmVjdDogaWYg aXQgaXMuCisKKyAgICAgICAgKiBXZWJWaWV3L1dlYkNsaXBWaWV3Lmg6CisgICAgICAgICogV2Vi Vmlldy9XZWJDbGlwVmlldy5tbToKKyAgICAgICAgKC1bV2ViQ2xpcFZpZXcgX2ltbWVkaWF0ZVNj cm9sbFRvUG9pbnQ6XSk6CisgICAgICAgICgtW1dlYkNsaXBWaWV3IF9jYW5Db3B5T25TY3JvbGxG b3JEZWx0YVg6ZGVsdGFZOl0pOgorICAgICAgICAoLVtXZWJDbGlwVmlldyBjdXJyZW50U2Nyb2xs SXNCbGl0XSk6CisgICAgICAgICogV2ViVmlldy9XZWJIVE1MVmlldy5tbToKKyAgICAgICAgKC1b V2ViSFRNTFZpZXcgc2V0TmVlZHNEaXNwbGF5SW5SZWN0Ol0pOgorICAgICAgICAoLVtXZWJIVE1M VmlldyBkcmF3UmVjdDpdKToKKwogMjAxNi0xMC0wNiAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBh cHBsZS5jb20+CiAKICAgICAgICAgQ2FjaGVkUmVzb3VyY2UgY2xpZW50IGhhbmRsaW5nIG1ldGhv ZHMgc2hvdWxkIHRha2UgcmVmZXJlbmNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21hYy9X ZWJWaWV3L1dlYkNsaXBWaWV3LmggYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkNsaXBW aWV3LmgKaW5kZXggNThhYWY3MzY4NWFiNDVhOGVjNWM0ZGZkMjRkYjQ4NWMxNmY2MTQ2Yi4uMjNi NjI2MjljMGY3MzhkYzBhZDJmZjQ1ZTQ3ZTFhNWEzOWQ5YTQ3NCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9tYWMvV2ViVmlldy9XZWJDbGlwVmlldy5oCisrKyBiL1NvdXJjZS9XZWJLaXQvbWFj L1dlYlZpZXcvV2ViQ2xpcFZpZXcuaApAQCAtMzQsOSArMzQsMTEgQEAKIHsKICAgICBCT09MIF9o YXZlQWRkaXRpb25hbENsaXA7CiAgICAgQk9PTCBfaXNTY3JvbGxpbmc7CisgICAgQk9PTCBfY3Vy cmVudFNjcm9sbElzQmxpdDsKICAgICBOU1JlY3QgX2FkZGl0aW9uYWxDbGlwOwogfQogCistIChC T09MKWN1cnJlbnRTY3JvbGxJc0JsaXQ7CiAtICh2b2lkKXNldEFkZGl0aW9uYWxDbGlwOihOU1Jl Y3QpYWRkaXRpb25hbENsaXA7CiAtICh2b2lkKXJlc2V0QWRkaXRpb25hbENsaXA7CiAtIChCT09M KWhhc0FkZGl0aW9uYWxDbGlwOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9tYWMvV2ViVmll dy9XZWJDbGlwVmlldy5tbSBiL1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViQ2xpcFZpZXcu bW0KaW5kZXggMjI1NGRlNmVjNTRkMzhhYmRiYmEyMzg2MTdiYzQ1MzczMWNjNWQyYS4uNTk3NmI1 ZWYyM2NmODE1MDQ5MDdmNjQ4MGFkY2Q4NTAxZDNlNzY0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9tYWMvV2ViVmlldy9XZWJDbGlwVmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9X ZWJWaWV3L1dlYkNsaXBWaWV3Lm1tCkBAIC01MCw2ICs1MCw3IEBAIEBlbmQKIAogQGludGVyZmFj ZSBOU0NsaXBWaWV3IChXZWJOU0NsaXBWaWV3RGV0YWlscykKIC0gKHZvaWQpX2ltbWVkaWF0ZVNj cm9sbFRvUG9pbnQ6KE5TUG9pbnQpbmV3T3JpZ2luOworLSAoQk9PTClfY2FuQ29weU9uU2Nyb2xs Rm9yRGVsdGFYOihDR0Zsb2F0KWRlbHRhWCBkZWx0YVk6KENHRmxvYXQpZGVsdGFZOwogQGVuZAog CiBAaW50ZXJmYWNlIE5TV2luZG93IChXZWJOU1dpbmRvd0RldGFpbHMpCkBAIC0xMDQsNiArMTA1 LDcgQEAgLSAoTlNSZWN0KXZpc2libGVSZWN0CiAtICh2b2lkKV9pbW1lZGlhdGVTY3JvbGxUb1Bv aW50OihOU1BvaW50KW5ld09yaWdpbgogewogICAgIF9pc1Njcm9sbGluZyA9IFlFUzsKKyAgICBf Y3VycmVudFNjcm9sbElzQmxpdCA9IE5POwogCiAgICAgW1tzZWxmIHdpbmRvd10gX2Rpc2FibGVE ZWxheWVkV2luZG93RGlzcGxheV07CiAKQEAgLTEyNiw2ICsxMjgsMTcgQEAgLSAodm9pZClfaW1t ZWRpYXRlU2Nyb2xsVG9Qb2ludDooTlNQb2ludCluZXdPcmlnaW4KICAgICBfaXNTY3JvbGxpbmcg PSBOTzsKIH0KIAorLSAoQk9PTClfY2FuQ29weU9uU2Nyb2xsRm9yRGVsdGFYOihDR0Zsb2F0KWRl bHRhWCBkZWx0YVk6KENHRmxvYXQpZGVsdGFZCit7CisgICAgX2N1cnJlbnRTY3JvbGxJc0JsaXQg PSBbc3VwZXIgX2NhbkNvcHlPblNjcm9sbEZvckRlbHRhWDpkZWx0YVggZGVsdGFZOmRlbHRhWV07 CisgICAgcmV0dXJuIF9jdXJyZW50U2Nyb2xsSXNCbGl0OworfQorCistIChCT09MKWN1cnJlbnRT Y3JvbGxJc0JsaXQKK3sKKyAgICByZXR1cm4gX2N1cnJlbnRTY3JvbGxJc0JsaXQ7Cit9CisKIC0g KHZvaWQpcmVzZXRBZGRpdGlvbmFsQ2xpcAogewogICAgIEFTU0VSVChfaGF2ZUFkZGl0aW9uYWxD bGlwKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViSFRNTFZpZXcu bW0gYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkhUTUxWaWV3Lm1tCmluZGV4IGJjZjlj NGE5N2U2M2E3YmIzYTQwNzQyNmVlODgzNDhjZGY2MDEwNzIuLjM5ZDBmNzVmYmE2ZjkxYWZkY2Rl N2MyNmY0MGJkYzU2M2Q2YWJlNTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZp ZXcvV2ViSFRNTFZpZXcubW0KKysrIGIvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJIVE1M Vmlldy5tbQpAQCAtNDExMiw3ICs0MTEyLDcgQEAgLSAodm9pZClzZXROZWVkc0Rpc3BsYXk6KEJP T0wpZmxhZwogCiAtICh2b2lkKXNldE5lZWRzRGlzcGxheUluUmVjdDooTlNSZWN0KWludmFsaWRS ZWN0CiB7Ci0gICAgaWYgKF9wcml2YXRlLT5pblNjcm9sbFBvc2l0aW9uQ2hhbmdlZCkgeworICAg IGlmIChfcHJpdmF0ZS0+aW5TY3JvbGxQb3NpdGlvbkNoYW5nZWQgJiYgWyhXZWJDbGlwVmlldyAq KVtzZWxmIHN1cGVydmlld10gY3VycmVudFNjcm9sbElzQmxpdF0pIHsKICAgICAgICAgLy8gV2hl biBzY3JvbGxpbmcsIHRoZSBkaXJ0eSByZWdpb25zIGFyZSBhZGp1c3RlZCBmb3IgdGhlIHNjcm9s bCBvbmx5CiAgICAgICAgIC8vIGFmdGVyIE5TVmlld0JvdW5kc0RpZENoYW5nZU5vdGlmaWNhdGlv biBpcyBzZW50LiBUcmFuc2xhdGUgdGhlIGludmFsaWQKICAgICAgICAgLy8gcmVjdCB0byBwcmUt c2Nyb2xsZWQgY29vcmRpbmF0ZXMgaW4gb3JkZXIgdG8gZ2V0IHRoZSByaWdodCBkaXJ0eSByZWdp b24KQEAgLTQyMjcsNyArNDIyNyw3IEBAIC0gKHZvaWQpZHJhd1JlY3Q6KE5TUmVjdClyZWN0CiAg ICAgY29uc3QgaW50IGNSZWN0VGhyZXNob2xkID0gMTA7IAogICAgIGNvbnN0IGZsb2F0IGNXYXN0 ZWRTcGFjZVRocmVzaG9sZCA9IDAuNzVmOyAKICAgICBCT09MIHVzZVVuaW9uZWRSZWN0ID0gKGNv dW50IDw9IDEpIHx8IChjb3VudCA+IGNSZWN0VGhyZXNob2xkKTsgCi0gICAgaWYgKCF1c2VVbmlv bmVkUmVjdCkgeyAKKyAgICBpZiAoIXVzZVVuaW9uZWRSZWN0KSB7CiAgICAgICAgIC8vIEF0dGVt cHQgdG8gZ3Vlc3Mgd2hldGhlciBvciBub3Qgd2Ugc2hvdWxkIHVzZSB0aGUgdW5pb25lZCByZWN0 IG9yIHRoZSBpbmRpdmlkdWFsIHJlY3RzLiAKICAgICAgICAgLy8gV2UgZG8gdGhpcyBieSBjb21w dXRpbmcgdGhlIHBlcmNlbnRhZ2Ugb2YgIndhc3RlZCBzcGFjZSIgaW4gdGhlIHVuaW9uLiAgSWYg dGhhdCB3YXN0ZWQgc3BhY2UgCiAgICAgICAgIC8vIGlzIHRvbyBsYXJnZSwgdGhlbiB3ZSB3aWxs IGRvIGluZGl2aWR1YWwgcmVjdCBwYWludGluZyBpbnN0ZWFkLiAK 290986 2016-10-07 17:13:00 -0700 2016-10-07 17:15:23 -0700 Patch bug-163154-20161007170944.patch text/plain 5115 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2OTEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggZjQ3OTliYmJi NWZlODg3Mjc0ZWM2NTg2NjVlOGZjY2Q3NzQ1ZjNlYy4uYzJkNzYzNWU4MjU4MTE3OTU3YTVkOTE3 OWJmOGVkZGM1MTAwNGEzZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDE2 LTEwLTA3ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAg IFtXSzEgTWFjXSBGaXggcmVwYWludHMgb2YgZml4ZWQtYmFja2dyb3VuZCBlbGVtZW50cyBpbiBs YXllci1iYWNrZWQgV2ViVmlld3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE2MzE1NAorICAgICAgICByZGFyOi8vcHJvYmxlbS8yODY3NDIxNgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgcjU1 MTU5IGFkZGVkIGNvZGUgdG8gY291bnRlcmFjdCBBcHBLaXQncyBhZGp1c3RtZW50IG9mIGRpcnR5 IHJlZ2lvbnMgZHVyaW5nIHNjcm9sbGluZywKKyAgICAgICAgYnkgb2Zmc2V0dGluZyB0aGUgZGly dHkgcmVjdCBpbiAtc2V0TmVlZHNEaXNwbGF5SW5SZWN0OiBpZiB0aGUgY2FsbCBoYXBwZW5zIGR1 cmluZworICAgICAgICB0aGUgTlNWaWV3Qm91bmRzRGlkQ2hhbmdlTm90aWZpY2F0aW9uIGhhbmRs aW5nLgorICAgICAgICAKKyAgICAgICAgSG93ZXZlciwgQXBwS2l0IG9ubHkgZG9lcyBkaXJ0eSBy ZWdpb24gYWRqdXN0bWVudCBpbiB0aGUgY29kZSBwYXRoIHRoYXQgYmxpdHMgKCJjb3B5CisgICAg ICAgIG9uIHNjcm9sbCIpLCBzbyByNTUxNTkgcHJvZHVjZXMgaW5jb3JyZWN0IGJlaGF2aW9yIGlu LCBmb3IgZXhhbXBsZSwgbGF5ZXItYmFja2VkIHZpZXdzLgorICAgICAgICAKKyAgICAgICAgRml4 IGJ5IG92ZXJyaWRpbmcgLVtOU0NsaXBWaWV3IF9jYW5Db3B5T25TY3JvbGxGb3JEZWx0YVg6ZGVs dGFZOl0gdG8ga25vdyBpZiBhIHNpbmdsZQorICAgICAgICBzY3JvbGwgaXMgZ29pbmcgdG8gYmxp dCwgYW5kIG9ubHkgZG8gYWRqdXN0bWVudHMgaW4gLXNldE5lZWRzRGlzcGxheUluUmVjdDogaWYg aXQgaXMuCisKKyAgICAgICAgKiBXZWJWaWV3L1dlYkNsaXBWaWV3Lmg6CisgICAgICAgICogV2Vi Vmlldy9XZWJDbGlwVmlldy5tbToKKyAgICAgICAgKC1bV2ViQ2xpcFZpZXcgX2ltbWVkaWF0ZVNj cm9sbFRvUG9pbnQ6XSk6CisgICAgICAgICgtW1dlYkNsaXBWaWV3IF9jYW5Db3B5T25TY3JvbGxG b3JEZWx0YVg6ZGVsdGFZOl0pOgorICAgICAgICAoLVtXZWJDbGlwVmlldyBjdXJyZW50U2Nyb2xs SXNCbGl0XSk6CisgICAgICAgICogV2ViVmlldy9XZWJIVE1MVmlldy5tbToKKyAgICAgICAgKC1b V2ViSFRNTFZpZXcgc2V0TmVlZHNEaXNwbGF5SW5SZWN0Ol0pOgorICAgICAgICAoLVtXZWJIVE1M VmlldyBkcmF3UmVjdDpdKToKKwogMjAxNi0xMC0wNiAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBh cHBsZS5jb20+CiAKICAgICAgICAgQ2FjaGVkUmVzb3VyY2UgY2xpZW50IGhhbmRsaW5nIG1ldGhv ZHMgc2hvdWxkIHRha2UgcmVmZXJlbmNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21hYy9X ZWJWaWV3L1dlYkNsaXBWaWV3LmggYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkNsaXBW aWV3LmgKaW5kZXggNThhYWY3MzY4NWFiNDVhOGVjNWM0ZGZkMjRkYjQ4NWMxNmY2MTQ2Yi4uMjNi NjI2MjljMGY3MzhkYzBhZDJmZjQ1ZTQ3ZTFhNWEzOWQ5YTQ3NCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9tYWMvV2ViVmlldy9XZWJDbGlwVmlldy5oCisrKyBiL1NvdXJjZS9XZWJLaXQvbWFj L1dlYlZpZXcvV2ViQ2xpcFZpZXcuaApAQCAtMzQsOSArMzQsMTEgQEAKIHsKICAgICBCT09MIF9o YXZlQWRkaXRpb25hbENsaXA7CiAgICAgQk9PTCBfaXNTY3JvbGxpbmc7CisgICAgQk9PTCBfY3Vy cmVudFNjcm9sbElzQmxpdDsKICAgICBOU1JlY3QgX2FkZGl0aW9uYWxDbGlwOwogfQogCistIChC T09MKWN1cnJlbnRTY3JvbGxJc0JsaXQ7CiAtICh2b2lkKXNldEFkZGl0aW9uYWxDbGlwOihOU1Jl Y3QpYWRkaXRpb25hbENsaXA7CiAtICh2b2lkKXJlc2V0QWRkaXRpb25hbENsaXA7CiAtIChCT09M KWhhc0FkZGl0aW9uYWxDbGlwOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9tYWMvV2ViVmll dy9XZWJDbGlwVmlldy5tbSBiL1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViQ2xpcFZpZXcu bW0KaW5kZXggMjI1NGRlNmVjNTRkMzhhYmRiYmEyMzg2MTdiYzQ1MzczMWNjNWQyYS4uNTk3NmI1 ZWYyM2NmODE1MDQ5MDdmNjQ4MGFkY2Q4NTAxZDNlNzY0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9tYWMvV2ViVmlldy9XZWJDbGlwVmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9X ZWJWaWV3L1dlYkNsaXBWaWV3Lm1tCkBAIC01MCw2ICs1MCw3IEBAIEBlbmQKIAogQGludGVyZmFj ZSBOU0NsaXBWaWV3IChXZWJOU0NsaXBWaWV3RGV0YWlscykKIC0gKHZvaWQpX2ltbWVkaWF0ZVNj cm9sbFRvUG9pbnQ6KE5TUG9pbnQpbmV3T3JpZ2luOworLSAoQk9PTClfY2FuQ29weU9uU2Nyb2xs Rm9yRGVsdGFYOihDR0Zsb2F0KWRlbHRhWCBkZWx0YVk6KENHRmxvYXQpZGVsdGFZOwogQGVuZAog CiBAaW50ZXJmYWNlIE5TV2luZG93IChXZWJOU1dpbmRvd0RldGFpbHMpCkBAIC0xMDQsNiArMTA1 LDcgQEAgLSAoTlNSZWN0KXZpc2libGVSZWN0CiAtICh2b2lkKV9pbW1lZGlhdGVTY3JvbGxUb1Bv aW50OihOU1BvaW50KW5ld09yaWdpbgogewogICAgIF9pc1Njcm9sbGluZyA9IFlFUzsKKyAgICBf Y3VycmVudFNjcm9sbElzQmxpdCA9IE5POwogCiAgICAgW1tzZWxmIHdpbmRvd10gX2Rpc2FibGVE ZWxheWVkV2luZG93RGlzcGxheV07CiAKQEAgLTEyNiw2ICsxMjgsMTcgQEAgLSAodm9pZClfaW1t ZWRpYXRlU2Nyb2xsVG9Qb2ludDooTlNQb2ludCluZXdPcmlnaW4KICAgICBfaXNTY3JvbGxpbmcg PSBOTzsKIH0KIAorLSAoQk9PTClfY2FuQ29weU9uU2Nyb2xsRm9yRGVsdGFYOihDR0Zsb2F0KWRl bHRhWCBkZWx0YVk6KENHRmxvYXQpZGVsdGFZCit7CisgICAgX2N1cnJlbnRTY3JvbGxJc0JsaXQg PSBbc3VwZXIgX2NhbkNvcHlPblNjcm9sbEZvckRlbHRhWDpkZWx0YVggZGVsdGFZOmRlbHRhWV07 CisgICAgcmV0dXJuIF9jdXJyZW50U2Nyb2xsSXNCbGl0OworfQorCistIChCT09MKWN1cnJlbnRT Y3JvbGxJc0JsaXQKK3sKKyAgICByZXR1cm4gX2N1cnJlbnRTY3JvbGxJc0JsaXQ7Cit9CisKIC0g KHZvaWQpcmVzZXRBZGRpdGlvbmFsQ2xpcAogewogICAgIEFTU0VSVChfaGF2ZUFkZGl0aW9uYWxD bGlwKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViSFRNTFZpZXcu bW0gYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkhUTUxWaWV3Lm1tCmluZGV4IGJjZjlj NGE5N2U2M2E3YmIzYTQwNzQyNmVlODgzNDhjZGY2MDEwNzIuLjU3YzAwY2Q1NjM0NzVmMWMwNWEy ODYyOTAwM2ZlMGRiM2Y0Mjc2MDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZp ZXcvV2ViSFRNTFZpZXcubW0KKysrIGIvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJIVE1M Vmlldy5tbQpAQCAtNDExMCw5ICs0MTEwLDIxIEBAIC0gKHZvaWQpc2V0TmVlZHNEaXNwbGF5OihC T09MKWZsYWcKIH0KICNlbmRpZgogCisjaWYgIVBMQVRGT1JNKElPUykKK3N0YXRpYyBCT09MIGN1 cnJlbnRTY3JvbGxJc0JsaXQoTlNWaWV3ICpjbGlwVmlldykKK3sKKyAgICByZXR1cm4gW2NsaXBW aWV3IGlzS2luZE9mQ2xhc3M6W1dlYkNsaXBWaWV3IGNsYXNzXV0gJiYgWyhXZWJDbGlwVmlldyAq KWNsaXBWaWV3IGN1cnJlbnRTY3JvbGxJc0JsaXRdOworfQorI2VuZGlmCisKIC0gKHZvaWQpc2V0 TmVlZHNEaXNwbGF5SW5SZWN0OihOU1JlY3QpaW52YWxpZFJlY3QKIHsKLSAgICBpZiAoX3ByaXZh dGUtPmluU2Nyb2xsUG9zaXRpb25DaGFuZ2VkKSB7CisgICAgaWYgKF9wcml2YXRlLT5pblNjcm9s bFBvc2l0aW9uQ2hhbmdlZAorI2lmICFQTEFURk9STShJT1MpCisgICAgICAgIC8vIEZJWE1FOiB0 aGlzIGVudGlyZSBmdW5jdGlvbiBjb3VsZCBiZSAjaWZkZWZmZWQgb3V0IG9uIGlPUy4gVGhlIGJl bG93IHdvcmthcm91bmQgaXMgQXBwS2l0LXNwZWNpZmljLgorICAgICAgICAmJiBjdXJyZW50U2Ny b2xsSXNCbGl0KFtzZWxmIHN1cGVydmlld10pCisjZW5kaWYKKyAgICApIHsKICAgICAgICAgLy8g V2hlbiBzY3JvbGxpbmcsIHRoZSBkaXJ0eSByZWdpb25zIGFyZSBhZGp1c3RlZCBmb3IgdGhlIHNj cm9sbCBvbmx5CiAgICAgICAgIC8vIGFmdGVyIE5TVmlld0JvdW5kc0RpZENoYW5nZU5vdGlmaWNh dGlvbiBpcyBzZW50LiBUcmFuc2xhdGUgdGhlIGludmFsaWQKICAgICAgICAgLy8gcmVjdCB0byBw cmUtc2Nyb2xsZWQgY29vcmRpbmF0ZXMgaW4gb3JkZXIgdG8gZ2V0IHRoZSByaWdodCBkaXJ0eSBy ZWdpb24KQEAgLTQyMjcsNyArNDIzOSw3IEBAIC0gKHZvaWQpZHJhd1JlY3Q6KE5TUmVjdClyZWN0 CiAgICAgY29uc3QgaW50IGNSZWN0VGhyZXNob2xkID0gMTA7IAogICAgIGNvbnN0IGZsb2F0IGNX YXN0ZWRTcGFjZVRocmVzaG9sZCA9IDAuNzVmOyAKICAgICBCT09MIHVzZVVuaW9uZWRSZWN0ID0g KGNvdW50IDw9IDEpIHx8IChjb3VudCA+IGNSZWN0VGhyZXNob2xkKTsgCi0gICAgaWYgKCF1c2VV bmlvbmVkUmVjdCkgeyAKKyAgICBpZiAoIXVzZVVuaW9uZWRSZWN0KSB7CiAgICAgICAgIC8vIEF0 dGVtcHQgdG8gZ3Vlc3Mgd2hldGhlciBvciBub3Qgd2Ugc2hvdWxkIHVzZSB0aGUgdW5pb25lZCBy ZWN0IG9yIHRoZSBpbmRpdmlkdWFsIHJlY3RzLiAKICAgICAgICAgLy8gV2UgZG8gdGhpcyBieSBj b21wdXRpbmcgdGhlIHBlcmNlbnRhZ2Ugb2YgIndhc3RlZCBzcGFjZSIgaW4gdGhlIHVuaW9uLiAg SWYgdGhhdCB3YXN0ZWQgc3BhY2UgCiAgICAgICAgIC8vIGlzIHRvbyBsYXJnZSwgdGhlbiB3ZSB3 aWxsIGRvIGluZGl2aWR1YWwgcmVjdCBwYWludGluZyBpbnN0ZWFkLiAK