<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>163132</bug_id>
          
          <creation_ts>2016-10-07 11:34:39 -0700</creation_ts>
          <short_desc>Adopt BlockPtr in ViewGestureController</short_desc>
          <delta_ts>2016-10-07 13:28:19 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Tim Horton">thorton</reporter>
          <assigned_to name="Tim Horton">thorton</assigned_to>
          <cc>andersca</cc>
    
    <cc>commit-queue</cc>
    
    <cc>simon.fraser</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1237692</commentid>
    <comment_count>0</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2016-10-07 11:34:39 -0700</bug_when>
    <thetext>Adopt BlockPtr in ViewGestureController</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1237693</commentid>
    <comment_count>1</comment_count>
      <attachid>290950</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2016-10-07 11:35:06 -0700</bug_when>
    <thetext>Created attachment 290950
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1237695</commentid>
    <comment_count>2</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-10-07 11:36:04 -0700</bug_when>
    <thetext>Attachment 290950 did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/ViewGestureController.h:269:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1237716</commentid>
    <comment_count>3</comment_count>
      <attachid>290950</attachid>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2016-10-07 12:03:12 -0700</bug_when>
    <thetext>Comment on attachment 290950
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290950&amp;action=review

&gt; Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm:720
&gt;  void ViewGestureController::setDidMoveSwipeSnapshotCallback(void(^callback)(CGRect))

Maybe this should take a BlockPtr too?

&gt; Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm:722
&gt; +    m_didMoveSwipeSnapshotCallback = makeBlockPtr(callback);

I don&apos;t think you need to use makeBlockPtr here.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1237744</commentid>
    <comment_count>4</comment_count>
      <attachid>290957</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2016-10-07 12:34:01 -0700</bug_when>
    <thetext>Created attachment 290957
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1237747</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-10-07 12:36:24 -0700</bug_when>
    <thetext>Attachment 290957 did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/ViewGestureController.h:104:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/mac/ViewGestureController.h:269:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/WebViewImpl.h:422:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm:3279:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1237753</commentid>
    <comment_count>6</comment_count>
      <attachid>290957</attachid>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2016-10-07 12:41:18 -0700</bug_when>
    <thetext>Comment on attachment 290957
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290957&amp;action=review

&gt; Source/WebKit2/UIProcess/Cocoa/WebViewImpl.h:422
&gt; +    void setDidMoveSwipeSnapshotCallback(BlockPtr&lt;void (CGRect)&gt;);

Should be BlockPtr&amp;&amp;

&gt; Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm:3279
&gt; +void WebViewImpl::setDidMoveSwipeSnapshotCallback(BlockPtr&lt;void (CGRect)&gt; callback)

Should be BlockPtr&amp;&amp; and use WTFMove.

&gt; Source/WebKit2/UIProcess/mac/ViewGestureController.h:104
&gt; +    void setDidMoveSwipeSnapshotCallback(BlockPtr&lt;void (CGRect)&gt; callback) { m_didMoveSwipeSnapshotCallback = callback; }

Should be BlockPtr&amp;&amp; and use WTFMove.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1237770</commentid>
    <comment_count>7</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2016-10-07 13:28:19 -0700</bug_when>
    <thetext>https://trac.webkit.org/changeset/206930</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>290950</attachid>
            <date>2016-10-07 11:35:06 -0700</date>
            <delta_ts>2016-10-07 12:33:58 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-163132-20161007113150.patch</filename>
            <type>text/plain</type>
            <size>3650</size>
            <attacher name="Tim Horton">thorton</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2OTIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDEyNTY4NjIyNmIxMWQx
YjEyMzg1OTI4YTg5MGMyM2NhNWY5MzlmNS4uYjVjN2YzMTE1N2UzNDgwNTMyNDk3MjZjNzUxNTIx
YmI5ZjgzMzY5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTEwLTA3ICBUaW0g
SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIEFkb3B0IEJsb2Nr
UHRyIGluIFZpZXdHZXN0dXJlQ29udHJvbGxlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzMTMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvVmlld0dlc3R1cmVDb250cm9sbGVyLmNw
cDoKKyAgICAgICAgKFdlYktpdDo6Vmlld0dlc3R1cmVDb250cm9sbGVyOjpTbmFwc2hvdFJlbW92
YWxUcmFja2VyOjpzdG9wV2FpdGluZ0ZvckV2ZW50KToKKyAgICAgICAgKiBVSVByb2Nlc3MvbWFj
L1ZpZXdHZXN0dXJlQ29udHJvbGxlci5oOgorICAgICAgICAoV2ViS2l0OjpWaWV3R2VzdHVyZUNv
bnRyb2xsZXI6Om1fZGlkTW92ZVN3aXBlU25hcHNob3RDYWxsYmFjayk6IERlbGV0ZWQuCisgICAg
ICAgICogVUlQcm9jZXNzL21hYy9WaWV3R2VzdHVyZUNvbnRyb2xsZXJNYWMubW06CisgICAgICAg
IChXZWJLaXQ6OlZpZXdHZXN0dXJlQ29udHJvbGxlcjo6cGxhdGZvcm1UZWFyZG93bik6CisgICAg
ICAgIChXZWJLaXQ6OlZpZXdHZXN0dXJlQ29udHJvbGxlcjo6c2V0RGlkTW92ZVN3aXBlU25hcHNo
b3RDYWxsYmFjayk6CisKIDIwMTYtMTAtMDcgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3
ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyMDY5MDkuCmRp
ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvVmlld0dlc3R1cmVDb250cm9sbGVy
LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9WaWV3R2VzdHVyZUNvbnRyb2xsZXIuY3Bw
CmluZGV4IGUyN2Q3OGNjMjA1ZjM5MTQxMGRiZTQ4ZGFhYjNjNDExY2Q5NDUwM2UuLjg1NmNjYTdh
M2ViN2M3MDU0ZmM4ODI2NzhmNGFmNzA0NzQxNjI3ZDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL
aXQyL1VJUHJvY2Vzcy9WaWV3R2VzdHVyZUNvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJL
aXQyL1VJUHJvY2Vzcy9WaWV3R2VzdHVyZUNvbnRyb2xsZXIuY3BwCkBAIC0yMzIsNyArMjMyLDcg
QEAgYm9vbCBWaWV3R2VzdHVyZUNvbnRyb2xsZXI6OlNuYXBzaG90UmVtb3ZhbFRyYWNrZXI6OnN0
b3BXYWl0aW5nRm9yRXZlbnQoRXZlbnRzIGUKICNpZiBMT0dfRElTQUJMRUQKICAgICBVTlVTRURf
UEFSQU0obG9nUmVhc29uKTsKICNlbmRpZgotICAgIGxvZyhsb2dSZWFzb24gKyAgZXZlbnRzRGVz
Y3JpcHRpb24oZXZlbnQpKTsKKyAgICBsb2cobG9nUmVhc29uICsgZXZlbnRzRGVzY3JpcHRpb24o
ZXZlbnQpKTsKIAogICAgIG1fb3V0c3RhbmRpbmdFdmVudHMgJj0gfmV2ZW50OwogCmRpZmYgLS1n
aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1ZpZXdHZXN0dXJlQ29udHJvbGxlci5o
IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9WaWV3R2VzdHVyZUNvbnRyb2xsZXIuaApp
bmRleCBkNTg2ODYxNWVjYjc5NmRlODEzZjY2ZDU3NDAzNDBjZDIzNThkZmI3Li40MTU3ZTk2ZmUx
OWU0NmE2MThjZWNmNzdkZDRkYTZhODlkNWM4NTJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
Mi9VSVByb2Nlc3MvbWFjL1ZpZXdHZXN0dXJlQ29udHJvbGxlci5oCisrKyBiL1NvdXJjZS9XZWJL
aXQyL1VJUHJvY2Vzcy9tYWMvVmlld0dlc3R1cmVDb250cm9sbGVyLmgKQEAgLTMyLDYgKzMyLDcg
QEAKICNpbmNsdWRlIDxXZWJDb3JlL0NvbG9yLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9GbG9hdFJl
Y3QuaD4KICNpbmNsdWRlIDxjaHJvbm8+CisjaW5jbHVkZSA8d3RmL0Jsb2NrUHRyLmg+CiAjaW5j
bHVkZSA8d3RmL1JldGFpblB0ci5oPgogI2luY2x1ZGUgPHd0Zi9SdW5Mb29wLmg+CiAKQEAgLTI2
NSw3ICsyNjYsNyBAQCBwcml2YXRlOgogCiAgICAgUGVuZGluZ1N3aXBlVHJhY2tlciBtX3BlbmRp
bmdTd2lwZVRyYWNrZXI7CiAKLSAgICB2b2lkIChebV9kaWRNb3ZlU3dpcGVTbmFwc2hvdENhbGxi
YWNrKShDR1JlY3QpIHsgbnVsbHB0ciB9OworICAgIEJsb2NrUHRyPHZvaWQgKENHUmVjdCk+IG1f
ZGlkTW92ZVN3aXBlU25hcHNob3RDYWxsYmFjazsKIAogICAgIGJvb2wgbV9oYXNPdXRzdGFuZGlu
Z1JlcGFpbnRSZXF1ZXN0IHsgZmFsc2UgfTsKICNlbHNlICAgIApkaWZmIC0tZ2l0IGEvU291cmNl
L1dlYktpdDIvVUlQcm9jZXNzL21hYy9WaWV3R2VzdHVyZUNvbnRyb2xsZXJNYWMubW0gYi9Tb3Vy
Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1ZpZXdHZXN0dXJlQ29udHJvbGxlck1hYy5tbQppbmRl
eCBlYWQ0Y2ExMTFjOWJlNTg1NzhmY2Q1ZTIxYmRlOWVkZmEwODI4Y2E2Li5hM2QyNzQ0ZTI5ODAy
NzkyY2EzM2JiMjUxNzBmMmFjMjYwZDgxMGYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9V
SVByb2Nlc3MvbWFjL1ZpZXdHZXN0dXJlQ29udHJvbGxlck1hYy5tbQorKysgYi9Tb3VyY2UvV2Vi
S2l0Mi9VSVByb2Nlc3MvbWFjL1ZpZXdHZXN0dXJlQ29udHJvbGxlck1hYy5tbQpAQCAtOTEsMTEg
KzkxLDYgQEAgdm9pZCBWaWV3R2VzdHVyZUNvbnRyb2xsZXI6OnBsYXRmb3JtVGVhcmRvd24oKQog
CiAgICAgaWYgKG1fYWN0aXZlR2VzdHVyZVR5cGUgPT0gVmlld0dlc3R1cmVUeXBlOjpTd2lwZSkK
ICAgICAgICAgcmVtb3ZlU3dpcGVTbmFwc2hvdCgpOwotCi0gICAgaWYgKG1fZGlkTW92ZVN3aXBl
U25hcHNob3RDYWxsYmFjaykgewotICAgICAgICBCbG9ja19yZWxlYXNlKG1fZGlkTW92ZVN3aXBl
U25hcHNob3RDYWxsYmFjayk7Ci0gICAgICAgIG1fZGlkTW92ZVN3aXBlU25hcHNob3RDYWxsYmFj
ayA9IG51bGxwdHI7Ci0gICAgfQogfQogCiBzdGF0aWMgZG91YmxlIHJlc2lzdGFuY2VGb3JEZWx0
YShkb3VibGUgZGVsdGFTY2FsZSwgZG91YmxlIGN1cnJlbnRTY2FsZSkKQEAgLTcyNCw5ICs3MTks
NyBAQCB2b2lkIFZpZXdHZXN0dXJlQ29udHJvbGxlcjo6aGFuZGxlU3dpcGVHZXN0dXJlKFdlYkJh
Y2tGb3J3YXJkTGlzdEl0ZW0qIHRhcmdldEl0ZQogCiB2b2lkIFZpZXdHZXN0dXJlQ29udHJvbGxl
cjo6c2V0RGlkTW92ZVN3aXBlU25hcHNob3RDYWxsYmFjayh2b2lkKF5jYWxsYmFjaykoQ0dSZWN0
KSkKIHsKLSAgICBpZiAobV9kaWRNb3ZlU3dpcGVTbmFwc2hvdENhbGxiYWNrKQotICAgICAgICBC
bG9ja19yZWxlYXNlKG1fZGlkTW92ZVN3aXBlU25hcHNob3RDYWxsYmFjayk7Ci0gICAgbV9kaWRN
b3ZlU3dpcGVTbmFwc2hvdENhbGxiYWNrID0gQmxvY2tfY29weShjYWxsYmFjayk7CisgICAgbV9k
aWRNb3ZlU3dpcGVTbmFwc2hvdENhbGxiYWNrID0gbWFrZUJsb2NrUHRyKGNhbGxiYWNrKTsKIH0K
IAogdm9pZCBWaWV3R2VzdHVyZUNvbnRyb2xsZXI6OmRpZE1vdmVTd2lwZVNuYXBzaG90TGF5ZXIo
KQo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>290957</attachid>
            <date>2016-10-07 12:34:01 -0700</date>
            <delta_ts>2016-10-07 12:41:44 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-163132-20161007123045.patch</filename>
            <type>text/plain</type>
            <size>6214</size>
            <attacher name="Tim Horton">thorton</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2OTIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDEyNTY4NjIyNmIxMWQx
YjEyMzg1OTI4YTg5MGMyM2NhNWY5MzlmNS4uNjZmNjA5YWQ4MDg2MTc5ODgxYmI1OTNhZGQwYjZk
ZjIyZjM4YThkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE2LTEwLTA3ICBUaW0g
SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIEFkb3B0IEJsb2Nr
UHRyIGluIFZpZXdHZXN0dXJlQ29udHJvbGxlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzMTMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQ29jb2EvV2ViVmlld0ltcGwuaDoKKyAg
ICAgICAgKiBVSVByb2Nlc3MvQ29jb2EvV2ViVmlld0ltcGwubW06CisgICAgICAgIChXZWJLaXQ6
OldlYlZpZXdJbXBsOjpzZXREaWRNb3ZlU3dpcGVTbmFwc2hvdENhbGxiYWNrKToKKyAgICAgICAg
KiBVSVByb2Nlc3MvVmlld0dlc3R1cmVDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6
Vmlld0dlc3R1cmVDb250cm9sbGVyOjpTbmFwc2hvdFJlbW92YWxUcmFja2VyOjpzdG9wV2FpdGlu
Z0ZvckV2ZW50KToKKyAgICAgICAgKiBVSVByb2Nlc3MvbWFjL1ZpZXdHZXN0dXJlQ29udHJvbGxl
ci5oOgorICAgICAgICAoV2ViS2l0OjpWaWV3R2VzdHVyZUNvbnRyb2xsZXI6OnNldERpZE1vdmVT
d2lwZVNuYXBzaG90Q2FsbGJhY2spOgorICAgICAgICAoV2ViS2l0OjpWaWV3R2VzdHVyZUNvbnRy
b2xsZXI6Om1fZGlkTW92ZVN3aXBlU25hcHNob3RDYWxsYmFjayk6IERlbGV0ZWQuCisgICAgICAg
ICogVUlQcm9jZXNzL21hYy9WaWV3R2VzdHVyZUNvbnRyb2xsZXJNYWMubW06CisgICAgICAgIChX
ZWJLaXQ6OlZpZXdHZXN0dXJlQ29udHJvbGxlcjo6cGxhdGZvcm1UZWFyZG93bik6CisgICAgICAg
IChXZWJLaXQ6OlZpZXdHZXN0dXJlQ29udHJvbGxlcjo6c2V0RGlkTW92ZVN3aXBlU25hcHNob3RD
YWxsYmFjayk6IERlbGV0ZWQuCisKIDIwMTYtMTAtMDcgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1x
dWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyMDY5
MDkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29jb2EvV2ViVmlld0lt
cGwuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5oCmluZGV4
IDU1YzZjY2UwMjUxYzgzNmQwMmQ1ZmY2OTAzZGJiNzY4YjlhMTMwNGYuLjQwZjgzNTQzYzU4MmI2
MjZjNTEyOTVhNDFkMTc0YzJiN2M5YzU1OTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJ
UHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz
cy9Db2NvYS9XZWJWaWV3SW1wbC5oCkBAIC0zNSw2ICszNSw3IEBACiAjaW5jbHVkZSA8V2ViQ29y
ZS9UZXh0SW5kaWNhdG9yV2luZG93Lmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9Vc2VySW50ZXJmYWNl
TGF5b3V0RGlyZWN0aW9uLmg+CiAjaW5jbHVkZSA8ZnVuY3Rpb25hbD4KKyNpbmNsdWRlIDx3dGYv
QmxvY2tQdHIuaD4KICNpbmNsdWRlIDx3dGYvUmV0YWluUHRyLmg+CiAjaW5jbHVkZSA8d3RmL1dl
YWtQdHIuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9XVEZTdHJpbmcuaD4KQEAgLTQxOCw3ICs0MTks
NyBAQCBwdWJsaWM6CiAgICAgdm9pZCBzZXRDdXN0b21Td2lwZVZpZXdzKE5TQXJyYXkgKik7CiAg
ICAgdm9pZCBzZXRDdXN0b21Td2lwZVZpZXdzVG9wQ29udGVudEluc2V0KGZsb2F0KTsKICAgICBi
b29sIHRyeVRvU3dpcGVXaXRoRXZlbnQoTlNFdmVudCAqLCBib29sIGlnbm9yaW5nUGlubmVkU3Rh
dGUpOwotICAgIHZvaWQgc2V0RGlkTW92ZVN3aXBlU25hcHNob3RDYWxsYmFjayh2b2lkKF4pKENH
UmVjdCkpOworICAgIHZvaWQgc2V0RGlkTW92ZVN3aXBlU25hcHNob3RDYWxsYmFjayhCbG9ja1B0
cjx2b2lkIChDR1JlY3QpPik7CiAKICAgICB2b2lkIHNjcm9sbFdoZWVsKE5TRXZlbnQgKik7CiAg
ICAgdm9pZCBzd2lwZVdpdGhFdmVudChOU0V2ZW50ICopOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl
YktpdDIvVUlQcm9jZXNzL0NvY29hL1dlYlZpZXdJbXBsLm1tIGIvU291cmNlL1dlYktpdDIvVUlQ
cm9jZXNzL0NvY29hL1dlYlZpZXdJbXBsLm1tCmluZGV4IGU3M2JkOGEwNjI4NGVhNjg4MDRjMGU4
YWQxNjExZDdkYmNkOTM1ODUuLjNkMTEyODBiYTQyOTUyMzk1NzQ4ZGI4ZGZhOTYzZTZhNDRkNjM4
ZTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1w
bC5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29jb2EvV2ViVmlld0ltcGwubW0K
QEAgLTMyNzYsNyArMzI3Niw3IEBAIGJvb2wgV2ViVmlld0ltcGw6OnRyeVRvU3dpcGVXaXRoRXZl
bnQoTlNFdmVudCAqZXZlbnQsIGJvb2wgaWdub3JpbmdQaW5uZWRTdGF0ZSkKICAgICByZXR1cm4g
aGFuZGxlZEV2ZW50OwogfQogCi12b2lkIFdlYlZpZXdJbXBsOjpzZXREaWRNb3ZlU3dpcGVTbmFw
c2hvdENhbGxiYWNrKHZvaWQoXmNhbGxiYWNrKShDR1JlY3QpKQordm9pZCBXZWJWaWV3SW1wbDo6
c2V0RGlkTW92ZVN3aXBlU25hcHNob3RDYWxsYmFjayhCbG9ja1B0cjx2b2lkIChDR1JlY3QpPiBj
YWxsYmFjaykKIHsKICAgICBpZiAoIW1fYWxsb3dzQmFja0ZvcndhcmROYXZpZ2F0aW9uR2VzdHVy
ZXMpCiAgICAgICAgIHJldHVybjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz
cy9WaWV3R2VzdHVyZUNvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1Zp
ZXdHZXN0dXJlQ29udHJvbGxlci5jcHAKaW5kZXggZTI3ZDc4Y2MyMDVmMzkxNDEwZGJlNDhkYWFi
M2M0MTFjZDk0NTAzZS4uODU2Y2NhN2EzZWI3YzcwNTRmYzg4MjY3OGY0YWY3MDQ3NDE2MjdkNiAx
MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1ZpZXdHZXN0dXJlQ29udHJvbGxl
ci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1ZpZXdHZXN0dXJlQ29udHJvbGxl
ci5jcHAKQEAgLTIzMiw3ICsyMzIsNyBAQCBib29sIFZpZXdHZXN0dXJlQ29udHJvbGxlcjo6U25h
cHNob3RSZW1vdmFsVHJhY2tlcjo6c3RvcFdhaXRpbmdGb3JFdmVudChFdmVudHMgZQogI2lmIExP
R19ESVNBQkxFRAogICAgIFVOVVNFRF9QQVJBTShsb2dSZWFzb24pOwogI2VuZGlmCi0gICAgbG9n
KGxvZ1JlYXNvbiArICBldmVudHNEZXNjcmlwdGlvbihldmVudCkpOworICAgIGxvZyhsb2dSZWFz
b24gKyBldmVudHNEZXNjcmlwdGlvbihldmVudCkpOwogCiAgICAgbV9vdXRzdGFuZGluZ0V2ZW50
cyAmPSB+ZXZlbnQ7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMv
Vmlld0dlc3R1cmVDb250cm9sbGVyLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1Zp
ZXdHZXN0dXJlQ29udHJvbGxlci5oCmluZGV4IGQ1ODY4NjE1ZWNiNzk2ZGU4MTNmNjZkNTc0MDM0
MGNkMjM1OGRmYjcuLjYxYzg5YzE1MzdiYTJlMzM3YTVlM2I3Y2FlZTk4OWEzZDlhNDdlNTIgMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvVmlld0dlc3R1cmVDb250cm9s
bGVyLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9WaWV3R2VzdHVyZUNvbnRy
b2xsZXIuaApAQCAtMzIsNiArMzIsNyBAQAogI2luY2x1ZGUgPFdlYkNvcmUvQ29sb3IuaD4KICNp
bmNsdWRlIDxXZWJDb3JlL0Zsb2F0UmVjdC5oPgogI2luY2x1ZGUgPGNocm9ubz4KKyNpbmNsdWRl
IDx3dGYvQmxvY2tQdHIuaD4KICNpbmNsdWRlIDx3dGYvUmV0YWluUHRyLmg+CiAjaW5jbHVkZSA8
d3RmL1J1bkxvb3AuaD4KIApAQCAtMTAwLDcgKzEwMSw3IEBAIHB1YmxpYzoKICAgICB2b2lkIHNl
dEN1c3RvbVN3aXBlVmlld3MoVmVjdG9yPFJldGFpblB0cjxOU1ZpZXc+PiB2aWV3cykgeyBtX2N1
c3RvbVN3aXBlVmlld3MgPSBXVEZNb3ZlKHZpZXdzKTsgfQogICAgIHZvaWQgc2V0Q3VzdG9tU3dp
cGVWaWV3c1RvcENvbnRlbnRJbnNldChmbG9hdCB0b3BDb250ZW50SW5zZXQpIHsgbV9jdXN0b21T
d2lwZVZpZXdzVG9wQ29udGVudEluc2V0ID0gdG9wQ29udGVudEluc2V0OyB9CiAgICAgV2ViQ29y
ZTo6RmxvYXRSZWN0IHdpbmRvd1JlbGF0aXZlQm91bmRzRm9yQ3VzdG9tU3dpcGVWaWV3cygpIGNv
bnN0OwotICAgIHZvaWQgc2V0RGlkTW92ZVN3aXBlU25hcHNob3RDYWxsYmFjayh2b2lkKF4pKENH
UmVjdCkpOworICAgIHZvaWQgc2V0RGlkTW92ZVN3aXBlU25hcHNob3RDYWxsYmFjayhCbG9ja1B0
cjx2b2lkIChDR1JlY3QpPiBjYWxsYmFjaykgeyBtX2RpZE1vdmVTd2lwZVNuYXBzaG90Q2FsbGJh
Y2sgPSBjYWxsYmFjazsgfQogCiAgICAgYm9vbCBzaG91bGRJZ25vcmVQaW5uZWRTdGF0ZSgpIHsg
cmV0dXJuIG1fcGVuZGluZ1N3aXBlVHJhY2tlci5zaG91bGRJZ25vcmVQaW5uZWRTdGF0ZSgpOyB9
CiAgICAgdm9pZCBzZXRTaG91bGRJZ25vcmVQaW5uZWRTdGF0ZShib29sIGlnbm9yZSkgeyBtX3Bl
bmRpbmdTd2lwZVRyYWNrZXIuc2V0U2hvdWxkSWdub3JlUGlubmVkU3RhdGUoaWdub3JlKTsgfQpA
QCAtMjY1LDcgKzI2Niw3IEBAIHByaXZhdGU6CiAKICAgICBQZW5kaW5nU3dpcGVUcmFja2VyIG1f
cGVuZGluZ1N3aXBlVHJhY2tlcjsKIAotICAgIHZvaWQgKF5tX2RpZE1vdmVTd2lwZVNuYXBzaG90
Q2FsbGJhY2spKENHUmVjdCkgeyBudWxscHRyIH07CisgICAgQmxvY2tQdHI8dm9pZCAoQ0dSZWN0
KT4gbV9kaWRNb3ZlU3dpcGVTbmFwc2hvdENhbGxiYWNrOwogCiAgICAgYm9vbCBtX2hhc091dHN0
YW5kaW5nUmVwYWludFJlcXVlc3QgeyBmYWxzZSB9OwogI2Vsc2UgICAgCmRpZmYgLS1naXQgYS9T
b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1ZpZXdHZXN0dXJlQ29udHJvbGxlck1hYy5tbSBi
L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvVmlld0dlc3R1cmVDb250cm9sbGVyTWFjLm1t
CmluZGV4IGVhZDRjYTExMWM5YmU1ODU3OGZjZDVlMjFiZGU5ZWRmYTA4MjhjYTYuLmM0MGZiYjc1
ODVlNmMzNzA5NmQxNzRiNTRlNjBkYzliZDBmMTFiNGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL
aXQyL1VJUHJvY2Vzcy9tYWMvVmlld0dlc3R1cmVDb250cm9sbGVyTWFjLm1tCisrKyBiL1NvdXJj
ZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvVmlld0dlc3R1cmVDb250cm9sbGVyTWFjLm1tCkBAIC05
MSwxMSArOTEsNiBAQCB2b2lkIFZpZXdHZXN0dXJlQ29udHJvbGxlcjo6cGxhdGZvcm1UZWFyZG93
bigpCiAKICAgICBpZiAobV9hY3RpdmVHZXN0dXJlVHlwZSA9PSBWaWV3R2VzdHVyZVR5cGU6OlN3
aXBlKQogICAgICAgICByZW1vdmVTd2lwZVNuYXBzaG90KCk7Ci0KLSAgICBpZiAobV9kaWRNb3Zl
U3dpcGVTbmFwc2hvdENhbGxiYWNrKSB7Ci0gICAgICAgIEJsb2NrX3JlbGVhc2UobV9kaWRNb3Zl
U3dpcGVTbmFwc2hvdENhbGxiYWNrKTsKLSAgICAgICAgbV9kaWRNb3ZlU3dpcGVTbmFwc2hvdENh
bGxiYWNrID0gbnVsbHB0cjsKLSAgICB9CiB9CiAKIHN0YXRpYyBkb3VibGUgcmVzaXN0YW5jZUZv
ckRlbHRhKGRvdWJsZSBkZWx0YVNjYWxlLCBkb3VibGUgY3VycmVudFNjYWxlKQpAQCAtNzIyLDEz
ICs3MTcsNiBAQCB2b2lkIFZpZXdHZXN0dXJlQ29udHJvbGxlcjo6aGFuZGxlU3dpcGVHZXN0dXJl
KFdlYkJhY2tGb3J3YXJkTGlzdEl0ZW0qIHRhcmdldEl0ZQogICAgIH0KIH0KIAotdm9pZCBWaWV3
R2VzdHVyZUNvbnRyb2xsZXI6OnNldERpZE1vdmVTd2lwZVNuYXBzaG90Q2FsbGJhY2sodm9pZChe
Y2FsbGJhY2spKENHUmVjdCkpCi17Ci0gICAgaWYgKG1fZGlkTW92ZVN3aXBlU25hcHNob3RDYWxs
YmFjaykKLSAgICAgICAgQmxvY2tfcmVsZWFzZShtX2RpZE1vdmVTd2lwZVNuYXBzaG90Q2FsbGJh
Y2spOwotICAgIG1fZGlkTW92ZVN3aXBlU25hcHNob3RDYWxsYmFjayA9IEJsb2NrX2NvcHkoY2Fs
bGJhY2spOwotfQotCiB2b2lkIFZpZXdHZXN0dXJlQ29udHJvbGxlcjo6ZGlkTW92ZVN3aXBlU25h
cHNob3RMYXllcigpCiB7CiAgICAgaWYgKCFtX2RpZE1vdmVTd2lwZVNuYXBzaG90Q2FsbGJhY2sp
Cg==
</data>
<flag name="review"
          id="314110"
          type_id="1"
          status="+"
          setter="andersca"
    />
          </attachment>
      

    </bug>

</bugzilla>